Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dependency on abstract message in schema extractor #7260

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove dependency on abstract message in schema extractor #7260

wants to merge 1 commit into from

Conversation

piochelepiotr
Copy link
Contributor

@piochelepiotr piochelepiotr commented Jun 28, 2024 •
edited
Loading

What Does This Do

Motivation

Trying to solve this error:

java.lang.IllegalAccessError: class datadog.trace.instrumentation.protobuf_java.SchemaExtractor (in unnamed module @xxxxxx) cannot access class com.google.protobuf.AbstractMessage (in module xxxx.yyyy) because module xxxx.yyyy does not export com.google.protobuf to unnamed module @xxxxxxxx

My theory is that the dynamic message instrumentation calls this class, but dynamic message has nothing to do with AbstractMessage, so maybe in some cases DynamicMessage exists, but not AbstractMessage?
But that doesn't seem to be 100% correlated with the error.

Additional Notes

I'm not confident this will work. Since the error says the whole protobuf module is not exported.
But I only instrument classes extending protobuf classes, so I don't understand how that can happen.

Jira ticket: [PROJ-IDENT]

@piochelepiotr piochelepiotr requested a review from a team as a code owner June 28, 2024 17:01
@pr-commenter
Copy link

pr-commenter bot commented Jun 28, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master piotr-wolski/data-streams-fix-crash-schema-tracking
git_commit_date 1719593653 1719593988
git_commit_sha 08f0979 fec8d9f
release_version 1.37.0-SNAPSHOT~08f09790be 1.37.0-SNAPSHOT~fec8d9fd8e
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1719596946 1719596946
ci_job_id 556837644 556837644
ci_pipeline_id 37881113 37881113
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.37.0-SNAPSHOT~fec8d9fd8e, baseline=1.37.0-SNAPSHOT~08f09790be

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.07 s) : 0, 1069727
Total [baseline] (8.548 s) : 0, 8548144
Agent [candidate] (1.074 s) : 0, 1074011
Total [candidate] (8.57 s) : 0, 8569510
section iast
Agent [baseline] (1.169 s) : 0, 1169157
Total [baseline] (9.028 s) : 0, 9028343
Agent [candidate] (1.17 s) : 0, 1169708
Total [candidate] (9.007 s) : 0, 9006540
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.169 s) : 0, 1169223
Total [baseline] (8.976 s) : 0, 8975794
Agent [candidate] (1.176 s) : 0, 1175784
Total [candidate] (8.968 s) : 0, 8968194
section iast_TELEMETRY_OFF
Agent [baseline] (1.165 s) : 0, 1164877
Total [baseline] (8.998 s) : 0, 8997649
Agent [candidate] (1.166 s) : 0, 1165953
Total [candidate] (9.002 s) : 0, 9001694
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.07 s -
Agent iast 1.169 s 99.43 ms (9.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.169 s 99.496 ms (9.3%)
Agent iast_TELEMETRY_OFF 1.165 s 95.15 ms (8.9%)
Total tracing 8.548 s -
Total iast 9.028 s 480.199 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 8.976 s 427.65 ms (5.0%)
Total iast_TELEMETRY_OFF 8.998 s 449.505 ms (5.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.074 s -
Agent iast 1.17 s 95.697 ms (8.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.176 s 101.773 ms (9.5%)
Agent iast_TELEMETRY_OFF 1.166 s 91.942 ms (8.6%)
Total tracing 8.57 s -
Total iast 9.007 s 437.03 ms (5.1%)
Total iast_HARDCODED_SECRET_DISABLED 8.968 s 398.684 ms (4.7%)
Total iast_TELEMETRY_OFF 9.002 s 432.184 ms (5.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.37.0-SNAPSHOT~fec8d9fd8e, baseline=1.37.0-SNAPSHOT~08f09790be

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.045 ms) : 0, 670045
BytebuddyAgent [candidate] (672.212 ms) : 0, 672212
GlobalTracer [baseline] (306.269 ms) : 0, 306269
GlobalTracer [candidate] (307.891 ms) : 0, 307891
AppSec [baseline] (50.313 ms) : 0, 50313
AppSec [candidate] (50.762 ms) : 0, 50762
Remote Config [baseline] (708.094 µs) : 0, 708
Remote Config [candidate] (687.666 µs) : 0, 688
Telemetry [baseline] (7.679 ms) : 0, 7679
Telemetry [candidate] (7.764 ms) : 0, 7764
section iast
BytebuddyAgent [baseline] (778.29 ms) : 0, 778290
BytebuddyAgent [candidate] (779.111 ms) : 0, 779111
GlobalTracer [baseline] (293.22 ms) : 0, 293220
GlobalTracer [candidate] (294.404 ms) : 0, 294404
AppSec [baseline] (47.3 ms) : 0, 47300
AppSec [candidate] (47.259 ms) : 0, 47259
Remote Config [baseline] (588.492 µs) : 0, 588
Remote Config [candidate] (597.487 µs) : 0, 597
Telemetry [baseline] (6.922 ms) : 0, 6922
Telemetry [candidate] (6.945 ms) : 0, 6945
IAST [baseline] (29.46 ms) : 0, 29460
IAST [candidate] (27.963 ms) : 0, 27963
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (778.586 ms) : 0, 778586
BytebuddyAgent [candidate] (782.09 ms) : 0, 782090
GlobalTracer [baseline] (294.005 ms) : 0, 294005
GlobalTracer [candidate] (295.629 ms) : 0, 295629
AppSec [baseline] (47.423 ms) : 0, 47423
AppSec [candidate] (47.582 ms) : 0, 47582
Remote Config [baseline] (627.749 µs) : 0, 628
Remote Config [candidate] (626.503 µs) : 0, 627
Telemetry [baseline] (7.777 ms) : 0, 7777
Telemetry [candidate] (7.059 ms) : 0, 7059
IAST [baseline] (27.385 ms) : 0, 27385
IAST [candidate] (29.3 ms) : 0, 29300
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (776.035 ms) : 0, 776035
BytebuddyAgent [candidate] (775.61 ms) : 0, 775610
GlobalTracer [baseline] (294.293 ms) : 0, 294293
GlobalTracer [candidate] (293.546 ms) : 0, 293546
AppSec [baseline] (46.899 ms) : 0, 46899
AppSec [candidate] (47.331 ms) : 0, 47331
Remote Config [baseline] (573.885 µs) : 0, 574
Remote Config [candidate] (584.761 µs) : 0, 585
Telemetry [baseline] (7.585 ms) : 0, 7585
Telemetry [candidate] (8.364 ms) : 0, 8364
IAST [baseline] (26.075 ms) : 0, 26075
IAST [candidate] (27.085 ms) : 0, 27085
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.37.0-SNAPSHOT~fec8d9fd8e, baseline=1.37.0-SNAPSHOT~08f09790be

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064162
Total [baseline] (10.379 s) : 0, 10379469
Agent [candidate] (1.062 s) : 0, 1061981
Total [candidate] (10.385 s) : 0, 10385492
section appsec
Agent [baseline] (1.184 s) : 0, 1184231
Total [baseline] (10.47 s) : 0, 10470327
Agent [candidate] (1.189 s) : 0, 1189132
Total [candidate] (10.454 s) : 0, 10453750
section iast
Agent [baseline] (1.17 s) : 0, 1169523
Total [baseline] (10.727 s) : 0, 10727225
Agent [candidate] (1.19 s) : 0, 1189869
Total [candidate] (10.785 s) : 0, 10784967
section profiling
Agent [baseline] (1.262 s) : 0, 1261661
Total [baseline] (10.588 s) : 0, 10588259
Agent [candidate] (1.263 s) : 0, 1263441
Total [candidate] (10.614 s) : 0, 10614127
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent appsec 1.184 s 120.069 ms (11.3%)
Agent iast 1.17 s 105.361 ms (9.9%)
Agent profiling 1.262 s 197.499 ms (18.6%)
Total tracing 10.379 s -
Total appsec 10.47 s 90.858 ms (0.9%)
Total iast 10.727 s 347.756 ms (3.4%)
Total profiling 10.588 s 208.79 ms (2.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent appsec 1.189 s 127.151 ms (12.0%)
Agent iast 1.19 s 127.888 ms (12.0%)
Agent profiling 1.263 s 201.459 ms (19.0%)
Total tracing 10.385 s -
Total appsec 10.454 s 68.258 ms (0.7%)
Total iast 10.785 s 399.475 ms (3.8%)
Total profiling 10.614 s 228.635 ms (2.2%) 
gantt
    title petclinic - break down per module: candidate=1.37.0-SNAPSHOT~fec8d9fd8e, baseline=1.37.0-SNAPSHOT~08f09790be

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.766 ms) : 0, 666766
BytebuddyAgent [candidate] (664.707 ms) : 0, 664707
GlobalTracer [baseline] (304.47 ms) : 0, 304470
GlobalTracer [candidate] (304.34 ms) : 0, 304340
AppSec [baseline] (50.073 ms) : 0, 50073
AppSec [candidate] (50.189 ms) : 0, 50189
Remote Config [baseline] (768.181 µs) : 0, 768
Remote Config [candidate] (714.756 µs) : 0, 715
Telemetry [baseline] (7.505 ms) : 0, 7505
Telemetry [candidate] (7.526 ms) : 0, 7526
section appsec
BytebuddyAgent [baseline] (676.947 ms) : 0, 676947
BytebuddyAgent [candidate] (680.337 ms) : 0, 680337
GlobalTracer [baseline] (297.876 ms) : 0, 297876
GlobalTracer [candidate] (299.326 ms) : 0, 299326
AppSec [baseline] (153.953 ms) : 0, 153953
AppSec [candidate] (154.409 ms) : 0, 154409
Remote Config [baseline] (628.064 µs) : 0, 628
Remote Config [candidate] (630.681 µs) : 0, 631
Telemetry [baseline] (9.011 ms) : 0, 9011
Telemetry [candidate] (8.348 ms) : 0, 8348
IAST [baseline] (22.209 ms) : 0, 22209
IAST [candidate] (22.546 ms) : 0, 22546
section iast
BytebuddyAgent [baseline] (778.829 ms) : 0, 778829
BytebuddyAgent [candidate] (792.052 ms) : 0, 792052
GlobalTracer [baseline] (294.107 ms) : 0, 294107
GlobalTracer [candidate] (299.363 ms) : 0, 299363
AppSec [baseline] (47.263 ms) : 0, 47263
AppSec [candidate] (48.266 ms) : 0, 48266
Remote Config [baseline] (616.787 µs) : 0, 617
Remote Config [candidate] (608.83 µs) : 0, 609
Telemetry [baseline] (7.748 ms) : 0, 7748
Telemetry [candidate] (7.099 ms) : 0, 7099
IAST [baseline] (27.54 ms) : 0, 27540
IAST [candidate] (28.848 ms) : 0, 28848
section profiling
BytebuddyAgent [baseline] (661.658 ms) : 0, 661658
BytebuddyAgent [candidate] (662.699 ms) : 0, 662699
GlobalTracer [baseline] (387.361 ms) : 0, 387361
GlobalTracer [candidate] (387.705 ms) : 0, 387705
AppSec [baseline] (51.727 ms) : 0, 51727
AppSec [candidate] (51.702 ms) : 0, 51702
Remote Config [baseline] (663.933 µs) : 0, 664
Remote Config [candidate] (660.376 µs) : 0, 660
Telemetry [baseline] (7.368 ms) : 0, 7368
Telemetry [candidate] (7.274 ms) : 0, 7274
ProfilingAgent [baseline] (95.814 ms) : 0, 95814
ProfilingAgent [candidate] (96.25 ms) : 0, 96250
Profiling [baseline] (95.84 ms) : 0, 95840
Profiling [candidate] (96.275 ms) : 0, 96275
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-28T17:19:54 2024-06-28T17:26:42
git_branch master piotr-wolski/data-streams-fix-crash-schema-tracking
git_commit_date 1719593653 1719593988
git_commit_sha 08f0979 fec8d9f
release_version 1.37.0-SNAPSHOT~08f09790be 1.37.0-SNAPSHOT~fec8d9fd8e
start_time 2024-06-28T17:19:40 2024-06-28T17:26:29
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1719595945 1719595945
ci_job_id 556837645 556837645
ci_pipeline_id 37881113 37881113
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.37.0-SNAPSHOT~fec8d9fd8e, baseline=1.37.0-SNAPSHOT~08f09790be
    dateFormat X
    axisFormat %s
section baseline
no_agent (366.944 µs) : 347, 387
.   : milestone, 367,
iast (483.899 µs) : 463, 505
.   : milestone, 484,
iast_FULL (547.999 µs) : 527, 569
.   : milestone, 548,
iast_GLOBAL (505.913 µs) : 484, 528
.   : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (476.051 µs) : 455, 497
.   : milestone, 476,
iast_INACTIVE (450.836 µs) : 430, 472
.   : milestone, 451,
iast_TELEMETRY_OFF (466.843 µs) : 445, 488
.   : milestone, 467,
tracing (436.393 µs) : 416, 457
.   : milestone, 436,
section candidate
no_agent (363.522 µs) : 344, 383
.   : milestone, 364,
iast (481.741 µs) : 461, 503
.   : milestone, 482,
iast_FULL (548.342 µs) : 527, 570
.   : milestone, 548,
iast_GLOBAL (498.58 µs) : 478, 520
.   : milestone, 499,
iast_HARDCODED_SECRET_DISABLED (480.253 µs) : 459, 502
.   : milestone, 480,
iast_INACTIVE (446.832 µs) : 426, 468
.   : milestone, 447,
iast_TELEMETRY_OFF (465.589 µs) : 444, 487
.   : milestone, 466,
tracing (441.549 µs) : 421, 462
.   : milestone, 442,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.944 µs [347.327 µs, 386.561 µs] -
iast 483.899 µs [462.597 µs, 505.202 µs] 116.955 µs (31.9%)
iast_FULL 547.999 µs [526.837 µs, 569.162 µs] 181.055 µs (49.3%)
iast_GLOBAL 505.913 µs [484.143 µs, 527.684 µs] 138.969 µs (37.9%)
iast_HARDCODED_SECRET_DISABLED 476.051 µs [454.845 µs, 497.256 µs] 109.107 µs (29.7%)
iast_INACTIVE 450.836 µs [429.549 µs, 472.123 µs] 83.892 µs (22.9%)
iast_TELEMETRY_OFF 466.843 µs [445.406 µs, 488.28 µs] 99.899 µs (27.2%)
tracing 436.393 µs [416.198 µs, 456.589 µs] 69.449 µs (18.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.522 µs [343.957 µs, 383.088 µs] -
iast 481.741 µs [460.674 µs, 502.807 µs] 118.218 µs (32.5%)
iast_FULL 548.342 µs [527.147 µs, 569.538 µs] 184.82 µs (50.8%)
iast_GLOBAL 498.58 µs [477.586 µs, 519.575 µs] 135.058 µs (37.2%)
iast_HARDCODED_SECRET_DISABLED 480.253 µs [458.87 µs, 501.636 µs] 116.73 µs (32.1%)
iast_INACTIVE 446.832 µs [425.557 µs, 468.107 µs] 83.31 µs (22.9%)
iast_TELEMETRY_OFF 465.589 µs [444.163 µs, 487.015 µs] 102.067 µs (28.1%)
tracing 441.549 µs [420.838 µs, 462.261 µs] 78.027 µs (21.5%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.37.0-SNAPSHOT~fec8d9fd8e, baseline=1.37.0-SNAPSHOT~08f09790be
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.346 ms) : 1327, 1365
.   : milestone, 1346,
appsec (1.704 ms) : 1679, 1730
.   : milestone, 1704,
appsec_no_iast (1.734 ms) : 1709, 1758
.   : milestone, 1734,
iast (1.468 ms) : 1445, 1491
.   : milestone, 1468,
profiling (1.47 ms) : 1446, 1494
.   : milestone, 1470,
tracing (1.452 ms) : 1427, 1476
.   : milestone, 1452,
section candidate
no_agent (1.354 ms) : 1334, 1375
.   : milestone, 1354,
appsec (1.722 ms) : 1697, 1746
.   : milestone, 1722,
appsec_no_iast (1.709 ms) : 1685, 1734
.   : milestone, 1709,
iast (1.486 ms) : 1463, 1509
.   : milestone, 1486,
profiling (1.481 ms) : 1457, 1506
.   : milestone, 1481,
tracing (1.439 ms) : 1415, 1463
.   : milestone, 1439,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.346 ms [1.327 ms, 1.365 ms] -
appsec 1.704 ms [1.679 ms, 1.73 ms] 358.475 µs (26.6%)
appsec_no_iast 1.734 ms [1.709 ms, 1.758 ms] 387.73 µs (28.8%)
iast 1.468 ms [1.445 ms, 1.491 ms] 121.872 µs (9.1%)
profiling 1.47 ms [1.446 ms, 1.494 ms] 124.194 µs (9.2%)
tracing 1.452 ms [1.427 ms, 1.476 ms] 105.991 µs (7.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.354 ms [1.334 ms, 1.375 ms] -
appsec 1.722 ms [1.697 ms, 1.746 ms] 367.42 µs (27.1%)
appsec_no_iast 1.709 ms [1.685 ms, 1.734 ms] 355.008 µs (26.2%)
iast 1.486 ms [1.463 ms, 1.509 ms] 131.599 µs (9.7%)
profiling 1.481 ms [1.457 ms, 1.506 ms] 127.193 µs (9.4%)
tracing 1.439 ms [1.415 ms, 1.463 ms] 84.777 µs (6.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master piotr-wolski/data-streams-fix-crash-schema-tracking
git_commit_date 1719593653 1719593988
git_commit_sha 08f0979 fec8d9f
release_version 1.37.0-SNAPSHOT~08f09790be 1.37.0-SNAPSHOT~fec8d9fd8e
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1719596466 1719596466
ci_job_id 556837646 556837646
ci_pipeline_id 37881113 37881113
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.37.0-SNAPSHOT~fec8d9fd8e, baseline=1.37.0-SNAPSHOT~08f09790be
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.459 ms) : 1447, 1470
.   : milestone, 1459,
appsec (2.202 ms) : 2168, 2236
.   : milestone, 2202,
iast (1.966 ms) : 1924, 2008
.   : milestone, 1966,
iast_GLOBAL (2.004 ms) : 1962, 2045
.   : milestone, 2004,
profiling (1.857 ms) : 1823, 1891
.   : milestone, 1857,
tracing (1.827 ms) : 1795, 1859
.   : milestone, 1827,
section candidate
no_agent (1.46 ms) : 1448, 1471
.   : milestone, 1460,
appsec (2.207 ms) : 2172, 2242
.   : milestone, 2207,
iast (1.956 ms) : 1915, 1997
.   : milestone, 1956,
iast_GLOBAL (2.011 ms) : 1970, 2053
.   : milestone, 2011,
profiling (2.307 ms) : 2132, 2482
.   : milestone, 2307,
tracing (1.826 ms) : 1794, 1857
.   : milestone, 1826,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.447 ms, 1.47 ms] -
appsec 2.202 ms [2.168 ms, 2.236 ms] 743.048 µs (50.9%)
iast 1.966 ms [1.924 ms, 2.008 ms] 507.309 µs (34.8%)
iast_GLOBAL 2.004 ms [1.962 ms, 2.045 ms] 544.909 µs (37.4%)
profiling 1.857 ms [1.823 ms, 1.891 ms] 398.061 µs (27.3%)
tracing 1.827 ms [1.795 ms, 1.859 ms] 368.217 µs (25.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.448 ms, 1.471 ms] -
appsec 2.207 ms [2.172 ms, 2.242 ms] 746.992 µs (51.2%)
iast 1.956 ms [1.915 ms, 1.997 ms] 496.117 µs (34.0%)
iast_GLOBAL 2.011 ms [1.97 ms, 2.053 ms] 551.23 µs (37.8%)
profiling 2.307 ms [2.132 ms, 2.482 ms] 846.812 µs (58.0%)
tracing 1.826 ms [1.794 ms, 1.857 ms] 365.622 µs (25.0%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.37.0-SNAPSHOT~fec8d9fd8e, baseline=1.37.0-SNAPSHOT~08f09790be
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.535 s) : 15535000, 15535000
.   : milestone, 15535000,
appsec (14.953 s) : 14953000, 14953000
.   : milestone, 14953000,
iast (19.032 s) : 19032000, 19032000
.   : milestone, 19032000,
iast_GLOBAL (17.787 s) : 17787000, 17787000
.   : milestone, 17787000,
profiling (15.8 s) : 15800000, 15800000
.   : milestone, 15800000,
tracing (14.848 s) : 14848000, 14848000
.   : milestone, 14848000,
section candidate
no_agent (15.002 s) : 15002000, 15002000
.   : milestone, 15002000,
appsec (15.084 s) : 15084000, 15084000
.   : milestone, 15084000,
iast (18.78 s) : 18780000, 18780000
.   : milestone, 18780000,
iast_GLOBAL (17.927 s) : 17927000, 17927000
.   : milestone, 17927000,
profiling (15.266 s) : 15266000, 15266000
.   : milestone, 15266000,
tracing (14.918 s) : 14918000, 14918000
.   : milestone, 14918000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.535 s [15.535 s, 15.535 s] -
appsec 14.953 s [14.953 s, 14.953 s] -582.0 ms (-3.7%)
iast 19.032 s [19.032 s, 19.032 s] 3.497 s (22.5%)
iast_GLOBAL 17.787 s [17.787 s, 17.787 s] 2.252 s (14.5%)
profiling 15.8 s [15.8 s, 15.8 s] 265.0 ms (1.7%)
tracing 14.848 s [14.848 s, 14.848 s] -687.0 ms (-4.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.002 s [15.002 s, 15.002 s] -
appsec 15.084 s [15.084 s, 15.084 s] 82.0 ms (0.5%)
iast 18.78 s [18.78 s, 18.78 s] 3.778 s (25.2%)
iast_GLOBAL 17.927 s [17.927 s, 17.927 s] 2.925 s (19.5%)
profiling 15.266 s [15.266 s, 15.266 s] 264.0 ms (1.8%)
tracing 14.918 s [14.918 s, 14.918 s] -84.0 ms (-0.6%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@piochelepiotr