Fix milestone assignment automation #7265

PerfectSlayer · 2024-07-01T16:00:49Z

What Does This Do

This PR tries to fix a regression from #7217

Motivation

The workflow is failing to identify master branch.
See: https://dd.slack.com/archives/C047YAMGZ7T/p1719847370062669

Additional Notes

Jira ticket: [PROJ-IDENT]

pr-commenter · 2024-07-01T16:47:23Z

Benchmarks

Startup

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-07-01T16:17:02	2024-07-01T16:23:50
git_branch	master	bbujon/ci-github-fix
git_commit_date	1719846429	1719849513
git_commit_sha	`cdecb42`	`8489411`
release_version	1.37.0-SNAPSHOT~cdecb42d28	1.37.0-SNAPSHOT~8489411050
start_time	2024-07-01T16:16:48	2024-07-01T16:23:37

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1719851374	1719851374
ci_job_id	558435227	558435227
ci_pipeline_id	38013120	38013120
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.37.0-SNAPSHOT~8489411050, baseline=1.37.0-SNAPSHOT~cdecb42d28
    dateFormat X
    axisFormat %s
section baseline
no_agent (365.228 µs) : 346, 384
.   : milestone, 365,
iast (480.124 µs) : 459, 502
.   : milestone, 480,
iast_FULL (548.74 µs) : 527, 570
.   : milestone, 549,
iast_GLOBAL (512.109 µs) : 491, 534
.   : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (484.571 µs) : 463, 506
.   : milestone, 485,
iast_INACTIVE (453.321 µs) : 432, 475
.   : milestone, 453,
iast_TELEMETRY_OFF (469.782 µs) : 449, 491
.   : milestone, 470,
tracing (439.853 µs) : 419, 460
.   : milestone, 440,
section candidate
no_agent (365.467 µs) : 346, 385
.   : milestone, 365,
iast (474.498 µs) : 454, 495
.   : milestone, 474,
iast_FULL (549.091 µs) : 528, 570
.   : milestone, 549,
iast_GLOBAL (502.665 µs) : 482, 524
.   : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (479.649 µs) : 458, 501
.   : milestone, 480,
iast_INACTIVE (445.187 µs) : 424, 466
.   : milestone, 445,
iast_TELEMETRY_OFF (477.611 µs) : 455, 500
.   : milestone, 478,
tracing (439.574 µs) : 419, 460
.   : milestone, 440,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	365.228 µs [345.988 µs, 384.469 µs]	-
iast	480.124 µs [458.528 µs, 501.719 µs]	114.895 µs (31.5%)
iast_FULL	548.74 µs [527.404 µs, 570.075 µs]	183.511 µs (50.2%)
iast_GLOBAL	512.109 µs [490.655 µs, 533.562 µs]	146.881 µs (40.2%)
iast_HARDCODED_SECRET_DISABLED	484.571 µs [462.761 µs, 506.382 µs]	119.343 µs (32.7%)
iast_INACTIVE	453.321 µs [432.073 µs, 474.568 µs]	88.092 µs (24.1%)
iast_TELEMETRY_OFF	469.782 µs [448.862 µs, 490.701 µs]	104.553 µs (28.6%)
tracing	439.853 µs [419.394 µs, 460.311 µs]	74.624 µs (20.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	365.467 µs [345.803 µs, 385.132 µs]	-
iast	474.498 µs [453.627 µs, 495.368 µs]	109.031 µs (29.8%)
iast_FULL	549.091 µs [528.116 µs, 570.066 µs]	183.624 µs (50.2%)
iast_GLOBAL	502.665 µs [481.686 µs, 523.644 µs]	137.198 µs (37.5%)
iast_HARDCODED_SECRET_DISABLED	479.649 µs [458.284 µs, 501.014 µs]	114.182 µs (31.2%)
iast_INACTIVE	445.187 µs [424.24 µs, 466.133 µs]	79.72 µs (21.8%)
iast_TELEMETRY_OFF	477.611 µs [455.055 µs, 500.168 µs]	112.144 µs (30.7%)
tracing	439.574 µs [418.932 µs, 460.216 µs]	74.107 µs (20.3%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.37.0-SNAPSHOT~8489411050, baseline=1.37.0-SNAPSHOT~cdecb42d28
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.343 ms) : 1324, 1363
.   : milestone, 1343,
appsec (1.732 ms) : 1708, 1756
.   : milestone, 1732,
appsec_no_iast (1.702 ms) : 1677, 1727
.   : milestone, 1702,
iast (1.475 ms) : 1452, 1498
.   : milestone, 1475,
profiling (1.482 ms) : 1457, 1507
.   : milestone, 1482,
tracing (1.485 ms) : 1461, 1508
.   : milestone, 1485,
section candidate
no_agent (1.345 ms) : 1326, 1365
.   : milestone, 1345,
appsec (1.715 ms) : 1689, 1740
.   : milestone, 1715,
appsec_no_iast (1.704 ms) : 1680, 1729
.   : milestone, 1704,
iast (1.492 ms) : 1470, 1515
.   : milestone, 1492,
profiling (1.472 ms) : 1448, 1497
.   : milestone, 1472,
tracing (1.464 ms) : 1440, 1489
.   : milestone, 1464,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.343 ms [1.324 ms, 1.363 ms]	-
appsec	1.732 ms [1.708 ms, 1.756 ms]	388.559 µs (28.9%)
appsec_no_iast	1.702 ms [1.677 ms, 1.727 ms]	358.687 µs (26.7%)
iast	1.475 ms [1.452 ms, 1.498 ms]	131.846 µs (9.8%)
profiling	1.482 ms [1.457 ms, 1.507 ms]	138.714 µs (10.3%)
tracing	1.485 ms [1.461 ms, 1.508 ms]	141.344 µs (10.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.345 ms [1.326 ms, 1.365 ms]	-
appsec	1.715 ms [1.689 ms, 1.74 ms]	369.188 µs (27.4%)
appsec_no_iast	1.704 ms [1.68 ms, 1.729 ms]	358.814 µs (26.7%)
iast	1.492 ms [1.47 ms, 1.515 ms]	147.006 µs (10.9%)
profiling	1.472 ms [1.448 ms, 1.497 ms]	127.004 µs (9.4%)
tracing	1.464 ms [1.44 ms, 1.489 ms]	119.07 µs (8.9%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bbujon/ci-github-fix
git_commit_date	1719846429	1719849513
git_commit_sha	`cdecb42`	`8489411`
release_version	1.37.0-SNAPSHOT~cdecb42d28	1.37.0-SNAPSHOT~8489411050

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1719851869	1719851869
ci_job_id	558435230	558435230
ci_pipeline_id	38013120	38013120
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.37.0-SNAPSHOT~8489411050, baseline=1.37.0-SNAPSHOT~cdecb42d28
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
.   : milestone, 1477,
appsec (2.241 ms) : 2205, 2277
.   : milestone, 2241,
iast (1.995 ms) : 1951, 2038
.   : milestone, 1995,
iast_GLOBAL (2.042 ms) : 1998, 2085
.   : milestone, 2042,
profiling (1.875 ms) : 1840, 1910
.   : milestone, 1875,
tracing (1.862 ms) : 1828, 1896
.   : milestone, 1862,
section candidate
no_agent (1.47 ms) : 1458, 1481
.   : milestone, 1470,
appsec (2.244 ms) : 2208, 2280
.   : milestone, 2244,
iast (1.979 ms) : 1937, 2021
.   : milestone, 1979,
iast_GLOBAL (2.026 ms) : 1983, 2068
.   : milestone, 2026,
profiling (1.899 ms) : 1862, 1936
.   : milestone, 1899,
tracing (1.859 ms) : 1825, 1893
.   : milestone, 1859,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.477 ms [1.466 ms, 1.489 ms]	-
appsec	2.241 ms [2.205 ms, 2.277 ms]	763.505 µs (51.7%)
iast	1.995 ms [1.951 ms, 2.038 ms]	517.399 µs (35.0%)
iast_GLOBAL	2.042 ms [1.998 ms, 2.085 ms]	564.093 µs (38.2%)
profiling	1.875 ms [1.84 ms, 1.91 ms]	397.811 µs (26.9%)
tracing	1.862 ms [1.828 ms, 1.896 ms]	384.537 µs (26.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.47 ms [1.458 ms, 1.481 ms]	-
appsec	2.244 ms [2.208 ms, 2.28 ms]	774.226 µs (52.7%)
iast	1.979 ms [1.937 ms, 2.021 ms]	509.154 µs (34.6%)
iast_GLOBAL	2.026 ms [1.983 ms, 2.068 ms]	555.787 µs (37.8%)
profiling	1.899 ms [1.862 ms, 1.936 ms]	429.215 µs (29.2%)
tracing	1.859 ms [1.825 ms, 1.893 ms]	389.421 µs (26.5%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.37.0-SNAPSHOT~8489411050, baseline=1.37.0-SNAPSHOT~cdecb42d28
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.258 s) : 15258000, 15258000
.   : milestone, 15258000,
appsec (14.852 s) : 14852000, 14852000
.   : milestone, 14852000,
iast (19.192 s) : 19192000, 19192000
.   : milestone, 19192000,
iast_GLOBAL (17.709 s) : 17709000, 17709000
.   : milestone, 17709000,
profiling (15.76 s) : 15760000, 15760000
.   : milestone, 15760000,
tracing (15.003 s) : 15003000, 15003000
.   : milestone, 15003000,
section candidate
no_agent (15.631 s) : 15631000, 15631000
.   : milestone, 15631000,
appsec (14.763 s) : 14763000, 14763000
.   : milestone, 14763000,
iast (19.078 s) : 19078000, 19078000
.   : milestone, 19078000,
iast_GLOBAL (17.79 s) : 17790000, 17790000
.   : milestone, 17790000,
profiling (15.835 s) : 15835000, 15835000
.   : milestone, 15835000,
tracing (14.977 s) : 14977000, 14977000
.   : milestone, 14977000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.258 s [15.258 s, 15.258 s]	-
appsec	14.852 s [14.852 s, 14.852 s]	-406.0 ms (-2.7%)
iast	19.192 s [19.192 s, 19.192 s]	3.934 s (25.8%)
iast_GLOBAL	17.709 s [17.709 s, 17.709 s]	2.451 s (16.1%)
profiling	15.76 s [15.76 s, 15.76 s]	502.0 ms (3.3%)
tracing	15.003 s [15.003 s, 15.003 s]	-255.0 ms (-1.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.631 s [15.631 s, 15.631 s]	-
appsec	14.763 s [14.763 s, 14.763 s]	-868.0 ms (-5.6%)
iast	19.078 s [19.078 s, 19.078 s]	3.447 s (22.1%)
iast_GLOBAL	17.79 s [17.79 s, 17.79 s]	2.159 s (13.8%)
profiling	15.835 s [15.835 s, 15.835 s]	204.0 ms (1.3%)
tracing	14.977 s [14.977 s, 14.977 s]	-654.0 ms (-4.2%)

fix(ci): Fix milestone assignment automation

8489411

PerfectSlayer added type: bug tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Jul 1, 2024

PerfectSlayer requested a review from a team as a code owner July 1, 2024 16:00

PerfectSlayer requested review from dougqh and ygree July 1, 2024 16:00

mcculls approved these changes Jul 1, 2024

View reviewed changes

PerfectSlayer merged commit a9dde4f into master Jul 2, 2024
84 checks passed

PerfectSlayer deleted the bbujon/ci-github-fix branch July 2, 2024 08:47

github-actions bot added this to the 1.37.0 milestone Jul 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix milestone assignment automation #7265

Fix milestone assignment automation #7265

PerfectSlayer commented Jul 1, 2024

pr-commenter bot commented Jul 1, 2024

Fix milestone assignment automation #7265

Fix milestone assignment automation #7265

Conversation

PerfectSlayer commented Jul 1, 2024

What Does This Do

Motivation

Additional Notes

pr-commenter bot commented Jul 1, 2024

Benchmarks

Startup

Load

Parameters

Summary

Dacapo

Parameters

Summary