Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move 'recordEvent' method to StatsDClient interface #7267

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Move 'recordEvent' method to StatsDClient interface #7267

merged 2 commits into from
Jul 2, 2024
+23 −16

Conversation

jbachorik
Copy link
Contributor

@jbachorik jbachorik commented Jul 2, 2024 •
edited by jira bot
Loading

What Does This Do

Follow-up to #10025 to move the recordEvent to StatsDClient interface

Jira ticket: PROF-10025

@jbachorik jbachorik requested review from a team as code owners July 2, 2024 12:35
@jbachorik jbachorik mentioned this pull request Jul 2, 2024
Merged
mcculls
mcculls approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@mcculls mcculls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jbachorik jbachorik merged commit 16dbb60 into master Jul 2, 2024
81 of 84 checks passed
@jbachorik jbachorik deleted the jb/statsd_event branch July 2, 2024 13:26
@github-actions github-actions bot added this to the 1.37.0 milestone Jul 2, 2024
@jbachorik jbachorik added tag: no release notes Changes to exclude from release notes comp: crash tracking Crash tracking labels Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcculls mcculls mcculls approved these changes

@PerfectSlayer PerfectSlayer Awaiting requested review from PerfectSlayer PerfectSlayer is a code owner automatically assigned from DataDog/apm-java

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: crash tracking Crash tracking tag: no release notes Changes to exclude from release notes
Projects
None yet
Milestone
1.37.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jbachorik @mcculls