[Bugfix] remove binary _datadog attribute if present in JMS SQS instrumentation to avoid crash
#7283
+58
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vandonr
changed the title
vandonr
changed the title
_datadog attribute if present in JMS SQS instrumentation to avoid crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Instrument JMS-SQS constructor to remove eventual
_datadogbinary message attribute that would make the library crash.Motivation
This situation can happen when clients send messages via SNS, where we have to use binary format to avoid breaking message filtering, and then use JMS to receive those messages through SQS.
Additional Notes
As mentioned as a comment in the code, any meaningful data in
_datadogwould be used in the awssdk SQS instrumentation, which happens before this instrumentation kicks in, so it's safe to remove that attribute and its content.If it were to become an issue, we'd have to convert the binary value to a string value instead of removing it.
solves DataDog/dd-trace-js#3549
Jira ticket: AIDM-183