Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use spark application name when service is set to hadoop #7294

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Use spark application name when service is set to hadoop #7294

merged 1 commit into from
Jul 12, 2024

Conversation

paul-laffon-dd
Copy link
Contributor

@paul-laffon-dd paul-laffon-dd commented Jul 9, 2024 •
edited
Loading

What Does This Do

DD_SPARK_APP_NAME_AS_SERVICE also use spark.app.name as the default service if service is set to hadoop

Motivation

USM can auto-infer the service to hadoop, in this case we still want to use the spark app name as the service

Additional Notes

Follow up of: #7252

@pr-commenter
Copy link

pr-commenter bot commented Jul 9, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master paul.laffon/default-spark-app-name-hadoop
git_commit_date 1720513897 1720514050
git_commit_sha 9e7aa67 2f40cd1
release_version 1.38.0-SNAPSHOT~9e7aa67ce6 1.38.0-SNAPSHOT~2f40cd1d33
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1720516441 1720516441
ci_job_id 566177580 566177580
ci_pipeline_id 38674671 38674671
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 7 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.38.0-SNAPSHOT~2f40cd1d33, baseline=1.38.0-SNAPSHOT~9e7aa67ce6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1066768
Total [baseline] (10.332 s) : 0, 10332174
Agent [candidate] (1.065 s) : 0, 1065144
Total [candidate] (10.398 s) : 0, 10398063
section appsec
Agent [baseline] (1.19 s) : 0, 1189694
Total [baseline] (10.538 s) : 0, 10537794
Agent [candidate] (1.183 s) : 0, 1182576
Total [candidate] (10.523 s) : 0, 10522696
section iast
Agent [baseline] (1.171 s) : 0, 1170776
Total [baseline] (10.696 s) : 0, 10695969
Agent [candidate] (1.173 s) : 0, 1173033
Total [candidate] (10.77 s) : 0, 10770001
section profiling
Agent [baseline] (1.265 s) : 0, 1265340
Total [baseline] (10.611 s) : 0, 10611372
Agent [candidate] (1.271 s) : 0, 1271218
Total [candidate] (10.589 s) : 0, 10588787
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.067 s -
Agent appsec 1.19 s 122.925 ms (11.5%)
Agent iast 1.171 s 104.008 ms (9.7%)
Agent profiling 1.265 s 198.572 ms (18.6%)
Total tracing 10.332 s -
Total appsec 10.538 s 205.62 ms (2.0%)
Total iast 10.696 s 363.795 ms (3.5%)
Total profiling 10.611 s 279.198 ms (2.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent appsec 1.183 s 117.433 ms (11.0%)
Agent iast 1.173 s 107.889 ms (10.1%)
Agent profiling 1.271 s 206.074 ms (19.3%)
Total tracing 10.398 s -
Total appsec 10.523 s 124.632 ms (1.2%)
Total iast 10.77 s 371.937 ms (3.6%)
Total profiling 10.589 s 190.723 ms (1.8%) 
gantt
    title petclinic - break down per module: candidate=1.38.0-SNAPSHOT~2f40cd1d33, baseline=1.38.0-SNAPSHOT~9e7aa67ce6

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.944 ms) : 0, 666944
BytebuddyAgent [candidate] (666.324 ms) : 0, 666324
GlobalTracer [baseline] (306.306 ms) : 0, 306306
GlobalTracer [candidate] (305.309 ms) : 0, 305309
AppSec [baseline] (50.325 ms) : 0, 50325
AppSec [candidate] (50.443 ms) : 0, 50443
Remote Config [baseline] (673.135 µs) : 0, 673
Remote Config [candidate] (670.6 µs) : 0, 671
Telemetry [baseline] (7.7 ms) : 0, 7700
Telemetry [candidate] (7.688 ms) : 0, 7688
section appsec
BytebuddyAgent [baseline] (680.436 ms) : 0, 680436
BytebuddyAgent [candidate] (675.8 ms) : 0, 675800
GlobalTracer [baseline] (300.472 ms) : 0, 300472
GlobalTracer [candidate] (298.621 ms) : 0, 298621
AppSec [baseline] (154.269 ms) : 0, 154269
AppSec [candidate] (153.772 ms) : 0, 153772
IAST [baseline] (21.497 ms) : 0, 21497
IAST [candidate] (20.311 ms) : 0, 20311
Remote Config [baseline] (626.224 µs) : 0, 626
Remote Config [candidate] (618.37 µs) : 0, 618
Telemetry [baseline] (8.267 ms) : 0, 8267
Telemetry [candidate] (8.916 ms) : 0, 8916
section iast
BytebuddyAgent [baseline] (778.931 ms) : 0, 778931
BytebuddyAgent [candidate] (780.342 ms) : 0, 780342
GlobalTracer [baseline] (295.73 ms) : 0, 295730
GlobalTracer [candidate] (295.759 ms) : 0, 295759
AppSec [baseline] (47.307 ms) : 0, 47307
AppSec [candidate] (47.426 ms) : 0, 47426
IAST [baseline] (27.85 ms) : 0, 27850
IAST [candidate] (28.541 ms) : 0, 28541
Remote Config [baseline] (567.972 µs) : 0, 568
Remote Config [candidate] (555.658 µs) : 0, 556
Telemetry [baseline] (6.935 ms) : 0, 6935
Telemetry [candidate] (6.87 ms) : 0, 6870
section profiling
BytebuddyAgent [baseline] (663.4 ms) : 0, 663400
BytebuddyAgent [candidate] (667.391 ms) : 0, 667391
GlobalTracer [baseline] (389.872 ms) : 0, 389872
GlobalTracer [candidate] (389.768 ms) : 0, 389768
AppSec [baseline] (51.421 ms) : 0, 51421
AppSec [candidate] (52.011 ms) : 0, 52011
Remote Config [baseline] (645.306 µs) : 0, 645
Remote Config [candidate] (647.264 µs) : 0, 647
Telemetry [baseline] (7.336 ms) : 0, 7336
Telemetry [candidate] (7.396 ms) : 0, 7396
ProfilingAgent [baseline] (95.463 ms) : 0, 95463
ProfilingAgent [candidate] (96.32 ms) : 0, 96320
Profiling [baseline] (95.488 ms) : 0, 95488
Profiling [candidate] (96.345 ms) : 0, 96345
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.38.0-SNAPSHOT~2f40cd1d33, baseline=1.38.0-SNAPSHOT~9e7aa67ce6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062973
Total [baseline] (8.559 s) : 0, 8558951
Agent [candidate] (1.064 s) : 0, 1064156
Total [candidate] (8.495 s) : 0, 8494639
section iast
Agent [baseline] (1.182 s) : 0, 1181672
Total [baseline] (9.006 s) : 0, 9005660
Agent [candidate] (1.175 s) : 0, 1174965
Total [candidate] (8.984 s) : 0, 8984426
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.172 s) : 0, 1172175
Total [baseline] (8.912 s) : 0, 8911501
Agent [candidate] (1.176 s) : 0, 1176313
Total [candidate] (8.956 s) : 0, 8955638
section iast_TELEMETRY_OFF
Agent [baseline] (1.17 s) : 0, 1170331
Total [baseline] (8.956 s) : 0, 8956271
Agent [candidate] (1.168 s) : 0, 1168223
Total [candidate] (8.954 s) : 0, 8953957
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent iast 1.182 s 118.698 ms (11.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.172 s 109.201 ms (10.3%)
Agent iast_TELEMETRY_OFF 1.17 s 107.358 ms (10.1%)
Total tracing 8.559 s -
Total iast 9.006 s 446.709 ms (5.2%)
Total iast_HARDCODED_SECRET_DISABLED 8.912 s 352.55 ms (4.1%)
Total iast_TELEMETRY_OFF 8.956 s 397.32 ms (4.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent iast 1.175 s 110.809 ms (10.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.176 s 112.158 ms (10.5%)
Agent iast_TELEMETRY_OFF 1.168 s 104.068 ms (9.8%)
Total tracing 8.495 s -
Total iast 8.984 s 489.787 ms (5.8%)
Total iast_HARDCODED_SECRET_DISABLED 8.956 s 460.999 ms (5.4%)
Total iast_TELEMETRY_OFF 8.954 s 459.318 ms (5.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.38.0-SNAPSHOT~2f40cd1d33, baseline=1.38.0-SNAPSHOT~9e7aa67ce6

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (665.19 ms) : 0, 665190
BytebuddyAgent [candidate] (665.784 ms) : 0, 665784
GlobalTracer [baseline] (305.014 ms) : 0, 305014
GlobalTracer [candidate] (305.252 ms) : 0, 305252
AppSec [baseline] (49.919 ms) : 0, 49919
AppSec [candidate] (50.065 ms) : 0, 50065
Remote Config [baseline] (663.156 µs) : 0, 663
Remote Config [candidate] (675.727 µs) : 0, 676
Telemetry [baseline] (7.658 ms) : 0, 7658
Telemetry [candidate] (7.77 ms) : 0, 7770
section iast
BytebuddyAgent [baseline] (787.504 ms) : 0, 787504
BytebuddyAgent [candidate] (784.931 ms) : 0, 784931
GlobalTracer [baseline] (298.267 ms) : 0, 298267
GlobalTracer [candidate] (295.904 ms) : 0, 295904
AppSec [baseline] (47.692 ms) : 0, 47692
AppSec [candidate] (47.311 ms) : 0, 47311
IAST [baseline] (26.063 ms) : 0, 26063
IAST [candidate] (25.581 ms) : 0, 25581
Remote Config [baseline] (600.213 µs) : 0, 600
Remote Config [candidate] (576.123 µs) : 0, 576
Telemetry [baseline] (7.963 ms) : 0, 7963
Telemetry [candidate] (7.096 ms) : 0, 7096
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (780.325 ms) : 0, 780325
BytebuddyAgent [candidate] (783.887 ms) : 0, 783887
GlobalTracer [baseline] (295.766 ms) : 0, 295766
GlobalTracer [candidate] (297.033 ms) : 0, 297033
AppSec [baseline] (47.337 ms) : 0, 47337
AppSec [candidate] (47.702 ms) : 0, 47702
IAST [baseline] (27.694 ms) : 0, 27694
IAST [candidate] (26.522 ms) : 0, 26522
Remote Config [baseline] (574.62 µs) : 0, 575
Remote Config [candidate] (573.424 µs) : 0, 573
Telemetry [baseline] (6.936 ms) : 0, 6936
Telemetry [candidate] (6.949 ms) : 0, 6949
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (779.144 ms) : 0, 779144
BytebuddyAgent [candidate] (777.904 ms) : 0, 777904
GlobalTracer [baseline] (295.797 ms) : 0, 295797
GlobalTracer [candidate] (295.534 ms) : 0, 295534
AppSec [baseline] (47.398 ms) : 0, 47398
AppSec [candidate] (47.177 ms) : 0, 47177
IAST [baseline] (26.966 ms) : 0, 26966
IAST [candidate] (26.594 ms) : 0, 26594
Remote Config [baseline] (609.034 µs) : 0, 609
Remote Config [candidate] (586.002 µs) : 0, 586
Telemetry [baseline] (6.873 ms) : 0, 6873
Telemetry [candidate] (6.864 ms) : 0, 6864
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-07-09T08:44:45 2024-07-09T08:51:32
git_branch master paul.laffon/default-spark-app-name-hadoop
git_commit_date 1720513897 1720514050
git_commit_sha 9e7aa67 2f40cd1
release_version 1.38.0-SNAPSHOT~9e7aa67ce6 1.38.0-SNAPSHOT~2f40cd1d33
start_time 2024-07-09T08:44:31 2024-07-09T08:51:19
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1720515437 1720515437
ci_job_id 566177581 566177581
ci_pipeline_id 38674671 38674671
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~2f40cd1d33, baseline=1.38.0-SNAPSHOT~9e7aa67ce6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.332 ms) : 1312, 1352
.   : milestone, 1332,
appsec (1.692 ms) : 1668, 1717
.   : milestone, 1692,
appsec_no_iast (1.729 ms) : 1705, 1752
.   : milestone, 1729,
iast (1.475 ms) : 1453, 1498
.   : milestone, 1475,
profiling (1.497 ms) : 1474, 1521
.   : milestone, 1497,
tracing (1.469 ms) : 1445, 1493
.   : milestone, 1469,
section candidate
no_agent (1.348 ms) : 1328, 1367
.   : milestone, 1348,
appsec (1.702 ms) : 1678, 1725
.   : milestone, 1702,
appsec_no_iast (1.705 ms) : 1680, 1730
.   : milestone, 1705,
iast (1.481 ms) : 1458, 1504
.   : milestone, 1481,
profiling (1.502 ms) : 1476, 1528
.   : milestone, 1502,
tracing (1.473 ms) : 1449, 1497
.   : milestone, 1473,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.332 ms [1.312 ms, 1.352 ms] -
appsec 1.692 ms [1.668 ms, 1.717 ms] 360.554 µs (27.1%)
appsec_no_iast 1.729 ms [1.705 ms, 1.752 ms] 396.688 µs (29.8%)
iast 1.475 ms [1.453 ms, 1.498 ms] 143.126 µs (10.7%)
profiling 1.497 ms [1.474 ms, 1.521 ms] 165.504 µs (12.4%)
tracing 1.469 ms [1.445 ms, 1.493 ms] 137.079 µs (10.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.348 ms [1.328 ms, 1.367 ms] -
appsec 1.702 ms [1.678 ms, 1.725 ms] 354.124 µs (26.3%)
appsec_no_iast 1.705 ms [1.68 ms, 1.73 ms] 356.858 µs (26.5%)
iast 1.481 ms [1.458 ms, 1.504 ms] 133.617 µs (9.9%)
profiling 1.502 ms [1.476 ms, 1.528 ms] 154.28 µs (11.4%)
tracing 1.473 ms [1.449 ms, 1.497 ms] 125.306 µs (9.3%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~2f40cd1d33, baseline=1.38.0-SNAPSHOT~9e7aa67ce6
    dateFormat X
    axisFormat %s
section baseline
no_agent (365.271 µs) : 346, 385
.   : milestone, 365,
iast (485.326 µs) : 464, 507
.   : milestone, 485,
iast_FULL (555.368 µs) : 534, 577
.   : milestone, 555,
iast_GLOBAL (503.506 µs) : 482, 525
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (479.827 µs) : 459, 501
.   : milestone, 480,
iast_INACTIVE (448.369 µs) : 428, 469
.   : milestone, 448,
iast_TELEMETRY_OFF (467.401 µs) : 447, 488
.   : milestone, 467,
tracing (434.629 µs) : 414, 455
.   : milestone, 435,
section candidate
no_agent (363.389 µs) : 344, 383
.   : milestone, 363,
iast (483.021 µs) : 462, 504
.   : milestone, 483,
iast_FULL (551.665 µs) : 531, 573
.   : milestone, 552,
iast_GLOBAL (497.523 µs) : 477, 518
.   : milestone, 498,
iast_HARDCODED_SECRET_DISABLED (476.814 µs) : 456, 498
.   : milestone, 477,
iast_INACTIVE (450.234 µs) : 429, 472
.   : milestone, 450,
iast_TELEMETRY_OFF (470.427 µs) : 449, 492
.   : milestone, 470,
tracing (444.96 µs) : 424, 466
.   : milestone, 445,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 365.271 µs [345.757 µs, 384.784 µs] -
iast 485.326 µs [463.577 µs, 507.075 µs] 120.055 µs (32.9%)
iast_FULL 555.368 µs [534.14 µs, 576.597 µs] 190.098 µs (52.0%)
iast_GLOBAL 503.506 µs [481.765 µs, 525.247 µs] 138.235 µs (37.8%)
iast_HARDCODED_SECRET_DISABLED 479.827 µs [458.748 µs, 500.906 µs] 114.556 µs (31.4%)
iast_INACTIVE 448.369 µs [427.67 µs, 469.068 µs] 83.098 µs (22.7%)
iast_TELEMETRY_OFF 467.401 µs [446.749 µs, 488.053 µs] 102.13 µs (28.0%)
tracing 434.629 µs [414.322 µs, 454.936 µs] 69.358 µs (19.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.389 µs [343.667 µs, 383.112 µs] -
iast 483.021 µs [461.72 µs, 504.322 µs] 119.632 µs (32.9%)
iast_FULL 551.665 µs [530.7 µs, 572.63 µs] 188.276 µs (51.8%)
iast_GLOBAL 497.523 µs [476.568 µs, 518.479 µs] 134.134 µs (36.9%)
iast_HARDCODED_SECRET_DISABLED 476.814 µs [455.851 µs, 497.777 µs] 113.425 µs (31.2%)
iast_INACTIVE 450.234 µs [428.919 µs, 471.549 µs] 86.845 µs (23.9%)
iast_TELEMETRY_OFF 470.427 µs [448.708 µs, 492.146 µs] 107.037 µs (29.5%)
tracing 444.96 µs [423.691 µs, 466.229 µs] 81.57 µs (22.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master paul.laffon/default-spark-app-name-hadoop
git_commit_date 1720513897 1720514050
git_commit_sha 9e7aa67 2f40cd1
release_version 1.38.0-SNAPSHOT~9e7aa67ce6 1.38.0-SNAPSHOT~2f40cd1d33
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1720515941 1720515941
ci_job_id 566177582 566177582
ci_pipeline_id 38674671 38674671
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~2f40cd1d33, baseline=1.38.0-SNAPSHOT~9e7aa67ce6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.456 ms) : 1444, 1467
.   : milestone, 1456,
appsec (2.232 ms) : 2196, 2268
.   : milestone, 2232,
iast (1.974 ms) : 1931, 2016
.   : milestone, 1974,
iast_GLOBAL (2.015 ms) : 1973, 2057
.   : milestone, 2015,
profiling (1.854 ms) : 1820, 1888
.   : milestone, 1854,
tracing (1.827 ms) : 1795, 1859
.   : milestone, 1827,
section candidate
no_agent (1.452 ms) : 1441, 1464
.   : milestone, 1452,
appsec (2.227 ms) : 2192, 2263
.   : milestone, 2227,
iast (1.97 ms) : 1928, 2012
.   : milestone, 1970,
iast_GLOBAL (2.007 ms) : 1964, 2050
.   : milestone, 2007,
profiling (1.848 ms) : 1815, 1882
.   : milestone, 1848,
tracing (1.84 ms) : 1807, 1872
.   : milestone, 1840,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.456 ms [1.444 ms, 1.467 ms] -
appsec 2.232 ms [2.196 ms, 2.268 ms] 776.317 µs (53.3%)
iast 1.974 ms [1.931 ms, 2.016 ms] 518.256 µs (35.6%)
iast_GLOBAL 2.015 ms [1.973 ms, 2.057 ms] 559.336 µs (38.4%)
profiling 1.854 ms [1.82 ms, 1.888 ms] 398.216 µs (27.4%)
tracing 1.827 ms [1.795 ms, 1.859 ms] 371.101 µs (25.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.452 ms [1.441 ms, 1.464 ms] -
appsec 2.227 ms [2.192 ms, 2.263 ms] 774.906 µs (53.4%)
iast 1.97 ms [1.928 ms, 2.012 ms] 517.941 µs (35.7%)
iast_GLOBAL 2.007 ms [1.964 ms, 2.05 ms] 554.773 µs (38.2%)
profiling 1.848 ms [1.815 ms, 1.882 ms] 395.958 µs (27.3%)
tracing 1.84 ms [1.807 ms, 1.872 ms] 387.339 µs (26.7%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~2f40cd1d33, baseline=1.38.0-SNAPSHOT~9e7aa67ce6
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.48 s) : 15480000, 15480000
.   : milestone, 15480000,
appsec (15.003 s) : 15003000, 15003000
.   : milestone, 15003000,
iast (18.61 s) : 18610000, 18610000
.   : milestone, 18610000,
iast_GLOBAL (17.928 s) : 17928000, 17928000
.   : milestone, 17928000,
profiling (15.251 s) : 15251000, 15251000
.   : milestone, 15251000,
tracing (15.219 s) : 15219000, 15219000
.   : milestone, 15219000,
section candidate
no_agent (15.45 s) : 15450000, 15450000
.   : milestone, 15450000,
appsec (14.835 s) : 14835000, 14835000
.   : milestone, 14835000,
iast (19.005 s) : 19005000, 19005000
.   : milestone, 19005000,
iast_GLOBAL (18.054 s) : 18054000, 18054000
.   : milestone, 18054000,
profiling (15.284 s) : 15284000, 15284000
.   : milestone, 15284000,
tracing (14.922 s) : 14922000, 14922000
.   : milestone, 14922000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.48 s [15.48 s, 15.48 s] -
appsec 15.003 s [15.003 s, 15.003 s] -477.0 ms (-3.1%)
iast 18.61 s [18.61 s, 18.61 s] 3.13 s (20.2%)
iast_GLOBAL 17.928 s [17.928 s, 17.928 s] 2.448 s (15.8%)
profiling 15.251 s [15.251 s, 15.251 s] -229.0 ms (-1.5%)
tracing 15.219 s [15.219 s, 15.219 s] -261.0 ms (-1.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.45 s [15.45 s, 15.45 s] -
appsec 14.835 s [14.835 s, 14.835 s] -615.0 ms (-4.0%)
iast 19.005 s [19.005 s, 19.005 s] 3.555 s (23.0%)
iast_GLOBAL 18.054 s [18.054 s, 18.054 s] 2.604 s (16.9%)
profiling 15.284 s [15.284 s, 15.284 s] -166.0 ms (-1.1%)
tracing 14.922 s [14.922 s, 14.922 s] -528.0 ms (-3.4%)

@paul-laffon-dd paul-laffon-dd added the inst: apache spark Apache Spark instrumentation label Jul 10, 2024
@paul-laffon-dd paul-laffon-dd marked this pull request as ready for review July 10, 2024 11:49
@paul-laffon-dd paul-laffon-dd requested a review from a team as a code owner July 10, 2024 11:49
yiliangzhou
yiliangzhou approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@yiliangzhou yiliangzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paul-laffon-dd paul-laffon-dd merged commit 1538da0 into master Jul 12, 2024
84 checks passed
@paul-laffon-dd paul-laffon-dd deleted the paul.laffon/default-spark-app-name-hadoop branch July 12, 2024 12:20
@github-actions github-actions bot added this to the 1.38.0 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiliangzhou yiliangzhou yiliangzhou approved these changes

Assignees
No one assigned
Labels
inst: apache spark Apache Spark instrumentation
Projects
None yet
Milestone
1.38.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paul-laffon-dd @yiliangzhou