-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove fast codec module as only one will ever exist #7302
Merged
manuel-alvarez-alvarez
merged 2 commits into
master
from
malvarez/iast-refactor-codec-module
Jul 11, 2024
Merged
Remove fast codec module as only one will ever exist #7302
manuel-alvarez-alvarez
merged 2 commits into
master
from
malvarez/iast-refactor-codec-module
Jul 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.38.0-SNAPSHOT~b91c2cb8ac, baseline=1.38.0-SNAPSHOT~120b584fde
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1061893
Total [baseline] (10.313 s) : 0, 10313043
Agent [candidate] (1.062 s) : 0, 1062335
Total [candidate] (10.371 s) : 0, 10370932
section appsec
Agent [baseline] (1.184 s) : 0, 1183966
Total [baseline] (10.573 s) : 0, 10573221
Agent [candidate] (1.18 s) : 0, 1179964
Total [candidate] (10.571 s) : 0, 10571494
section iast
Agent [baseline] (1.17 s) : 0, 1169511
Total [baseline] (10.705 s) : 0, 10704791
Agent [candidate] (1.179 s) : 0, 1178614
Total [candidate] (10.789 s) : 0, 10788827
section profiling
Agent [baseline] (1.262 s) : 0, 1262480
Total [baseline] (10.594 s) : 0, 10593817
Agent [candidate] (1.271 s) : 0, 1270911
Total [candidate] (10.658 s) : 0, 10657604
gantt
title petclinic - break down per module: candidate=1.38.0-SNAPSHOT~b91c2cb8ac, baseline=1.38.0-SNAPSHOT~120b584fde
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.556 ms) : 0, 664556
BytebuddyAgent [candidate] (664.625 ms) : 0, 664625
GlobalTracer [baseline] (304.74 ms) : 0, 304740
GlobalTracer [candidate] (304.766 ms) : 0, 304766
AppSec [baseline] (49.771 ms) : 0, 49771
AppSec [candidate] (50.081 ms) : 0, 50081
Remote Config [baseline] (664.371 µs) : 0, 664
Remote Config [candidate] (669.453 µs) : 0, 669
Telemetry [baseline] (7.603 ms) : 0, 7603
Telemetry [candidate] (7.632 ms) : 0, 7632
section appsec
BytebuddyAgent [baseline] (675.075 ms) : 0, 675075
BytebuddyAgent [candidate] (675.192 ms) : 0, 675192
GlobalTracer [baseline] (299.842 ms) : 0, 299842
GlobalTracer [candidate] (298.284 ms) : 0, 298284
AppSec [baseline] (154.587 ms) : 0, 154587
AppSec [candidate] (154.038 ms) : 0, 154038
IAST [baseline] (20.583 ms) : 0, 20583
IAST [candidate] (20.914 ms) : 0, 20914
Remote Config [baseline] (628.22 µs) : 0, 628
Remote Config [candidate] (618.274 µs) : 0, 618
Telemetry [baseline] (8.953 ms) : 0, 8953
Telemetry [candidate] (6.743 ms) : 0, 6743
section iast
BytebuddyAgent [baseline] (778.223 ms) : 0, 778223
BytebuddyAgent [candidate] (784.267 ms) : 0, 784267
GlobalTracer [baseline] (295.097 ms) : 0, 295097
GlobalTracer [candidate] (297.631 ms) : 0, 297631
AppSec [baseline] (47.223 ms) : 0, 47223
AppSec [candidate] (47.413 ms) : 0, 47413
IAST [baseline] (27.073 ms) : 0, 27073
IAST [candidate] (28.144 ms) : 0, 28144
Remote Config [baseline] (583.814 µs) : 0, 584
Remote Config [candidate] (586.936 µs) : 0, 587
Telemetry [baseline] (7.814 ms) : 0, 7814
Telemetry [candidate] (6.951 ms) : 0, 6951
section profiling
BytebuddyAgent [baseline] (661.5 ms) : 0, 661500
BytebuddyAgent [candidate] (666.333 ms) : 0, 666333
GlobalTracer [baseline] (388.133 ms) : 0, 388133
GlobalTracer [candidate] (390.948 ms) : 0, 390948
AppSec [baseline] (51.507 ms) : 0, 51507
AppSec [candidate] (51.894 ms) : 0, 51894
Remote Config [baseline] (640.208 µs) : 0, 640
Remote Config [candidate] (645.192 µs) : 0, 645
Telemetry [baseline] (7.363 ms) : 0, 7363
Telemetry [candidate] (7.394 ms) : 0, 7394
ProfilingAgent [baseline] (96.265 ms) : 0, 96265
ProfilingAgent [candidate] (96.168 ms) : 0, 96168
Profiling [baseline] (96.291 ms) : 0, 96291
Profiling [candidate] (96.193 ms) : 0, 96193
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.38.0-SNAPSHOT~b91c2cb8ac, baseline=1.38.0-SNAPSHOT~120b584fde
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1061770
Total [baseline] (8.507 s) : 0, 8507269
Agent [candidate] (1.063 s) : 0, 1062885
Total [candidate] (8.536 s) : 0, 8535714
section iast
Agent [baseline] (1.175 s) : 0, 1174852
Total [baseline] (8.96 s) : 0, 8959896
Agent [candidate] (1.17 s) : 0, 1169981
Total [candidate] (8.96 s) : 0, 8959680
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.176 s) : 0, 1175724
Total [baseline] (8.938 s) : 0, 8938061
Agent [candidate] (1.169 s) : 0, 1169331
Total [candidate] (8.968 s) : 0, 8968142
section iast_TELEMETRY_OFF
Agent [baseline] (1.166 s) : 0, 1166396
Total [baseline] (8.948 s) : 0, 8947880
Agent [candidate] (1.168 s) : 0, 1167810
Total [candidate] (8.945 s) : 0, 8945375
gantt
title insecure-bank - break down per module: candidate=1.38.0-SNAPSHOT~b91c2cb8ac, baseline=1.38.0-SNAPSHOT~120b584fde
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.46 ms) : 0, 664460
BytebuddyAgent [candidate] (664.852 ms) : 0, 664852
GlobalTracer [baseline] (304.315 ms) : 0, 304315
GlobalTracer [candidate] (305.103 ms) : 0, 305103
AppSec [baseline] (50.109 ms) : 0, 50109
AppSec [candidate] (49.953 ms) : 0, 49953
Remote Config [baseline] (674.077 µs) : 0, 674
Remote Config [candidate] (675.76 µs) : 0, 676
Telemetry [baseline] (7.678 ms) : 0, 7678
Telemetry [candidate] (7.737 ms) : 0, 7737
section iast
BytebuddyAgent [baseline] (780.745 ms) : 0, 780745
BytebuddyAgent [candidate] (778.682 ms) : 0, 778682
GlobalTracer [baseline] (297.534 ms) : 0, 297534
GlobalTracer [candidate] (295.186 ms) : 0, 295186
AppSec [baseline] (48.455 ms) : 0, 48455
AppSec [candidate] (47.344 ms) : 0, 47344
IAST [baseline] (26.313 ms) : 0, 26313
IAST [candidate] (27.774 ms) : 0, 27774
Remote Config [baseline] (590.958 µs) : 0, 591
Remote Config [candidate] (590.646 µs) : 0, 591
Telemetry [baseline] (7.704 ms) : 0, 7704
Telemetry [candidate] (6.933 ms) : 0, 6933
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (783.421 ms) : 0, 783421
BytebuddyAgent [candidate] (778.45 ms) : 0, 778450
GlobalTracer [baseline] (295.821 ms) : 0, 295821
GlobalTracer [candidate] (295.686 ms) : 0, 295686
AppSec [baseline] (47.527 ms) : 0, 47527
AppSec [candidate] (47.423 ms) : 0, 47423
IAST [baseline] (27.832 ms) : 0, 27832
IAST [candidate] (26.613 ms) : 0, 26613
Remote Config [baseline] (573.217 µs) : 0, 573
Remote Config [candidate] (583.782 µs) : 0, 584
Telemetry [baseline] (6.917 ms) : 0, 6917
Telemetry [candidate] (7.019 ms) : 0, 7019
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (776.088 ms) : 0, 776088
BytebuddyAgent [candidate] (776.251 ms) : 0, 776251
GlobalTracer [baseline] (294.855 ms) : 0, 294855
GlobalTracer [candidate] (295.9 ms) : 0, 295900
AppSec [baseline] (47.051 ms) : 0, 47051
AppSec [candidate] (47.064 ms) : 0, 47064
IAST [baseline] (27.489 ms) : 0, 27489
IAST [candidate] (27.692 ms) : 0, 27692
Remote Config [baseline] (605.533 µs) : 0, 606
Remote Config [candidate] (577.593 µs) : 0, 578
Telemetry [baseline] (6.775 ms) : 0, 6775
Telemetry [candidate] (6.781 ms) : 0, 6781
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~b91c2cb8ac, baseline=1.38.0-SNAPSHOT~120b584fde
dateFormat X
axisFormat %s
section baseline
no_agent (1.344 ms) : 1324, 1363
. : milestone, 1344,
appsec (1.72 ms) : 1697, 1743
. : milestone, 1720,
appsec_no_iast (1.696 ms) : 1672, 1721
. : milestone, 1696,
iast (1.482 ms) : 1459, 1505
. : milestone, 1482,
profiling (1.465 ms) : 1440, 1489
. : milestone, 1465,
tracing (1.448 ms) : 1424, 1473
. : milestone, 1448,
section candidate
no_agent (1.346 ms) : 1325, 1366
. : milestone, 1346,
appsec (1.708 ms) : 1684, 1731
. : milestone, 1708,
appsec_no_iast (1.715 ms) : 1692, 1739
. : milestone, 1715,
iast (1.482 ms) : 1459, 1504
. : milestone, 1482,
profiling (1.481 ms) : 1457, 1505
. : milestone, 1481,
tracing (1.444 ms) : 1419, 1468
. : milestone, 1444,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~b91c2cb8ac, baseline=1.38.0-SNAPSHOT~120b584fde
dateFormat X
axisFormat %s
section baseline
no_agent (362.746 µs) : 342, 384
. : milestone, 363,
iast (473.926 µs) : 453, 495
. : milestone, 474,
iast_FULL (546.392 µs) : 525, 568
. : milestone, 546,
iast_GLOBAL (497.557 µs) : 476, 519
. : milestone, 498,
iast_HARDCODED_SECRET_DISABLED (472.101 µs) : 451, 493
. : milestone, 472,
iast_INACTIVE (449.127 µs) : 428, 471
. : milestone, 449,
iast_TELEMETRY_OFF (463.198 µs) : 442, 484
. : milestone, 463,
tracing (438.027 µs) : 417, 459
. : milestone, 438,
section candidate
no_agent (363.837 µs) : 344, 384
. : milestone, 364,
iast (480.474 µs) : 459, 502
. : milestone, 480,
iast_FULL (544.992 µs) : 524, 566
. : milestone, 545,
iast_GLOBAL (502.584 µs) : 481, 524
. : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (469.814 µs) : 449, 491
. : milestone, 470,
iast_INACTIVE (450.183 µs) : 429, 472
. : milestone, 450,
iast_TELEMETRY_OFF (472.515 µs) : 451, 494
. : milestone, 473,
tracing (437.417 µs) : 417, 458
. : milestone, 437,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~b91c2cb8ac, baseline=1.38.0-SNAPSHOT~120b584fde
dateFormat X
axisFormat %s
section baseline
no_agent (1.456 ms) : 1444, 1467
. : milestone, 1456,
appsec (2.228 ms) : 2192, 2263
. : milestone, 2228,
iast (1.972 ms) : 1930, 2013
. : milestone, 1972,
iast_GLOBAL (2.008 ms) : 1966, 2050
. : milestone, 2008,
profiling (1.863 ms) : 1829, 1897
. : milestone, 1863,
tracing (1.836 ms) : 1804, 1869
. : milestone, 1836,
section candidate
no_agent (1.457 ms) : 1446, 1469
. : milestone, 1457,
appsec (2.222 ms) : 2188, 2257
. : milestone, 2222,
iast (1.972 ms) : 1930, 2014
. : milestone, 1972,
iast_GLOBAL (2.02 ms) : 1978, 2062
. : milestone, 2020,
profiling (1.863 ms) : 1828, 1898
. : milestone, 1863,
tracing (1.837 ms) : 1805, 1870
. : milestone, 1837,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~b91c2cb8ac, baseline=1.38.0-SNAPSHOT~120b584fde
dateFormat X
axisFormat %s
section baseline
no_agent (15.22 s) : 15220000, 15220000
. : milestone, 15220000,
appsec (14.768 s) : 14768000, 14768000
. : milestone, 14768000,
iast (18.65 s) : 18650000, 18650000
. : milestone, 18650000,
iast_GLOBAL (18.035 s) : 18035000, 18035000
. : milestone, 18035000,
profiling (15.402 s) : 15402000, 15402000
. : milestone, 15402000,
tracing (15.037 s) : 15037000, 15037000
. : milestone, 15037000,
section candidate
no_agent (14.997 s) : 14997000, 14997000
. : milestone, 14997000,
appsec (14.999 s) : 14999000, 14999000
. : milestone, 14999000,
iast (18.898 s) : 18898000, 18898000
. : milestone, 18898000,
iast_GLOBAL (17.743 s) : 17743000, 17743000
. : milestone, 17743000,
profiling (15.435 s) : 15435000, 15435000
. : milestone, 15435000,
tracing (14.918 s) : 14918000, 14918000
. : milestone, 14918000,
|
jandro996
reviewed
Jul 10, 2024
dd-java-agent/agent-iast/src/main/java/com/datadog/iast/IastSystem.java
Outdated
Show resolved
Hide resolved
jandro996
approved these changes
Jul 10, 2024
981b308
to
b91c2cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: asm iast
Application Security Management (IAST)
tag: no release notes
Changes to exclude from release notes
type: refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Refactors the CodecModule implementation to make it easier to review PR
Motivation
Additional Notes
Jira ticket: APPSEC-53838