Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce GatewayContext to propagate instrumentation specific traits #7304

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Introduce GatewayContext to propagate instrumentation specific traits #7304

merged 1 commit into from
Jul 11, 2024

Conversation

ValentinZakharov
Copy link
Contributor

@ValentinZakharov ValentinZakharov commented Jul 10, 2024 •
edited by jira bot
Loading

What Does This Do

Introduced GatewayContext. It used to describe instrumentations data traits that are passes through the InstrumentationGateway. Currently, each instrumentation data has:

  • isTransient - to identify if the data is ephemeral or persistent within the request
  • isRasp - to identity data origin for Exploit Prevention

Motivation

This is part of Exploit prevention to let provide ruleType for the RASP instrumentations.

Additional Notes

Jira ticket: APPSEC-47228

@ValentinZakharov ValentinZakharov self-assigned this Jul 10, 2024
@ValentinZakharov ValentinZakharov added comp: asm waf Application Security Management (WAF) type: refactoring tag: no release notes Changes to exclude from release notes labels Jul 10, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jul 10, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master vzakharov/gateway_context
git_commit_date 1720619307 1720634880
git_commit_sha 120b584 eaf1c28
release_version 1.38.0-SNAPSHOT~120b584fde 1.38.0-SNAPSHOT~eaf1c28272
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1720637237 1720637237
ci_job_id 568659803 568659803
ci_pipeline_id 38871740 38871740
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.38.0-SNAPSHOT~eaf1c28272, baseline=1.38.0-SNAPSHOT~120b584fde

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065014
Total [baseline] (10.288 s) : 0, 10288367
Agent [candidate] (1.062 s) : 0, 1061707
Total [candidate] (10.301 s) : 0, 10300905
section appsec
Agent [baseline] (1.188 s) : 0, 1187639
Total [baseline] (10.485 s) : 0, 10484717
Agent [candidate] (1.184 s) : 0, 1184038
Total [candidate] (10.494 s) : 0, 10493941
section iast
Agent [baseline] (1.18 s) : 0, 1179828
Total [baseline] (10.673 s) : 0, 10672731
Agent [candidate] (1.171 s) : 0, 1171101
Total [candidate] (10.764 s) : 0, 10763972
section profiling
Agent [baseline] (1.265 s) : 0, 1264561
Total [baseline] (10.602 s) : 0, 10602193
Agent [candidate] (1.272 s) : 0, 1271936
Total [candidate] (10.588 s) : 0, 10588362
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent appsec 1.188 s 122.625 ms (11.5%)
Agent iast 1.18 s 114.813 ms (10.8%)
Agent profiling 1.265 s 199.547 ms (18.7%)
Total tracing 10.288 s -
Total appsec 10.485 s 196.351 ms (1.9%)
Total iast 10.673 s 384.365 ms (3.7%)
Total profiling 10.602 s 313.826 ms (3.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent appsec 1.184 s 122.331 ms (11.5%)
Agent iast 1.171 s 109.394 ms (10.3%)
Agent profiling 1.272 s 210.229 ms (19.8%)
Total tracing 10.301 s -
Total appsec 10.494 s 193.036 ms (1.9%)
Total iast 10.764 s 463.066 ms (4.5%)
Total profiling 10.588 s 287.456 ms (2.8%) 
gantt
    title petclinic - break down per module: candidate=1.38.0-SNAPSHOT~eaf1c28272, baseline=1.38.0-SNAPSHOT~120b584fde

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.417 ms) : 0, 666417
BytebuddyAgent [candidate] (664.094 ms) : 0, 664094
GlobalTracer [baseline] (305.357 ms) : 0, 305357
GlobalTracer [candidate] (305.05 ms) : 0, 305050
AppSec [baseline] (50.113 ms) : 0, 50113
AppSec [candidate] (49.8 ms) : 0, 49800
Remote Config [baseline] (672.119 µs) : 0, 672
Remote Config [candidate] (667.823 µs) : 0, 668
Telemetry [baseline] (7.74 ms) : 0, 7740
Telemetry [candidate] (7.649 ms) : 0, 7649
section appsec
BytebuddyAgent [baseline] (679.659 ms) : 0, 679659
BytebuddyAgent [candidate] (677.863 ms) : 0, 677863
GlobalTracer [baseline] (299.343 ms) : 0, 299343
GlobalTracer [candidate] (298.888 ms) : 0, 298888
AppSec [baseline] (154.05 ms) : 0, 154050
AppSec [candidate] (153.83 ms) : 0, 153830
IAST [baseline] (22.176 ms) : 0, 22176
IAST [candidate] (19.475 ms) : 0, 19475
Remote Config [baseline] (625.561 µs) : 0, 626
Remote Config [candidate] (623.903 µs) : 0, 624
Telemetry [baseline] (8.013 ms) : 0, 8013
Telemetry [candidate] (8.3 ms) : 0, 8300
section iast
BytebuddyAgent [baseline] (785.289 ms) : 0, 785289
BytebuddyAgent [candidate] (778.692 ms) : 0, 778692
GlobalTracer [baseline] (297.186 ms) : 0, 297186
GlobalTracer [candidate] (295.82 ms) : 0, 295820
AppSec [baseline] (47.545 ms) : 0, 47545
AppSec [candidate] (47.017 ms) : 0, 47017
IAST [baseline] (27.91 ms) : 0, 27910
IAST [candidate] (28.534 ms) : 0, 28534
Remote Config [baseline] (579.974 µs) : 0, 580
Remote Config [candidate] (569.389 µs) : 0, 569
Telemetry [baseline] (7.715 ms) : 0, 7715
Telemetry [candidate] (6.912 ms) : 0, 6912
section profiling
BytebuddyAgent [baseline] (662.971 ms) : 0, 662971
BytebuddyAgent [candidate] (666.256 ms) : 0, 666256
GlobalTracer [baseline] (388.966 ms) : 0, 388966
GlobalTracer [candidate] (391.87 ms) : 0, 391870
AppSec [baseline] (51.359 ms) : 0, 51359
AppSec [candidate] (51.804 ms) : 0, 51804
Remote Config [baseline] (638.681 µs) : 0, 639
Remote Config [candidate] (657.613 µs) : 0, 658
Telemetry [baseline] (7.349 ms) : 0, 7349
Telemetry [candidate] (7.438 ms) : 0, 7438
ProfilingAgent [baseline] (96.104 ms) : 0, 96104
ProfilingAgent [candidate] (96.27 ms) : 0, 96270
Profiling [baseline] (96.129 ms) : 0, 96129
Profiling [candidate] (96.294 ms) : 0, 96294
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.38.0-SNAPSHOT~eaf1c28272, baseline=1.38.0-SNAPSHOT~120b584fde

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1069360
Total [baseline] (8.531 s) : 0, 8530958
Agent [candidate] (1.062 s) : 0, 1061570
Total [candidate] (8.488 s) : 0, 8487657
section iast
Agent [baseline] (1.169 s) : 0, 1168719
Total [baseline] (8.929 s) : 0, 8928847
Agent [candidate] (1.17 s) : 0, 1170251
Total [candidate] (8.919 s) : 0, 8918730
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.171 s) : 0, 1170646
Total [baseline] (8.928 s) : 0, 8928200
Agent [candidate] (1.186 s) : 0, 1185565
Total [candidate] (8.935 s) : 0, 8935374
section iast_TELEMETRY_OFF
Agent [baseline] (1.166 s) : 0, 1165822
Total [baseline] (8.959 s) : 0, 8959322
Agent [candidate] (1.167 s) : 0, 1167458
Total [candidate] (8.985 s) : 0, 8984781
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.069 s -
Agent iast 1.169 s 99.358 ms (9.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.171 s 101.286 ms (9.5%)
Agent iast_TELEMETRY_OFF 1.166 s 96.462 ms (9.0%)
Total tracing 8.531 s -
Total iast 8.929 s 397.888 ms (4.7%)
Total iast_HARDCODED_SECRET_DISABLED 8.928 s 397.242 ms (4.7%)
Total iast_TELEMETRY_OFF 8.959 s 428.364 ms (5.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent iast 1.17 s 108.681 ms (10.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.186 s 123.995 ms (11.7%)
Agent iast_TELEMETRY_OFF 1.167 s 105.888 ms (10.0%)
Total tracing 8.488 s -
Total iast 8.919 s 431.073 ms (5.1%)
Total iast_HARDCODED_SECRET_DISABLED 8.935 s 447.717 ms (5.3%)
Total iast_TELEMETRY_OFF 8.985 s 497.123 ms (5.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.38.0-SNAPSHOT~eaf1c28272, baseline=1.38.0-SNAPSHOT~120b584fde

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.007 ms) : 0, 669007
BytebuddyAgent [candidate] (664.051 ms) : 0, 664051
GlobalTracer [baseline] (307.249 ms) : 0, 307249
GlobalTracer [candidate] (304.572 ms) : 0, 304572
AppSec [baseline] (50.078 ms) : 0, 50078
AppSec [candidate] (50.089 ms) : 0, 50089
Remote Config [baseline] (673.551 µs) : 0, 674
Remote Config [candidate] (672.98 µs) : 0, 673
Telemetry [baseline] (7.687 ms) : 0, 7687
Telemetry [candidate] (7.654 ms) : 0, 7654
section iast
BytebuddyAgent [baseline] (778.014 ms) : 0, 778014
BytebuddyAgent [candidate] (778.452 ms) : 0, 778452
GlobalTracer [baseline] (295.33 ms) : 0, 295330
GlobalTracer [candidate] (295.205 ms) : 0, 295205
AppSec [baseline] (47.984 ms) : 0, 47984
AppSec [candidate] (47.134 ms) : 0, 47134
IAST [baseline] (26.452 ms) : 0, 26452
IAST [candidate] (27.64 ms) : 0, 27640
Remote Config [baseline] (574.323 µs) : 0, 574
Remote Config [candidate] (583.736 µs) : 0, 584
Telemetry [baseline] (6.928 ms) : 0, 6928
Telemetry [candidate] (7.779 ms) : 0, 7779
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (779.996 ms) : 0, 779996
BytebuddyAgent [candidate] (790.328 ms) : 0, 790328
GlobalTracer [baseline] (295.488 ms) : 0, 295488
GlobalTracer [candidate] (299.408 ms) : 0, 299408
AppSec [baseline] (47.226 ms) : 0, 47226
AppSec [candidate] (47.998 ms) : 0, 47998
IAST [baseline] (26.925 ms) : 0, 26925
IAST [candidate] (26.576 ms) : 0, 26576
Remote Config [baseline] (566.594 µs) : 0, 567
Remote Config [candidate] (574.269 µs) : 0, 574
Telemetry [baseline] (6.887 ms) : 0, 6887
Telemetry [candidate] (6.978 ms) : 0, 6978
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (775.564 ms) : 0, 775564
BytebuddyAgent [candidate] (776.814 ms) : 0, 776814
GlobalTracer [baseline] (294.766 ms) : 0, 294766
GlobalTracer [candidate] (295.528 ms) : 0, 295528
AppSec [baseline] (47.012 ms) : 0, 47012
AppSec [candidate] (47.102 ms) : 0, 47102
IAST [baseline] (27.583 ms) : 0, 27583
IAST [candidate] (26.99 ms) : 0, 26990
Remote Config [baseline] (599.682 µs) : 0, 600
Remote Config [candidate] (603.194 µs) : 0, 603
Telemetry [baseline] (6.794 ms) : 0, 6794
Telemetry [candidate] (6.892 ms) : 0, 6892
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-07-10T18:17:51 2024-07-10T18:24:40
git_branch master vzakharov/gateway_context
git_commit_date 1720619307 1720634880
git_commit_sha 120b584 eaf1c28
release_version 1.38.0-SNAPSHOT~120b584fde 1.38.0-SNAPSHOT~eaf1c28272
start_time 2024-07-10T18:17:37 2024-07-10T18:24:26
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1720636224 1720636224
ci_job_id 568659804 568659804
ci_pipeline_id 38871740 38871740
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~eaf1c28272, baseline=1.38.0-SNAPSHOT~120b584fde
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.354 ms) : 1335, 1374
.   : milestone, 1354,
appsec (1.711 ms) : 1688, 1735
.   : milestone, 1711,
appsec_no_iast (1.722 ms) : 1698, 1747
.   : milestone, 1722,
iast (1.467 ms) : 1444, 1489
.   : milestone, 1467,
profiling (1.5 ms) : 1474, 1527
.   : milestone, 1500,
tracing (1.467 ms) : 1442, 1491
.   : milestone, 1467,
section candidate
no_agent (1.352 ms) : 1333, 1372
.   : milestone, 1352,
appsec (1.717 ms) : 1692, 1741
.   : milestone, 1717,
appsec_no_iast (1.716 ms) : 1692, 1740
.   : milestone, 1716,
iast (1.473 ms) : 1450, 1495
.   : milestone, 1473,
profiling (1.491 ms) : 1466, 1516
.   : milestone, 1491,
tracing (1.451 ms) : 1427, 1475
.   : milestone, 1451,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.354 ms [1.335 ms, 1.374 ms] -
appsec 1.711 ms [1.688 ms, 1.735 ms] 357.164 µs (26.4%)
appsec_no_iast 1.722 ms [1.698 ms, 1.747 ms] 368.275 µs (27.2%)
iast 1.467 ms [1.444 ms, 1.489 ms] 112.881 µs (8.3%)
profiling 1.5 ms [1.474 ms, 1.527 ms] 146.185 µs (10.8%)
tracing 1.467 ms [1.442 ms, 1.491 ms] 112.445 µs (8.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.352 ms [1.333 ms, 1.372 ms] -
appsec 1.717 ms [1.692 ms, 1.741 ms] 364.117 µs (26.9%)
appsec_no_iast 1.716 ms [1.692 ms, 1.74 ms] 363.362 µs (26.9%)
iast 1.473 ms [1.45 ms, 1.495 ms] 120.533 µs (8.9%)
profiling 1.491 ms [1.466 ms, 1.516 ms] 138.427 µs (10.2%)
tracing 1.451 ms [1.427 ms, 1.475 ms] 98.869 µs (7.3%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~eaf1c28272, baseline=1.38.0-SNAPSHOT~120b584fde
    dateFormat X
    axisFormat %s
section baseline
no_agent (370.24 µs) : 351, 390
.   : milestone, 370,
iast (488.086 µs) : 466, 510
.   : milestone, 488,
iast_FULL (553.636 µs) : 533, 575
.   : milestone, 554,
iast_GLOBAL (514.953 µs) : 491, 539
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (483.168 µs) : 462, 504
.   : milestone, 483,
iast_INACTIVE (453.595 µs) : 433, 475
.   : milestone, 454,
iast_TELEMETRY_OFF (471.531 µs) : 450, 493
.   : milestone, 472,
tracing (447.182 µs) : 427, 468
.   : milestone, 447,
section candidate
no_agent (364.869 µs) : 345, 385
.   : milestone, 365,
iast (486.462 µs) : 466, 507
.   : milestone, 486,
iast_FULL (553.755 µs) : 533, 575
.   : milestone, 554,
iast_GLOBAL (516.408 µs) : 493, 540
.   : milestone, 516,
iast_HARDCODED_SECRET_DISABLED (481.579 µs) : 460, 503
.   : milestone, 482,
iast_INACTIVE (453.296 µs) : 433, 474
.   : milestone, 453,
iast_TELEMETRY_OFF (470.208 µs) : 449, 491
.   : milestone, 470,
tracing (446.01 µs) : 425, 467
.   : milestone, 446,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.24 µs [350.874 µs, 389.605 µs] -
iast 488.086 µs [466.259 µs, 509.913 µs] 117.847 µs (31.8%)
iast_FULL 553.636 µs [532.713 µs, 574.558 µs] 183.396 µs (49.5%)
iast_GLOBAL 514.953 µs [491.177 µs, 538.729 µs] 144.714 µs (39.1%)
iast_HARDCODED_SECRET_DISABLED 483.168 µs [462.136 µs, 504.199 µs] 112.928 µs (30.5%)
iast_INACTIVE 453.595 µs [432.504 µs, 474.685 µs] 83.355 µs (22.5%)
iast_TELEMETRY_OFF 471.531 µs [450.416 µs, 492.647 µs] 101.292 µs (27.4%)
tracing 447.182 µs [426.636 µs, 467.728 µs] 76.942 µs (20.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.869 µs [344.802 µs, 384.937 µs] -
iast 486.462 µs [465.501 µs, 507.422 µs] 121.592 µs (33.3%)
iast_FULL 553.755 µs [532.711 µs, 574.8 µs] 188.886 µs (51.8%)
iast_GLOBAL 516.408 µs [493.275 µs, 539.541 µs] 151.539 µs (41.5%)
iast_HARDCODED_SECRET_DISABLED 481.579 µs [460.082 µs, 503.077 µs] 116.71 µs (32.0%)
iast_INACTIVE 453.296 µs [432.648 µs, 473.944 µs] 88.427 µs (24.2%)
iast_TELEMETRY_OFF 470.208 µs [449.404 µs, 491.012 µs] 105.338 µs (28.9%)
tracing 446.01 µs [425.013 µs, 467.006 µs] 81.14 µs (22.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master vzakharov/gateway_context
git_commit_date 1720619307 1720634880
git_commit_sha 120b584 eaf1c28
release_version 1.38.0-SNAPSHOT~120b584fde 1.38.0-SNAPSHOT~eaf1c28272
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1720636753 1720636753
ci_job_id 568659805 568659805
ci_pipeline_id 38871740 38871740
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~eaf1c28272, baseline=1.38.0-SNAPSHOT~120b584fde
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.455 ms) : 1443, 1466
.   : milestone, 1455,
appsec (2.221 ms) : 2186, 2257
.   : milestone, 2221,
iast (1.968 ms) : 1926, 2010
.   : milestone, 1968,
iast_GLOBAL (2.009 ms) : 1966, 2052
.   : milestone, 2009,
profiling (1.866 ms) : 1830, 1901
.   : milestone, 1866,
tracing (1.828 ms) : 1795, 1860
.   : milestone, 1828,
section candidate
no_agent (1.459 ms) : 1447, 1470
.   : milestone, 1459,
appsec (2.218 ms) : 2183, 2253
.   : milestone, 2218,
iast (1.972 ms) : 1930, 2014
.   : milestone, 1972,
iast_GLOBAL (2.002 ms) : 1960, 2043
.   : milestone, 2002,
profiling (1.842 ms) : 1808, 1876
.   : milestone, 1842,
tracing (1.83 ms) : 1797, 1862
.   : milestone, 1830,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.455 ms [1.443 ms, 1.466 ms] -
appsec 2.221 ms [2.186 ms, 2.257 ms] 766.663 µs (52.7%)
iast 1.968 ms [1.926 ms, 2.01 ms] 512.807 µs (35.3%)
iast_GLOBAL 2.009 ms [1.966 ms, 2.052 ms] 553.992 µs (38.1%)
profiling 1.866 ms [1.83 ms, 1.901 ms] 411.174 µs (28.3%)
tracing 1.828 ms [1.795 ms, 1.86 ms] 373.047 µs (25.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.447 ms, 1.47 ms] -
appsec 2.218 ms [2.183 ms, 2.253 ms] 759.405 µs (52.1%)
iast 1.972 ms [1.93 ms, 2.014 ms] 513.258 µs (35.2%)
iast_GLOBAL 2.002 ms [1.96 ms, 2.043 ms] 543.23 µs (37.2%)
profiling 1.842 ms [1.808 ms, 1.876 ms] 383.444 µs (26.3%)
tracing 1.83 ms [1.797 ms, 1.862 ms] 371.344 µs (25.5%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~eaf1c28272, baseline=1.38.0-SNAPSHOT~120b584fde
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.083 s) : 15083000, 15083000
.   : milestone, 15083000,
appsec (14.939 s) : 14939000, 14939000
.   : milestone, 14939000,
iast (18.692 s) : 18692000, 18692000
.   : milestone, 18692000,
iast_GLOBAL (17.86 s) : 17860000, 17860000
.   : milestone, 17860000,
profiling (15.035 s) : 15035000, 15035000
.   : milestone, 15035000,
tracing (15.208 s) : 15208000, 15208000
.   : milestone, 15208000,
section candidate
no_agent (15.396 s) : 15396000, 15396000
.   : milestone, 15396000,
appsec (14.799 s) : 14799000, 14799000
.   : milestone, 14799000,
iast (18.645 s) : 18645000, 18645000
.   : milestone, 18645000,
iast_GLOBAL (17.986 s) : 17986000, 17986000
.   : milestone, 17986000,
profiling (15.79 s) : 15790000, 15790000
.   : milestone, 15790000,
tracing (14.956 s) : 14956000, 14956000
.   : milestone, 14956000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.083 s [15.083 s, 15.083 s] -
appsec 14.939 s [14.939 s, 14.939 s] -144.0 ms (-1.0%)
iast 18.692 s [18.692 s, 18.692 s] 3.609 s (23.9%)
iast_GLOBAL 17.86 s [17.86 s, 17.86 s] 2.777 s (18.4%)
profiling 15.035 s [15.035 s, 15.035 s] -48.0 ms (-0.3%)
tracing 15.208 s [15.208 s, 15.208 s] 125.0 ms (0.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.396 s [15.396 s, 15.396 s] -
appsec 14.799 s [14.799 s, 14.799 s] -597.0 ms (-3.9%)
iast 18.645 s [18.645 s, 18.645 s] 3.249 s (21.1%)
iast_GLOBAL 17.986 s [17.986 s, 17.986 s] 2.59 s (16.8%)
profiling 15.79 s [15.79 s, 15.79 s] 394.0 ms (2.6%)
tracing 14.956 s [14.956 s, 14.956 s] -440.0 ms (-2.9%)

@ValentinZakharov ValentinZakharov force-pushed the vzakharov/gateway_context branch 2 times, most recently from 4d4a752 to d0a4cfa Compare July 10, 2024 17:30
@ValentinZakharov ValentinZakharov marked this pull request as ready for review July 11, 2024 07:09
@ValentinZakharov ValentinZakharov requested a review from a team as a code owner July 11, 2024 07:09
@ValentinZakharov ValentinZakharov changed the title GatewayContext Introduce GatewayContext to propagate instrumentation specific traits Jul 11, 2024
@ValentinZakharov ValentinZakharov merged commit 8b00e3e into master Jul 11, 2024
82 checks passed
@ValentinZakharov ValentinZakharov deleted the vzakharov/gateway_context branch July 11, 2024 09:08
@github-actions github-actions bot added this to the 1.38.0 milestone Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smola smola smola approved these changes

@manuel-alvarez-alvarez manuel-alvarez-alvarez manuel-alvarez-alvarez approved these changes

@jandro996 jandro996 Awaiting requested review from jandro996 jandro996 is a code owner automatically assigned from DataDog/asm-java

Assignees

@ValentinZakharov ValentinZakharov

Labels
comp: asm waf Application Security Management (WAF) tag: no release notes Changes to exclude from release notes type: refactoring
Projects
None yet
Milestone
1.38.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ValentinZakharov @smola @manuel-alvarez-alvarez