Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support jetty client 12 #7305

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Support jetty client 12 #7305

merged 4 commits into from
Jul 12, 2024

Conversation

amarziali
Copy link
Collaborator

@amarziali amarziali commented Jul 10, 2024 •
edited
Loading

What Does This Do

Instrument jetty client 12+

Motivation

See #7300

Additional Notes

Jira ticket: [PROJ-IDENT]

@pr-commenter
Copy link

pr-commenter bot commented Jul 10, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/jetty-client-12
git_commit_date 1720700493 1720703653
git_commit_sha 95a52cc 50e50cd
release_version 1.38.0-SNAPSHOT~95a52cc95e 1.38.0-SNAPSHOT~50e50cd22e
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1720706134 1720706134
ci_job_id 569507577 569507577
ci_pipeline_id 38935075 38935075
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 7 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.38.0-SNAPSHOT~50e50cd22e, baseline=1.38.0-SNAPSHOT~95a52cc95e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1061162
Total [baseline] (10.359 s) : 0, 10358538
Agent [candidate] (1.072 s) : 0, 1071542
Total [candidate] (10.352 s) : 0, 10352494
section appsec
Agent [baseline] (1.182 s) : 0, 1181840
Total [baseline] (10.487 s) : 0, 10486971
Agent [candidate] (1.184 s) : 0, 1184148
Total [candidate] (10.531 s) : 0, 10531220
section iast
Agent [baseline] (1.17 s) : 0, 1170444
Total [baseline] (10.724 s) : 0, 10723960
Agent [candidate] (1.175 s) : 0, 1174995
Total [candidate] (10.703 s) : 0, 10702937
section profiling
Agent [baseline] (1.262 s) : 0, 1261823
Total [baseline] (10.621 s) : 0, 10621398
Agent [candidate] (1.264 s) : 0, 1264208
Total [candidate] (10.568 s) : 0, 10568216
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.061 s -
Agent appsec 1.182 s 120.678 ms (11.4%)
Agent iast 1.17 s 109.282 ms (10.3%)
Agent profiling 1.262 s 200.662 ms (18.9%)
Total tracing 10.359 s -
Total appsec 10.487 s 128.433 ms (1.2%)
Total iast 10.724 s 365.422 ms (3.5%)
Total profiling 10.621 s 262.86 ms (2.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.072 s -
Agent appsec 1.184 s 112.606 ms (10.5%)
Agent iast 1.175 s 103.453 ms (9.7%)
Agent profiling 1.264 s 192.666 ms (18.0%)
Total tracing 10.352 s -
Total appsec 10.531 s 178.725 ms (1.7%)
Total iast 10.703 s 350.443 ms (3.4%)
Total profiling 10.568 s 215.722 ms (2.1%) 
gantt
    title petclinic - break down per module: candidate=1.38.0-SNAPSHOT~50e50cd22e, baseline=1.38.0-SNAPSHOT~95a52cc95e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (663.909 ms) : 0, 663909
BytebuddyAgent [candidate] (670.694 ms) : 0, 670694
GlobalTracer [baseline] (304.473 ms) : 0, 304473
GlobalTracer [candidate] (307.113 ms) : 0, 307113
AppSec [baseline] (49.9 ms) : 0, 49900
AppSec [candidate] (50.536 ms) : 0, 50536
Remote Config [baseline] (666.446 µs) : 0, 666
Remote Config [candidate] (674.534 µs) : 0, 675
Telemetry [baseline] (7.638 ms) : 0, 7638
Telemetry [candidate] (7.692 ms) : 0, 7692
section appsec
BytebuddyAgent [baseline] (675.867 ms) : 0, 675867
BytebuddyAgent [candidate] (676.694 ms) : 0, 676694
GlobalTracer [baseline] (297.762 ms) : 0, 297762
GlobalTracer [candidate] (299.227 ms) : 0, 299227
AppSec [baseline] (153.709 ms) : 0, 153709
AppSec [candidate] (153.602 ms) : 0, 153602
Remote Config [baseline] (619.057 µs) : 0, 619
Remote Config [candidate] (621.185 µs) : 0, 621
Telemetry [baseline] (8.587 ms) : 0, 8587
Telemetry [candidate] (8.574 ms) : 0, 8574
IAST [baseline] (21.426 ms) : 0, 21426
IAST [candidate] (21.446 ms) : 0, 21446
section iast
BytebuddyAgent [baseline] (778.862 ms) : 0, 778862
BytebuddyAgent [candidate] (781.717 ms) : 0, 781717
GlobalTracer [baseline] (295.179 ms) : 0, 295179
GlobalTracer [candidate] (296.348 ms) : 0, 296348
AppSec [baseline] (47.219 ms) : 0, 47219
AppSec [candidate] (48.814 ms) : 0, 48814
Remote Config [baseline] (575.025 µs) : 0, 575
Remote Config [candidate] (560.634 µs) : 0, 561
Telemetry [baseline] (6.957 ms) : 0, 6957
Telemetry [candidate] (6.945 ms) : 0, 6945
IAST [baseline] (28.102 ms) : 0, 28102
IAST [candidate] (26.982 ms) : 0, 26982
section profiling
BytebuddyAgent [baseline] (661.677 ms) : 0, 661677
BytebuddyAgent [candidate] (663.381 ms) : 0, 663381
GlobalTracer [baseline] (388.199 ms) : 0, 388199
GlobalTracer [candidate] (388.115 ms) : 0, 388115
AppSec [baseline] (51.387 ms) : 0, 51387
AppSec [candidate] (51.385 ms) : 0, 51385
Remote Config [baseline] (645.447 µs) : 0, 645
Remote Config [candidate] (657.965 µs) : 0, 658
Telemetry [baseline] (7.344 ms) : 0, 7344
Telemetry [candidate] (7.36 ms) : 0, 7360
ProfilingAgent [baseline] (95.441 ms) : 0, 95441
ProfilingAgent [candidate] (96.081 ms) : 0, 96081
Profiling [baseline] (95.465 ms) : 0, 95465
Profiling [candidate] (96.106 ms) : 0, 96106
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.38.0-SNAPSHOT~50e50cd22e, baseline=1.38.0-SNAPSHOT~95a52cc95e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1062098
Total [baseline] (8.496 s) : 0, 8496124
Agent [candidate] (1.069 s) : 0, 1068976
Total [candidate] (8.503 s) : 0, 8503401
section iast
Agent [baseline] (1.183 s) : 0, 1182814
Total [baseline] (8.97 s) : 0, 8969572
Agent [candidate] (1.171 s) : 0, 1170628
Total [candidate] (8.976 s) : 0, 8976488
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.172 s) : 0, 1172232
Total [baseline] (8.959 s) : 0, 8959174
Agent [candidate] (1.166 s) : 0, 1166279
Total [candidate] (8.897 s) : 0, 8896556
section iast_TELEMETRY_OFF
Agent [baseline] (1.176 s) : 0, 1175587
Total [baseline] (8.922 s) : 0, 8921742
Agent [candidate] (1.179 s) : 0, 1178688
Total [candidate] (9.002 s) : 0, 9001720
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent iast 1.183 s 120.716 ms (11.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.172 s 110.134 ms (10.4%)
Agent iast_TELEMETRY_OFF 1.176 s 113.489 ms (10.7%)
Total tracing 8.496 s -
Total iast 8.97 s 473.448 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 8.959 s 463.05 ms (5.5%)
Total iast_TELEMETRY_OFF 8.922 s 425.618 ms (5.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.069 s -
Agent iast 1.171 s 101.652 ms (9.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.166 s 97.303 ms (9.1%)
Agent iast_TELEMETRY_OFF 1.179 s 109.712 ms (10.3%)
Total tracing 8.503 s -
Total iast 8.976 s 473.086 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 8.897 s 393.155 ms (4.6%)
Total iast_TELEMETRY_OFF 9.002 s 498.318 ms (5.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.38.0-SNAPSHOT~50e50cd22e, baseline=1.38.0-SNAPSHOT~95a52cc95e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.861 ms) : 0, 664861
BytebuddyAgent [candidate] (669.356 ms) : 0, 669356
GlobalTracer [baseline] (304.555 ms) : 0, 304555
GlobalTracer [candidate] (306.862 ms) : 0, 306862
AppSec [baseline] (49.861 ms) : 0, 49861
AppSec [candidate] (49.861 ms) : 0, 49861
Remote Config [baseline] (671.051 µs) : 0, 671
Remote Config [candidate] (665.836 µs) : 0, 666
Telemetry [baseline] (7.655 ms) : 0, 7655
Telemetry [candidate] (7.547 ms) : 0, 7547
section iast
BytebuddyAgent [baseline] (788.774 ms) : 0, 788774
BytebuddyAgent [candidate] (779.597 ms) : 0, 779597
GlobalTracer [baseline] (297.323 ms) : 0, 297323
GlobalTracer [candidate] (295.377 ms) : 0, 295377
AppSec [baseline] (49.05 ms) : 0, 49050
AppSec [candidate] (47.382 ms) : 0, 47382
IAST [baseline] (26.483 ms) : 0, 26483
IAST [candidate] (27.151 ms) : 0, 27151
Remote Config [baseline] (575.728 µs) : 0, 576
Remote Config [candidate] (588.414 µs) : 0, 588
Telemetry [baseline] (6.936 ms) : 0, 6936
Telemetry [candidate] (7.037 ms) : 0, 7037
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (779.771 ms) : 0, 779771
BytebuddyAgent [candidate] (777.206 ms) : 0, 777206
GlobalTracer [baseline] (296.007 ms) : 0, 296007
GlobalTracer [candidate] (294.372 ms) : 0, 294372
AppSec [baseline] (47.341 ms) : 0, 47341
AppSec [candidate] (47.827 ms) : 0, 47827
IAST [baseline] (27.974 ms) : 0, 27974
IAST [candidate] (25.878 ms) : 0, 25878
Remote Config [baseline] (576.746 µs) : 0, 577
Remote Config [candidate] (566.972 µs) : 0, 567
Telemetry [baseline] (6.98 ms) : 0, 6980
Telemetry [candidate] (6.936 ms) : 0, 6936
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (781.711 ms) : 0, 781711
BytebuddyAgent [candidate] (786.155 ms) : 0, 786155
GlobalTracer [baseline] (296.822 ms) : 0, 296822
GlobalTracer [candidate] (296.689 ms) : 0, 296689
AppSec [baseline] (47.644 ms) : 0, 47644
AppSec [candidate] (47.281 ms) : 0, 47281
IAST [baseline] (26.792 ms) : 0, 26792
IAST [candidate] (27.46 ms) : 0, 27460
Remote Config [baseline] (582.571 µs) : 0, 583
Remote Config [candidate] (568.658 µs) : 0, 569
Telemetry [baseline] (8.445 ms) : 0, 8445
Telemetry [candidate] (6.809 ms) : 0, 6809
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-07-11T13:26:16 2024-07-11T13:33:03
git_branch master andrea.marziali/jetty-client-12
git_commit_date 1720700493 1720703653
git_commit_sha 95a52cc 50e50cd
release_version 1.38.0-SNAPSHOT~95a52cc95e 1.38.0-SNAPSHOT~50e50cd22e
start_time 2024-07-11T13:26:03 2024-07-11T13:32:49
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1720705126 1720705126
ci_job_id 569507578 569507578
ci_pipeline_id 38935075 38935075
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~50e50cd22e, baseline=1.38.0-SNAPSHOT~95a52cc95e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.338 ms) : 1319, 1357
.   : milestone, 1338,
appsec (1.713 ms) : 1690, 1737
.   : milestone, 1713,
appsec_no_iast (1.726 ms) : 1701, 1750
.   : milestone, 1726,
iast (1.474 ms) : 1452, 1496
.   : milestone, 1474,
profiling (1.481 ms) : 1456, 1506
.   : milestone, 1481,
tracing (1.463 ms) : 1439, 1486
.   : milestone, 1463,
section candidate
no_agent (1.365 ms) : 1346, 1384
.   : milestone, 1365,
appsec (1.721 ms) : 1697, 1744
.   : milestone, 1721,
appsec_no_iast (1.72 ms) : 1697, 1744
.   : milestone, 1720,
iast (1.473 ms) : 1450, 1495
.   : milestone, 1473,
profiling (1.486 ms) : 1461, 1510
.   : milestone, 1486,
tracing (1.463 ms) : 1439, 1487
.   : milestone, 1463,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.338 ms [1.319 ms, 1.357 ms] -
appsec 1.713 ms [1.69 ms, 1.737 ms] 375.601 µs (28.1%)
appsec_no_iast 1.726 ms [1.701 ms, 1.75 ms] 387.864 µs (29.0%)
iast 1.474 ms [1.452 ms, 1.496 ms] 136.097 µs (10.2%)
profiling 1.481 ms [1.456 ms, 1.506 ms] 142.851 µs (10.7%)
tracing 1.463 ms [1.439 ms, 1.486 ms] 124.68 µs (9.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.365 ms [1.346 ms, 1.384 ms] -
appsec 1.721 ms [1.697 ms, 1.744 ms] 355.678 µs (26.1%)
appsec_no_iast 1.72 ms [1.697 ms, 1.744 ms] 355.297 µs (26.0%)
iast 1.473 ms [1.45 ms, 1.495 ms] 107.953 µs (7.9%)
profiling 1.486 ms [1.461 ms, 1.51 ms] 120.843 µs (8.9%)
tracing 1.463 ms [1.439 ms, 1.487 ms] 97.729 µs (7.2%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~50e50cd22e, baseline=1.38.0-SNAPSHOT~95a52cc95e
    dateFormat X
    axisFormat %s
section baseline
no_agent (365.591 µs) : 345, 386
.   : milestone, 366,
iast (480.963 µs) : 459, 503
.   : milestone, 481,
iast_FULL (550.383 µs) : 530, 571
.   : milestone, 550,
iast_GLOBAL (496.559 µs) : 476, 517
.   : milestone, 497,
iast_HARDCODED_SECRET_DISABLED (471.172 µs) : 450, 492
.   : milestone, 471,
iast_INACTIVE (450.961 µs) : 429, 472
.   : milestone, 451,
iast_TELEMETRY_OFF (466.231 µs) : 445, 487
.   : milestone, 466,
tracing (435.225 µs) : 415, 456
.   : milestone, 435,
section candidate
no_agent (366.811 µs) : 347, 387
.   : milestone, 367,
iast (474.158 µs) : 453, 495
.   : milestone, 474,
iast_FULL (547.619 µs) : 527, 569
.   : milestone, 548,
iast_GLOBAL (499.188 µs) : 478, 521
.   : milestone, 499,
iast_HARDCODED_SECRET_DISABLED (472.703 µs) : 452, 494
.   : milestone, 473,
iast_INACTIVE (446.557 µs) : 426, 467
.   : milestone, 447,
iast_TELEMETRY_OFF (466.544 µs) : 445, 488
.   : milestone, 467,
tracing (441.67 µs) : 421, 462
.   : milestone, 442,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 365.591 µs [345.45 µs, 385.732 µs] -
iast 480.963 µs [459.389 µs, 502.537 µs] 115.372 µs (31.6%)
iast_FULL 550.383 µs [529.531 µs, 571.234 µs] 184.791 µs (50.5%)
iast_GLOBAL 496.559 µs [475.743 µs, 517.375 µs] 130.968 µs (35.8%)
iast_HARDCODED_SECRET_DISABLED 471.172 µs [450.187 µs, 492.157 µs] 105.581 µs (28.9%)
iast_INACTIVE 450.961 µs [429.437 µs, 472.484 µs] 85.37 µs (23.4%)
iast_TELEMETRY_OFF 466.231 µs [445.073 µs, 487.389 µs] 100.64 µs (27.5%)
tracing 435.225 µs [414.642 µs, 455.808 µs] 69.634 µs (19.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.811 µs [346.869 µs, 386.753 µs] -
iast 474.158 µs [453.125 µs, 495.191 µs] 107.347 µs (29.3%)
iast_FULL 547.619 µs [526.526 µs, 568.712 µs] 180.808 µs (49.3%)
iast_GLOBAL 499.188 µs [477.684 µs, 520.692 µs] 132.378 µs (36.1%)
iast_HARDCODED_SECRET_DISABLED 472.703 µs [451.743 µs, 493.664 µs] 105.892 µs (28.9%)
iast_INACTIVE 446.557 µs [425.71 µs, 467.404 µs] 79.746 µs (21.7%)
iast_TELEMETRY_OFF 466.544 µs [445.122 µs, 487.967 µs] 99.734 µs (27.2%)
tracing 441.67 µs [420.928 µs, 462.411 µs] 74.859 µs (20.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/jetty-client-12
git_commit_date 1720700493 1720703653
git_commit_sha 95a52cc 50e50cd
release_version 1.38.0-SNAPSHOT~95a52cc95e 1.38.0-SNAPSHOT~50e50cd22e
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1720705632 1720705632
ci_job_id 569507579 569507579
ci_pipeline_id 38935075 38935075
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~50e50cd22e, baseline=1.38.0-SNAPSHOT~95a52cc95e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.454 ms) : 1442, 1465
.   : milestone, 1454,
appsec (2.219 ms) : 2185, 2254
.   : milestone, 2219,
iast (1.967 ms) : 1925, 2008
.   : milestone, 1967,
iast_GLOBAL (2.013 ms) : 1971, 2055
.   : milestone, 2013,
profiling (2.36 ms) : 2172, 2548
.   : milestone, 2360,
tracing (1.825 ms) : 1793, 1858
.   : milestone, 1825,
section candidate
no_agent (1.454 ms) : 1443, 1465
.   : milestone, 1454,
appsec (2.217 ms) : 2182, 2253
.   : milestone, 2217,
iast (1.964 ms) : 1922, 2005
.   : milestone, 1964,
iast_GLOBAL (2.014 ms) : 1970, 2057
.   : milestone, 2014,
profiling (1.862 ms) : 1827, 1896
.   : milestone, 1862,
tracing (1.837 ms) : 1804, 1871
.   : milestone, 1837,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.454 ms [1.442 ms, 1.465 ms] -
appsec 2.219 ms [2.185 ms, 2.254 ms] 765.456 µs (52.7%)
iast 1.967 ms [1.925 ms, 2.008 ms] 513.079 µs (35.3%)
iast_GLOBAL 2.013 ms [1.971 ms, 2.055 ms] 559.064 µs (38.5%)
profiling 2.36 ms [2.172 ms, 2.548 ms] 906.37 µs (62.3%)
tracing 1.825 ms [1.793 ms, 1.858 ms] 371.612 µs (25.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.454 ms [1.443 ms, 1.465 ms] -
appsec 2.217 ms [2.182 ms, 2.253 ms] 763.369 µs (52.5%)
iast 1.964 ms [1.922 ms, 2.005 ms] 509.693 µs (35.1%)
iast_GLOBAL 2.014 ms [1.97 ms, 2.057 ms] 559.749 µs (38.5%)
profiling 1.862 ms [1.827 ms, 1.896 ms] 407.765 µs (28.0%)
tracing 1.837 ms [1.804 ms, 1.871 ms] 383.307 µs (26.4%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~50e50cd22e, baseline=1.38.0-SNAPSHOT~95a52cc95e
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.363 s) : 15363000, 15363000
.   : milestone, 15363000,
appsec (15.009 s) : 15009000, 15009000
.   : milestone, 15009000,
iast (18.754 s) : 18754000, 18754000
.   : milestone, 18754000,
iast_GLOBAL (17.854 s) : 17854000, 17854000
.   : milestone, 17854000,
profiling (15.804 s) : 15804000, 15804000
.   : milestone, 15804000,
tracing (15.096 s) : 15096000, 15096000
.   : milestone, 15096000,
section candidate
no_agent (15.424 s) : 15424000, 15424000
.   : milestone, 15424000,
appsec (15.152 s) : 15152000, 15152000
.   : milestone, 15152000,
iast (18.829 s) : 18829000, 18829000
.   : milestone, 18829000,
iast_GLOBAL (17.869 s) : 17869000, 17869000
.   : milestone, 17869000,
profiling (15.31 s) : 15310000, 15310000
.   : milestone, 15310000,
tracing (15.05 s) : 15050000, 15050000
.   : milestone, 15050000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.363 s [15.363 s, 15.363 s] -
appsec 15.009 s [15.009 s, 15.009 s] -354.0 ms (-2.3%)
iast 18.754 s [18.754 s, 18.754 s] 3.391 s (22.1%)
iast_GLOBAL 17.854 s [17.854 s, 17.854 s] 2.491 s (16.2%)
profiling 15.804 s [15.804 s, 15.804 s] 441.0 ms (2.9%)
tracing 15.096 s [15.096 s, 15.096 s] -267.0 ms (-1.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.424 s [15.424 s, 15.424 s] -
appsec 15.152 s [15.152 s, 15.152 s] -272.0 ms (-1.8%)
iast 18.829 s [18.829 s, 18.829 s] 3.405 s (22.1%)
iast_GLOBAL 17.869 s [17.869 s, 17.869 s] 2.445 s (15.9%)
profiling 15.31 s [15.31 s, 15.31 s] -114.0 ms (-0.7%)
tracing 15.05 s [15.05 s, 15.05 s] -374.0 ms (-2.4%)

@amarziali amarziali marked this pull request as ready for review July 11, 2024 12:22
@amarziali amarziali requested review from a team as code owners July 11, 2024 12:22
@amarziali amarziali requested review from mcculls and dougqh July 11, 2024 12:22
@amarziali amarziali force-pushed the andrea.marziali/jetty-client-12 branch from 2481985 to 50e50cd Compare July 11, 2024 13:14
vandonr
vandonr reviewed Jul 11, 2024
View reviewed changes
Copy link
Contributor

@vandonr vandonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit hard to review... I can diff those files locally with the 10.0 instrumentation, but maybe you can point to the things you had to change for this instrumentation ?

nayeem-kamal
nayeem-kamal approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@nayeem-kamal nayeem-kamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. As @vandonr 's comment states. Maybe you could just add a bit in the description or in a comment about what the changes are from previous versions.

@amarziali
Copy link
Collaborator Author

This is a bit hard to review... I can diff those files locally with the 10.0 instrumentation, but maybe you can point to the things you had to change for this instrumentation ?

The request/response classes have a package change as well the way the span completion listener is applied differs

@amarziali amarziali merged commit 63f16d7 into master Jul 12, 2024
82 checks passed
@amarziali amarziali deleted the andrea.marziali/jetty-client-12 branch July 12, 2024 05:48
@github-actions github-actions bot added this to the 1.38.0 milestone Jul 12, 2024
@vandonr
Copy link
Contributor

vandonr commented Jul 12, 2024

For a future case like this, what we can do is do a first commit where the files are just copied, and then a commit where the changes are done. This allows reviewing the changes by looking at the second commit only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vandonr vandonr vandonr left review comments

@nayeem-kamal nayeem-kamal nayeem-kamal approved these changes

@mcculls mcculls Awaiting requested review from mcculls mcculls is a code owner automatically assigned from DataDog/apm-java

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
inst: jetty Jetty instrumentation type: feature request
Projects
None yet
Milestone
1.38.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amarziali @vandonr @nayeem-kamal