Add missing dependency to unlock dependency lock updates #7306

PerfectSlayer · 2024-07-11T09:39:38Z

What Does This Do

This PR is a follow up of #7298

Motivation

Nightly still broken

Additional Notes

Jira ticket: [PROJ-IDENT]

… updates

pr-commenter · 2024-07-11T10:15:48Z

Benchmarks

Startup

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-07-11T09:48:53	2024-07-11T09:55:39
git_branch	master	bbujon/fix-dependency-locking
git_commit_date	1720688910	1720690608
git_commit_sha	`8b00e3e`	`7529177`
release_version	1.38.0-SNAPSHOT~8b00e3e102	1.38.0-SNAPSHOT~75291778da
start_time	2024-07-11T09:48:39	2024-07-11T09:55:26

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1720692082	1720692082
ci_job_id	569229490	569229490
ci_pipeline_id	38921019	38921019
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~75291778da, baseline=1.38.0-SNAPSHOT~8b00e3e102
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.33 ms) : 1310, 1350
.   : milestone, 1330,
appsec (1.71 ms) : 1685, 1736
.   : milestone, 1710,
appsec_no_iast (1.707 ms) : 1682, 1731
.   : milestone, 1707,
iast (1.477 ms) : 1455, 1499
.   : milestone, 1477,
profiling (1.481 ms) : 1457, 1506
.   : milestone, 1481,
tracing (1.459 ms) : 1434, 1483
.   : milestone, 1459,
section candidate
no_agent (1.358 ms) : 1339, 1378
.   : milestone, 1358,
appsec (1.695 ms) : 1671, 1719
.   : milestone, 1695,
appsec_no_iast (1.699 ms) : 1676, 1723
.   : milestone, 1699,
iast (1.469 ms) : 1447, 1490
.   : milestone, 1469,
profiling (1.5 ms) : 1476, 1524
.   : milestone, 1500,
tracing (1.459 ms) : 1435, 1482
.   : milestone, 1459,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.33 ms [1.31 ms, 1.35 ms]	-
appsec	1.71 ms [1.685 ms, 1.736 ms]	380.756 µs (28.6%)
appsec_no_iast	1.707 ms [1.682 ms, 1.731 ms]	377.261 µs (28.4%)
iast	1.477 ms [1.455 ms, 1.499 ms]	147.084 µs (11.1%)
profiling	1.481 ms [1.457 ms, 1.506 ms]	151.728 µs (11.4%)
tracing	1.459 ms [1.434 ms, 1.483 ms]	129.013 µs (9.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.358 ms [1.339 ms, 1.378 ms]	-
appsec	1.695 ms [1.671 ms, 1.719 ms]	336.634 µs (24.8%)
appsec_no_iast	1.699 ms [1.676 ms, 1.723 ms]	341.025 µs (25.1%)
iast	1.469 ms [1.447 ms, 1.49 ms]	110.523 µs (8.1%)
profiling	1.5 ms [1.476 ms, 1.524 ms]	141.634 µs (10.4%)
tracing	1.459 ms [1.435 ms, 1.482 ms]	100.162 µs (7.4%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~75291778da, baseline=1.38.0-SNAPSHOT~8b00e3e102
    dateFormat X
    axisFormat %s
section baseline
no_agent (362.192 µs) : 343, 382
.   : milestone, 362,
iast (479.349 µs) : 458, 501
.   : milestone, 479,
iast_FULL (544.015 µs) : 523, 565
.   : milestone, 544,
iast_GLOBAL (507.79 µs) : 486, 530
.   : milestone, 508,
iast_HARDCODED_SECRET_DISABLED (477.834 µs) : 457, 499
.   : milestone, 478,
iast_INACTIVE (456.368 µs) : 433, 479
.   : milestone, 456,
iast_TELEMETRY_OFF (471.301 µs) : 449, 493
.   : milestone, 471,
tracing (438.894 µs) : 418, 459
.   : milestone, 439,
section candidate
no_agent (367.329 µs) : 346, 388
.   : milestone, 367,
iast (477.934 µs) : 457, 499
.   : milestone, 478,
iast_FULL (544.262 µs) : 523, 566
.   : milestone, 544,
iast_GLOBAL (497.494 µs) : 476, 519
.   : milestone, 497,
iast_HARDCODED_SECRET_DISABLED (477.334 µs) : 456, 498
.   : milestone, 477,
iast_INACTIVE (449.869 µs) : 429, 471
.   : milestone, 450,
iast_TELEMETRY_OFF (466.014 µs) : 445, 487
.   : milestone, 466,
tracing (439.316 µs) : 418, 460
.   : milestone, 439,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	362.192 µs [342.519 µs, 381.864 µs]	-
iast	479.349 µs [457.839 µs, 500.86 µs]	117.158 µs (32.3%)
iast_FULL	544.015 µs [523.081 µs, 564.948 µs]	181.823 µs (50.2%)
iast_GLOBAL	507.79 µs [485.801 µs, 529.779 µs]	145.599 µs (40.2%)
iast_HARDCODED_SECRET_DISABLED	477.834 µs [456.7 µs, 498.969 µs]	115.643 µs (31.9%)
iast_INACTIVE	456.368 µs [433.25 µs, 479.485 µs]	94.176 µs (26.0%)
iast_TELEMETRY_OFF	471.301 µs [449.438 µs, 493.165 µs]	109.11 µs (30.1%)
tracing	438.894 µs [418.352 µs, 459.436 µs]	76.703 µs (21.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	367.329 µs [346.496 µs, 388.161 µs]	-
iast	477.934 µs [456.664 µs, 499.204 µs]	110.605 µs (30.1%)
iast_FULL	544.262 µs [522.923 µs, 565.601 µs]	176.933 µs (48.2%)
iast_GLOBAL	497.494 µs [476.486 µs, 518.502 µs]	130.165 µs (35.4%)
iast_HARDCODED_SECRET_DISABLED	477.334 µs [456.202 µs, 498.465 µs]	110.005 µs (29.9%)
iast_INACTIVE	449.869 µs [428.659 µs, 471.079 µs]	82.54 µs (22.5%)
iast_TELEMETRY_OFF	466.014 µs [444.678 µs, 487.35 µs]	98.686 µs (26.9%)
tracing	439.316 µs [418.202 µs, 460.431 µs]	71.988 µs (19.6%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bbujon/fix-dependency-locking
git_commit_date	1720688910	1720690608
git_commit_sha	`8b00e3e`	`7529177`
release_version	1.38.0-SNAPSHOT~8b00e3e102	1.38.0-SNAPSHOT~75291778da

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1720692600	1720692600
ci_job_id	569229491	569229491
ci_pipeline_id	38921019	38921019
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~75291778da, baseline=1.38.0-SNAPSHOT~8b00e3e102
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.462 ms) : 1450, 1473
.   : milestone, 1462,
appsec (2.22 ms) : 2185, 2255
.   : milestone, 2220,
iast (1.982 ms) : 1940, 2024
.   : milestone, 1982,
iast_GLOBAL (2.01 ms) : 1968, 2052
.   : milestone, 2010,
profiling (1.858 ms) : 1824, 1891
.   : milestone, 1858,
tracing (1.84 ms) : 1807, 1873
.   : milestone, 1840,
section candidate
no_agent (1.453 ms) : 1442, 1464
.   : milestone, 1453,
appsec (2.238 ms) : 2203, 2272
.   : milestone, 2238,
iast (1.983 ms) : 1941, 2025
.   : milestone, 1983,
iast_GLOBAL (2.019 ms) : 1976, 2061
.   : milestone, 2019,
profiling (1.864 ms) : 1830, 1898
.   : milestone, 1864,
tracing (1.843 ms) : 1810, 1876
.   : milestone, 1843,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.462 ms [1.45 ms, 1.473 ms]	-
appsec	2.22 ms [2.185 ms, 2.255 ms]	758.303 µs (51.9%)
iast	1.982 ms [1.94 ms, 2.024 ms]	520.571 µs (35.6%)
iast_GLOBAL	2.01 ms [1.968 ms, 2.052 ms]	548.305 µs (37.5%)
profiling	1.858 ms [1.824 ms, 1.891 ms]	396.171 µs (27.1%)
tracing	1.84 ms [1.807 ms, 1.873 ms]	378.535 µs (25.9%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.453 ms [1.442 ms, 1.464 ms]	-
appsec	2.238 ms [2.203 ms, 2.272 ms]	784.657 µs (54.0%)
iast	1.983 ms [1.941 ms, 2.025 ms]	530.163 µs (36.5%)
iast_GLOBAL	2.019 ms [1.976 ms, 2.061 ms]	565.801 µs (38.9%)
profiling	1.864 ms [1.83 ms, 1.898 ms]	410.762 µs (28.3%)
tracing	1.843 ms [1.81 ms, 1.876 ms]	389.869 µs (26.8%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~75291778da, baseline=1.38.0-SNAPSHOT~8b00e3e102
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.005 s) : 15005000, 15005000
.   : milestone, 15005000,
appsec (15.262 s) : 15262000, 15262000
.   : milestone, 15262000,
iast (18.997 s) : 18997000, 18997000
.   : milestone, 18997000,
iast_GLOBAL (17.997 s) : 17997000, 17997000
.   : milestone, 17997000,
profiling (15.402 s) : 15402000, 15402000
.   : milestone, 15402000,
tracing (15.057 s) : 15057000, 15057000
.   : milestone, 15057000,
section candidate
no_agent (15.183 s) : 15183000, 15183000
.   : milestone, 15183000,
appsec (15.079 s) : 15079000, 15079000
.   : milestone, 15079000,
iast (18.973 s) : 18973000, 18973000
.   : milestone, 18973000,
iast_GLOBAL (17.654 s) : 17654000, 17654000
.   : milestone, 17654000,
profiling (14.789 s) : 14789000, 14789000
.   : milestone, 14789000,
tracing (15.066 s) : 15066000, 15066000
.   : milestone, 15066000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.005 s [15.005 s, 15.005 s]	-
appsec	15.262 s [15.262 s, 15.262 s]	257.0 ms (1.7%)
iast	18.997 s [18.997 s, 18.997 s]	3.992 s (26.6%)
iast_GLOBAL	17.997 s [17.997 s, 17.997 s]	2.992 s (19.9%)
profiling	15.402 s [15.402 s, 15.402 s]	397.0 ms (2.6%)
tracing	15.057 s [15.057 s, 15.057 s]	52.0 ms (0.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.183 s [15.183 s, 15.183 s]	-
appsec	15.079 s [15.079 s, 15.079 s]	-104.0 ms (-0.7%)
iast	18.973 s [18.973 s, 18.973 s]	3.79 s (25.0%)
iast_GLOBAL	17.654 s [17.654 s, 17.654 s]	2.471 s (16.3%)
profiling	14.789 s [14.789 s, 14.789 s]	-394.0 ms (-2.6%)
tracing	15.066 s [15.066 s, 15.066 s]	-117.0 ms (-0.8%)

feat(ci-visibility): Add missing dependency to unlock dependency lock…

7529177

… updates

PerfectSlayer added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Jul 11, 2024

PerfectSlayer requested a review from a team as a code owner July 11, 2024 09:39

PerfectSlayer requested a review from nikita-tkachenko-datadog July 11, 2024 09:39

nikita-tkachenko-datadog approved these changes Jul 11, 2024

View reviewed changes

PerfectSlayer enabled auto-merge July 11, 2024 09:40

PerfectSlayer merged commit db1f4c3 into master Jul 11, 2024
83 of 84 checks passed

PerfectSlayer deleted the bbujon/fix-dependency-locking branch July 11, 2024 12:00

github-actions bot added this to the 1.38.0 milestone Jul 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing dependency to unlock dependency lock updates #7306

Add missing dependency to unlock dependency lock updates #7306

PerfectSlayer commented Jul 11, 2024

pr-commenter bot commented Jul 11, 2024

Add missing dependency to unlock dependency lock updates #7306

Add missing dependency to unlock dependency lock updates #7306

Conversation

PerfectSlayer commented Jul 11, 2024

What Does This Do

Motivation

Additional Notes

pr-commenter bot commented Jul 11, 2024

Benchmarks

Startup

Load

Parameters

Summary

Dacapo

Parameters

Summary