Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't recompute DSM pathway hash for known tags #7307

Merged
merged 6 commits into from
Aug 7, 2024
Merged

Don't recompute DSM pathway hash for known tags #7307

merged 6 commits into from
Aug 7, 2024

Conversation

vandonr
Copy link
Contributor

@vandonr vandonr commented Jul 11, 2024 •
edited
Loading

What Does This Do

I'm assuming that the wellKnownTags are constant, and that we can save them and avoid recomputing the hash every time for them.

Motivation

trying to save time and memory when DSM is used

Additional Notes

By removing the stringbuilder from the hash builder, we should also save some extra memory, at the expense of not computing the hash lazily, but I don't see any code path where we wouldn't want the hash in the end anyway.

@pr-commenter
Copy link

pr-commenter bot commented Jul 11, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master vandonr/dsm
git_commit_date 1722411166 1722417518
git_commit_sha 0bbb077 8b67249
release_version 1.38.0-SNAPSHOT~0bbb077d19 1.38.0-SNAPSHOT~8b67249f96
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1722419990 1722419990
ci_job_id 590005773 590005773
ci_pipeline_id 40546342 40546342
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 17 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.38.0-SNAPSHOT~8b67249f96, baseline=1.38.0-SNAPSHOT~0bbb077d19

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1043397
Total [baseline] (10.263 s) : 0, 10262882
Agent [candidate] (1.053 s) : 0, 1053077
Total [candidate] (10.398 s) : 0, 10398239
section appsec
Agent [baseline] (1.166 s) : 0, 1165787
Total [baseline] (10.446 s) : 0, 10446215
Agent [candidate] (1.179 s) : 0, 1179395
Total [candidate] (10.486 s) : 0, 10486452
section iast
Agent [baseline] (1.185 s) : 0, 1184601
Total [baseline] (10.837 s) : 0, 10836524
Agent [candidate] (1.177 s) : 0, 1176740
Total [candidate] (10.953 s) : 0, 10953054
section profiling
Agent [baseline] (1.249 s) : 0, 1249107
Total [baseline] (10.558 s) : 0, 10558406
Agent [candidate] (1.25 s) : 0, 1250458
Total [candidate] (10.624 s) : 0, 10624338
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.043 s -
Agent appsec 1.166 s 122.389 ms (11.7%)
Agent iast 1.185 s 141.204 ms (13.5%)
Agent profiling 1.249 s 205.71 ms (19.7%)
Total tracing 10.263 s -
Total appsec 10.446 s 183.333 ms (1.8%)
Total iast 10.837 s 573.642 ms (5.6%)
Total profiling 10.558 s 295.524 ms (2.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.053 s -
Agent appsec 1.179 s 126.318 ms (12.0%)
Agent iast 1.177 s 123.663 ms (11.7%)
Agent profiling 1.25 s 197.381 ms (18.7%)
Total tracing 10.398 s -
Total appsec 10.486 s 88.212 ms (0.8%)
Total iast 10.953 s 554.815 ms (5.3%)
Total profiling 10.624 s 226.099 ms (2.2%) 
gantt
    title petclinic - break down per module: candidate=1.38.0-SNAPSHOT~8b67249f96, baseline=1.38.0-SNAPSHOT~0bbb077d19

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (667.068 ms) : 0, 667068
BytebuddyAgent [candidate] (672.174 ms) : 0, 672174
GlobalTracer [baseline] (304.835 ms) : 0, 304835
GlobalTracer [candidate] (308.517 ms) : 0, 308517
AppSec [baseline] (49.772 ms) : 0, 49772
AppSec [candidate] (50.488 ms) : 0, 50488
Remote Config [baseline] (727.952 µs) : 0, 728
Remote Config [candidate] (764.751 µs) : 0, 765
Telemetry [baseline] (7.574 ms) : 0, 7574
Telemetry [candidate] (7.572 ms) : 0, 7572
section appsec
BytebuddyAgent [baseline] (677.829 ms) : 0, 677829
BytebuddyAgent [candidate] (685.606 ms) : 0, 685606
GlobalTracer [baseline] (298.66 ms) : 0, 298660
GlobalTracer [candidate] (302.973 ms) : 0, 302973
AppSec [baseline] (155.099 ms) : 0, 155099
AppSec [candidate] (156.447 ms) : 0, 156447
Remote Config [baseline] (626.476 µs) : 0, 626
Remote Config [candidate] (626.507 µs) : 0, 627
Telemetry [baseline] (9.502 ms) : 0, 9502
Telemetry [candidate] (8.54 ms) : 0, 8540
IAST [baseline] (21.128 ms) : 0, 21128
IAST [candidate] (23.121 ms) : 0, 23121
section iast
BytebuddyAgent [baseline] (788.52 ms) : 0, 788520
BytebuddyAgent [candidate] (783.354 ms) : 0, 783354
GlobalTracer [baseline] (298.841 ms) : 0, 298841
GlobalTracer [candidate] (296.072 ms) : 0, 296072
AppSec [baseline] (48.488 ms) : 0, 48488
AppSec [candidate] (53.462 ms) : 0, 53462
Remote Config [baseline] (574.535 µs) : 0, 575
Remote Config [candidate] (599.262 µs) : 0, 599
Telemetry [baseline] (7.867 ms) : 0, 7867
Telemetry [candidate] (7.006 ms) : 0, 7006
IAST [baseline] (26.699 ms) : 0, 26699
IAST [candidate] (22.681 ms) : 0, 22681
section profiling
ProfilingAgent [baseline] (94.395 ms) : 0, 94395
ProfilingAgent [candidate] (95.505 ms) : 0, 95505
BytebuddyAgent [baseline] (667.976 ms) : 0, 667976
BytebuddyAgent [candidate] (666.856 ms) : 0, 666856
GlobalTracer [baseline] (390.261 ms) : 0, 390261
GlobalTracer [candidate] (391.523 ms) : 0, 391523
AppSec [baseline] (51.38 ms) : 0, 51380
AppSec [candidate] (51.464 ms) : 0, 51464
Remote Config [baseline] (650.204 µs) : 0, 650
Remote Config [candidate] (653.53 µs) : 0, 654
Telemetry [baseline] (7.386 ms) : 0, 7386
Telemetry [candidate] (7.335 ms) : 0, 7335
Profiling [baseline] (94.419 ms) : 0, 94419
Profiling [candidate] (95.529 ms) : 0, 95529
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.38.0-SNAPSHOT~8b67249f96, baseline=1.38.0-SNAPSHOT~0bbb077d19

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1044543
Total [baseline] (8.478 s) : 0, 8478367
Agent [candidate] (1.053 s) : 0, 1052720
Total [candidate] (8.49 s) : 0, 8489889
section iast
Agent [baseline] (1.192 s) : 0, 1192304
Total [baseline] (8.988 s) : 0, 8988361
Agent [candidate] (1.184 s) : 0, 1184099
Total [candidate] (8.948 s) : 0, 8948327
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.183 s) : 0, 1182512
Total [baseline] (8.965 s) : 0, 8964938
Agent [candidate] (1.175 s) : 0, 1174566
Total [candidate] (8.955 s) : 0, 8955120
section iast_TELEMETRY_OFF
Agent [baseline] (1.182 s) : 0, 1182434
Total [baseline] (9.024 s) : 0, 9024366
Agent [candidate] (1.171 s) : 0, 1171245
Total [candidate] (8.958 s) : 0, 8958119
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent iast 1.192 s 147.761 ms (14.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.183 s 137.97 ms (13.2%)
Agent iast_TELEMETRY_OFF 1.182 s 137.892 ms (13.2%)
Total tracing 8.478 s -
Total iast 8.988 s 509.994 ms (6.0%)
Total iast_HARDCODED_SECRET_DISABLED 8.965 s 486.571 ms (5.7%)
Total iast_TELEMETRY_OFF 9.024 s 545.999 ms (6.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.053 s -
Agent iast 1.184 s 131.379 ms (12.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.175 s 121.846 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.171 s 118.524 ms (11.3%)
Total tracing 8.49 s -
Total iast 8.948 s 458.439 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.955 s 465.231 ms (5.5%)
Total iast_TELEMETRY_OFF 8.958 s 468.231 ms (5.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.38.0-SNAPSHOT~8b67249f96, baseline=1.38.0-SNAPSHOT~0bbb077d19

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (667.674 ms) : 0, 667674
BytebuddyAgent [candidate] (672.396 ms) : 0, 672396
GlobalTracer [baseline] (305.458 ms) : 0, 305458
GlobalTracer [candidate] (308.229 ms) : 0, 308229
AppSec [baseline] (49.764 ms) : 0, 49764
AppSec [candidate] (50.309 ms) : 0, 50309
Remote Config [baseline] (746.994 µs) : 0, 747
Remote Config [candidate] (807.131 µs) : 0, 807
Telemetry [baseline] (7.482 ms) : 0, 7482
Telemetry [candidate] (7.456 ms) : 0, 7456
section iast
BytebuddyAgent [baseline] (795.261 ms) : 0, 795261
BytebuddyAgent [candidate] (787.749 ms) : 0, 787749
GlobalTracer [baseline] (299.439 ms) : 0, 299439
GlobalTracer [candidate] (298.56 ms) : 0, 298560
AppSec [baseline] (51.697 ms) : 0, 51697
AppSec [candidate] (52.325 ms) : 0, 52325
Remote Config [baseline] (1.422 ms) : 0, 1422
Remote Config [candidate] (598.564 µs) : 0, 599
Telemetry [baseline] (7.135 ms) : 0, 7135
Telemetry [candidate] (8.759 ms) : 0, 8759
IAST [baseline] (23.705 ms) : 0, 23705
IAST [candidate] (22.534 ms) : 0, 22534
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (787.894 ms) : 0, 787894
BytebuddyAgent [candidate] (781.724 ms) : 0, 781724
GlobalTracer [baseline] (297.333 ms) : 0, 297333
GlobalTracer [candidate] (297.36 ms) : 0, 297360
AppSec [baseline] (52.784 ms) : 0, 52784
AppSec [candidate] (50.362 ms) : 0, 50362
Remote Config [baseline] (566.928 µs) : 0, 567
Remote Config [candidate] (569.241 µs) : 0, 569
Telemetry [baseline] (7.821 ms) : 0, 7821
Telemetry [candidate] (7.007 ms) : 0, 7007
IAST [baseline] (22.541 ms) : 0, 22541
IAST [candidate] (24.03 ms) : 0, 24030
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (789.945 ms) : 0, 789945
BytebuddyAgent [candidate] (778.174 ms) : 0, 778174
GlobalTracer [baseline] (299.755 ms) : 0, 299755
GlobalTracer [candidate] (297.201 ms) : 0, 297201
AppSec [baseline] (47.875 ms) : 0, 47875
AppSec [candidate] (47.907 ms) : 0, 47907
Remote Config [baseline] (612.665 µs) : 0, 613
Remote Config [candidate] (578.454 µs) : 0, 578
Telemetry [baseline] (7.159 ms) : 0, 7159
Telemetry [candidate] (6.821 ms) : 0, 6821
IAST [baseline] (23.445 ms) : 0, 23445
IAST [candidate] (27.094 ms) : 0, 27094
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-07-31T09:28:16 2024-07-31T09:35:06
git_branch master vandonr/dsm
git_commit_date 1722411166 1722417518
git_commit_sha 0bbb077 8b67249
release_version 1.38.0-SNAPSHOT~0bbb077d19 1.38.0-SNAPSHOT~8b67249f96
start_time 2024-07-31T09:28:03 2024-07-31T09:34:53
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1722418851 1722418851
ci_job_id 590005774 590005774
ci_pipeline_id 40546342 40546342
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~8b67249f96, baseline=1.38.0-SNAPSHOT~0bbb077d19
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.348 ms) : 1328, 1369
.   : milestone, 1348,
appsec (1.704 ms) : 1679, 1729
.   : milestone, 1704,
appsec_no_iast (1.723 ms) : 1699, 1747
.   : milestone, 1723,
iast (1.495 ms) : 1473, 1517
.   : milestone, 1495,
profiling (1.503 ms) : 1477, 1529
.   : milestone, 1503,
tracing (1.464 ms) : 1440, 1489
.   : milestone, 1464,
section candidate
no_agent (1.332 ms) : 1314, 1351
.   : milestone, 1332,
appsec (1.711 ms) : 1688, 1734
.   : milestone, 1711,
appsec_no_iast (1.725 ms) : 1701, 1749
.   : milestone, 1725,
iast (1.47 ms) : 1447, 1493
.   : milestone, 1470,
profiling (1.488 ms) : 1463, 1513
.   : milestone, 1488,
tracing (1.458 ms) : 1434, 1483
.   : milestone, 1458,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.348 ms [1.328 ms, 1.369 ms] -
appsec 1.704 ms [1.679 ms, 1.729 ms] 355.711 µs (26.4%)
appsec_no_iast 1.723 ms [1.699 ms, 1.747 ms] 374.47 µs (27.8%)
iast 1.495 ms [1.473 ms, 1.517 ms] 146.472 µs (10.9%)
profiling 1.503 ms [1.477 ms, 1.529 ms] 154.912 µs (11.5%)
tracing 1.464 ms [1.44 ms, 1.489 ms] 116.114 µs (8.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.332 ms [1.314 ms, 1.351 ms] -
appsec 1.711 ms [1.688 ms, 1.734 ms] 378.768 µs (28.4%)
appsec_no_iast 1.725 ms [1.701 ms, 1.749 ms] 392.687 µs (29.5%)
iast 1.47 ms [1.447 ms, 1.493 ms] 137.936 µs (10.4%)
profiling 1.488 ms [1.463 ms, 1.513 ms] 155.607 µs (11.7%)
tracing 1.458 ms [1.434 ms, 1.483 ms] 125.835 µs (9.4%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~8b67249f96, baseline=1.38.0-SNAPSHOT~0bbb077d19
    dateFormat X
    axisFormat %s
section baseline
no_agent (366.326 µs) : 347, 386
.   : milestone, 366,
iast (475.273 µs) : 454, 496
.   : milestone, 475,
iast_FULL (554.711 µs) : 534, 576
.   : milestone, 555,
iast_GLOBAL (505.965 µs) : 484, 527
.   : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (475.02 µs) : 454, 496
.   : milestone, 475,
iast_INACTIVE (458.234 µs) : 436, 480
.   : milestone, 458,
iast_TELEMETRY_OFF (477.014 µs) : 456, 498
.   : milestone, 477,
tracing (437.465 µs) : 417, 458
.   : milestone, 437,
section candidate
no_agent (367.646 µs) : 348, 387
.   : milestone, 368,
iast (483.884 µs) : 463, 505
.   : milestone, 484,
iast_FULL (549.613 µs) : 528, 571
.   : milestone, 550,
iast_GLOBAL (511.551 µs) : 489, 534
.   : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (485.433 µs) : 463, 507
.   : milestone, 485,
iast_INACTIVE (452.936 µs) : 431, 474
.   : milestone, 453,
iast_TELEMETRY_OFF (467.013 µs) : 446, 488
.   : milestone, 467,
tracing (440.763 µs) : 421, 461
.   : milestone, 441,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.326 µs [346.888 µs, 385.764 µs] -
iast 475.273 µs [454.329 µs, 496.217 µs] 108.947 µs (29.7%)
iast_FULL 554.711 µs [533.509 µs, 575.914 µs] 188.385 µs (51.4%)
iast_GLOBAL 505.965 µs [484.497 µs, 527.432 µs] 139.639 µs (38.1%)
iast_HARDCODED_SECRET_DISABLED 475.02 µs [454.414 µs, 495.626 µs] 108.694 µs (29.7%)
iast_INACTIVE 458.234 µs [436.026 µs, 480.442 µs] 91.908 µs (25.1%)
iast_TELEMETRY_OFF 477.014 µs [455.723 µs, 498.304 µs] 110.688 µs (30.2%)
tracing 437.465 µs [417.38 µs, 457.549 µs] 71.139 µs (19.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.646 µs [347.878 µs, 387.414 µs] -
iast 483.884 µs [463.095 µs, 504.673 µs] 116.238 µs (31.6%)
iast_FULL 549.613 µs [528.49 µs, 570.736 µs] 181.967 µs (49.5%)
iast_GLOBAL 511.551 µs [488.924 µs, 534.178 µs] 143.905 µs (39.1%)
iast_HARDCODED_SECRET_DISABLED 485.433 µs [463.379 µs, 507.487 µs] 117.787 µs (32.0%)
iast_INACTIVE 452.936 µs [431.376 µs, 474.496 µs] 85.29 µs (23.2%)
iast_TELEMETRY_OFF 467.013 µs [446.159 µs, 487.866 µs] 99.366 µs (27.0%)
tracing 440.763 µs [420.727 µs, 460.799 µs] 73.117 µs (19.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master vandonr/dsm
git_commit_date 1722411166 1722417518
git_commit_sha 0bbb077 8b67249
release_version 1.38.0-SNAPSHOT~0bbb077d19 1.38.0-SNAPSHOT~8b67249f96
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1722419347 1722419347
ci_job_id 590005775 590005775
ci_pipeline_id 40546342 40546342
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~8b67249f96, baseline=1.38.0-SNAPSHOT~0bbb077d19
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.452 ms) : 1440, 1463
.   : milestone, 1452,
appsec (2.204 ms) : 2170, 2239
.   : milestone, 2204,
iast (1.967 ms) : 1924, 2010
.   : milestone, 1967,
iast_GLOBAL (2.003 ms) : 1960, 2046
.   : milestone, 2003,
profiling (1.851 ms) : 1817, 1885
.   : milestone, 1851,
tracing (1.818 ms) : 1785, 1850
.   : milestone, 1818,
section candidate
no_agent (1.449 ms) : 1437, 1460
.   : milestone, 1449,
appsec (2.201 ms) : 2166, 2236
.   : milestone, 2201,
iast (1.963 ms) : 1921, 2005
.   : milestone, 1963,
iast_GLOBAL (2.001 ms) : 1959, 2044
.   : milestone, 2001,
profiling (1.846 ms) : 1812, 1879
.   : milestone, 1846,
tracing (1.828 ms) : 1795, 1861
.   : milestone, 1828,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.452 ms [1.44 ms, 1.463 ms] -
appsec 2.204 ms [2.17 ms, 2.239 ms] 752.796 µs (51.9%)
iast 1.967 ms [1.924 ms, 2.01 ms] 515.199 µs (35.5%)
iast_GLOBAL 2.003 ms [1.96 ms, 2.046 ms] 551.08 µs (38.0%)
profiling 1.851 ms [1.817 ms, 1.885 ms] 399.837 µs (27.5%)
tracing 1.818 ms [1.785 ms, 1.85 ms] 366.34 µs (25.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.449 ms [1.437 ms, 1.46 ms] -
appsec 2.201 ms [2.166 ms, 2.236 ms] 752.272 µs (51.9%)
iast 1.963 ms [1.921 ms, 2.005 ms] 514.096 µs (35.5%)
iast_GLOBAL 2.001 ms [1.959 ms, 2.044 ms] 552.826 µs (38.2%)
profiling 1.846 ms [1.812 ms, 1.879 ms] 396.929 µs (27.4%)
tracing 1.828 ms [1.795 ms, 1.861 ms] 379.363 µs (26.2%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~8b67249f96, baseline=1.38.0-SNAPSHOT~0bbb077d19
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.837 s) : 14837000, 14837000
.   : milestone, 14837000,
appsec (15.145 s) : 15145000, 15145000
.   : milestone, 15145000,
iast (18.827 s) : 18827000, 18827000
.   : milestone, 18827000,
iast_GLOBAL (17.82 s) : 17820000, 17820000
.   : milestone, 17820000,
profiling (15.367 s) : 15367000, 15367000
.   : milestone, 15367000,
tracing (15.259 s) : 15259000, 15259000
.   : milestone, 15259000,
section candidate
no_agent (15.222 s) : 15222000, 15222000
.   : milestone, 15222000,
appsec (14.931 s) : 14931000, 14931000
.   : milestone, 14931000,
iast (18.723 s) : 18723000, 18723000
.   : milestone, 18723000,
iast_GLOBAL (17.632 s) : 17632000, 17632000
.   : milestone, 17632000,
profiling (15.307 s) : 15307000, 15307000
.   : milestone, 15307000,
tracing (15.004 s) : 15004000, 15004000
.   : milestone, 15004000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.837 s [14.837 s, 14.837 s] -
appsec 15.145 s [15.145 s, 15.145 s] 308.0 ms (2.1%)
iast 18.827 s [18.827 s, 18.827 s] 3.99 s (26.9%)
iast_GLOBAL 17.82 s [17.82 s, 17.82 s] 2.983 s (20.1%)
profiling 15.367 s [15.367 s, 15.367 s] 530.0 ms (3.6%)
tracing 15.259 s [15.259 s, 15.259 s] 422.0 ms (2.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.222 s [15.222 s, 15.222 s] -
appsec 14.931 s [14.931 s, 14.931 s] -291.0 ms (-1.9%)
iast 18.723 s [18.723 s, 18.723 s] 3.501 s (23.0%)
iast_GLOBAL 17.632 s [17.632 s, 17.632 s] 2.41 s (15.8%)
profiling 15.307 s [15.307 s, 15.307 s] 85.0 ms (0.6%)
tracing 15.004 s [15.004 s, 15.004 s] -218.0 ms (-1.4%)

@vandonr vandonr added comp: data streams Data Streams Monitoring tag: performance Performance related changes labels Jul 18, 2024
@vandonr vandonr marked this pull request as ready for review August 5, 2024 16:59
@vandonr vandonr requested a review from a team as a code owner August 5, 2024 16:59
@vandonr vandonr merged commit 7059a72 into master Aug 7, 2024
80 checks passed
@vandonr vandonr deleted the vandonr/dsm branch August 7, 2024 13:03
@github-actions github-actions bot added this to the 1.39.0 milestone Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali approved these changes

@kr-igor kr-igor kr-igor approved these changes

@mcculls mcculls Awaiting requested review from mcculls mcculls is a code owner automatically assigned from DataDog/apm-java

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: data streams Data Streams Monitoring tag: performance Performance related changes
Projects
None yet
Milestone
1.39.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vandonr @amarziali @kr-igor