-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PoC] AWS Payload observability #7312
Draft
ygree
wants to merge
3
commits into
master
Choose a base branch
from
ygree/aws-payload-tagging
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+745
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~b968dfc318, baseline=1.39.0-SNAPSHOT~93ecbc62b2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054510
Total [baseline] (8.511 s) : 0, 8510664
Agent [candidate] (1.051 s) : 0, 1051330
Total [candidate] (8.507 s) : 0, 8507328
section iast
Agent [baseline] (1.186 s) : 0, 1185981
Total [baseline] (9.022 s) : 0, 9021892
Agent [candidate] (1.181 s) : 0, 1181021
Total [candidate] (9.01 s) : 0, 9010414
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.178 s) : 0, 1177909
Total [baseline] (8.978 s) : 0, 8978208
Agent [candidate] (1.186 s) : 0, 1186232
Total [candidate] (8.992 s) : 0, 8991777
section iast_TELEMETRY_OFF
Agent [baseline] (1.184 s) : 0, 1183752
Total [baseline] (9.047 s) : 0, 9046593
Agent [candidate] (1.181 s) : 0, 1180591
Total [candidate] (8.972 s) : 0, 8972397
gantt
title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~b968dfc318, baseline=1.39.0-SNAPSHOT~93ecbc62b2
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (672.155 ms) : 0, 672155
BytebuddyAgent [candidate] (667.587 ms) : 0, 667587
GlobalTracer [baseline] (309.225 ms) : 0, 309225
GlobalTracer [candidate] (311.29 ms) : 0, 311290
AppSec [baseline] (51.357 ms) : 0, 51357
AppSec [candidate] (51.026 ms) : 0, 51026
Remote Config [baseline] (686.668 µs) : 0, 687
Remote Config [candidate] (671.88 µs) : 0, 672
Telemetry [baseline] (7.594 ms) : 0, 7594
Telemetry [candidate] (7.343 ms) : 0, 7343
section iast
BytebuddyAgent [baseline] (788.877 ms) : 0, 788877
BytebuddyAgent [candidate] (782.225 ms) : 0, 782225
GlobalTracer [baseline] (299.066 ms) : 0, 299066
GlobalTracer [candidate] (301.695 ms) : 0, 301695
AppSec [baseline] (51.299 ms) : 0, 51299
AppSec [candidate] (52.278 ms) : 0, 52278
IAST [baseline] (22.847 ms) : 0, 22847
IAST [candidate] (23.661 ms) : 0, 23661
Remote Config [baseline] (593.941 µs) : 0, 594
Remote Config [candidate] (565.109 µs) : 0, 565
Telemetry [baseline] (9.727 ms) : 0, 9727
Telemetry [candidate] (7.123 ms) : 0, 7123
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (783.304 ms) : 0, 783304
BytebuddyAgent [candidate] (785.429 ms) : 0, 785429
GlobalTracer [baseline] (297.65 ms) : 0, 297650
GlobalTracer [candidate] (302.502 ms) : 0, 302502
AppSec [baseline] (50.3 ms) : 0, 50300
AppSec [candidate] (50.369 ms) : 0, 50369
IAST [baseline] (22.844 ms) : 0, 22844
IAST [candidate] (22.569 ms) : 0, 22569
Remote Config [baseline] (602.099 µs) : 0, 602
Remote Config [candidate] (593.057 µs) : 0, 593
Telemetry [baseline] (9.676 ms) : 0, 9676
Telemetry [candidate] (11.209 ms) : 0, 11209
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (786.278 ms) : 0, 786278
BytebuddyAgent [candidate] (781.397 ms) : 0, 781397
GlobalTracer [baseline] (299.251 ms) : 0, 299251
GlobalTracer [candidate] (301.666 ms) : 0, 301666
AppSec [baseline] (52.913 ms) : 0, 52913
AppSec [candidate] (52.702 ms) : 0, 52702
IAST [baseline] (23.145 ms) : 0, 23145
IAST [candidate] (23.724 ms) : 0, 23724
Remote Config [baseline] (629.615 µs) : 0, 630
Remote Config [candidate] (606.271 µs) : 0, 606
Telemetry [baseline] (7.979 ms) : 0, 7979
Telemetry [candidate] (6.987 ms) : 0, 6987
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~b968dfc318, baseline=1.39.0-SNAPSHOT~93ecbc62b2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1050455
Total [baseline] (10.377 s) : 0, 10377106
Agent [candidate] (1.059 s) : 0, 1059077
Total [candidate] (10.299 s) : 0, 10298569
section appsec
Agent [baseline] (1.171 s) : 0, 1171033
Total [baseline] (10.502 s) : 0, 10502137
Agent [candidate] (1.179 s) : 0, 1179424
Total [candidate] (10.53 s) : 0, 10530285
section iast
Agent [baseline] (1.181 s) : 0, 1180622
Total [baseline] (10.805 s) : 0, 10805388
Agent [candidate] (1.188 s) : 0, 1187662
Total [candidate] (10.864 s) : 0, 10863702
section profiling
Agent [baseline] (1.249 s) : 0, 1248804
Total [baseline] (10.719 s) : 0, 10718583
Agent [candidate] (1.26 s) : 0, 1259973
Total [candidate] (10.668 s) : 0, 10667564
gantt
title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~b968dfc318, baseline=1.39.0-SNAPSHOT~93ecbc62b2
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.951 ms) : 0, 669951
BytebuddyAgent [candidate] (672.795 ms) : 0, 672795
GlobalTracer [baseline] (307.714 ms) : 0, 307714
GlobalTracer [candidate] (313.04 ms) : 0, 313040
AppSec [baseline] (51.125 ms) : 0, 51125
AppSec [candidate] (51.621 ms) : 0, 51621
Remote Config [baseline] (690.873 µs) : 0, 691
Remote Config [candidate] (687.772 µs) : 0, 688
Telemetry [baseline] (7.527 ms) : 0, 7527
Telemetry [candidate] (7.422 ms) : 0, 7422
section appsec
BytebuddyAgent [baseline] (679.465 ms) : 0, 679465
BytebuddyAgent [candidate] (681.667 ms) : 0, 681667
GlobalTracer [baseline] (300.963 ms) : 0, 300963
GlobalTracer [candidate] (306.067 ms) : 0, 306067
AppSec [baseline] (156.726 ms) : 0, 156726
AppSec [candidate] (160.673 ms) : 0, 160673
IAST [baseline] (20.145 ms) : 0, 20145
IAST [candidate] (18.064 ms) : 0, 18064
Remote Config [baseline] (603.53 µs) : 0, 604
Remote Config [candidate] (600.837 µs) : 0, 601
Telemetry [baseline] (9.701 ms) : 0, 9701
Telemetry [candidate] (7.842 ms) : 0, 7842
section iast
BytebuddyAgent [baseline] (783.046 ms) : 0, 783046
BytebuddyAgent [candidate] (785.511 ms) : 0, 785511
GlobalTracer [baseline] (299.146 ms) : 0, 299146
GlobalTracer [candidate] (303.895 ms) : 0, 303895
AppSec [baseline] (53.572 ms) : 0, 53572
AppSec [candidate] (50.412 ms) : 0, 50412
IAST [baseline] (23.551 ms) : 0, 23551
IAST [candidate] (24.899 ms) : 0, 24899
Remote Config [baseline] (627.757 µs) : 0, 628
Remote Config [candidate] (590.614 µs) : 0, 591
Telemetry [baseline] (7.188 ms) : 0, 7188
Telemetry [candidate] (8.847 ms) : 0, 8847
section profiling
BytebuddyAgent [baseline] (664.019 ms) : 0, 664019
BytebuddyAgent [candidate] (669.519 ms) : 0, 669519
GlobalTracer [baseline] (391.19 ms) : 0, 391190
GlobalTracer [candidate] (397.356 ms) : 0, 397356
AppSec [baseline] (52.406 ms) : 0, 52406
AppSec [candidate] (52.711 ms) : 0, 52711
Remote Config [baseline] (682.701 µs) : 0, 683
Remote Config [candidate] (705.653 µs) : 0, 706
Telemetry [baseline] (7.383 ms) : 0, 7383
Telemetry [candidate] (7.423 ms) : 0, 7423
ProfilingAgent [baseline] (95.909 ms) : 0, 95909
ProfilingAgent [candidate] (94.763 ms) : 0, 94763
Profiling [baseline] (95.933 ms) : 0, 95933
Profiling [candidate] (94.787 ms) : 0, 94787
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 6 metrics, 22 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~b968dfc318, baseline=1.39.0-SNAPSHOT~93ecbc62b2
dateFormat X
axisFormat %s
section baseline
no_agent (1.7 ms) : 1675, 1725
. : milestone, 1700,
appsec (2.173 ms) : 2140, 2206
. : milestone, 2173,
appsec_no_iast (2.166 ms) : 2134, 2198
. : milestone, 2166,
iast (1.876 ms) : 1847, 1906
. : milestone, 1876,
profiling (1.954 ms) : 1906, 2002
. : milestone, 1954,
tracing (1.86 ms) : 1828, 1891
. : milestone, 1860,
section candidate
no_agent (1.703 ms) : 1678, 1729
. : milestone, 1703,
appsec (2.161 ms) : 2130, 2193
. : milestone, 2161,
appsec_no_iast (2.161 ms) : 2129, 2193
. : milestone, 2161,
iast (1.896 ms) : 1866, 1925
. : milestone, 1896,
profiling (1.934 ms) : 1897, 1971
. : milestone, 1934,
tracing (1.876 ms) : 1844, 1907
. : milestone, 1876,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~b968dfc318, baseline=1.39.0-SNAPSHOT~93ecbc62b2
dateFormat X
axisFormat %s
section baseline
no_agent (451.9 µs) : 422, 481
. : milestone, 452,
iast (584.662 µs) : 552, 618
. : milestone, 585,
iast_FULL (685.626 µs) : 652, 719
. : milestone, 686,
iast_GLOBAL (611.595 µs) : 578, 645
. : milestone, 612,
iast_HARDCODED_SECRET_DISABLED (582.328 µs) : 550, 614
. : milestone, 582,
iast_INACTIVE (560.961 µs) : 529, 593
. : milestone, 561,
iast_TELEMETRY_OFF (571.623 µs) : 539, 604
. : milestone, 572,
tracing (533.449 µs) : 503, 564
. : milestone, 533,
section candidate
no_agent (451.298 µs) : 422, 480
. : milestone, 451,
iast (587.939 µs) : 555, 621
. : milestone, 588,
iast_FULL (680.035 µs) : 647, 713
. : milestone, 680,
iast_GLOBAL (623.113 µs) : 591, 656
. : milestone, 623,
iast_HARDCODED_SECRET_DISABLED (581.678 µs) : 549, 615
. : milestone, 582,
iast_INACTIVE (548.328 µs) : 517, 580
. : milestone, 548,
iast_TELEMETRY_OFF (570.287 µs) : 537, 603
. : milestone, 570,
tracing (539.679 µs) : 510, 570
. : milestone, 540,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~b968dfc318, baseline=1.39.0-SNAPSHOT~93ecbc62b2
dateFormat X
axisFormat %s
section baseline
no_agent (1.464 ms) : 1452, 1475
. : milestone, 1464,
appsec (2.221 ms) : 2186, 2256
. : milestone, 2221,
iast (1.956 ms) : 1914, 1997
. : milestone, 1956,
iast_GLOBAL (2.018 ms) : 1974, 2062
. : milestone, 2018,
profiling (1.868 ms) : 1834, 1903
. : milestone, 1868,
tracing (1.84 ms) : 1807, 1873
. : milestone, 1840,
section candidate
no_agent (1.458 ms) : 1447, 1469
. : milestone, 1458,
appsec (2.208 ms) : 2173, 2243
. : milestone, 2208,
iast (1.982 ms) : 1938, 2026
. : milestone, 1982,
iast_GLOBAL (2.001 ms) : 1959, 2044
. : milestone, 2001,
profiling (1.851 ms) : 1817, 1886
. : milestone, 1851,
tracing (1.83 ms) : 1797, 1862
. : milestone, 1830,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~b968dfc318, baseline=1.39.0-SNAPSHOT~93ecbc62b2
dateFormat X
axisFormat %s
section baseline
no_agent (15.555 s) : 15555000, 15555000
. : milestone, 15555000,
appsec (15.054 s) : 15054000, 15054000
. : milestone, 15054000,
iast (18.876 s) : 18876000, 18876000
. : milestone, 18876000,
iast_GLOBAL (17.891 s) : 17891000, 17891000
. : milestone, 17891000,
profiling (15.577 s) : 15577000, 15577000
. : milestone, 15577000,
tracing (15.052 s) : 15052000, 15052000
. : milestone, 15052000,
section candidate
no_agent (15.015 s) : 15015000, 15015000
. : milestone, 15015000,
appsec (14.974 s) : 14974000, 14974000
. : milestone, 14974000,
iast (18.866 s) : 18866000, 18866000
. : milestone, 18866000,
iast_GLOBAL (17.706 s) : 17706000, 17706000
. : milestone, 17706000,
profiling (15.752 s) : 15752000, 15752000
. : milestone, 15752000,
tracing (15.088 s) : 15088000, 15088000
. : milestone, 15088000,
|
c9a799d
to
1e180f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds functionality to capture AWS Json response/request payload and convert it to span tags while applying expansion and redaction defined rules.
Motivation
Having the ability to see data that was passed into an HTTPS payload from one service to the other.
Help customers (especially those who are using serverless architecture) reproduce and resolve bugs in their serverless compute code or configuration.
Additional Notes
Jira ticket: AIDM-174
NodeJS: DataDog/dd-trace-js#4309