Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix instanceof as predicate for value expression #7313

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Fix instanceof as predicate for value expression #7313

merged 2 commits into from
Jul 16, 2024
+176 −1

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Jul 12, 2024 •
edited by jira bot
Loading

What Does This Do

Add instanceof among the predicate functions when parsing value expressions.
Add test for parsing top level value expressions

Motivation

Additional Notes

Jira ticket: DEBUG-2527

@jpbempel jpbempel requested a review from a team as a code owner July 12, 2024 09:03
@jpbempel jpbempel requested review from cimi and removed request for a team July 12, 2024 09:03
@pr-commenter
Copy link

pr-commenter bot commented Jul 12, 2024 •
edited
Loading

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1721115727 1721116101
end_time 2024-07-16T07:43:21 2024-07-16T07:49:36
git_branch master jpbempel/fix-instanceof-predicate
git_commit_sha c31955f f233fe6
start_time 2024-07-16T07:42:08 2024-07-16T07:48:22
See matching parameters
Baseline Candidate
ci_job_id 573280815 573280815
ci_pipeline_id 39240394 39240394
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1721115035 1721115035

Summary

Found 0 performance improvements and 4 performance regressions! Performance is the same for 4 metrics, 7 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:loop worse
[+685.437µs; +692.725µs] or [+6.791%; +6.863%]		 worse
[+668.262µs; +717.705µs] or [+6.522%; +7.005%]		 worse
[+615.652µs; +727.788µs] or [+5.942%; +7.024%]		 unstable
[-694.682µs; +1138.923µs] or [-6.214%; +10.187%]		 worse
[-6.597op/s; -4.716op/s] or [-6.860%; -4.904%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-12.176µs; +17.599µs] or [-4.791%; +6.924%]		 unstable
[-22.222µs; +27.196µs] or [-7.657%; +9.371%]		 unstable
[-30.344µs; +39.527µs] or [-10.027%; +13.062%]		 unstable
[-64.007µs; +96.004µs] or [-10.101%; +15.151%]		 same
scenario:basic same same same unstable
[-19.750µs; +51.537µs] or [-3.363%; +8.775%]		 unstable
[-213.266op/s; +78.313op/s] or [-8.104%; +2.976%]
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (290.206 µs) : 268, 312
.   : milestone, 290,
basic (300.277 µs) : 290, 310
.   : milestone, 300,
loop (10.246 ms) : 10234, 10258
.   : milestone, 10246,
section candidate
noprobe (292.693 µs) : 268, 318
.   : milestone, 293,
basic (298.71 µs) : 290, 307
.   : milestone, 299,
loop (10.939 ms) : 10909, 10969
.   : milestone, 10939,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 290.206 µs [268.075 µs, 312.338 µs]
basic 300.277 µs [290.408 µs, 310.147 µs]
loop 10.246 ms [10.234 ms, 10.258 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 292.693 µs [267.763 µs, 317.623 µs]
basic 298.71 µs [289.997 µs, 307.423 µs]
loop 10.939 ms [10.909 ms, 10.969 ms]

@pr-commenter
Copy link

pr-commenter bot commented Jul 12, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-instanceof-predicate
git_commit_date 1721114243 1721115035
git_commit_sha c31955f f233fe6
release_version 1.38.0-SNAPSHOT~c31955fcdf 1.38.0-SNAPSHOT~f233fe60f8
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1721117567 1721117567
ci_job_id 573280809 573280809
ci_pipeline_id 39240394 39240394
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.38.0-SNAPSHOT~f233fe60f8, baseline=1.38.0-SNAPSHOT~c31955fcdf

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064478
Total [baseline] (10.313 s) : 0, 10312847
Agent [candidate] (1.065 s) : 0, 1064835
Total [candidate] (10.304 s) : 0, 10303661
section appsec
Agent [baseline] (1.183 s) : 0, 1183326
Total [baseline] (10.585 s) : 0, 10584512
Agent [candidate] (1.194 s) : 0, 1193885
Total [candidate] (10.579 s) : 0, 10579136
section iast
Agent [baseline] (1.177 s) : 0, 1177311
Total [baseline] (10.94 s) : 0, 10940396
Agent [candidate] (1.176 s) : 0, 1176365
Total [candidate] (10.743 s) : 0, 10743469
section profiling
Agent [baseline] (1.264 s) : 0, 1263837
Total [baseline] (10.569 s) : 0, 10569158
Agent [candidate] (1.266 s) : 0, 1266207
Total [candidate] (10.621 s) : 0, 10620706
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent appsec 1.183 s 118.848 ms (11.2%)
Agent iast 1.177 s 112.833 ms (10.6%)
Agent profiling 1.264 s 199.359 ms (18.7%)
Total tracing 10.313 s -
Total appsec 10.585 s 271.665 ms (2.6%)
Total iast 10.94 s 627.549 ms (6.1%)
Total profiling 10.569 s 256.311 ms (2.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent appsec 1.194 s 129.05 ms (12.1%)
Agent iast 1.176 s 111.53 ms (10.5%)
Agent profiling 1.266 s 201.372 ms (18.9%)
Total tracing 10.304 s -
Total appsec 10.579 s 275.474 ms (2.7%)
Total iast 10.743 s 439.808 ms (4.3%)
Total profiling 10.621 s 317.045 ms (3.1%) 
gantt
    title petclinic - break down per module: candidate=1.38.0-SNAPSHOT~f233fe60f8, baseline=1.38.0-SNAPSHOT~c31955fcdf

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.25 ms) : 0, 666250
BytebuddyAgent [candidate] (666.613 ms) : 0, 666613
GlobalTracer [baseline] (305.312 ms) : 0, 305312
GlobalTracer [candidate] (304.973 ms) : 0, 304973
AppSec [baseline] (50.012 ms) : 0, 50012
AppSec [candidate] (50.16 ms) : 0, 50160
Remote Config [baseline] (672.407 µs) : 0, 672
Remote Config [candidate] (675.347 µs) : 0, 675
Telemetry [baseline] (7.633 ms) : 0, 7633
Telemetry [candidate] (7.715 ms) : 0, 7715
section appsec
BytebuddyAgent [baseline] (676.617 ms) : 0, 676617
BytebuddyAgent [candidate] (683.64 ms) : 0, 683640
GlobalTracer [baseline] (299.294 ms) : 0, 299294
GlobalTracer [candidate] (301.503 ms) : 0, 301503
AppSec [baseline] (153.723 ms) : 0, 153723
AppSec [candidate] (154.355 ms) : 0, 154355
Remote Config [baseline] (619.128 µs) : 0, 619
Remote Config [candidate] (628.463 µs) : 0, 628
Telemetry [baseline] (8.863 ms) : 0, 8863
Telemetry [candidate] (8.606 ms) : 0, 8606
IAST [baseline] (19.076 ms) : 0, 19076
IAST [candidate] (20.221 ms) : 0, 20221
section iast
BytebuddyAgent [baseline] (785.386 ms) : 0, 785386
BytebuddyAgent [candidate] (784.224 ms) : 0, 784224
GlobalTracer [baseline] (296.501 ms) : 0, 296501
GlobalTracer [candidate] (297.042 ms) : 0, 297042
AppSec [baseline] (48.043 ms) : 0, 48043
AppSec [candidate] (47.758 ms) : 0, 47758
Remote Config [baseline] (572.673 µs) : 0, 573
Remote Config [candidate] (579.315 µs) : 0, 579
Telemetry [baseline] (8.497 ms) : 0, 8497
Telemetry [candidate] (7.661 ms) : 0, 7661
IAST [baseline] (24.649 ms) : 0, 24649
IAST [candidate] (25.444 ms) : 0, 25444
section profiling
ProfilingAgent [baseline] (96.236 ms) : 0, 96236
ProfilingAgent [candidate] (96.357 ms) : 0, 96357
BytebuddyAgent [baseline] (662.731 ms) : 0, 662731
BytebuddyAgent [candidate] (663.648 ms) : 0, 663648
GlobalTracer [baseline] (388.148 ms) : 0, 388148
GlobalTracer [candidate] (389.064 ms) : 0, 389064
AppSec [baseline] (51.511 ms) : 0, 51511
AppSec [candidate] (51.811 ms) : 0, 51811
Remote Config [baseline] (648.123 µs) : 0, 648
Remote Config [candidate] (656.462 µs) : 0, 656
Telemetry [baseline] (7.272 ms) : 0, 7272
Telemetry [candidate] (7.365 ms) : 0, 7365
Profiling [baseline] (96.261 ms) : 0, 96261
Profiling [candidate] (96.381 ms) : 0, 96381
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.38.0-SNAPSHOT~f233fe60f8, baseline=1.38.0-SNAPSHOT~c31955fcdf

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.07 s) : 0, 1069995
Total [baseline] (8.567 s) : 0, 8567088
Agent [candidate] (1.063 s) : 0, 1063325
Total [candidate] (8.53 s) : 0, 8530416
section iast
Agent [baseline] (1.174 s) : 0, 1174273
Total [baseline] (8.98 s) : 0, 8980480
Agent [candidate] (1.17 s) : 0, 1169947
Total [candidate] (9.052 s) : 0, 9051965
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.174 s) : 0, 1174448
Total [baseline] (8.948 s) : 0, 8948107
Agent [candidate] (1.171 s) : 0, 1171303
Total [candidate] (8.968 s) : 0, 8967877
section iast_TELEMETRY_OFF
Agent [baseline] (1.166 s) : 0, 1166321
Total [baseline] (8.962 s) : 0, 8961660
Agent [candidate] (1.169 s) : 0, 1168725
Total [candidate] (8.998 s) : 0, 8997583
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.07 s -
Agent iast 1.174 s 104.277 ms (9.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.174 s 104.453 ms (9.8%)
Agent iast_TELEMETRY_OFF 1.166 s 96.326 ms (9.0%)
Total tracing 8.567 s -
Total iast 8.98 s 413.392 ms (4.8%)
Total iast_HARDCODED_SECRET_DISABLED 8.948 s 381.019 ms (4.4%)
Total iast_TELEMETRY_OFF 8.962 s 394.572 ms (4.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent iast 1.17 s 106.621 ms (10.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.171 s 107.978 ms (10.2%)
Agent iast_TELEMETRY_OFF 1.169 s 105.4 ms (9.9%)
Total tracing 8.53 s -
Total iast 9.052 s 521.549 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 8.968 s 437.461 ms (5.1%)
Total iast_TELEMETRY_OFF 8.998 s 467.167 ms (5.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.38.0-SNAPSHOT~f233fe60f8, baseline=1.38.0-SNAPSHOT~c31955fcdf

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.84 ms) : 0, 669840
BytebuddyAgent [candidate] (665.334 ms) : 0, 665334
GlobalTracer [baseline] (306.69 ms) : 0, 306690
GlobalTracer [candidate] (304.953 ms) : 0, 304953
AppSec [baseline] (50.437 ms) : 0, 50437
AppSec [candidate] (50.259 ms) : 0, 50259
Remote Config [baseline] (706.634 µs) : 0, 707
Remote Config [candidate] (669.344 µs) : 0, 669
Telemetry [baseline] (7.663 ms) : 0, 7663
Telemetry [candidate] (7.635 ms) : 0, 7635
section iast
BytebuddyAgent [baseline] (781.467 ms) : 0, 781467
BytebuddyAgent [candidate] (778.731 ms) : 0, 778731
GlobalTracer [baseline] (296.162 ms) : 0, 296162
GlobalTracer [candidate] (294.635 ms) : 0, 294635
AppSec [baseline] (47.502 ms) : 0, 47502
AppSec [candidate] (48.886 ms) : 0, 48886
Remote Config [baseline] (577.701 µs) : 0, 578
Remote Config [candidate] (579.566 µs) : 0, 580
Telemetry [baseline] (6.952 ms) : 0, 6952
Telemetry [candidate] (7.931 ms) : 0, 7931
IAST [baseline] (28.115 ms) : 0, 28115
IAST [candidate] (25.72 ms) : 0, 25720
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (781.608 ms) : 0, 781608
BytebuddyAgent [candidate] (779.88 ms) : 0, 779880
GlobalTracer [baseline] (296.0 ms) : 0, 296000
GlobalTracer [candidate] (295.942 ms) : 0, 295942
AppSec [baseline] (48.809 ms) : 0, 48809
AppSec [candidate] (48.163 ms) : 0, 48163
Remote Config [baseline] (555.729 µs) : 0, 556
Remote Config [candidate] (568.115 µs) : 0, 568
Telemetry [baseline] (7.625 ms) : 0, 7625
Telemetry [candidate] (6.98 ms) : 0, 6980
IAST [baseline] (26.29 ms) : 0, 26290
IAST [candidate] (26.218 ms) : 0, 26218
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (777.301 ms) : 0, 777301
BytebuddyAgent [candidate] (777.069 ms) : 0, 777069
GlobalTracer [baseline] (294.889 ms) : 0, 294889
GlobalTracer [candidate] (294.992 ms) : 0, 294992
AppSec [baseline] (47.175 ms) : 0, 47175
AppSec [candidate] (47.425 ms) : 0, 47425
Remote Config [baseline] (571.871 µs) : 0, 572
Remote Config [candidate] (572.698 µs) : 0, 573
Telemetry [baseline] (7.637 ms) : 0, 7637
Telemetry [candidate] (6.854 ms) : 0, 6854
IAST [baseline] (25.207 ms) : 0, 25207
IAST [candidate] (28.236 ms) : 0, 28236
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-07-16T07:43:43 2024-07-16T07:50:31
git_branch master jpbempel/fix-instanceof-predicate
git_commit_date 1721114243 1721115035
git_commit_sha c31955f f233fe6
release_version 1.38.0-SNAPSHOT~c31955fcdf 1.38.0-SNAPSHOT~f233fe60f8
start_time 2024-07-16T07:43:30 2024-07-16T07:50:18
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1721116576 1721116576
ci_job_id 573280810 573280810
ci_pipeline_id 39240394 39240394
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~f233fe60f8, baseline=1.38.0-SNAPSHOT~c31955fcdf
    dateFormat X
    axisFormat %s
section baseline
no_agent (363.741 µs) : 344, 384
.   : milestone, 364,
iast (478.695 µs) : 457, 501
.   : milestone, 479,
iast_FULL (552.889 µs) : 532, 574
.   : milestone, 553,
iast_GLOBAL (499.988 µs) : 479, 521
.   : milestone, 500,
iast_HARDCODED_SECRET_DISABLED (485.418 µs) : 464, 507
.   : milestone, 485,
iast_INACTIVE (451.126 µs) : 430, 472
.   : milestone, 451,
iast_TELEMETRY_OFF (466.811 µs) : 446, 488
.   : milestone, 467,
tracing (442.752 µs) : 422, 464
.   : milestone, 443,
section candidate
no_agent (366.073 µs) : 346, 386
.   : milestone, 366,
iast (480.126 µs) : 459, 501
.   : milestone, 480,
iast_FULL (554.843 µs) : 534, 576
.   : milestone, 555,
iast_GLOBAL (506.897 µs) : 486, 528
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (482.331 µs) : 461, 504
.   : milestone, 482,
iast_INACTIVE (447.405 µs) : 427, 468
.   : milestone, 447,
iast_TELEMETRY_OFF (465.887 µs) : 445, 487
.   : milestone, 466,
tracing (434.299 µs) : 414, 455
.   : milestone, 434,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.741 µs [343.9 µs, 383.582 µs] -
iast 478.695 µs [456.755 µs, 500.635 µs] 114.954 µs (31.6%)
iast_FULL 552.889 µs [531.838 µs, 573.94 µs] 189.148 µs (52.0%)
iast_GLOBAL 499.988 µs [479.182 µs, 520.794 µs] 136.247 µs (37.5%)
iast_HARDCODED_SECRET_DISABLED 485.418 µs [464.245 µs, 506.59 µs] 121.677 µs (33.5%)
iast_INACTIVE 451.126 µs [430.011 µs, 472.241 µs] 87.385 µs (24.0%)
iast_TELEMETRY_OFF 466.811 µs [445.966 µs, 487.656 µs] 103.07 µs (28.3%)
tracing 442.752 µs [421.773 µs, 463.731 µs] 79.011 µs (21.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.073 µs [346.29 µs, 385.856 µs] -
iast 480.126 µs [459.163 µs, 501.088 µs] 114.053 µs (31.2%)
iast_FULL 554.843 µs [533.839 µs, 575.848 µs] 188.771 µs (51.6%)
iast_GLOBAL 506.897 µs [485.719 µs, 528.076 µs] 140.825 µs (38.5%)
iast_HARDCODED_SECRET_DISABLED 482.331 µs [461.115 µs, 503.548 µs] 116.259 µs (31.8%)
iast_INACTIVE 447.405 µs [426.616 µs, 468.194 µs] 81.332 µs (22.2%)
iast_TELEMETRY_OFF 465.887 µs [444.811 µs, 486.964 µs] 99.815 µs (27.3%)
tracing 434.299 µs [413.995 µs, 454.602 µs] 68.226 µs (18.6%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~f233fe60f8, baseline=1.38.0-SNAPSHOT~c31955fcdf
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.332 ms) : 1312, 1351
.   : milestone, 1332,
appsec (1.725 ms) : 1701, 1748
.   : milestone, 1725,
appsec_no_iast (1.713 ms) : 1689, 1738
.   : milestone, 1713,
iast (1.464 ms) : 1442, 1487
.   : milestone, 1464,
profiling (1.503 ms) : 1479, 1527
.   : milestone, 1503,
tracing (1.45 ms) : 1425, 1475
.   : milestone, 1450,
section candidate
no_agent (1.337 ms) : 1317, 1358
.   : milestone, 1337,
appsec (1.708 ms) : 1685, 1731
.   : milestone, 1708,
appsec_no_iast (1.697 ms) : 1673, 1721
.   : milestone, 1697,
iast (1.463 ms) : 1440, 1485
.   : milestone, 1463,
profiling (1.513 ms) : 1488, 1539
.   : milestone, 1513,
tracing (1.487 ms) : 1463, 1511
.   : milestone, 1487,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.332 ms [1.312 ms, 1.351 ms] -
appsec 1.725 ms [1.701 ms, 1.748 ms] 392.817 µs (29.5%)
appsec_no_iast 1.713 ms [1.689 ms, 1.738 ms] 381.538 µs (28.6%)
iast 1.464 ms [1.442 ms, 1.487 ms] 132.589 µs (10.0%)
profiling 1.503 ms [1.479 ms, 1.527 ms] 171.281 µs (12.9%)
tracing 1.45 ms [1.425 ms, 1.475 ms] 118.083 µs (8.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.337 ms [1.317 ms, 1.358 ms] -
appsec 1.708 ms [1.685 ms, 1.731 ms] 370.559 µs (27.7%)
appsec_no_iast 1.697 ms [1.673 ms, 1.721 ms] 359.311 µs (26.9%)
iast 1.463 ms [1.44 ms, 1.485 ms] 125.35 µs (9.4%)
profiling 1.513 ms [1.488 ms, 1.539 ms] 175.983 µs (13.2%)
tracing 1.487 ms [1.463 ms, 1.511 ms] 149.523 µs (11.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-instanceof-predicate
git_commit_date 1721114243 1721115035
git_commit_sha c31955f f233fe6
release_version 1.38.0-SNAPSHOT~c31955fcdf 1.38.0-SNAPSHOT~f233fe60f8
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1721117062 1721117062
ci_job_id 573280811 573280811
ci_pipeline_id 39240394 39240394
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~f233fe60f8, baseline=1.38.0-SNAPSHOT~c31955fcdf
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.54 s) : 15540000, 15540000
.   : milestone, 15540000,
appsec (14.968 s) : 14968000, 14968000
.   : milestone, 14968000,
iast (19.132 s) : 19132000, 19132000
.   : milestone, 19132000,
iast_GLOBAL (18.032 s) : 18032000, 18032000
.   : milestone, 18032000,
profiling (14.98 s) : 14980000, 14980000
.   : milestone, 14980000,
tracing (15.117 s) : 15117000, 15117000
.   : milestone, 15117000,
section candidate
no_agent (15.085 s) : 15085000, 15085000
.   : milestone, 15085000,
appsec (15.212 s) : 15212000, 15212000
.   : milestone, 15212000,
iast (18.839 s) : 18839000, 18839000
.   : milestone, 18839000,
iast_GLOBAL (18.325 s) : 18325000, 18325000
.   : milestone, 18325000,
profiling (15.411 s) : 15411000, 15411000
.   : milestone, 15411000,
tracing (15.109 s) : 15109000, 15109000
.   : milestone, 15109000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.54 s [15.54 s, 15.54 s] -
appsec 14.968 s [14.968 s, 14.968 s] -572.0 ms (-3.7%)
iast 19.132 s [19.132 s, 19.132 s] 3.592 s (23.1%)
iast_GLOBAL 18.032 s [18.032 s, 18.032 s] 2.492 s (16.0%)
profiling 14.98 s [14.98 s, 14.98 s] -560.0 ms (-3.6%)
tracing 15.117 s [15.117 s, 15.117 s] -423.0 ms (-2.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.085 s [15.085 s, 15.085 s] -
appsec 15.212 s [15.212 s, 15.212 s] 127.0 ms (0.8%)
iast 18.839 s [18.839 s, 18.839 s] 3.754 s (24.9%)
iast_GLOBAL 18.325 s [18.325 s, 18.325 s] 3.24 s (21.5%)
profiling 15.411 s [15.411 s, 15.411 s] 326.0 ms (2.2%)
tracing 15.109 s [15.109 s, 15.109 s] 24.0 ms (0.2%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~f233fe60f8, baseline=1.38.0-SNAPSHOT~c31955fcdf
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.464 ms) : 1453, 1476
.   : milestone, 1464,
appsec (2.222 ms) : 2187, 2256
.   : milestone, 2222,
iast (1.97 ms) : 1929, 2012
.   : milestone, 1970,
iast_GLOBAL (2.023 ms) : 1980, 2065
.   : milestone, 2023,
profiling (1.858 ms) : 1824, 1892
.   : milestone, 1858,
tracing (1.857 ms) : 1824, 1891
.   : milestone, 1857,
section candidate
no_agent (1.462 ms) : 1451, 1474
.   : milestone, 1462,
appsec (2.219 ms) : 2184, 2253
.   : milestone, 2219,
iast (1.978 ms) : 1936, 2020
.   : milestone, 1978,
iast_GLOBAL (2.019 ms) : 1977, 2061
.   : milestone, 2019,
profiling (1.873 ms) : 1837, 1909
.   : milestone, 1873,
tracing (1.848 ms) : 1815, 1881
.   : milestone, 1848,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.464 ms [1.453 ms, 1.476 ms] -
appsec 2.222 ms [2.187 ms, 2.256 ms] 757.514 µs (51.7%)
iast 1.97 ms [1.929 ms, 2.012 ms] 506.227 µs (34.6%)
iast_GLOBAL 2.023 ms [1.98 ms, 2.065 ms] 558.356 µs (38.1%)
profiling 1.858 ms [1.824 ms, 1.892 ms] 393.65 µs (26.9%)
tracing 1.857 ms [1.824 ms, 1.891 ms] 393.281 µs (26.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.451 ms, 1.474 ms] -
appsec 2.219 ms [2.184 ms, 2.253 ms] 756.284 µs (51.7%)
iast 1.978 ms [1.936 ms, 2.02 ms] 515.812 µs (35.3%)
iast_GLOBAL 2.019 ms [1.977 ms, 2.061 ms] 556.97 µs (38.1%)
profiling 1.873 ms [1.837 ms, 1.909 ms] 410.691 µs (28.1%)
tracing 1.848 ms [1.815 ms, 1.881 ms] 386.142 µs (26.4%)

@jpbempel
Fix instanceof as predicate for value expression
7e2a568 
Add `instanceof` among the predicate functions when parsing value
expressions.
Add test for parsing top level value expressions
@jpbempel jpbempel force-pushed the jpbempel/fix-instanceof-predicate branch from 580b578 to 7e2a568 Compare July 13, 2024 08:00
@PerfectSlayer PerfectSlayer added the comp: debugger Dynamic Instrumentation label Jul 15, 2024
shatzi
shatzi approved these changes Jul 16, 2024
View reviewed changes
...-agent/agent-debugger/debugger-el/src/test/java/com/datadog/debugger/el/ValueScriptTest.java
}

@Test
public void predicates() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are no assertions here. not sure what this test expect to catch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jpbempel jpbempel merged commit 2efac1a into master Jul 16, 2024
83 checks passed
@jpbempel jpbempel deleted the jpbempel/fix-instanceof-predicate branch July 16, 2024 08:42
@github-actions github-actions bot added this to the 1.38.0 milestone Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shatzi shatzi shatzi approved these changes

@cimi cimi Awaiting requested review from cimi cimi is a code owner automatically assigned from DataDog/debugger-java

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation type: bug
Projects
None yet
Milestone
1.38.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jpbempel @shatzi @PerfectSlayer