-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize per-test code coverage #7315
Merged
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/segmentful-coverage-optimisation
Jul 15, 2024
Merged
Optimize per-test code coverage #7315
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/segmentful-coverage-optimisation
Jul 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-tkachenko-datadog
added
tag: performance
Performance related changes
comp: ci visibility
Continuous Integration Visibility
run-tests: all
Run all tests
labels
Jul 12, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.38.0-SNAPSHOT~8519757f6d, baseline=1.38.0-SNAPSHOT~f0eec59df9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063815
Total [baseline] (10.299 s) : 0, 10299356
Agent [candidate] (1.063 s) : 0, 1063072
Total [candidate] (10.304 s) : 0, 10304312
section appsec
Agent [baseline] (1.183 s) : 0, 1183121
Total [baseline] (10.512 s) : 0, 10512233
Agent [candidate] (1.182 s) : 0, 1182447
Total [candidate] (10.481 s) : 0, 10480667
section iast
Agent [baseline] (1.173 s) : 0, 1173006
Total [baseline] (10.726 s) : 0, 10726373
Agent [candidate] (1.171 s) : 0, 1170946
Total [candidate] (10.727 s) : 0, 10727136
section profiling
Agent [baseline] (1.264 s) : 0, 1264490
Total [baseline] (10.545 s) : 0, 10544921
Agent [candidate] (1.273 s) : 0, 1272779
Total [candidate] (10.559 s) : 0, 10559023
gantt
title petclinic - break down per module: candidate=1.38.0-SNAPSHOT~8519757f6d, baseline=1.38.0-SNAPSHOT~f0eec59df9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.216 ms) : 0, 666216
BytebuddyAgent [candidate] (665.104 ms) : 0, 665104
GlobalTracer [baseline] (304.787 ms) : 0, 304787
GlobalTracer [candidate] (304.953 ms) : 0, 304953
AppSec [baseline] (49.978 ms) : 0, 49978
AppSec [candidate] (50.038 ms) : 0, 50038
Remote Config [baseline] (678.459 µs) : 0, 678
Remote Config [candidate] (671.569 µs) : 0, 672
Telemetry [baseline] (7.584 ms) : 0, 7584
Telemetry [candidate] (7.608 ms) : 0, 7608
section appsec
BytebuddyAgent [baseline] (677.279 ms) : 0, 677279
BytebuddyAgent [candidate] (675.796 ms) : 0, 675796
GlobalTracer [baseline] (299.196 ms) : 0, 299196
GlobalTracer [candidate] (298.762 ms) : 0, 298762
AppSec [baseline] (153.244 ms) : 0, 153244
AppSec [candidate] (153.614 ms) : 0, 153614
IAST [baseline] (20.843 ms) : 0, 20843
IAST [candidate] (20.129 ms) : 0, 20129
Remote Config [baseline] (622.344 µs) : 0, 622
Remote Config [candidate] (618.798 µs) : 0, 619
Telemetry [baseline] (7.643 ms) : 0, 7643
Telemetry [candidate] (8.895 ms) : 0, 8895
section iast
BytebuddyAgent [baseline] (780.778 ms) : 0, 780778
BytebuddyAgent [candidate] (780.175 ms) : 0, 780175
GlobalTracer [baseline] (296.237 ms) : 0, 296237
GlobalTracer [candidate] (295.822 ms) : 0, 295822
AppSec [baseline] (50.292 ms) : 0, 50292
AppSec [candidate] (48.525 ms) : 0, 48525
IAST [baseline] (24.718 ms) : 0, 24718
IAST [candidate] (25.401 ms) : 0, 25401
Remote Config [baseline] (565.297 µs) : 0, 565
Remote Config [candidate] (567.502 µs) : 0, 568
Telemetry [baseline] (6.92 ms) : 0, 6920
Telemetry [candidate] (6.863 ms) : 0, 6863
section profiling
BytebuddyAgent [baseline] (662.572 ms) : 0, 662572
BytebuddyAgent [candidate] (667.865 ms) : 0, 667865
GlobalTracer [baseline] (388.148 ms) : 0, 388148
GlobalTracer [candidate] (391.411 ms) : 0, 391411
AppSec [baseline] (51.685 ms) : 0, 51685
AppSec [candidate] (51.634 ms) : 0, 51634
Remote Config [baseline] (659.418 µs) : 0, 659
Remote Config [candidate] (666.395 µs) : 0, 666
Telemetry [baseline] (7.409 ms) : 0, 7409
Telemetry [candidate] (7.398 ms) : 0, 7398
ProfilingAgent [baseline] (96.69 ms) : 0, 96690
ProfilingAgent [candidate] (95.978 ms) : 0, 95978
Profiling [baseline] (96.716 ms) : 0, 96716
Profiling [candidate] (96.002 ms) : 0, 96002
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.38.0-SNAPSHOT~8519757f6d, baseline=1.38.0-SNAPSHOT~f0eec59df9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062903
Total [baseline] (8.505 s) : 0, 8505173
Agent [candidate] (1.07 s) : 0, 1069733
Total [candidate] (8.519 s) : 0, 8518890
section iast
Agent [baseline] (1.171 s) : 0, 1170891
Total [baseline] (8.951 s) : 0, 8950571
Agent [candidate] (1.185 s) : 0, 1185471
Total [candidate] (9.042 s) : 0, 9041529
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.174 s) : 0, 1173655
Total [baseline] (8.928 s) : 0, 8928242
Agent [candidate] (1.17 s) : 0, 1170416
Total [candidate] (8.91 s) : 0, 8909966
section iast_TELEMETRY_OFF
Agent [baseline] (1.175 s) : 0, 1174862
Total [baseline] (8.97 s) : 0, 8969819
Agent [candidate] (1.185 s) : 0, 1184658
Total [candidate] (8.986 s) : 0, 8985872
gantt
title insecure-bank - break down per module: candidate=1.38.0-SNAPSHOT~8519757f6d, baseline=1.38.0-SNAPSHOT~f0eec59df9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.847 ms) : 0, 664847
BytebuddyAgent [candidate] (669.462 ms) : 0, 669462
GlobalTracer [baseline] (305.435 ms) : 0, 305435
GlobalTracer [candidate] (306.699 ms) : 0, 306699
AppSec [baseline] (49.935 ms) : 0, 49935
AppSec [candidate] (50.424 ms) : 0, 50424
Remote Config [baseline] (675.877 µs) : 0, 676
Remote Config [candidate] (675.25 µs) : 0, 675
Telemetry [baseline] (7.586 ms) : 0, 7586
Telemetry [candidate] (7.693 ms) : 0, 7693
section iast
BytebuddyAgent [baseline] (780.002 ms) : 0, 780002
BytebuddyAgent [candidate] (789.812 ms) : 0, 789812
GlobalTracer [baseline] (295.455 ms) : 0, 295455
GlobalTracer [candidate] (299.115 ms) : 0, 299115
AppSec [baseline] (48.644 ms) : 0, 48644
AppSec [candidate] (49.337 ms) : 0, 49337
IAST [baseline] (25.882 ms) : 0, 25882
IAST [candidate] (26.051 ms) : 0, 26051
Remote Config [baseline] (559.136 µs) : 0, 559
Remote Config [candidate] (590.75 µs) : 0, 591
Telemetry [baseline] (6.871 ms) : 0, 6871
Telemetry [candidate] (7.019 ms) : 0, 7019
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (781.244 ms) : 0, 781244
BytebuddyAgent [candidate] (779.306 ms) : 0, 779306
GlobalTracer [baseline] (295.544 ms) : 0, 295544
GlobalTracer [candidate] (295.29 ms) : 0, 295290
AppSec [baseline] (47.405 ms) : 0, 47405
AppSec [candidate] (49.562 ms) : 0, 49562
IAST [baseline] (28.416 ms) : 0, 28416
IAST [candidate] (25.275 ms) : 0, 25275
Remote Config [baseline] (565.82 µs) : 0, 566
Remote Config [candidate] (558.641 µs) : 0, 559
Telemetry [baseline] (6.929 ms) : 0, 6929
Telemetry [candidate] (6.915 ms) : 0, 6915
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (781.877 ms) : 0, 781877
BytebuddyAgent [candidate] (788.571 ms) : 0, 788571
GlobalTracer [baseline] (296.507 ms) : 0, 296507
GlobalTracer [candidate] (298.901 ms) : 0, 298901
AppSec [baseline] (47.46 ms) : 0, 47460
AppSec [candidate] (47.63 ms) : 0, 47630
IAST [baseline] (28.017 ms) : 0, 28017
IAST [candidate] (28.393 ms) : 0, 28393
Remote Config [baseline] (571.134 µs) : 0, 571
Remote Config [candidate] (580.843 µs) : 0, 581
Telemetry [baseline] (6.817 ms) : 0, 6817
Telemetry [candidate] (6.87 ms) : 0, 6870
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 11 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~8519757f6d, baseline=1.38.0-SNAPSHOT~f0eec59df9
dateFormat X
axisFormat %s
section baseline
no_agent (1.325 ms) : 1306, 1344
. : milestone, 1325,
appsec (1.706 ms) : 1683, 1729
. : milestone, 1706,
appsec_no_iast (1.722 ms) : 1698, 1746
. : milestone, 1722,
iast (1.451 ms) : 1428, 1473
. : milestone, 1451,
profiling (1.474 ms) : 1449, 1499
. : milestone, 1474,
tracing (1.461 ms) : 1438, 1485
. : milestone, 1461,
section candidate
no_agent (1.329 ms) : 1310, 1348
. : milestone, 1329,
appsec (1.689 ms) : 1667, 1712
. : milestone, 1689,
appsec_no_iast (1.711 ms) : 1686, 1735
. : milestone, 1711,
iast (1.489 ms) : 1467, 1511
. : milestone, 1489,
profiling (1.543 ms) : 1518, 1568
. : milestone, 1543,
tracing (1.45 ms) : 1425, 1475
. : milestone, 1450,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~8519757f6d, baseline=1.38.0-SNAPSHOT~f0eec59df9
dateFormat X
axisFormat %s
section baseline
no_agent (366.506 µs) : 347, 386
. : milestone, 367,
iast (482.064 µs) : 460, 504
. : milestone, 482,
iast_FULL (546.629 µs) : 526, 568
. : milestone, 547,
iast_GLOBAL (505.349 µs) : 483, 528
. : milestone, 505,
iast_HARDCODED_SECRET_DISABLED (476.915 µs) : 456, 498
. : milestone, 477,
iast_INACTIVE (455.384 µs) : 433, 478
. : milestone, 455,
iast_TELEMETRY_OFF (463.2 µs) : 442, 484
. : milestone, 463,
tracing (453.702 µs) : 433, 474
. : milestone, 454,
section candidate
no_agent (371.973 µs) : 352, 391
. : milestone, 372,
iast (476.422 µs) : 455, 497
. : milestone, 476,
iast_FULL (549.806 µs) : 529, 571
. : milestone, 550,
iast_GLOBAL (507.013 µs) : 485, 529
. : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (472.191 µs) : 451, 493
. : milestone, 472,
iast_INACTIVE (448.907 µs) : 428, 470
. : milestone, 449,
iast_TELEMETRY_OFF (465.415 µs) : 444, 487
. : milestone, 465,
tracing (437.085 µs) : 416, 458
. : milestone, 437,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~8519757f6d, baseline=1.38.0-SNAPSHOT~f0eec59df9
dateFormat X
axisFormat %s
section baseline
no_agent (15.175 s) : 15175000, 15175000
. : milestone, 15175000,
appsec (14.895 s) : 14895000, 14895000
. : milestone, 14895000,
iast (18.61 s) : 18610000, 18610000
. : milestone, 18610000,
iast_GLOBAL (17.964 s) : 17964000, 17964000
. : milestone, 17964000,
profiling (15.202 s) : 15202000, 15202000
. : milestone, 15202000,
tracing (15.255 s) : 15255000, 15255000
. : milestone, 15255000,
section candidate
no_agent (15.445 s) : 15445000, 15445000
. : milestone, 15445000,
appsec (15.145 s) : 15145000, 15145000
. : milestone, 15145000,
iast (18.726 s) : 18726000, 18726000
. : milestone, 18726000,
iast_GLOBAL (18.226 s) : 18226000, 18226000
. : milestone, 18226000,
profiling (14.854 s) : 14854000, 14854000
. : milestone, 14854000,
tracing (15.042 s) : 15042000, 15042000
. : milestone, 15042000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~8519757f6d, baseline=1.38.0-SNAPSHOT~f0eec59df9
dateFormat X
axisFormat %s
section baseline
no_agent (1.463 ms) : 1451, 1474
. : milestone, 1463,
appsec (2.231 ms) : 2196, 2266
. : milestone, 2231,
iast (1.983 ms) : 1941, 2025
. : milestone, 1983,
iast_GLOBAL (2.014 ms) : 1972, 2056
. : milestone, 2014,
profiling (1.865 ms) : 1831, 1900
. : milestone, 1865,
tracing (1.84 ms) : 1807, 1873
. : milestone, 1840,
section candidate
no_agent (1.465 ms) : 1453, 1476
. : milestone, 1465,
appsec (2.221 ms) : 2187, 2256
. : milestone, 2221,
iast (1.976 ms) : 1934, 2017
. : milestone, 1976,
iast_GLOBAL (2.015 ms) : 1974, 2056
. : milestone, 2015,
profiling (1.854 ms) : 1821, 1888
. : milestone, 1854,
tracing (1.849 ms) : 1815, 1882
. : milestone, 1849,
|
nikita-tkachenko-datadog
force-pushed
the
nikita-tkachenko/segmentful-coverage-optimisation
branch
2 times, most recently
from
July 12, 2024 12:16
9272c4c
to
577d498
Compare
nikita-tkachenko-datadog
force-pushed
the
nikita-tkachenko/segmentful-coverage-optimisation
branch
from
July 12, 2024 13:39
577d498
to
8519757
Compare
nikita-tkachenko-datadog
requested review from
romainkomorndatadog,
mcculls and
PerfectSlayer
July 12, 2024 15:18
romainkomorndatadog
approved these changes
Jul 15, 2024
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/segmentful-coverage-optimisation
branch
July 15, 2024 10:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: ci visibility
Continuous Integration Visibility
run-tests: all
Run all tests
tag: performance
Performance related changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Reduces the overhead of per-test code coverage.
Additional Notes
The following things were optimised:
Also some cosmetic improvements were done: moving classes around, renaming methods, improving documentation and comments.
Jira ticket: SDTEST-533