-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture the auto-injection related settings in JFR recording #7317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardstartin
approved these changes
Jul 12, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.38.0-SNAPSHOT~c9265acfea, baseline=1.38.0-SNAPSHOT~f0eec59df9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064041
Total [baseline] (10.276 s) : 0, 10275854
Agent [candidate] (1.069 s) : 0, 1069082
Total [candidate] (10.263 s) : 0, 10262667
section appsec
Agent [baseline] (1.19 s) : 0, 1189676
Total [baseline] (10.549 s) : 0, 10549154
Agent [candidate] (1.181 s) : 0, 1181176
Total [candidate] (10.465 s) : 0, 10465051
section iast
Agent [baseline] (1.171 s) : 0, 1170623
Total [baseline] (10.667 s) : 0, 10667239
Agent [candidate] (1.171 s) : 0, 1171465
Total [candidate] (10.699 s) : 0, 10698765
section profiling
Agent [baseline] (1.261 s) : 0, 1260601
Total [baseline] (10.546 s) : 0, 10545611
Agent [candidate] (1.263 s) : 0, 1262884
Total [candidate] (10.52 s) : 0, 10520091
gantt
title petclinic - break down per module: candidate=1.38.0-SNAPSHOT~c9265acfea, baseline=1.38.0-SNAPSHOT~f0eec59df9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.123 ms) : 0, 666123
BytebuddyAgent [candidate] (669.385 ms) : 0, 669385
GlobalTracer [baseline] (304.841 ms) : 0, 304841
GlobalTracer [candidate] (306.412 ms) : 0, 306412
AppSec [baseline] (50.135 ms) : 0, 50135
AppSec [candidate] (50.28 ms) : 0, 50280
Remote Config [baseline] (674.503 µs) : 0, 675
Remote Config [candidate] (673.96 µs) : 0, 674
Telemetry [baseline] (7.664 ms) : 0, 7664
Telemetry [candidate] (7.614 ms) : 0, 7614
section appsec
BytebuddyAgent [baseline] (680.032 ms) : 0, 680032
BytebuddyAgent [candidate] (675.589 ms) : 0, 675589
GlobalTracer [baseline] (299.979 ms) : 0, 299979
GlobalTracer [candidate] (298.845 ms) : 0, 298845
AppSec [baseline] (154.472 ms) : 0, 154472
AppSec [candidate] (153.388 ms) : 0, 153388
Remote Config [baseline] (623.775 µs) : 0, 624
Remote Config [candidate] (616.468 µs) : 0, 616
Telemetry [baseline] (9.255 ms) : 0, 9255
Telemetry [candidate] (7.304 ms) : 0, 7304
IAST [baseline] (20.992 ms) : 0, 20992
IAST [candidate] (21.574 ms) : 0, 21574
section iast
BytebuddyAgent [baseline] (780.133 ms) : 0, 780133
BytebuddyAgent [candidate] (779.799 ms) : 0, 779799
GlobalTracer [baseline] (295.299 ms) : 0, 295299
GlobalTracer [candidate] (295.614 ms) : 0, 295614
AppSec [baseline] (49.587 ms) : 0, 49587
AppSec [candidate] (47.908 ms) : 0, 47908
Remote Config [baseline] (569.74 µs) : 0, 570
Remote Config [candidate] (575.288 µs) : 0, 575
Telemetry [baseline] (6.951 ms) : 0, 6951
Telemetry [candidate] (7.794 ms) : 0, 7794
IAST [baseline] (24.504 ms) : 0, 24504
IAST [candidate] (26.252 ms) : 0, 26252
section profiling
ProfilingAgent [baseline] (95.83 ms) : 0, 95830
ProfilingAgent [candidate] (95.316 ms) : 0, 95316
BytebuddyAgent [baseline] (660.918 ms) : 0, 660918
BytebuddyAgent [candidate] (662.459 ms) : 0, 662459
GlobalTracer [baseline] (387.416 ms) : 0, 387416
GlobalTracer [candidate] (388.67 ms) : 0, 388670
AppSec [baseline] (51.44 ms) : 0, 51440
AppSec [candidate] (51.305 ms) : 0, 51305
Remote Config [baseline] (643.219 µs) : 0, 643
Remote Config [candidate] (647.67 µs) : 0, 648
Telemetry [baseline] (7.289 ms) : 0, 7289
Telemetry [candidate] (7.288 ms) : 0, 7288
Profiling [baseline] (95.854 ms) : 0, 95854
Profiling [candidate] (95.341 ms) : 0, 95341
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.38.0-SNAPSHOT~c9265acfea, baseline=1.38.0-SNAPSHOT~f0eec59df9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1060255
Total [baseline] (8.52 s) : 0, 8519870
Agent [candidate] (1.07 s) : 0, 1069762
Total [candidate] (8.524 s) : 0, 8524161
section iast
Agent [baseline] (1.182 s) : 0, 1182233
Total [baseline] (8.954 s) : 0, 8954197
Agent [candidate] (1.169 s) : 0, 1169304
Total [candidate] (8.926 s) : 0, 8926383
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.17 s) : 0, 1170034
Total [baseline] (8.911 s) : 0, 8911270
Agent [candidate] (1.179 s) : 0, 1179481
Total [candidate] (8.929 s) : 0, 8928701
section iast_TELEMETRY_OFF
Agent [baseline] (1.166 s) : 0, 1165672
Total [baseline] (8.931 s) : 0, 8930609
Agent [candidate] (1.166 s) : 0, 1165821
Total [candidate] (8.936 s) : 0, 8936110
gantt
title insecure-bank - break down per module: candidate=1.38.0-SNAPSHOT~c9265acfea, baseline=1.38.0-SNAPSHOT~f0eec59df9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (663.598 ms) : 0, 663598
BytebuddyAgent [candidate] (669.607 ms) : 0, 669607
GlobalTracer [baseline] (304.079 ms) : 0, 304079
GlobalTracer [candidate] (306.93 ms) : 0, 306930
AppSec [baseline] (49.881 ms) : 0, 49881
AppSec [candidate] (50.283 ms) : 0, 50283
Remote Config [baseline] (662.367 µs) : 0, 662
Remote Config [candidate] (670.745 µs) : 0, 671
Telemetry [baseline] (7.633 ms) : 0, 7633
Telemetry [candidate] (7.615 ms) : 0, 7615
section iast
BytebuddyAgent [baseline] (789.205 ms) : 0, 789205
BytebuddyAgent [candidate] (779.103 ms) : 0, 779103
GlobalTracer [baseline] (296.746 ms) : 0, 296746
GlobalTracer [candidate] (295.065 ms) : 0, 295065
AppSec [baseline] (48.17 ms) : 0, 48170
AppSec [candidate] (47.238 ms) : 0, 47238
IAST [baseline] (26.915 ms) : 0, 26915
IAST [candidate] (26.956 ms) : 0, 26956
Remote Config [baseline] (578.785 µs) : 0, 579
Remote Config [candidate] (569.908 µs) : 0, 570
Telemetry [baseline] (6.983 ms) : 0, 6983
Telemetry [candidate] (6.918 ms) : 0, 6918
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (779.939 ms) : 0, 779939
BytebuddyAgent [candidate] (786.066 ms) : 0, 786066
GlobalTracer [baseline] (295.281 ms) : 0, 295281
GlobalTracer [candidate] (297.435 ms) : 0, 297435
AppSec [baseline] (47.788 ms) : 0, 47788
AppSec [candidate] (48.644 ms) : 0, 48644
IAST [baseline] (25.957 ms) : 0, 25957
IAST [candidate] (26.224 ms) : 0, 26224
Remote Config [baseline] (561.999 µs) : 0, 562
Remote Config [candidate] (563.99 µs) : 0, 564
Telemetry [baseline] (6.958 ms) : 0, 6958
Telemetry [candidate] (6.957 ms) : 0, 6957
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (776.122 ms) : 0, 776122
BytebuddyAgent [candidate] (775.381 ms) : 0, 775381
GlobalTracer [baseline] (294.29 ms) : 0, 294290
GlobalTracer [candidate] (294.738 ms) : 0, 294738
AppSec [baseline] (46.942 ms) : 0, 46942
AppSec [candidate] (47.138 ms) : 0, 47138
IAST [baseline] (26.673 ms) : 0, 26673
IAST [candidate] (27.692 ms) : 0, 27692
Remote Config [baseline] (572.719 µs) : 0, 573
Remote Config [candidate] (571.932 µs) : 0, 572
Telemetry [baseline] (7.569 ms) : 0, 7569
Telemetry [candidate] (6.768 ms) : 0, 6768
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~c9265acfea, baseline=1.38.0-SNAPSHOT~f0eec59df9
dateFormat X
axisFormat %s
section baseline
no_agent (1.334 ms) : 1315, 1352
. : milestone, 1334,
appsec (1.689 ms) : 1667, 1712
. : milestone, 1689,
appsec_no_iast (1.712 ms) : 1688, 1736
. : milestone, 1712,
iast (1.481 ms) : 1459, 1502
. : milestone, 1481,
profiling (1.491 ms) : 1466, 1515
. : milestone, 1491,
tracing (1.461 ms) : 1437, 1485
. : milestone, 1461,
section candidate
no_agent (1.345 ms) : 1326, 1364
. : milestone, 1345,
appsec (1.694 ms) : 1671, 1717
. : milestone, 1694,
appsec_no_iast (1.703 ms) : 1679, 1727
. : milestone, 1703,
iast (1.473 ms) : 1451, 1495
. : milestone, 1473,
profiling (1.469 ms) : 1444, 1493
. : milestone, 1469,
tracing (1.47 ms) : 1445, 1495
. : milestone, 1470,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~c9265acfea, baseline=1.38.0-SNAPSHOT~f0eec59df9
dateFormat X
axisFormat %s
section baseline
no_agent (359.775 µs) : 340, 379
. : milestone, 360,
iast (476.15 µs) : 455, 497
. : milestone, 476,
iast_FULL (546.397 µs) : 525, 567
. : milestone, 546,
iast_GLOBAL (504.441 µs) : 482, 526
. : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (478.699 µs) : 458, 500
. : milestone, 479,
iast_INACTIVE (451.422 µs) : 430, 473
. : milestone, 451,
iast_TELEMETRY_OFF (465.709 µs) : 445, 487
. : milestone, 466,
tracing (429.494 µs) : 410, 449
. : milestone, 429,
section candidate
no_agent (361.095 µs) : 342, 380
. : milestone, 361,
iast (474.192 µs) : 453, 495
. : milestone, 474,
iast_FULL (543.812 µs) : 523, 565
. : milestone, 544,
iast_GLOBAL (502.446 µs) : 481, 523
. : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (486.161 µs) : 464, 508
. : milestone, 486,
iast_INACTIVE (449.027 µs) : 428, 470
. : milestone, 449,
iast_TELEMETRY_OFF (468.714 µs) : 447, 490
. : milestone, 469,
tracing (435.037 µs) : 415, 455
. : milestone, 435,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~c9265acfea, baseline=1.38.0-SNAPSHOT~f0eec59df9
dateFormat X
axisFormat %s
section baseline
no_agent (1.463 ms) : 1452, 1475
. : milestone, 1463,
appsec (2.221 ms) : 2186, 2255
. : milestone, 2221,
iast (1.955 ms) : 1914, 1996
. : milestone, 1955,
iast_GLOBAL (2.015 ms) : 1973, 2057
. : milestone, 2015,
profiling (1.867 ms) : 1832, 1902
. : milestone, 1867,
tracing (1.845 ms) : 1812, 1878
. : milestone, 1845,
section candidate
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (2.226 ms) : 2191, 2260
. : milestone, 2226,
iast (1.983 ms) : 1940, 2026
. : milestone, 1983,
iast_GLOBAL (2.024 ms) : 1981, 2067
. : milestone, 2024,
profiling (1.865 ms) : 1831, 1900
. : milestone, 1865,
tracing (1.843 ms) : 1810, 1877
. : milestone, 1843,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~c9265acfea, baseline=1.38.0-SNAPSHOT~f0eec59df9
dateFormat X
axisFormat %s
section baseline
no_agent (14.949 s) : 14949000, 14949000
. : milestone, 14949000,
appsec (15.336 s) : 15336000, 15336000
. : milestone, 15336000,
iast (18.976 s) : 18976000, 18976000
. : milestone, 18976000,
iast_GLOBAL (17.964 s) : 17964000, 17964000
. : milestone, 17964000,
profiling (15.183 s) : 15183000, 15183000
. : milestone, 15183000,
tracing (15.09 s) : 15090000, 15090000
. : milestone, 15090000,
section candidate
no_agent (15.006 s) : 15006000, 15006000
. : milestone, 15006000,
appsec (14.941 s) : 14941000, 14941000
. : milestone, 14941000,
iast (18.758 s) : 18758000, 18758000
. : milestone, 18758000,
iast_GLOBAL (17.986 s) : 17986000, 17986000
. : milestone, 17986000,
profiling (15.886 s) : 15886000, 15886000
. : milestone, 15886000,
tracing (14.918 s) : 14918000, 14918000
. : milestone, 14918000,
|
jbachorik
force-pushed
the
jb/profiler_ssi_setting
branch
from
July 12, 2024 12:21
ce74934
to
63917c4
Compare
jbachorik
force-pushed
the
jb/profiler_ssi_setting
branch
from
July 12, 2024 13:39
63917c4
to
c9265ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
It captures the values from settings related to auto-injection in the JFR recording.
Motivation
Make the debugging of service with auto-injected and auto-enabled functionality like profiling.
Additional Notes
Jira ticket: PROF-10157