Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Gradle v8.9 instrumentation #7319

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Fix Gradle v8.9 instrumentation #7319

merged 1 commit into from
Jul 12, 2024

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Jul 12, 2024 •
edited
Loading

What Does This Do

Fixes Gradle instrumentation following release v8.9

Additional Notes

Previous version of the code used org.gradle.internal.service.DefaultServiceRegistry#addProvider(Object) method to register CI Visibility plugin.
In Gradle v8.9 this method was replaced with org.gradle.internal.service.DefaultServiceRegistry#addProvider(org.gradle.internal.service.ServiceRegistrationProvider).
The new ServiceRegistrationProvider interface is introduced in Gradle v8.9.

The fixed version of the code uses alternative service registration method which works both in v8.9 and in older versions.

Jira ticket: SDTEST-566

@nikita-tkachenko-datadog nikita-tkachenko-datadog added type: bug comp: ci visibility Continuous Integration Visibility labels Jul 12, 2024
@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review July 12, 2024 12:54
@nikita-tkachenko-datadog nikita-tkachenko-datadog requested a review from a team as a code owner July 12, 2024 12:54
@pr-commenter
Copy link

pr-commenter bot commented Jul 12, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/fix-gradle-8.9-instrumentation
git_commit_date 1720763282 1720788625
git_commit_sha 63f16d7 352f20d
release_version 1.38.0-SNAPSHOT~63f16d7b20 1.38.0-SNAPSHOT~352f20da9c
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1720791092 1720791092
ci_job_id 570805171 570805171
ci_pipeline_id 39030351 39030351
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.38.0-SNAPSHOT~352f20da9c, baseline=1.38.0-SNAPSHOT~63f16d7b20

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065109
Total [baseline] (8.513 s) : 0, 8512536
Agent [candidate] (1.065 s) : 0, 1064878
Total [candidate] (8.509 s) : 0, 8509453
section iast
Agent [baseline] (1.172 s) : 0, 1171859
Total [baseline] (8.971 s) : 0, 8970753
Agent [candidate] (1.191 s) : 0, 1190823
Total [candidate] (9.023 s) : 0, 9022645
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.173 s) : 0, 1172676
Total [baseline] (8.916 s) : 0, 8916087
Agent [candidate] (1.17 s) : 0, 1169711
Total [candidate] (8.96 s) : 0, 8960472
section iast_TELEMETRY_OFF
Agent [baseline] (1.176 s) : 0, 1176160
Total [baseline] (8.98 s) : 0, 8979806
Agent [candidate] (1.168 s) : 0, 1168387
Total [candidate] (8.964 s) : 0, 8964478
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent iast 1.172 s 106.75 ms (10.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.173 s 107.567 ms (10.1%)
Agent iast_TELEMETRY_OFF 1.176 s 111.051 ms (10.4%)
Total tracing 8.513 s -
Total iast 8.971 s 458.217 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.916 s 403.551 ms (4.7%)
Total iast_TELEMETRY_OFF 8.98 s 467.27 ms (5.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent iast 1.191 s 125.945 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.17 s 104.832 ms (9.8%)
Agent iast_TELEMETRY_OFF 1.168 s 103.509 ms (9.7%)
Total tracing 8.509 s -
Total iast 9.023 s 513.192 ms (6.0%)
Total iast_HARDCODED_SECRET_DISABLED 8.96 s 451.019 ms (5.3%)
Total iast_TELEMETRY_OFF 8.964 s 455.025 ms (5.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.38.0-SNAPSHOT~352f20da9c, baseline=1.38.0-SNAPSHOT~63f16d7b20

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.418 ms) : 0, 666418
BytebuddyAgent [candidate] (666.148 ms) : 0, 666148
GlobalTracer [baseline] (305.475 ms) : 0, 305475
GlobalTracer [candidate] (305.727 ms) : 0, 305727
AppSec [baseline] (50.338 ms) : 0, 50338
AppSec [candidate] (50.09 ms) : 0, 50090
Remote Config [baseline] (670.83 µs) : 0, 671
Remote Config [candidate] (675.15 µs) : 0, 675
Telemetry [baseline] (7.652 ms) : 0, 7652
Telemetry [candidate] (7.628 ms) : 0, 7628
section iast
BytebuddyAgent [baseline] (781.103 ms) : 0, 781103
BytebuddyAgent [candidate] (796.588 ms) : 0, 796588
GlobalTracer [baseline] (295.38 ms) : 0, 295380
GlobalTracer [candidate] (299.5 ms) : 0, 299500
AppSec [baseline] (48.065 ms) : 0, 48065
AppSec [candidate] (49.376 ms) : 0, 49376
IAST [baseline] (26.247 ms) : 0, 26247
IAST [candidate] (24.005 ms) : 0, 24005
Remote Config [baseline] (586.284 µs) : 0, 586
Remote Config [candidate] (578.87 µs) : 0, 579
Telemetry [baseline] (7.009 ms) : 0, 7009
Telemetry [candidate] (7.032 ms) : 0, 7032
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (780.702 ms) : 0, 780702
BytebuddyAgent [candidate] (779.884 ms) : 0, 779884
GlobalTracer [baseline] (295.616 ms) : 0, 295616
GlobalTracer [candidate] (295.197 ms) : 0, 295197
AppSec [baseline] (48.998 ms) : 0, 48998
AppSec [candidate] (48.027 ms) : 0, 48027
IAST [baseline] (26.317 ms) : 0, 26317
IAST [candidate] (25.497 ms) : 0, 25497
Remote Config [baseline] (559.481 µs) : 0, 559
Remote Config [candidate] (568.301 µs) : 0, 568
Telemetry [baseline] (6.977 ms) : 0, 6977
Telemetry [candidate] (7.013 ms) : 0, 7013
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (782.905 ms) : 0, 782905
BytebuddyAgent [candidate] (778.425 ms) : 0, 778425
GlobalTracer [baseline] (296.823 ms) : 0, 296823
GlobalTracer [candidate] (294.808 ms) : 0, 294808
AppSec [baseline] (47.189 ms) : 0, 47189
AppSec [candidate] (47.159 ms) : 0, 47159
IAST [baseline] (27.504 ms) : 0, 27504
IAST [candidate] (27.064 ms) : 0, 27064
Remote Config [baseline] (561.376 µs) : 0, 561
Remote Config [candidate] (572.19 µs) : 0, 572
Telemetry [baseline] (7.558 ms) : 0, 7558
Telemetry [candidate] (6.803 ms) : 0, 6803
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.38.0-SNAPSHOT~352f20da9c, baseline=1.38.0-SNAPSHOT~63f16d7b20

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.073 s) : 0, 1072517
Total [baseline] (10.35 s) : 0, 10350170
Agent [candidate] (1.071 s) : 0, 1070819
Total [candidate] (10.327 s) : 0, 10327440
section appsec
Agent [baseline] (1.184 s) : 0, 1184491
Total [baseline] (10.487 s) : 0, 10486838
Agent [candidate] (1.192 s) : 0, 1192371
Total [candidate] (10.511 s) : 0, 10511040
section iast
Agent [baseline] (1.172 s) : 0, 1171837
Total [baseline] (10.698 s) : 0, 10697554
Agent [candidate] (1.183 s) : 0, 1183281
Total [candidate] (10.722 s) : 0, 10721586
section profiling
Agent [baseline] (1.281 s) : 0, 1281351
Total [baseline] (10.594 s) : 0, 10593798
Agent [candidate] (1.266 s) : 0, 1265851
Total [candidate] (10.584 s) : 0, 10584357
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.073 s -
Agent appsec 1.184 s 111.974 ms (10.4%)
Agent iast 1.172 s 99.32 ms (9.3%)
Agent profiling 1.281 s 208.834 ms (19.5%)
Total tracing 10.35 s -
Total appsec 10.487 s 136.667 ms (1.3%)
Total iast 10.698 s 347.384 ms (3.4%)
Total profiling 10.594 s 243.627 ms (2.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.071 s -
Agent appsec 1.192 s 121.551 ms (11.4%)
Agent iast 1.183 s 112.462 ms (10.5%)
Agent profiling 1.266 s 195.032 ms (18.2%)
Total tracing 10.327 s -
Total appsec 10.511 s 183.6 ms (1.8%)
Total iast 10.722 s 394.146 ms (3.8%)
Total profiling 10.584 s 256.917 ms (2.5%) 
gantt
    title petclinic - break down per module: candidate=1.38.0-SNAPSHOT~352f20da9c, baseline=1.38.0-SNAPSHOT~63f16d7b20

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (671.451 ms) : 0, 671451
BytebuddyAgent [candidate] (671.67 ms) : 0, 671670
GlobalTracer [baseline] (307.508 ms) : 0, 307508
GlobalTracer [candidate] (305.935 ms) : 0, 305935
AppSec [baseline] (50.344 ms) : 0, 50344
AppSec [candidate] (49.923 ms) : 0, 49923
Remote Config [baseline] (683.408 µs) : 0, 683
Remote Config [candidate] (669.186 µs) : 0, 669
Telemetry [baseline] (7.651 ms) : 0, 7651
Telemetry [candidate] (7.607 ms) : 0, 7607
section appsec
BytebuddyAgent [baseline] (677.516 ms) : 0, 677516
BytebuddyAgent [candidate] (682.038 ms) : 0, 682038
GlobalTracer [baseline] (299.81 ms) : 0, 299810
GlobalTracer [candidate] (300.916 ms) : 0, 300916
AppSec [baseline] (153.633 ms) : 0, 153633
AppSec [candidate] (154.191 ms) : 0, 154191
IAST [baseline] (21.645 ms) : 0, 21645
IAST [candidate] (22.904 ms) : 0, 22904
Remote Config [baseline] (621.487 µs) : 0, 621
Remote Config [candidate] (622.863 µs) : 0, 623
Telemetry [baseline] (7.365 ms) : 0, 7365
Telemetry [candidate] (8.273 ms) : 0, 8273
section iast
BytebuddyAgent [baseline] (780.58 ms) : 0, 780580
BytebuddyAgent [candidate] (787.407 ms) : 0, 787407
GlobalTracer [baseline] (295.247 ms) : 0, 295247
GlobalTracer [candidate] (297.89 ms) : 0, 297890
AppSec [baseline] (48.655 ms) : 0, 48655
AppSec [candidate] (47.686 ms) : 0, 47686
IAST [baseline] (26.239 ms) : 0, 26239
IAST [candidate] (26.621 ms) : 0, 26621
Remote Config [baseline] (579.288 µs) : 0, 579
Remote Config [candidate] (582.792 µs) : 0, 583
Telemetry [baseline] (7.007 ms) : 0, 7007
Telemetry [candidate] (9.411 ms) : 0, 9411
section profiling
BytebuddyAgent [baseline] (672.324 ms) : 0, 672324
BytebuddyAgent [candidate] (663.721 ms) : 0, 663721
GlobalTracer [baseline] (392.974 ms) : 0, 392974
GlobalTracer [candidate] (389.047 ms) : 0, 389047
AppSec [baseline] (52.68 ms) : 0, 52680
AppSec [candidate] (51.943 ms) : 0, 51943
Remote Config [baseline] (668.847 µs) : 0, 669
Remote Config [candidate] (669.66 µs) : 0, 670
Telemetry [baseline] (7.39 ms) : 0, 7390
Telemetry [candidate] (7.325 ms) : 0, 7325
ProfilingAgent [baseline] (97.318 ms) : 0, 97318
ProfilingAgent [candidate] (95.873 ms) : 0, 95873
Profiling [baseline] (97.343 ms) : 0, 97343
Profiling [candidate] (95.898 ms) : 0, 95898
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-07-12T13:04:24 2024-07-12T13:11:11
git_branch master nikita-tkachenko/fix-gradle-8.9-instrumentation
git_commit_date 1720763282 1720788625
git_commit_sha 63f16d7 352f20d
release_version 1.38.0-SNAPSHOT~63f16d7b20 1.38.0-SNAPSHOT~352f20da9c
start_time 2024-07-12T13:04:10 2024-07-12T13:10:58
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1720790215 1720790215
ci_job_id 570805172 570805172
ci_pipeline_id 39030351 39030351
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~352f20da9c, baseline=1.38.0-SNAPSHOT~63f16d7b20
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.343 ms) : 1324, 1362
.   : milestone, 1343,
appsec (1.692 ms) : 1669, 1714
.   : milestone, 1692,
appsec_no_iast (1.722 ms) : 1699, 1746
.   : milestone, 1722,
iast (1.472 ms) : 1450, 1494
.   : milestone, 1472,
profiling (1.483 ms) : 1458, 1508
.   : milestone, 1483,
tracing (1.448 ms) : 1424, 1473
.   : milestone, 1448,
section candidate
no_agent (1.34 ms) : 1320, 1360
.   : milestone, 1340,
appsec (1.706 ms) : 1683, 1730
.   : milestone, 1706,
appsec_no_iast (1.727 ms) : 1703, 1750
.   : milestone, 1727,
iast (1.475 ms) : 1453, 1498
.   : milestone, 1475,
profiling (1.492 ms) : 1467, 1516
.   : milestone, 1492,
tracing (1.458 ms) : 1434, 1483
.   : milestone, 1458,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.324 ms, 1.362 ms] -
appsec 1.692 ms [1.669 ms, 1.714 ms] 348.414 µs (25.9%)
appsec_no_iast 1.722 ms [1.699 ms, 1.746 ms] 379.279 µs (28.2%)
iast 1.472 ms [1.45 ms, 1.494 ms] 128.751 µs (9.6%)
profiling 1.483 ms [1.458 ms, 1.508 ms] 139.911 µs (10.4%)
tracing 1.448 ms [1.424 ms, 1.473 ms] 105.309 µs (7.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.34 ms [1.32 ms, 1.36 ms] -
appsec 1.706 ms [1.683 ms, 1.73 ms] 366.402 µs (27.3%)
appsec_no_iast 1.727 ms [1.703 ms, 1.75 ms] 386.568 µs (28.8%)
iast 1.475 ms [1.453 ms, 1.498 ms] 135.29 µs (10.1%)
profiling 1.492 ms [1.467 ms, 1.516 ms] 151.75 µs (11.3%)
tracing 1.458 ms [1.434 ms, 1.483 ms] 118.42 µs (8.8%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~352f20da9c, baseline=1.38.0-SNAPSHOT~63f16d7b20
    dateFormat X
    axisFormat %s
section baseline
no_agent (363.643 µs) : 344, 383
.   : milestone, 364,
iast (486.197 µs) : 464, 508
.   : milestone, 486,
iast_FULL (545.073 µs) : 524, 566
.   : milestone, 545,
iast_GLOBAL (504.285 µs) : 483, 526
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (473.398 µs) : 452, 494
.   : milestone, 473,
iast_INACTIVE (450.801 µs) : 429, 472
.   : milestone, 451,
iast_TELEMETRY_OFF (465.001 µs) : 444, 486
.   : milestone, 465,
tracing (441.197 µs) : 420, 463
.   : milestone, 441,
section candidate
no_agent (371.902 µs) : 352, 392
.   : milestone, 372,
iast (476.326 µs) : 455, 497
.   : milestone, 476,
iast_FULL (542.473 µs) : 521, 564
.   : milestone, 542,
iast_GLOBAL (506.265 µs) : 485, 527
.   : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (486.181 µs) : 464, 508
.   : milestone, 486,
iast_INACTIVE (448.911 µs) : 428, 470
.   : milestone, 449,
iast_TELEMETRY_OFF (470.028 µs) : 449, 491
.   : milestone, 470,
tracing (441.909 µs) : 421, 463
.   : milestone, 442,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.643 µs [344.278 µs, 383.008 µs] -
iast 486.197 µs [464.495 µs, 507.899 µs] 122.554 µs (33.7%)
iast_FULL 545.073 µs [524.108 µs, 566.037 µs] 181.43 µs (49.9%)
iast_GLOBAL 504.285 µs [482.559 µs, 526.011 µs] 140.642 µs (38.7%)
iast_HARDCODED_SECRET_DISABLED 473.398 µs [452.471 µs, 494.324 µs] 109.755 µs (30.2%)
iast_INACTIVE 450.801 µs [429.497 µs, 472.105 µs] 87.158 µs (24.0%)
iast_TELEMETRY_OFF 465.001 µs [443.914 µs, 486.088 µs] 101.358 µs (27.9%)
tracing 441.197 µs [419.884 µs, 462.509 µs] 77.554 µs (21.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.902 µs [351.883 µs, 391.921 µs] -
iast 476.326 µs [455.235 µs, 497.417 µs] 104.424 µs (28.1%)
iast_FULL 542.473 µs [521.433 µs, 563.512 µs] 170.571 µs (45.9%)
iast_GLOBAL 506.265 µs [485.232 µs, 527.297 µs] 134.363 µs (36.1%)
iast_HARDCODED_SECRET_DISABLED 486.181 µs [464.341 µs, 508.022 µs] 114.279 µs (30.7%)
iast_INACTIVE 448.911 µs [427.888 µs, 469.934 µs] 77.009 µs (20.7%)
iast_TELEMETRY_OFF 470.028 µs [448.708 µs, 491.348 µs] 98.126 µs (26.4%)
tracing 441.909 µs [420.869 µs, 462.95 µs] 70.007 µs (18.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/fix-gradle-8.9-instrumentation
git_commit_date 1720763282 1720788625
git_commit_sha 63f16d7 352f20d
release_version 1.38.0-SNAPSHOT~63f16d7b20 1.38.0-SNAPSHOT~352f20da9c
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1720790762 1720790762
ci_job_id 570805173 570805173
ci_pipeline_id 39030351 39030351
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~352f20da9c, baseline=1.38.0-SNAPSHOT~63f16d7b20
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.277 s) : 15277000, 15277000
.   : milestone, 15277000,
appsec (15.197 s) : 15197000, 15197000
.   : milestone, 15197000,
iast (18.774 s) : 18774000, 18774000
.   : milestone, 18774000,
iast_GLOBAL (18.035 s) : 18035000, 18035000
.   : milestone, 18035000,
profiling (15.416 s) : 15416000, 15416000
.   : milestone, 15416000,
tracing (14.994 s) : 14994000, 14994000
.   : milestone, 14994000,
section candidate
no_agent (15.149 s) : 15149000, 15149000
.   : milestone, 15149000,
appsec (15.285 s) : 15285000, 15285000
.   : milestone, 15285000,
iast (18.561 s) : 18561000, 18561000
.   : milestone, 18561000,
iast_GLOBAL (17.665 s) : 17665000, 17665000
.   : milestone, 17665000,
profiling (15.551 s) : 15551000, 15551000
.   : milestone, 15551000,
tracing (15.261 s) : 15261000, 15261000
.   : milestone, 15261000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.277 s [15.277 s, 15.277 s] -
appsec 15.197 s [15.197 s, 15.197 s] -80.0 ms (-0.5%)
iast 18.774 s [18.774 s, 18.774 s] 3.497 s (22.9%)
iast_GLOBAL 18.035 s [18.035 s, 18.035 s] 2.758 s (18.1%)
profiling 15.416 s [15.416 s, 15.416 s] 139.0 ms (0.9%)
tracing 14.994 s [14.994 s, 14.994 s] -283.0 ms (-1.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.149 s [15.149 s, 15.149 s] -
appsec 15.285 s [15.285 s, 15.285 s] 136.0 ms (0.9%)
iast 18.561 s [18.561 s, 18.561 s] 3.412 s (22.5%)
iast_GLOBAL 17.665 s [17.665 s, 17.665 s] 2.516 s (16.6%)
profiling 15.551 s [15.551 s, 15.551 s] 402.0 ms (2.7%)
tracing 15.261 s [15.261 s, 15.261 s] 112.0 ms (0.7%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~352f20da9c, baseline=1.38.0-SNAPSHOT~63f16d7b20
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.451 ms) : 1440, 1463
.   : milestone, 1451,
appsec (2.236 ms) : 2200, 2272
.   : milestone, 2236,
iast (1.965 ms) : 1923, 2007
.   : milestone, 1965,
iast_GLOBAL (2.006 ms) : 1962, 2049
.   : milestone, 2006,
profiling (1.844 ms) : 1810, 1879
.   : milestone, 1844,
tracing (1.827 ms) : 1795, 1860
.   : milestone, 1827,
section candidate
no_agent (1.463 ms) : 1451, 1474
.   : milestone, 1463,
appsec (2.205 ms) : 2171, 2239
.   : milestone, 2205,
iast (1.973 ms) : 1931, 2015
.   : milestone, 1973,
iast_GLOBAL (2.002 ms) : 1961, 2044
.   : milestone, 2002,
profiling (1.84 ms) : 1806, 1875
.   : milestone, 1840,
tracing (1.836 ms) : 1803, 1869
.   : milestone, 1836,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.451 ms [1.44 ms, 1.463 ms] -
appsec 2.236 ms [2.2 ms, 2.272 ms] 784.588 µs (54.1%)
iast 1.965 ms [1.923 ms, 2.007 ms] 513.111 µs (35.4%)
iast_GLOBAL 2.006 ms [1.962 ms, 2.049 ms] 554.168 µs (38.2%)
profiling 1.844 ms [1.81 ms, 1.879 ms] 392.798 µs (27.1%)
tracing 1.827 ms [1.795 ms, 1.86 ms] 375.974 µs (25.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.463 ms [1.451 ms, 1.474 ms] -
appsec 2.205 ms [2.171 ms, 2.239 ms] 742.3 µs (50.8%)
iast 1.973 ms [1.931 ms, 2.015 ms] 510.607 µs (34.9%)
iast_GLOBAL 2.002 ms [1.961 ms, 2.044 ms] 539.661 µs (36.9%)
profiling 1.84 ms [1.806 ms, 1.875 ms] 377.681 µs (25.8%)
tracing 1.836 ms [1.803 ms, 1.869 ms] 373.49 µs (25.5%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit f0eec59 into master Jul 12, 2024
84 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/fix-gradle-8.9-instrumentation branch July 12, 2024 13:37
@github-actions github-actions bot added this to the 1.38.0 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@juan-fernandez juan-fernandez juan-fernandez approved these changes

@anmarchenko anmarchenko Awaiting requested review from anmarchenko anmarchenko is a code owner automatically assigned from DataDog/ci-app-libraries-java

Assignees
No one assigned
Labels
comp: ci visibility Continuous Integration Visibility type: bug
Projects
None yet
Milestone
1.38.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nikita-tkachenko-datadog @PerfectSlayer @juan-fernandez