-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add telemetry app product change message #7348
Add telemetry app product change message #7348
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 16 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~8f52cfe385, baseline=1.39.0-SNAPSHOT~23ce5ef2d1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1047672
Total [baseline] (10.338 s) : 0, 10338335
Agent [candidate] (1.055 s) : 0, 1054854
Total [candidate] (10.456 s) : 0, 10455549
section appsec
Agent [baseline] (1.169 s) : 0, 1168887
Total [baseline] (10.56 s) : 0, 10559730
Agent [candidate] (1.177 s) : 0, 1177333
Total [candidate] (10.53 s) : 0, 10529735
section iast
Agent [baseline] (1.185 s) : 0, 1184849
Total [baseline] (10.838 s) : 0, 10838126
Agent [candidate] (1.181 s) : 0, 1181376
Total [candidate] (10.851 s) : 0, 10851258
section profiling
Agent [baseline] (1.248 s) : 0, 1247721
Total [baseline] (10.58 s) : 0, 10580295
Agent [candidate] (1.249 s) : 0, 1248615
Total [candidate] (10.613 s) : 0, 10613490
gantt
title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~8f52cfe385, baseline=1.39.0-SNAPSHOT~23ce5ef2d1
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.478 ms) : 0, 668478
BytebuddyAgent [candidate] (672.833 ms) : 0, 672833
GlobalTracer [baseline] (307.069 ms) : 0, 307069
GlobalTracer [candidate] (308.923 ms) : 0, 308923
AppSec [baseline] (50.696 ms) : 0, 50696
AppSec [candidate] (51.427 ms) : 0, 51427
Remote Config [baseline] (678.482 µs) : 0, 678
Remote Config [candidate] (690.013 µs) : 0, 690
Telemetry [baseline] (7.316 ms) : 0, 7316
Telemetry [candidate] (7.44 ms) : 0, 7440
section appsec
BytebuddyAgent [baseline] (678.776 ms) : 0, 678776
BytebuddyAgent [candidate] (683.285 ms) : 0, 683285
GlobalTracer [baseline] (300.513 ms) : 0, 300513
GlobalTracer [candidate] (302.473 ms) : 0, 302473
AppSec [baseline] (156.209 ms) : 0, 156209
AppSec [candidate] (157.252 ms) : 0, 157252
Remote Config [baseline] (609.743 µs) : 0, 610
Remote Config [candidate] (605.62 µs) : 0, 606
Telemetry [baseline] (8.537 ms) : 0, 8537
Telemetry [candidate] (9.317 ms) : 0, 9317
IAST [baseline] (21.484 ms) : 0, 21484
IAST [candidate] (21.626 ms) : 0, 21626
section iast
BytebuddyAgent [baseline] (789.143 ms) : 0, 789143
BytebuddyAgent [candidate] (785.504 ms) : 0, 785504
GlobalTracer [baseline] (298.848 ms) : 0, 298848
GlobalTracer [candidate] (297.593 ms) : 0, 297593
AppSec [baseline] (53.938 ms) : 0, 53938
AppSec [candidate] (52.082 ms) : 0, 52082
Remote Config [baseline] (578.5 µs) : 0, 578
Remote Config [candidate] (588.316 µs) : 0, 588
Telemetry [baseline] (7.065 ms) : 0, 7065
Telemetry [candidate] (8.742 ms) : 0, 8742
IAST [baseline] (21.705 ms) : 0, 21705
IAST [candidate] (23.299 ms) : 0, 23299
section profiling
ProfilingAgent [baseline] (95.143 ms) : 0, 95143
ProfilingAgent [candidate] (94.627 ms) : 0, 94627
BytebuddyAgent [baseline] (664.107 ms) : 0, 664107
BytebuddyAgent [candidate] (664.751 ms) : 0, 664751
GlobalTracer [baseline] (391.374 ms) : 0, 391374
GlobalTracer [candidate] (391.44 ms) : 0, 391440
AppSec [baseline] (52.029 ms) : 0, 52029
AppSec [candidate] (52.547 ms) : 0, 52547
Remote Config [baseline] (684.61 µs) : 0, 685
Remote Config [candidate] (686.865 µs) : 0, 687
Telemetry [baseline] (7.195 ms) : 0, 7195
Telemetry [candidate] (7.386 ms) : 0, 7386
Profiling [baseline] (95.168 ms) : 0, 95168
Profiling [candidate] (94.652 ms) : 0, 94652
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~8f52cfe385, baseline=1.39.0-SNAPSHOT~23ce5ef2d1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1048678
Total [baseline] (8.506 s) : 0, 8506055
Agent [candidate] (1.048 s) : 0, 1048292
Total [candidate] (8.506 s) : 0, 8505668
section iast
Agent [baseline] (1.178 s) : 0, 1178488
Total [baseline] (9.072 s) : 0, 9072399
Agent [candidate] (1.175 s) : 0, 1175424
Total [candidate] (9.007 s) : 0, 9007111
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.186 s) : 0, 1185901
Total [baseline] (9.008 s) : 0, 9008196
Agent [candidate] (1.176 s) : 0, 1175835
Total [candidate] (8.983 s) : 0, 8983092
section iast_TELEMETRY_OFF
Agent [baseline] (1.175 s) : 0, 1174901
Total [baseline] (9.038 s) : 0, 9038153
Agent [candidate] (1.182 s) : 0, 1182294
Total [candidate] (9.069 s) : 0, 9068699
gantt
title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~8f52cfe385, baseline=1.39.0-SNAPSHOT~23ce5ef2d1
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.056 ms) : 0, 669056
BytebuddyAgent [candidate] (668.582 ms) : 0, 668582
GlobalTracer [baseline] (307.148 ms) : 0, 307148
GlobalTracer [candidate] (307.014 ms) : 0, 307014
AppSec [baseline] (50.977 ms) : 0, 50977
AppSec [candidate] (51.092 ms) : 0, 51092
Remote Config [baseline] (685.627 µs) : 0, 686
Remote Config [candidate] (681.981 µs) : 0, 682
Telemetry [baseline] (7.382 ms) : 0, 7382
Telemetry [candidate] (7.47 ms) : 0, 7470
section iast
BytebuddyAgent [baseline] (784.459 ms) : 0, 784459
BytebuddyAgent [candidate] (781.774 ms) : 0, 781774
GlobalTracer [baseline] (296.804 ms) : 0, 296804
GlobalTracer [candidate] (295.906 ms) : 0, 295906
AppSec [baseline] (52.946 ms) : 0, 52946
AppSec [candidate] (53.449 ms) : 0, 53449
Remote Config [baseline] (594.496 µs) : 0, 594
Remote Config [candidate] (592.027 µs) : 0, 592
Telemetry [baseline] (7.816 ms) : 0, 7816
Telemetry [candidate] (7.108 ms) : 0, 7108
IAST [baseline] (22.387 ms) : 0, 22387
IAST [candidate] (23.097 ms) : 0, 23097
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (789.559 ms) : 0, 789559
BytebuddyAgent [candidate] (781.407 ms) : 0, 781407
GlobalTracer [baseline] (299.277 ms) : 0, 299277
GlobalTracer [candidate] (297.032 ms) : 0, 297032
AppSec [baseline] (52.48 ms) : 0, 52480
AppSec [candidate] (51.015 ms) : 0, 51015
Remote Config [baseline] (581.251 µs) : 0, 581
Remote Config [candidate] (582.54 µs) : 0, 583
Telemetry [baseline] (7.001 ms) : 0, 7001
Telemetry [candidate] (7.922 ms) : 0, 7922
IAST [baseline] (23.413 ms) : 0, 23413
IAST [candidate] (24.304 ms) : 0, 24304
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (780.995 ms) : 0, 780995
BytebuddyAgent [candidate] (785.428 ms) : 0, 785428
GlobalTracer [baseline] (297.782 ms) : 0, 297782
GlobalTracer [candidate] (298.889 ms) : 0, 298889
AppSec [baseline] (51.198 ms) : 0, 51198
AppSec [candidate] (52.615 ms) : 0, 52615
Remote Config [baseline] (613.497 µs) : 0, 613
Remote Config [candidate] (623.635 µs) : 0, 624
Telemetry [baseline] (6.903 ms) : 0, 6903
Telemetry [candidate] (7.129 ms) : 0, 7129
IAST [baseline] (23.871 ms) : 0, 23871
IAST [candidate] (23.978 ms) : 0, 23978
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~8f52cfe385, baseline=1.39.0-SNAPSHOT~23ce5ef2d1
dateFormat X
axisFormat %s
section baseline
no_agent (1.35 ms) : 1330, 1370
. : milestone, 1350,
appsec (1.693 ms) : 1670, 1717
. : milestone, 1693,
appsec_no_iast (1.718 ms) : 1694, 1742
. : milestone, 1718,
iast (1.459 ms) : 1437, 1482
. : milestone, 1459,
profiling (1.506 ms) : 1480, 1532
. : milestone, 1506,
tracing (1.452 ms) : 1427, 1476
. : milestone, 1452,
section candidate
no_agent (1.345 ms) : 1326, 1364
. : milestone, 1345,
appsec (1.732 ms) : 1710, 1755
. : milestone, 1732,
appsec_no_iast (1.693 ms) : 1669, 1717
. : milestone, 1693,
iast (1.478 ms) : 1457, 1500
. : milestone, 1478,
profiling (1.517 ms) : 1491, 1543
. : milestone, 1517,
tracing (1.47 ms) : 1445, 1494
. : milestone, 1470,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~8f52cfe385, baseline=1.39.0-SNAPSHOT~23ce5ef2d1
dateFormat X
axisFormat %s
section baseline
no_agent (360.387 µs) : 341, 380
. : milestone, 360,
iast (476.049 µs) : 455, 497
. : milestone, 476,
iast_FULL (546.964 µs) : 526, 568
. : milestone, 547,
iast_GLOBAL (505.027 µs) : 483, 527
. : milestone, 505,
iast_HARDCODED_SECRET_DISABLED (483.21 µs) : 462, 505
. : milestone, 483,
iast_INACTIVE (445.919 µs) : 424, 467
. : milestone, 446,
iast_TELEMETRY_OFF (461.946 µs) : 441, 483
. : milestone, 462,
tracing (442.984 µs) : 422, 464
. : milestone, 443,
section candidate
no_agent (367.389 µs) : 348, 387
. : milestone, 367,
iast (473.503 µs) : 452, 495
. : milestone, 474,
iast_FULL (553.556 µs) : 532, 576
. : milestone, 554,
iast_GLOBAL (500.876 µs) : 479, 523
. : milestone, 501,
iast_HARDCODED_SECRET_DISABLED (473.706 µs) : 453, 495
. : milestone, 474,
iast_INACTIVE (450.36 µs) : 427, 473
. : milestone, 450,
iast_TELEMETRY_OFF (471.656 µs) : 450, 493
. : milestone, 472,
tracing (436.784 µs) : 416, 457
. : milestone, 437,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~8f52cfe385, baseline=1.39.0-SNAPSHOT~23ce5ef2d1
dateFormat X
axisFormat %s
section baseline
no_agent (1.465 ms) : 1454, 1477
. : milestone, 1465,
appsec (2.228 ms) : 2194, 2263
. : milestone, 2228,
iast (1.997 ms) : 1955, 2040
. : milestone, 1997,
iast_GLOBAL (2.022 ms) : 1979, 2065
. : milestone, 2022,
profiling (1.876 ms) : 1842, 1911
. : milestone, 1876,
tracing (1.852 ms) : 1818, 1885
. : milestone, 1852,
section candidate
no_agent (1.459 ms) : 1447, 1470
. : milestone, 1459,
appsec (2.223 ms) : 2188, 2258
. : milestone, 2223,
iast (1.959 ms) : 1917, 2000
. : milestone, 1959,
iast_GLOBAL (2.021 ms) : 1978, 2063
. : milestone, 2021,
profiling (2.362 ms) : 2175, 2549
. : milestone, 2362,
tracing (1.842 ms) : 1810, 1875
. : milestone, 1842,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~8f52cfe385, baseline=1.39.0-SNAPSHOT~23ce5ef2d1
dateFormat X
axisFormat %s
section baseline
no_agent (15.61 s) : 15610000, 15610000
. : milestone, 15610000,
appsec (14.993 s) : 14993000, 14993000
. : milestone, 14993000,
iast (18.996 s) : 18996000, 18996000
. : milestone, 18996000,
iast_GLOBAL (17.873 s) : 17873000, 17873000
. : milestone, 17873000,
profiling (14.866 s) : 14866000, 14866000
. : milestone, 14866000,
tracing (15.112 s) : 15112000, 15112000
. : milestone, 15112000,
section candidate
no_agent (14.866 s) : 14866000, 14866000
. : milestone, 14866000,
appsec (15.063 s) : 15063000, 15063000
. : milestone, 15063000,
iast (18.646 s) : 18646000, 18646000
. : milestone, 18646000,
iast_GLOBAL (17.878 s) : 17878000, 17878000
. : milestone, 17878000,
profiling (15.393 s) : 15393000, 15393000
. : milestone, 15393000,
tracing (14.912 s) : 14912000, 14912000
. : milestone, 14912000,
|
telemetry/src/main/java/datadog/telemetry/TelemetryRequestBody.java
Outdated
Show resolved
Hide resolved
telemetry/src/main/java/datadog/telemetry/TelemetryService.java
Outdated
Show resolved
Hide resolved
telemetry/src/test/groovy/datadog/telemetry/TelemetryServiceSpecification.groovy
Outdated
Show resolved
Hide resolved
telemetry/src/test/groovy/datadog/telemetry/TelemetryRequestBodySpecification.groovy
Outdated
Show resolved
Hide resolved
…ecification.groovy Co-authored-by: Manuel Álvarez Álvarez <[email protected]>
telemetry/src/main/java/datadog/telemetry/TelemetryService.java
Outdated
Show resolved
Hide resolved
Changing the approach to telemetry event queue instead of keep the last product state in memory |
internal-api/src/main/java/datadog/trace/api/telemetry/Product.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Needs review by language platform team too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
What Does This Do
Motivation
ASM enablement (appsec.enabled) in telemetry product action should reflect remote config changes. Digging into this we noticed that the app_product_change telemetry request type is not implemented in java
Additional Notes
Only implemented to detect appsec product changes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APPSEC-53874