Add telemetry app product change message #7348

jandro996 · 2024-07-18T18:05:57Z

What Does This Do

Add new app_product_change request type
Update request boy writeProducts method to be able to build the json making each product optional as the schema defines
Add new Product change telemetry event
Add more tests

Motivation

ASM enablement (appsec.enabled) in telemetry product action should reflect remote config changes. Digging into this we noticed that the app_product_change telemetry request type is not implemented in java

Additional Notes

Only implemented to detect appsec product changes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APPSEC-53874

pr-commenter · 2024-07-18T18:26:46Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alejandro.gonzalez/add-telemtry-app_product_change
git_commit_date	1723194941	1723222366
git_commit_sha	`23ce5ef`	`8f52cfe`
release_version	1.39.0-SNAPSHOT~23ce5ef2d1	1.39.0-SNAPSHOT~8f52cfe385

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1723224765	1723224765
ci_job_id	600500978	600500978
ci_pipeline_id	41357727	41357727
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 16 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~8f52cfe385, baseline=1.39.0-SNAPSHOT~23ce5ef2d1

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1047672
Total [baseline] (10.338 s) : 0, 10338335
Agent [candidate] (1.055 s) : 0, 1054854
Total [candidate] (10.456 s) : 0, 10455549
section appsec
Agent [baseline] (1.169 s) : 0, 1168887
Total [baseline] (10.56 s) : 0, 10559730
Agent [candidate] (1.177 s) : 0, 1177333
Total [candidate] (10.53 s) : 0, 10529735
section iast
Agent [baseline] (1.185 s) : 0, 1184849
Total [baseline] (10.838 s) : 0, 10838126
Agent [candidate] (1.181 s) : 0, 1181376
Total [candidate] (10.851 s) : 0, 10851258
section profiling
Agent [baseline] (1.248 s) : 0, 1247721
Total [baseline] (10.58 s) : 0, 10580295
Agent [candidate] (1.249 s) : 0, 1248615
Total [candidate] (10.613 s) : 0, 10613490

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.048 s	-
Agent	appsec	1.169 s	121.215 ms (11.6%)
Agent	iast	1.185 s	137.177 ms (13.1%)
Agent	profiling	1.248 s	200.048 ms (19.1%)
Total	tracing	10.338 s	-
Total	appsec	10.56 s	221.395 ms (2.1%)
Total	iast	10.838 s	499.791 ms (4.8%)
Total	profiling	10.58 s	241.96 ms (2.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.055 s	-
Agent	appsec	1.177 s	122.479 ms (11.6%)
Agent	iast	1.181 s	126.522 ms (12.0%)
Agent	profiling	1.249 s	193.761 ms (18.4%)
Total	tracing	10.456 s	-
Total	appsec	10.53 s	74.186 ms (0.7%)
Total	iast	10.851 s	395.709 ms (3.8%)
Total	profiling	10.613 s	157.94 ms (1.5%)

gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~8f52cfe385, baseline=1.39.0-SNAPSHOT~23ce5ef2d1

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.478 ms) : 0, 668478
BytebuddyAgent [candidate] (672.833 ms) : 0, 672833
GlobalTracer [baseline] (307.069 ms) : 0, 307069
GlobalTracer [candidate] (308.923 ms) : 0, 308923
AppSec [baseline] (50.696 ms) : 0, 50696
AppSec [candidate] (51.427 ms) : 0, 51427
Remote Config [baseline] (678.482 µs) : 0, 678
Remote Config [candidate] (690.013 µs) : 0, 690
Telemetry [baseline] (7.316 ms) : 0, 7316
Telemetry [candidate] (7.44 ms) : 0, 7440
section appsec
BytebuddyAgent [baseline] (678.776 ms) : 0, 678776
BytebuddyAgent [candidate] (683.285 ms) : 0, 683285
GlobalTracer [baseline] (300.513 ms) : 0, 300513
GlobalTracer [candidate] (302.473 ms) : 0, 302473
AppSec [baseline] (156.209 ms) : 0, 156209
AppSec [candidate] (157.252 ms) : 0, 157252
Remote Config [baseline] (609.743 µs) : 0, 610
Remote Config [candidate] (605.62 µs) : 0, 606
Telemetry [baseline] (8.537 ms) : 0, 8537
Telemetry [candidate] (9.317 ms) : 0, 9317
IAST [baseline] (21.484 ms) : 0, 21484
IAST [candidate] (21.626 ms) : 0, 21626
section iast
BytebuddyAgent [baseline] (789.143 ms) : 0, 789143
BytebuddyAgent [candidate] (785.504 ms) : 0, 785504
GlobalTracer [baseline] (298.848 ms) : 0, 298848
GlobalTracer [candidate] (297.593 ms) : 0, 297593
AppSec [baseline] (53.938 ms) : 0, 53938
AppSec [candidate] (52.082 ms) : 0, 52082
Remote Config [baseline] (578.5 µs) : 0, 578
Remote Config [candidate] (588.316 µs) : 0, 588
Telemetry [baseline] (7.065 ms) : 0, 7065
Telemetry [candidate] (8.742 ms) : 0, 8742
IAST [baseline] (21.705 ms) : 0, 21705
IAST [candidate] (23.299 ms) : 0, 23299
section profiling
ProfilingAgent [baseline] (95.143 ms) : 0, 95143
ProfilingAgent [candidate] (94.627 ms) : 0, 94627
BytebuddyAgent [baseline] (664.107 ms) : 0, 664107
BytebuddyAgent [candidate] (664.751 ms) : 0, 664751
GlobalTracer [baseline] (391.374 ms) : 0, 391374
GlobalTracer [candidate] (391.44 ms) : 0, 391440
AppSec [baseline] (52.029 ms) : 0, 52029
AppSec [candidate] (52.547 ms) : 0, 52547
Remote Config [baseline] (684.61 µs) : 0, 685
Remote Config [candidate] (686.865 µs) : 0, 687
Telemetry [baseline] (7.195 ms) : 0, 7195
Telemetry [candidate] (7.386 ms) : 0, 7386
Profiling [baseline] (95.168 ms) : 0, 95168
Profiling [candidate] (94.652 ms) : 0, 94652

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~8f52cfe385, baseline=1.39.0-SNAPSHOT~23ce5ef2d1

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1048678
Total [baseline] (8.506 s) : 0, 8506055
Agent [candidate] (1.048 s) : 0, 1048292
Total [candidate] (8.506 s) : 0, 8505668
section iast
Agent [baseline] (1.178 s) : 0, 1178488
Total [baseline] (9.072 s) : 0, 9072399
Agent [candidate] (1.175 s) : 0, 1175424
Total [candidate] (9.007 s) : 0, 9007111
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.186 s) : 0, 1185901
Total [baseline] (9.008 s) : 0, 9008196
Agent [candidate] (1.176 s) : 0, 1175835
Total [candidate] (8.983 s) : 0, 8983092
section iast_TELEMETRY_OFF
Agent [baseline] (1.175 s) : 0, 1174901
Total [baseline] (9.038 s) : 0, 9038153
Agent [candidate] (1.182 s) : 0, 1182294
Total [candidate] (9.069 s) : 0, 9068699

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.049 s	-
Agent	iast	1.178 s	129.81 ms (12.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.186 s	137.223 ms (13.1%)
Agent	iast_TELEMETRY_OFF	1.175 s	126.223 ms (12.0%)
Total	tracing	8.506 s	-
Total	iast	9.072 s	566.344 ms (6.7%)
Total	iast_HARDCODED_SECRET_DISABLED	9.008 s	502.14 ms (5.9%)
Total	iast_TELEMETRY_OFF	9.038 s	532.098 ms (6.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.048 s	-
Agent	iast	1.175 s	127.132 ms (12.1%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.176 s	127.542 ms (12.2%)
Agent	iast_TELEMETRY_OFF	1.182 s	134.002 ms (12.8%)
Total	tracing	8.506 s	-
Total	iast	9.007 s	501.443 ms (5.9%)
Total	iast_HARDCODED_SECRET_DISABLED	8.983 s	477.424 ms (5.6%)
Total	iast_TELEMETRY_OFF	9.069 s	563.031 ms (6.6%)

gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~8f52cfe385, baseline=1.39.0-SNAPSHOT~23ce5ef2d1

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.056 ms) : 0, 669056
BytebuddyAgent [candidate] (668.582 ms) : 0, 668582
GlobalTracer [baseline] (307.148 ms) : 0, 307148
GlobalTracer [candidate] (307.014 ms) : 0, 307014
AppSec [baseline] (50.977 ms) : 0, 50977
AppSec [candidate] (51.092 ms) : 0, 51092
Remote Config [baseline] (685.627 µs) : 0, 686
Remote Config [candidate] (681.981 µs) : 0, 682
Telemetry [baseline] (7.382 ms) : 0, 7382
Telemetry [candidate] (7.47 ms) : 0, 7470
section iast
BytebuddyAgent [baseline] (784.459 ms) : 0, 784459
BytebuddyAgent [candidate] (781.774 ms) : 0, 781774
GlobalTracer [baseline] (296.804 ms) : 0, 296804
GlobalTracer [candidate] (295.906 ms) : 0, 295906
AppSec [baseline] (52.946 ms) : 0, 52946
AppSec [candidate] (53.449 ms) : 0, 53449
Remote Config [baseline] (594.496 µs) : 0, 594
Remote Config [candidate] (592.027 µs) : 0, 592
Telemetry [baseline] (7.816 ms) : 0, 7816
Telemetry [candidate] (7.108 ms) : 0, 7108
IAST [baseline] (22.387 ms) : 0, 22387
IAST [candidate] (23.097 ms) : 0, 23097
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (789.559 ms) : 0, 789559
BytebuddyAgent [candidate] (781.407 ms) : 0, 781407
GlobalTracer [baseline] (299.277 ms) : 0, 299277
GlobalTracer [candidate] (297.032 ms) : 0, 297032
AppSec [baseline] (52.48 ms) : 0, 52480
AppSec [candidate] (51.015 ms) : 0, 51015
Remote Config [baseline] (581.251 µs) : 0, 581
Remote Config [candidate] (582.54 µs) : 0, 583
Telemetry [baseline] (7.001 ms) : 0, 7001
Telemetry [candidate] (7.922 ms) : 0, 7922
IAST [baseline] (23.413 ms) : 0, 23413
IAST [candidate] (24.304 ms) : 0, 24304
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (780.995 ms) : 0, 780995
BytebuddyAgent [candidate] (785.428 ms) : 0, 785428
GlobalTracer [baseline] (297.782 ms) : 0, 297782
GlobalTracer [candidate] (298.889 ms) : 0, 298889
AppSec [baseline] (51.198 ms) : 0, 51198
AppSec [candidate] (52.615 ms) : 0, 52615
Remote Config [baseline] (613.497 µs) : 0, 613
Remote Config [candidate] (623.635 µs) : 0, 624
Telemetry [baseline] (6.903 ms) : 0, 6903
Telemetry [candidate] (7.129 ms) : 0, 7129
IAST [baseline] (23.871 ms) : 0, 23871
IAST [candidate] (23.978 ms) : 0, 23978

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-08-09T17:03:25	2024-08-09T17:10:12
git_branch	master	alejandro.gonzalez/add-telemtry-app_product_change
git_commit_date	1723194941	1723222366
git_commit_sha	`23ce5ef`	`8f52cfe`
release_version	1.39.0-SNAPSHOT~23ce5ef2d1	1.39.0-SNAPSHOT~8f52cfe385
start_time	2024-08-09T17:03:11	2024-08-09T17:09:59

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1723223757	1723223757
ci_job_id	600500979	600500979
ci_pipeline_id	41357727	41357727
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~8f52cfe385, baseline=1.39.0-SNAPSHOT~23ce5ef2d1
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.35 ms) : 1330, 1370
.   : milestone, 1350,
appsec (1.693 ms) : 1670, 1717
.   : milestone, 1693,
appsec_no_iast (1.718 ms) : 1694, 1742
.   : milestone, 1718,
iast (1.459 ms) : 1437, 1482
.   : milestone, 1459,
profiling (1.506 ms) : 1480, 1532
.   : milestone, 1506,
tracing (1.452 ms) : 1427, 1476
.   : milestone, 1452,
section candidate
no_agent (1.345 ms) : 1326, 1364
.   : milestone, 1345,
appsec (1.732 ms) : 1710, 1755
.   : milestone, 1732,
appsec_no_iast (1.693 ms) : 1669, 1717
.   : milestone, 1693,
iast (1.478 ms) : 1457, 1500
.   : milestone, 1478,
profiling (1.517 ms) : 1491, 1543
.   : milestone, 1517,
tracing (1.47 ms) : 1445, 1494
.   : milestone, 1470,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.35 ms [1.33 ms, 1.37 ms]	-
appsec	1.693 ms [1.67 ms, 1.717 ms]	343.22 µs (25.4%)
appsec_no_iast	1.718 ms [1.694 ms, 1.742 ms]	368.187 µs (27.3%)
iast	1.459 ms [1.437 ms, 1.482 ms]	109.003 µs (8.1%)
profiling	1.506 ms [1.48 ms, 1.532 ms]	156.047 µs (11.6%)
tracing	1.452 ms [1.427 ms, 1.476 ms]	101.575 µs (7.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.345 ms [1.326 ms, 1.364 ms]	-
appsec	1.732 ms [1.71 ms, 1.755 ms]	387.379 µs (28.8%)
appsec_no_iast	1.693 ms [1.669 ms, 1.717 ms]	348.26 µs (25.9%)
iast	1.478 ms [1.457 ms, 1.5 ms]	133.604 µs (9.9%)
profiling	1.517 ms [1.491 ms, 1.543 ms]	172.18 µs (12.8%)
tracing	1.47 ms [1.445 ms, 1.494 ms]	124.836 µs (9.3%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~8f52cfe385, baseline=1.39.0-SNAPSHOT~23ce5ef2d1
    dateFormat X
    axisFormat %s
section baseline
no_agent (360.387 µs) : 341, 380
.   : milestone, 360,
iast (476.049 µs) : 455, 497
.   : milestone, 476,
iast_FULL (546.964 µs) : 526, 568
.   : milestone, 547,
iast_GLOBAL (505.027 µs) : 483, 527
.   : milestone, 505,
iast_HARDCODED_SECRET_DISABLED (483.21 µs) : 462, 505
.   : milestone, 483,
iast_INACTIVE (445.919 µs) : 424, 467
.   : milestone, 446,
iast_TELEMETRY_OFF (461.946 µs) : 441, 483
.   : milestone, 462,
tracing (442.984 µs) : 422, 464
.   : milestone, 443,
section candidate
no_agent (367.389 µs) : 348, 387
.   : milestone, 367,
iast (473.503 µs) : 452, 495
.   : milestone, 474,
iast_FULL (553.556 µs) : 532, 576
.   : milestone, 554,
iast_GLOBAL (500.876 µs) : 479, 523
.   : milestone, 501,
iast_HARDCODED_SECRET_DISABLED (473.706 µs) : 453, 495
.   : milestone, 474,
iast_INACTIVE (450.36 µs) : 427, 473
.   : milestone, 450,
iast_TELEMETRY_OFF (471.656 µs) : 450, 493
.   : milestone, 472,
tracing (436.784 µs) : 416, 457
.   : milestone, 437,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	360.387 µs [340.641 µs, 380.133 µs]	-
iast	476.049 µs [454.677 µs, 497.421 µs]	115.662 µs (32.1%)
iast_FULL	546.964 µs [525.888 µs, 568.039 µs]	186.577 µs (51.8%)
iast_GLOBAL	505.027 µs [483.005 µs, 527.048 µs]	144.64 µs (40.1%)
iast_HARDCODED_SECRET_DISABLED	483.21 µs [461.611 µs, 504.81 µs]	122.823 µs (34.1%)
iast_INACTIVE	445.919 µs [424.347 µs, 467.49 µs]	85.531 µs (23.7%)
iast_TELEMETRY_OFF	461.946 µs [440.955 µs, 482.936 µs]	101.558 µs (28.2%)
tracing	442.984 µs [422.089 µs, 463.879 µs]	82.597 µs (22.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	367.389 µs [347.967 µs, 386.811 µs]	-
iast	473.503 µs [452.275 µs, 494.731 µs]	106.114 µs (28.9%)
iast_FULL	553.556 µs [531.505 µs, 575.608 µs]	186.167 µs (50.7%)
iast_GLOBAL	500.876 µs [478.574 µs, 523.177 µs]	133.486 µs (36.3%)
iast_HARDCODED_SECRET_DISABLED	473.706 µs [452.663 µs, 494.749 µs]	106.317 µs (28.9%)
iast_INACTIVE	450.36 µs [427.474 µs, 473.247 µs]	82.971 µs (22.6%)
iast_TELEMETRY_OFF	471.656 µs [449.904 µs, 493.408 µs]	104.267 µs (28.4%)
tracing	436.784 µs [416.435 µs, 457.133 µs]	69.394 µs (18.9%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alejandro.gonzalez/add-telemtry-app_product_change
git_commit_date	1723194941	1723222366
git_commit_sha	`23ce5ef`	`8f52cfe`
release_version	1.39.0-SNAPSHOT~23ce5ef2d1	1.39.0-SNAPSHOT~8f52cfe385

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1723224260	1723224260
ci_job_id	600500980	600500980
ci_pipeline_id	41357727	41357727
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~8f52cfe385, baseline=1.39.0-SNAPSHOT~23ce5ef2d1
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.465 ms) : 1454, 1477
.   : milestone, 1465,
appsec (2.228 ms) : 2194, 2263
.   : milestone, 2228,
iast (1.997 ms) : 1955, 2040
.   : milestone, 1997,
iast_GLOBAL (2.022 ms) : 1979, 2065
.   : milestone, 2022,
profiling (1.876 ms) : 1842, 1911
.   : milestone, 1876,
tracing (1.852 ms) : 1818, 1885
.   : milestone, 1852,
section candidate
no_agent (1.459 ms) : 1447, 1470
.   : milestone, 1459,
appsec (2.223 ms) : 2188, 2258
.   : milestone, 2223,
iast (1.959 ms) : 1917, 2000
.   : milestone, 1959,
iast_GLOBAL (2.021 ms) : 1978, 2063
.   : milestone, 2021,
profiling (2.362 ms) : 2175, 2549
.   : milestone, 2362,
tracing (1.842 ms) : 1810, 1875
.   : milestone, 1842,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.465 ms [1.454 ms, 1.477 ms]	-
appsec	2.228 ms [2.194 ms, 2.263 ms]	763.361 µs (52.1%)
iast	1.997 ms [1.955 ms, 2.04 ms]	532.256 µs (36.3%)
iast_GLOBAL	2.022 ms [1.979 ms, 2.065 ms]	556.811 µs (38.0%)
profiling	1.876 ms [1.842 ms, 1.911 ms]	411.059 µs (28.1%)
tracing	1.852 ms [1.818 ms, 1.885 ms]	386.544 µs (26.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.459 ms [1.447 ms, 1.47 ms]	-
appsec	2.223 ms [2.188 ms, 2.258 ms]	764.286 µs (52.4%)
iast	1.959 ms [1.917 ms, 2.0 ms]	499.972 µs (34.3%)
iast_GLOBAL	2.021 ms [1.978 ms, 2.063 ms]	561.911 µs (38.5%)
profiling	2.362 ms [2.175 ms, 2.549 ms]	903.072 µs (61.9%)
tracing	1.842 ms [1.81 ms, 1.875 ms]	383.335 µs (26.3%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~8f52cfe385, baseline=1.39.0-SNAPSHOT~23ce5ef2d1
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.61 s) : 15610000, 15610000
.   : milestone, 15610000,
appsec (14.993 s) : 14993000, 14993000
.   : milestone, 14993000,
iast (18.996 s) : 18996000, 18996000
.   : milestone, 18996000,
iast_GLOBAL (17.873 s) : 17873000, 17873000
.   : milestone, 17873000,
profiling (14.866 s) : 14866000, 14866000
.   : milestone, 14866000,
tracing (15.112 s) : 15112000, 15112000
.   : milestone, 15112000,
section candidate
no_agent (14.866 s) : 14866000, 14866000
.   : milestone, 14866000,
appsec (15.063 s) : 15063000, 15063000
.   : milestone, 15063000,
iast (18.646 s) : 18646000, 18646000
.   : milestone, 18646000,
iast_GLOBAL (17.878 s) : 17878000, 17878000
.   : milestone, 17878000,
profiling (15.393 s) : 15393000, 15393000
.   : milestone, 15393000,
tracing (14.912 s) : 14912000, 14912000
.   : milestone, 14912000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.61 s [15.61 s, 15.61 s]	-
appsec	14.993 s [14.993 s, 14.993 s]	-617.0 ms (-4.0%)
iast	18.996 s [18.996 s, 18.996 s]	3.386 s (21.7%)
iast_GLOBAL	17.873 s [17.873 s, 17.873 s]	2.263 s (14.5%)
profiling	14.866 s [14.866 s, 14.866 s]	-744.0 ms (-4.8%)
tracing	15.112 s [15.112 s, 15.112 s]	-498.0 ms (-3.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.866 s [14.866 s, 14.866 s]	-
appsec	15.063 s [15.063 s, 15.063 s]	197.0 ms (1.3%)
iast	18.646 s [18.646 s, 18.646 s]	3.78 s (25.4%)
iast_GLOBAL	17.878 s [17.878 s, 17.878 s]	3.012 s (20.3%)
profiling	15.393 s [15.393 s, 15.393 s]	527.0 ms (3.5%)
tracing	14.912 s [14.912 s, 14.912 s]	46.0 ms (0.3%)

telemetry/src/main/java/datadog/telemetry/TelemetryRequestBody.java

telemetry/src/main/java/datadog/telemetry/TelemetryService.java

…t_change

telemetry/src/test/groovy/datadog/telemetry/TelemetryServiceSpecification.groovy

telemetry/src/test/groovy/datadog/telemetry/TelemetryRequestBodySpecification.groovy

…ecification.groovy Co-authored-by: Manuel Álvarez Álvarez <[email protected]>

telemetry/src/main/java/datadog/telemetry/TelemetryService.java

jandro996 · 2024-07-25T10:55:43Z

Changing the approach to telemetry event queue instead of keep the last product state in memory

…t_change

internal-api/src/main/java/datadog/trace/api/telemetry/Product.java

…t_change

smola

Looks good. Needs review by language platform team too.

PerfectSlayer

Looks good 👍

…t_change

jandro996 added 3 commits July 18, 2024 08:13

Add new app_product_change message, needs more testing

e9a377d

fix writeChangedProducts shortcircuit

53a45fb

refactor and testing

6f2c487

jandro996 added the comp: telemetry Telemetry label Jul 18, 2024

jandro996 requested review from smola and manuel-alvarez-alvarez July 18, 2024 18:08

manuel-alvarez-alvarez reviewed Jul 23, 2024

View reviewed changes

telemetry/src/main/java/datadog/telemetry/TelemetryRequestBody.java Outdated Show resolved Hide resolved

manuel-alvarez-alvarez reviewed Jul 23, 2024

View reviewed changes

telemetry/src/main/java/datadog/telemetry/TelemetryService.java Outdated Show resolved Hide resolved

jandro996 added 5 commits July 24, 2024 12:36

change Pair for Map and fix product update source

8f4a06a

fix imports

3c43f5b

move products enum

6014d1e

Merge branch 'master' into alejandro.gonzalez/add-telemtry-app_produc…

0f866ec

…t_change

fix request body

a811822

jandro996 requested a review from manuel-alvarez-alvarez July 24, 2024 12:42

jandro996 marked this pull request as ready for review July 25, 2024 10:24

jandro996 requested a review from a team as a code owner July 25, 2024 10:24

jandro996 requested review from dougqh and PerfectSlayer July 25, 2024 10:24

manuel-alvarez-alvarez reviewed Jul 25, 2024

View reviewed changes

telemetry/src/test/groovy/datadog/telemetry/TelemetryServiceSpecification.groovy Outdated Show resolved Hide resolved

manuel-alvarez-alvarez reviewed Jul 25, 2024

View reviewed changes

telemetry/src/test/groovy/datadog/telemetry/TelemetryRequestBodySpecification.groovy Outdated Show resolved Hide resolved

Update telemetry/src/test/groovy/datadog/telemetry/TelemetryServiceSp…

bece84e

…ecification.groovy Co-authored-by: Manuel Álvarez Álvarez <[email protected]>

manuel-alvarez-alvarez reviewed Jul 25, 2024

View reviewed changes

telemetry/src/main/java/datadog/telemetry/TelemetryService.java Outdated Show resolved Hide resolved

jandro996 marked this pull request as draft July 25, 2024 10:53

improve test writeProducts

4abeee4

PerfectSlayer added the type: enhancement label Jul 25, 2024

jandro996 added 3 commits July 26, 2024 15:29

change approach to get product changes from a queue of events

8216994

fix codenarc

1683d4b

fix test

959c058

jandro996 added 3 commits July 29, 2024 10:15

remove * import

f97969b

use enum map

86cebff

Merge branch 'master' into alejandro.gonzalez/add-telemtry-app_produc…

c38f92a

…t_change

jandro996 requested a review from manuel-alvarez-alvarez July 30, 2024 08:23

manuel-alvarez-alvarez reviewed Jul 30, 2024

View reviewed changes

internal-api/src/main/java/datadog/trace/api/telemetry/Product.java Outdated Show resolved Hide resolved

jandro996 added 4 commits July 30, 2024 13:14

Rename Product to ProductChange and add some logs

2b41ac0

Add test to fix jacoco

8525ef1

Add test to fix jacoco

341cac1

Merge branch 'master' into alejandro.gonzalez/add-telemtry-app_produc…

2be32f3

…t_change

jandro996 marked this pull request as ready for review July 31, 2024 08:16

jandro996 requested a review from a team as a code owner July 31, 2024 08:16

jandro996 requested a review from manuel-alvarez-alvarez July 31, 2024 08:16

smola approved these changes Aug 6, 2024

View reviewed changes

PerfectSlayer approved these changes Aug 7, 2024

View reviewed changes

jandro996 added 3 commits August 7, 2024 17:28

Merge branch 'master' into alejandro.gonzalez/add-telemtry-app_produc…

fb500fe

…t_change

fix request type

dc2f482

Merge branch 'master' into alejandro.gonzalez/add-telemtry-app_produc…

8f52cfe

…t_change

jandro996 merged commit 67ad13b into master Aug 9, 2024
80 checks passed

jandro996 deleted the alejandro.gonzalez/add-telemtry-app_product_change branch August 9, 2024 18:56

github-actions bot added this to the 1.39.0 milestone Aug 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add telemetry app product change message #7348

Add telemetry app product change message #7348

jandro996 commented Jul 18, 2024 •

edited

Loading

pr-commenter bot commented Jul 18, 2024 •

edited

Loading

jandro996 commented Jul 25, 2024

smola left a comment

PerfectSlayer left a comment

Add telemetry app product change message #7348

Add telemetry app product change message #7348

Conversation

jandro996 commented Jul 18, 2024 • edited Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Jul 18, 2024 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

jandro996 commented Jul 25, 2024

smola left a comment

Choose a reason for hiding this comment

PerfectSlayer left a comment

Choose a reason for hiding this comment

jandro996 commented Jul 18, 2024 •

edited

Loading

pr-commenter bot commented Jul 18, 2024 •

edited

Loading