Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor appsec GatewayBridge #7358

Merged
merged 6 commits into from
Aug 1, 2024
Merged

Refactor appsec GatewayBridge #7358

merged 6 commits into from
Aug 1, 2024

Conversation

jandro996
Copy link
Member

What Does This Do

GatewayBridge modularisation

Motivation

The GatewayBridge class is starting to contain a lot of functionality that could be modularised.

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@pr-commenter
Copy link

pr-commenter bot commented Jul 25, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alejandro.gonzalez/gateway-bridge-refactor
git_commit_date 1722432590 1722490503
git_commit_sha 3700064 47522c6
release_version 1.38.0-SNAPSHOT~3700064c3e 1.38.0-SNAPSHOT~47522c6df5
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1722493677 1722493677
ci_job_id 591329611 591329611
ci_pipeline_id 40648149 40648149
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 3 performance regressions! Performance is the same for 47 metrics, 13 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:iast:Remote Config worse
[+14.614µs; +80.557µs] or [+2.021%; +11.141%]		 770.664µs 723.079µs
scenario:startup:petclinic:profiling:ProfilingAgent worse
[+3.202ms; +8.801ms] or [+2.188%; +6.014%]		 152.333ms 146.332ms
scenario:startup:petclinic:profiling:Profiling worse
[+3.198ms; +8.811ms] or [+2.184%; +6.018%]		 152.406ms 146.402ms
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.38.0-SNAPSHOT~47522c6df5, baseline=1.38.0-SNAPSHOT~3700064c3e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.556 s) : 0, 1556075
Total [baseline] (11.844 s) : 0, 11844052
Agent [candidate] (1.556 s) : 0, 1556168
Total [candidate] (11.832 s) : 0, 11832173
section iast
Agent [baseline] (1.717 s) : 0, 1716993
Total [baseline] (12.476 s) : 0, 12475958
Agent [candidate] (1.716 s) : 0, 1715866
Total [candidate] (12.483 s) : 0, 12482554
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.716 s) : 0, 1716151
Total [baseline] (12.421 s) : 0, 12420976
Agent [candidate] (1.726 s) : 0, 1725865
Total [candidate] (12.444 s) : 0, 12443605
section iast_TELEMETRY_OFF
Agent [baseline] (1.724 s) : 0, 1723554
Total [baseline] (12.483 s) : 0, 12482514
Agent [candidate] (1.714 s) : 0, 1713954
Total [candidate] (12.492 s) : 0, 12492344
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.556 s -
Agent iast 1.717 s 160.918 ms (10.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.716 s 160.076 ms (10.3%)
Agent iast_TELEMETRY_OFF 1.724 s 167.479 ms (10.8%)
Total tracing 11.844 s -
Total iast 12.476 s 631.906 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 12.421 s 576.923 ms (4.9%)
Total iast_TELEMETRY_OFF 12.483 s 638.462 ms (5.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.556 s -
Agent iast 1.716 s 159.698 ms (10.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.726 s 169.697 ms (10.9%)
Agent iast_TELEMETRY_OFF 1.714 s 157.786 ms (10.1%)
Total tracing 11.832 s -
Total iast 12.483 s 650.381 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 12.444 s 611.432 ms (5.2%)
Total iast_TELEMETRY_OFF 12.492 s 660.17 ms (5.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.38.0-SNAPSHOT~47522c6df5, baseline=1.38.0-SNAPSHOT~3700064c3e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (998.928 ms) : 0, 998928
BytebuddyAgent [candidate] (999.125 ms) : 0, 999125
GlobalTracer [baseline] (454.896 ms) : 0, 454896
GlobalTracer [candidate] (454.712 ms) : 0, 454712
AppSec [baseline] (71.304 ms) : 0, 71304
AppSec [candidate] (71.643 ms) : 0, 71643
Remote Config [baseline] (826.992 µs) : 0, 827
Remote Config [candidate] (856.412 µs) : 0, 856
Telemetry [baseline] (10.024 ms) : 0, 10024
Telemetry [candidate] (9.664 ms) : 0, 9664
section iast
BytebuddyAgent [baseline] (1.15 s) : 0, 1150262
BytebuddyAgent [candidate] (1.152 s) : 0, 1152420
GlobalTracer [baseline] (434.091 ms) : 0, 434091
GlobalTracer [candidate] (434.065 ms) : 0, 434065
AppSec [baseline] (73.884 ms) : 0, 73884
AppSec [candidate] (69.873 ms) : 0, 69873
IAST [baseline] (28.932 ms) : 0, 28932
IAST [candidate] (28.591 ms) : 0, 28591
Remote Config [baseline] (723.079 µs) : 0, 723
Remote Config [candidate] (770.664 µs) : 0, 771
Telemetry [baseline] (9.129 ms) : 0, 9129
Telemetry [candidate] (10.087 ms) : 0, 10087
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (1.15 s) : 0, 1150239
BytebuddyAgent [candidate] (1.157 s) : 0, 1157436
GlobalTracer [baseline] (434.441 ms) : 0, 434441
GlobalTracer [candidate] (436.6 ms) : 0, 436600
AppSec [baseline] (71.26 ms) : 0, 71260
AppSec [candidate] (69.287 ms) : 0, 69287
IAST [baseline] (30.187 ms) : 0, 30187
IAST [candidate] (30.316 ms) : 0, 30316
Remote Config [baseline] (731.569 µs) : 0, 732
Remote Config [candidate] (758.397 µs) : 0, 758
Telemetry [baseline] (9.18 ms) : 0, 9180
Telemetry [candidate] (11.207 ms) : 0, 11207
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (1.159 s) : 0, 1158689
BytebuddyAgent [candidate] (1.149 s) : 0, 1148994
GlobalTracer [baseline] (435.238 ms) : 0, 435238
GlobalTracer [candidate] (434.919 ms) : 0, 434919
AppSec [baseline] (66.97 ms) : 0, 66970
AppSec [candidate] (66.73 ms) : 0, 66730
IAST [baseline] (32.862 ms) : 0, 32862
IAST [candidate] (33.367 ms) : 0, 33367
Remote Config [baseline] (707.269 µs) : 0, 707
Remote Config [candidate] (802.091 µs) : 0, 802
Telemetry [baseline] (8.877 ms) : 0, 8877
Telemetry [candidate] (9.036 ms) : 0, 9036
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.38.0-SNAPSHOT~47522c6df5, baseline=1.38.0-SNAPSHOT~3700064c3e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.55 s) : 0, 1550401
Total [baseline] (14.247 s) : 0, 14247203
Agent [candidate] (1.55 s) : 0, 1549741
Total [candidate] (14.269 s) : 0, 14268738
section appsec
Agent [baseline] (1.729 s) : 0, 1728862
Total [baseline] (14.36 s) : 0, 14359731
Agent [candidate] (1.732 s) : 0, 1732171
Total [candidate] (14.366 s) : 0, 14366311
section iast
Agent [baseline] (1.714 s) : 0, 1713536
Total [baseline] (14.769 s) : 0, 14769286
Agent [candidate] (1.722 s) : 0, 1722354
Total [candidate] (14.864 s) : 0, 14864403
section profiling
Agent [baseline] (1.852 s) : 0, 1851656
Total [baseline] (14.738 s) : 0, 14738181
Agent [candidate] (1.863 s) : 0, 1863397
Total [candidate] (14.657 s) : 0, 14656989
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.55 s -
Agent appsec 1.729 s 178.461 ms (11.5%)
Agent iast 1.714 s 163.135 ms (10.5%)
Agent profiling 1.852 s 301.254 ms (19.4%)
Total tracing 14.247 s -
Total appsec 14.36 s 112.528 ms (0.8%)
Total iast 14.769 s 522.083 ms (3.7%)
Total profiling 14.738 s 490.978 ms (3.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.55 s -
Agent appsec 1.732 s 182.43 ms (11.8%)
Agent iast 1.722 s 172.613 ms (11.1%)
Agent profiling 1.863 s 313.656 ms (20.2%)
Total tracing 14.269 s -
Total appsec 14.366 s 97.573 ms (0.7%)
Total iast 14.864 s 595.665 ms (4.2%)
Total profiling 14.657 s 388.251 ms (2.7%) 
gantt
    title petclinic - break down per module: candidate=1.38.0-SNAPSHOT~47522c6df5, baseline=1.38.0-SNAPSHOT~3700064c3e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (995.009 ms) : 0, 995009
BytebuddyAgent [candidate] (994.131 ms) : 0, 994131
GlobalTracer [baseline] (453.624 ms) : 0, 453624
GlobalTracer [candidate] (453.615 ms) : 0, 453615
AppSec [baseline] (70.933 ms) : 0, 70933
AppSec [candidate] (71.435 ms) : 0, 71435
Remote Config [baseline] (878.309 µs) : 0, 878
Remote Config [candidate] (854.698 µs) : 0, 855
Telemetry [baseline] (9.866 ms) : 0, 9866
Telemetry [candidate] (9.601 ms) : 0, 9601
section appsec
BytebuddyAgent [baseline] (1.008 s) : 0, 1007824
BytebuddyAgent [candidate] (1.009 s) : 0, 1009275
GlobalTracer [baseline] (445.412 ms) : 0, 445412
GlobalTracer [candidate] (445.746 ms) : 0, 445746
AppSec [baseline] (232.886 ms) : 0, 232886
AppSec [candidate] (232.074 ms) : 0, 232074
IAST [baseline] (25.733 ms) : 0, 25733
IAST [candidate] (24.763 ms) : 0, 24763
Remote Config [baseline] (785.065 µs) : 0, 785
Remote Config [candidate] (759.711 µs) : 0, 760
Telemetry [baseline] (9.047 ms) : 0, 9047
Telemetry [candidate] (11.829 ms) : 0, 11829
section iast
BytebuddyAgent [baseline] (1.151 s) : 0, 1150674
BytebuddyAgent [candidate] (1.157 s) : 0, 1157065
GlobalTracer [baseline] (433.432 ms) : 0, 433432
GlobalTracer [candidate] (435.105 ms) : 0, 435105
AppSec [baseline] (66.876 ms) : 0, 66876
AppSec [candidate] (68.208 ms) : 0, 68208
IAST [baseline] (31.686 ms) : 0, 31686
IAST [candidate] (30.223 ms) : 0, 30223
Remote Config [baseline] (736.454 µs) : 0, 736
Remote Config [candidate] (732.776 µs) : 0, 733
Telemetry [baseline] (10.09 ms) : 0, 10090
Telemetry [candidate] (10.832 ms) : 0, 10832
section profiling
BytebuddyAgent [baseline] (985.377 ms) : 0, 985377
BytebuddyAgent [candidate] (988.056 ms) : 0, 988056
GlobalTracer [baseline] (582.782 ms) : 0, 582782
GlobalTracer [candidate] (585.222 ms) : 0, 585222
AppSec [baseline] (72.183 ms) : 0, 72183
AppSec [candidate] (72.559 ms) : 0, 72559
Remote Config [baseline] (881.855 µs) : 0, 882
Remote Config [candidate] (915.948 µs) : 0, 916
Telemetry [baseline] (9.365 ms) : 0, 9365
Telemetry [candidate] (9.312 ms) : 0, 9312
ProfilingAgent [baseline] (146.332 ms) : 0, 146332
ProfilingAgent [candidate] (152.333 ms) : 0, 152333
Profiling [baseline] (146.402 ms) : 0, 146402
Profiling [candidate] (152.406 ms) : 0, 152406
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-01T05:47:33 2024-08-01T05:56:33
git_branch master alejandro.gonzalez/gateway-bridge-refactor
git_commit_date 1722432590 1722490503
git_commit_sha 3700064 47522c6
release_version 1.38.0-SNAPSHOT~3700064c3e 1.38.0-SNAPSHOT~47522c6df5
start_time 2024-08-01T05:47:17 2024-08-01T05:56:17
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1722492250 1722492250
ci_job_id 591329612 591329612
ci_pipeline_id 40648149 40648149
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 metrics, 22 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~47522c6df5, baseline=1.38.0-SNAPSHOT~3700064c3e
    dateFormat X
    axisFormat %s
section baseline
no_agent (458.377 µs) : 429, 488
.   : milestone, 458,
iast (582.679 µs) : 551, 614
.   : milestone, 583,
iast_FULL (683.736 µs) : 652, 716
.   : milestone, 684,
iast_GLOBAL (617.83 µs) : 585, 650
.   : milestone, 618,
iast_HARDCODED_SECRET_DISABLED (584.075 µs) : 552, 616
.   : milestone, 584,
iast_INACTIVE (552.17 µs) : 520, 584
.   : milestone, 552,
iast_TELEMETRY_OFF (570.23 µs) : 538, 603
.   : milestone, 570,
tracing (534.462 µs) : 505, 564
.   : milestone, 534,
section candidate
no_agent (448.848 µs) : 420, 478
.   : milestone, 449,
iast (591.036 µs) : 560, 622
.   : milestone, 591,
iast_FULL (675.988 µs) : 644, 708
.   : milestone, 676,
iast_GLOBAL (622.151 µs) : 590, 654
.   : milestone, 622,
iast_HARDCODED_SECRET_DISABLED (582.689 µs) : 551, 615
.   : milestone, 583,
iast_INACTIVE (547.362 µs) : 515, 579
.   : milestone, 547,
iast_TELEMETRY_OFF (566.746 µs) : 535, 599
.   : milestone, 567,
tracing (540.629 µs) : 511, 571
.   : milestone, 541,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 458.377 µs [428.64 µs, 488.114 µs] -
iast 582.679 µs [551.012 µs, 614.346 µs] 124.302 µs (27.1%)
iast_FULL 683.736 µs [651.679 µs, 715.792 µs] 225.359 µs (49.2%)
iast_GLOBAL 617.83 µs [585.385 µs, 650.276 µs] 159.453 µs (34.8%)
iast_HARDCODED_SECRET_DISABLED 584.075 µs [552.191 µs, 615.958 µs] 125.698 µs (27.4%)
iast_INACTIVE 552.17 µs [519.859 µs, 584.481 µs] 93.793 µs (20.5%)
iast_TELEMETRY_OFF 570.23 µs [537.91 µs, 602.55 µs] 111.853 µs (24.4%)
tracing 534.462 µs [504.677 µs, 564.247 µs] 76.085 µs (16.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 448.848 µs [420.186 µs, 477.509 µs] -
iast 591.036 µs [560.072 µs, 622.0 µs] 142.189 µs (31.7%)
iast_FULL 675.988 µs [643.767 µs, 708.209 µs] 227.14 µs (50.6%)
iast_GLOBAL 622.151 µs [590.393 µs, 653.908 µs] 173.303 µs (38.6%)
iast_HARDCODED_SECRET_DISABLED 582.689 µs [550.856 µs, 614.522 µs] 133.842 µs (29.8%)
iast_INACTIVE 547.362 µs [515.315 µs, 579.41 µs] 98.515 µs (21.9%)
iast_TELEMETRY_OFF 566.746 µs [534.839 µs, 598.652 µs] 117.898 µs (26.3%)
tracing 540.629 µs [510.636 µs, 570.623 µs] 91.782 µs (20.4%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~47522c6df5, baseline=1.38.0-SNAPSHOT~3700064c3e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.693 ms) : 1668, 1718
.   : milestone, 1693,
appsec (2.183 ms) : 2151, 2215
.   : milestone, 2183,
appsec_no_iast (2.15 ms) : 2119, 2182
.   : milestone, 2150,
iast (1.877 ms) : 1847, 1906
.   : milestone, 1877,
profiling (1.982 ms) : 1945, 2018
.   : milestone, 1982,
tracing (1.861 ms) : 1829, 1893
.   : milestone, 1861,
section candidate
no_agent (1.695 ms) : 1670, 1720
.   : milestone, 1695,
appsec (2.177 ms) : 2144, 2211
.   : milestone, 2177,
appsec_no_iast (2.204 ms) : 2172, 2236
.   : milestone, 2204,
iast (1.847 ms) : 1818, 1877
.   : milestone, 1847,
profiling (1.969 ms) : 1934, 2004
.   : milestone, 1969,
tracing (1.864 ms) : 1833, 1895
.   : milestone, 1864,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.693 ms [1.668 ms, 1.718 ms] -
appsec 2.183 ms [2.151 ms, 2.215 ms] 490.317 µs (29.0%)
appsec_no_iast 2.15 ms [2.119 ms, 2.182 ms] 457.719 µs (27.0%)
iast 1.877 ms [1.847 ms, 1.906 ms] 183.8 µs (10.9%)
profiling 1.982 ms [1.945 ms, 2.018 ms] 288.814 µs (17.1%)
tracing 1.861 ms [1.829 ms, 1.893 ms] 168.429 µs (10.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.695 ms [1.67 ms, 1.72 ms] -
appsec 2.177 ms [2.144 ms, 2.211 ms] 482.537 µs (28.5%)
appsec_no_iast 2.204 ms [2.172 ms, 2.236 ms] 509.355 µs (30.1%)
iast 1.847 ms [1.818 ms, 1.877 ms] 152.41 µs (9.0%)
profiling 1.969 ms [1.934 ms, 2.004 ms] 274.332 µs (16.2%)
tracing 1.864 ms [1.833 ms, 1.895 ms] 169.207 µs (10.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alejandro.gonzalez/gateway-bridge-refactor
git_commit_date 1722432590 1722490503
git_commit_sha 3700064 47522c6
release_version 1.38.0-SNAPSHOT~3700064c3e 1.38.0-SNAPSHOT~47522c6df5
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1722493051 1722493051
ci_job_id 591329613 591329613
ci_pipeline_id 40648149 40648149
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~47522c6df5, baseline=1.38.0-SNAPSHOT~3700064c3e
    dateFormat X
    axisFormat %s
section baseline
no_agent (21.085 s) : 21085000, 21085000
.   : milestone, 21085000,
appsec (21.521 s) : 21521000, 21521000
.   : milestone, 21521000,
iast (24.767 s) : 24767000, 24767000
.   : milestone, 24767000,
iast_GLOBAL (24.935 s) : 24935000, 24935000
.   : milestone, 24935000,
profiling (21.033 s) : 21033000, 21033000
.   : milestone, 21033000,
tracing (21.196 s) : 21196000, 21196000
.   : milestone, 21196000,
section candidate
no_agent (20.395 s) : 20395000, 20395000
.   : milestone, 20395000,
appsec (20.752 s) : 20752000, 20752000
.   : milestone, 20752000,
iast (24.132 s) : 24132000, 24132000
.   : milestone, 24132000,
iast_GLOBAL (25.071 s) : 25071000, 25071000
.   : milestone, 25071000,
profiling (21.254 s) : 21254000, 21254000
.   : milestone, 21254000,
tracing (20.373 s) : 20373000, 20373000
.   : milestone, 20373000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 21.085 s [21.085 s, 21.085 s] -
appsec 21.521 s [21.521 s, 21.521 s] 436.0 ms (2.1%)
iast 24.767 s [24.767 s, 24.767 s] 3.682 s (17.5%)
iast_GLOBAL 24.935 s [24.935 s, 24.935 s] 3.85 s (18.3%)
profiling 21.033 s [21.033 s, 21.033 s] -52.0 ms (-0.2%)
tracing 21.196 s [21.196 s, 21.196 s] 111.0 ms (0.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 20.395 s [20.395 s, 20.395 s] -
appsec 20.752 s [20.752 s, 20.752 s] 357.0 ms (1.8%)
iast 24.132 s [24.132 s, 24.132 s] 3.737 s (18.3%)
iast_GLOBAL 25.071 s [25.071 s, 25.071 s] 4.676 s (22.9%)
profiling 21.254 s [21.254 s, 21.254 s] 859.0 ms (4.2%)
tracing 20.373 s [20.373 s, 20.373 s] -22.0 ms (-0.1%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~47522c6df5, baseline=1.38.0-SNAPSHOT~3700064c3e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.545 ms) : 1533, 1558
.   : milestone, 1545,
appsec (2.696 ms) : 2634, 2759
.   : milestone, 2696,
iast (2.356 ms) : 2283, 2428
.   : milestone, 2356,
iast_GLOBAL (2.402 ms) : 2328, 2476
.   : milestone, 2402,
profiling (2.226 ms) : 2163, 2288
.   : milestone, 2226,
tracing (2.186 ms) : 2126, 2246
.   : milestone, 2186,
section candidate
no_agent (1.537 ms) : 1524, 1549
.   : milestone, 1537,
appsec (2.721 ms) : 2659, 2783
.   : milestone, 2721,
iast (2.338 ms) : 2267, 2410
.   : milestone, 2338,
iast_GLOBAL (2.417 ms) : 2342, 2492
.   : milestone, 2417,
profiling (2.925 ms) : 2656, 3193
.   : milestone, 2925,
tracing (2.192 ms) : 2132, 2253
.   : milestone, 2192,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.545 ms [1.533 ms, 1.558 ms] -
appsec 2.696 ms [2.634 ms, 2.759 ms] 1.151 ms (74.5%)
iast 2.356 ms [2.283 ms, 2.428 ms] 810.372 µs (52.4%)
iast_GLOBAL 2.402 ms [2.328 ms, 2.476 ms] 856.638 µs (55.4%)
profiling 2.226 ms [2.163 ms, 2.288 ms] 680.636 µs (44.0%)
tracing 2.186 ms [2.126 ms, 2.246 ms] 641.011 µs (41.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.537 ms [1.524 ms, 1.549 ms] -
appsec 2.721 ms [2.659 ms, 2.783 ms] 1.185 ms (77.1%)
iast 2.338 ms [2.267 ms, 2.41 ms] 801.874 µs (52.2%)
iast_GLOBAL 2.417 ms [2.342 ms, 2.492 ms] 880.522 µs (57.3%)
profiling 2.925 ms [2.656 ms, 3.193 ms] 1.388 ms (90.3%)
tracing 2.192 ms [2.132 ms, 2.253 ms] 655.784 µs (42.7%)

@jandro996
Copy link
Member Author

jandro996 commented Jul 26, 2024 •
edited
Loading

There are coverage errors in the callbacks, but IMHO it's better to check if you agree with this approach before fix them

@jandro996 jandro996 closed this Jul 31, 2024
@jandro996 jandro996 reopened this Jul 31, 2024
@manuel-alvarez-alvarez manuel-alvarez-alvarez added type: refactoring comp: asm waf Application Security Management (WAF) tag: no release notes Changes to exclude from release notes labels Jul 31, 2024
@manuel-alvarez-alvarez
Copy link
Member

There are coverage errors in the callbacks, but IMHO it's better to check if you agree with this approach before fix them

LGTM, remember squashing your commits as I think there are a few leftovers 😉

@jandro996 jandro996 marked this pull request as ready for review August 1, 2024 05:34
@jandro996 jandro996 requested a review from a team as a code owner August 1, 2024 05:34
@jandro996 jandro996 merged commit 85f67f7 into master Aug 1, 2024
80 checks passed
@jandro996 jandro996 deleted the alejandro.gonzalez/gateway-bridge-refactor branch August 1, 2024 09:23
@github-actions github-actions bot added this to the 1.38.0 milestone Aug 1, 2024
@nayeem-kamal nayeem-kamal changed the title appsec GatewayBridge refactor Refactor appsec GatewayBridge Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuel-alvarez-alvarez manuel-alvarez-alvarez manuel-alvarez-alvarez approved these changes

@ValentinZakharov ValentinZakharov ValentinZakharov approved these changes

Assignees
No one assigned
Labels
comp: asm waf Application Security Management (WAF) tag: no release notes Changes to exclude from release notes type: refactoring
Projects
None yet
Milestone
1.38.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jandro996 @manuel-alvarez-alvarez @ValentinZakharov