-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nightly deploys #7370
Merged
Merged
Fix nightly deploys #7370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randomanderson
added
type: bug
tag: no release notes
Changes to exclude from release notes
comp: tooling
Build & Tooling
labels
Jul 30, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.38.0-SNAPSHOT~5cda1d145d, baseline=1.38.0-SNAPSHOT~7028eafd9d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.552 s) : 0, 1551992
Total [baseline] (14.316 s) : 0, 14315569
Agent [candidate] (1.542 s) : 0, 1542448
Total [candidate] (14.223 s) : 0, 14222636
section appsec
Agent [baseline] (1.728 s) : 0, 1728429
Total [baseline] (14.386 s) : 0, 14385638
Agent [candidate] (1.728 s) : 0, 1728475
Total [candidate] (14.43 s) : 0, 14429548
section iast
Agent [baseline] (1.717 s) : 0, 1716750
Total [baseline] (14.83 s) : 0, 14829552
Agent [candidate] (1.717 s) : 0, 1717310
Total [candidate] (14.796 s) : 0, 14795746
section profiling
Agent [baseline] (1.862 s) : 0, 1861605
Total [baseline] (14.635 s) : 0, 14634919
Agent [candidate] (1.863 s) : 0, 1862943
Total [candidate] (14.53 s) : 0, 14530216
gantt
title petclinic - break down per module: candidate=1.38.0-SNAPSHOT~5cda1d145d, baseline=1.38.0-SNAPSHOT~7028eafd9d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (996.508 ms) : 0, 996508
BytebuddyAgent [candidate] (990.396 ms) : 0, 990396
GlobalTracer [baseline] (453.623 ms) : 0, 453623
GlobalTracer [candidate] (451.113 ms) : 0, 451113
AppSec [baseline] (71.054 ms) : 0, 71054
AppSec [candidate] (70.289 ms) : 0, 70289
Remote Config [baseline] (894.744 µs) : 0, 895
Remote Config [candidate] (866.093 µs) : 0, 866
Telemetry [baseline] (9.865 ms) : 0, 9865
Telemetry [candidate] (9.751 ms) : 0, 9751
section appsec
BytebuddyAgent [baseline] (1.007 s) : 0, 1006962
BytebuddyAgent [candidate] (1.007 s) : 0, 1006594
GlobalTracer [baseline] (445.232 ms) : 0, 445232
GlobalTracer [candidate] (445.848 ms) : 0, 445848
AppSec [baseline] (231.204 ms) : 0, 231204
AppSec [candidate] (231.464 ms) : 0, 231464
IAST [baseline] (27.67 ms) : 0, 27670
IAST [candidate] (25.737 ms) : 0, 25737
Remote Config [baseline] (784.355 µs) : 0, 784
Remote Config [candidate] (781.113 µs) : 0, 781
Telemetry [baseline] (10.424 ms) : 0, 10424
Telemetry [candidate] (10.81 ms) : 0, 10810
section iast
BytebuddyAgent [baseline] (1.151 s) : 0, 1151375
BytebuddyAgent [candidate] (1.153 s) : 0, 1152661
GlobalTracer [baseline] (434.26 ms) : 0, 434260
GlobalTracer [candidate] (433.726 ms) : 0, 433726
AppSec [baseline] (68.567 ms) : 0, 68567
AppSec [candidate] (70.006 ms) : 0, 70006
IAST [baseline] (31.735 ms) : 0, 31735
IAST [candidate] (30.922 ms) : 0, 30922
Remote Config [baseline] (729.885 µs) : 0, 730
Remote Config [candidate] (723.416 µs) : 0, 723
Telemetry [baseline] (10.057 ms) : 0, 10057
Telemetry [candidate] (9.186 ms) : 0, 9186
section profiling
BytebuddyAgent [baseline] (988.928 ms) : 0, 988928
BytebuddyAgent [candidate] (989.262 ms) : 0, 989262
GlobalTracer [baseline] (586.056 ms) : 0, 586056
GlobalTracer [candidate] (586.445 ms) : 0, 586445
AppSec [baseline] (72.133 ms) : 0, 72133
AppSec [candidate] (72.298 ms) : 0, 72298
Remote Config [baseline] (862.142 µs) : 0, 862
Remote Config [candidate] (868.78 µs) : 0, 869
Telemetry [baseline] (9.396 ms) : 0, 9396
Telemetry [candidate] (9.367 ms) : 0, 9367
ProfilingAgent [baseline] (149.26 ms) : 0, 149260
ProfilingAgent [candidate] (149.685 ms) : 0, 149685
Profiling [baseline] (149.335 ms) : 0, 149335
Profiling [candidate] (149.759 ms) : 0, 149759
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.38.0-SNAPSHOT~5cda1d145d, baseline=1.38.0-SNAPSHOT~7028eafd9d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.548 s) : 0, 1547755
Total [baseline] (11.821 s) : 0, 11821076
Agent [candidate] (1.542 s) : 0, 1541689
Total [candidate] (11.795 s) : 0, 11795068
section iast
Agent [baseline] (1.713 s) : 0, 1713382
Total [baseline] (12.467 s) : 0, 12467273
Agent [candidate] (1.716 s) : 0, 1716251
Total [candidate] (12.479 s) : 0, 12479183
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.715 s) : 0, 1714852
Total [baseline] (12.42 s) : 0, 12419854
Agent [candidate] (1.715 s) : 0, 1715364
Total [candidate] (12.462 s) : 0, 12461774
section iast_TELEMETRY_OFF
Agent [baseline] (1.708 s) : 0, 1708107
Total [baseline] (12.461 s) : 0, 12460879
Agent [candidate] (1.71 s) : 0, 1710057
Total [candidate] (12.476 s) : 0, 12476240
gantt
title insecure-bank - break down per module: candidate=1.38.0-SNAPSHOT~5cda1d145d, baseline=1.38.0-SNAPSHOT~7028eafd9d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (993.789 ms) : 0, 993789
BytebuddyAgent [candidate] (989.585 ms) : 0, 989585
GlobalTracer [baseline] (452.301 ms) : 0, 452301
GlobalTracer [candidate] (451.047 ms) : 0, 451047
AppSec [baseline] (70.956 ms) : 0, 70956
AppSec [candidate] (70.479 ms) : 0, 70479
Remote Config [baseline] (886.242 µs) : 0, 886
Remote Config [candidate] (880.487 µs) : 0, 880
Telemetry [baseline] (9.858 ms) : 0, 9858
Telemetry [candidate] (9.724 ms) : 0, 9724
section iast
BytebuddyAgent [baseline] (1.15 s) : 0, 1149789
BytebuddyAgent [candidate] (1.151 s) : 0, 1150961
GlobalTracer [baseline] (433.339 ms) : 0, 433339
GlobalTracer [candidate] (434.126 ms) : 0, 434126
AppSec [baseline] (71.341 ms) : 0, 71341
AppSec [candidate] (73.103 ms) : 0, 73103
IAST [baseline] (29.14 ms) : 0, 29140
IAST [candidate] (28.238 ms) : 0, 28238
Remote Config [baseline] (739.5 µs) : 0, 740
Remote Config [candidate] (724.732 µs) : 0, 725
Telemetry [baseline] (9.114 ms) : 0, 9114
Telemetry [candidate] (9.075 ms) : 0, 9075
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (1.151 s) : 0, 1151130
BytebuddyAgent [candidate] (1.15 s) : 0, 1149993
GlobalTracer [baseline] (434.182 ms) : 0, 434182
GlobalTracer [candidate] (434.793 ms) : 0, 434793
AppSec [baseline] (69.312 ms) : 0, 69312
AppSec [candidate] (71.812 ms) : 0, 71812
IAST [baseline] (29.408 ms) : 0, 29408
IAST [candidate] (28.586 ms) : 0, 28586
Remote Config [baseline] (768.253 µs) : 0, 768
Remote Config [candidate] (755.874 µs) : 0, 756
Telemetry [baseline] (9.982 ms) : 0, 9982
Telemetry [candidate] (9.24 ms) : 0, 9240
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (1.146 s) : 0, 1145985
BytebuddyAgent [candidate] (1.145 s) : 0, 1144848
GlobalTracer [baseline] (432.988 ms) : 0, 432988
GlobalTracer [candidate] (434.578 ms) : 0, 434578
AppSec [baseline] (66.85 ms) : 0, 66850
AppSec [candidate] (67.042 ms) : 0, 67042
IAST [baseline] (32.705 ms) : 0, 32705
IAST [candidate] (33.892 ms) : 0, 33892
Remote Config [baseline] (709.815 µs) : 0, 710
Remote Config [candidate] (720.73 µs) : 0, 721
Telemetry [baseline] (8.918 ms) : 0, 8918
Telemetry [candidate] (8.9 ms) : 0, 8900
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~5cda1d145d, baseline=1.38.0-SNAPSHOT~7028eafd9d
dateFormat X
axisFormat %s
section baseline
no_agent (1.343 ms) : 1323, 1362
. : milestone, 1343,
appsec (1.7 ms) : 1676, 1725
. : milestone, 1700,
appsec_no_iast (1.708 ms) : 1684, 1732
. : milestone, 1708,
iast (1.472 ms) : 1449, 1495
. : milestone, 1472,
profiling (1.482 ms) : 1457, 1507
. : milestone, 1482,
tracing (1.452 ms) : 1429, 1476
. : milestone, 1452,
section candidate
no_agent (1.34 ms) : 1321, 1359
. : milestone, 1340,
appsec (1.727 ms) : 1704, 1751
. : milestone, 1727,
appsec_no_iast (1.726 ms) : 1702, 1750
. : milestone, 1726,
iast (1.493 ms) : 1471, 1515
. : milestone, 1493,
profiling (1.545 ms) : 1519, 1571
. : milestone, 1545,
tracing (1.462 ms) : 1438, 1486
. : milestone, 1462,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~5cda1d145d, baseline=1.38.0-SNAPSHOT~7028eafd9d
dateFormat X
axisFormat %s
section baseline
no_agent (360.845 µs) : 341, 380
. : milestone, 361,
iast (482.914 µs) : 461, 505
. : milestone, 483,
iast_FULL (547.5 µs) : 526, 569
. : milestone, 548,
iast_GLOBAL (501.306 µs) : 480, 522
. : milestone, 501,
iast_HARDCODED_SECRET_DISABLED (477.82 µs) : 457, 499
. : milestone, 478,
iast_INACTIVE (448.288 µs) : 426, 470
. : milestone, 448,
iast_TELEMETRY_OFF (473.271 µs) : 452, 494
. : milestone, 473,
tracing (440.101 µs) : 414, 467
. : milestone, 440,
section candidate
no_agent (359.899 µs) : 340, 379
. : milestone, 360,
iast (475.458 µs) : 454, 496
. : milestone, 475,
iast_FULL (548.223 µs) : 527, 569
. : milestone, 548,
iast_GLOBAL (504.332 µs) : 483, 526
. : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (475.477 µs) : 455, 496
. : milestone, 475,
iast_INACTIVE (447.981 µs) : 426, 470
. : milestone, 448,
iast_TELEMETRY_OFF (469.459 µs) : 448, 490
. : milestone, 469,
tracing (435.779 µs) : 415, 457
. : milestone, 436,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~5cda1d145d, baseline=1.38.0-SNAPSHOT~7028eafd9d
dateFormat X
axisFormat %s
section baseline
no_agent (1.544 ms) : 1531, 1557
. : milestone, 1544,
appsec (2.71 ms) : 2648, 2773
. : milestone, 2710,
iast (2.391 ms) : 2317, 2466
. : milestone, 2391,
iast_GLOBAL (2.416 ms) : 2342, 2490
. : milestone, 2416,
profiling (2.231 ms) : 2167, 2296
. : milestone, 2231,
tracing (2.174 ms) : 2115, 2233
. : milestone, 2174,
section candidate
no_agent (1.544 ms) : 1532, 1557
. : milestone, 1544,
appsec (2.711 ms) : 2649, 2773
. : milestone, 2711,
iast (2.368 ms) : 2295, 2440
. : milestone, 2368,
iast_GLOBAL (2.414 ms) : 2341, 2486
. : milestone, 2414,
profiling (2.217 ms) : 2154, 2280
. : milestone, 2217,
tracing (2.177 ms) : 2118, 2236
. : milestone, 2177,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~5cda1d145d, baseline=1.38.0-SNAPSHOT~7028eafd9d
dateFormat X
axisFormat %s
section baseline
no_agent (20.458 s) : 20458000, 20458000
. : milestone, 20458000,
appsec (21.708 s) : 21708000, 21708000
. : milestone, 21708000,
iast (24.797 s) : 24797000, 24797000
. : milestone, 24797000,
iast_GLOBAL (24.467 s) : 24467000, 24467000
. : milestone, 24467000,
profiling (21.353 s) : 21353000, 21353000
. : milestone, 21353000,
tracing (21.175 s) : 21175000, 21175000
. : milestone, 21175000,
section candidate
no_agent (20.273 s) : 20273000, 20273000
. : milestone, 20273000,
appsec (20.876 s) : 20876000, 20876000
. : milestone, 20876000,
iast (24.05 s) : 24050000, 24050000
. : milestone, 24050000,
iast_GLOBAL (24.953 s) : 24953000, 24953000
. : milestone, 24953000,
profiling (21.473 s) : 21473000, 21473000
. : milestone, 21473000,
tracing (20.733 s) : 20733000, 20733000
. : milestone, 20733000,
|
PerfectSlayer
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Fixes the schedule deploy:
SKIP_SHARED_PIPELINE: $POPULATE_CACHE
variable assignment doesn't work. It needs to be done as a workflow rulemacrobenchmarks
anddeploy_to_sonatype
jobs depended onbuild
which was not available during nightly jobsAdditionally:
build
in addition tobuild_with_cache
so any dependency issues won't bork the build in the futureMotivation
The nightly deploy has been broken for months despite occasional efforts to fix it
Additional Notes
I tested this be creating a scheduled job with
POPULATE_CACHE=true
and ensuring everything works as expectedContributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issue