-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix links in pull request template #7371
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.38.0-SNAPSHOT~175ed5b9c0, baseline=1.38.0-SNAPSHOT~7028eafd9d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.541 s) : 0, 1540580
Total [baseline] (14.151 s) : 0, 14150912
Agent [candidate] (1.543 s) : 0, 1543080
Total [candidate] (14.216 s) : 0, 14216071
section appsec
Agent [baseline] (1.725 s) : 0, 1724702
Total [baseline] (14.351 s) : 0, 14351239
Agent [candidate] (1.728 s) : 0, 1727574
Total [candidate] (14.337 s) : 0, 14337374
section iast
Agent [baseline] (1.713 s) : 0, 1712743
Total [baseline] (14.736 s) : 0, 14736285
Agent [candidate] (1.713 s) : 0, 1713077
Total [candidate] (14.741 s) : 0, 14740696
section profiling
Agent [baseline] (1.85 s) : 0, 1849882
Total [baseline] (14.587 s) : 0, 14587232
Agent [candidate] (1.851 s) : 0, 1851213
Total [candidate] (14.545 s) : 0, 14545493
gantt
title petclinic - break down per module: candidate=1.38.0-SNAPSHOT~175ed5b9c0, baseline=1.38.0-SNAPSHOT~7028eafd9d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (988.769 ms) : 0, 988769
BytebuddyAgent [candidate] (989.983 ms) : 0, 989983
GlobalTracer [baseline] (450.905 ms) : 0, 450905
GlobalTracer [candidate] (451.939 ms) : 0, 451939
AppSec [baseline] (70.367 ms) : 0, 70367
AppSec [candidate] (70.464 ms) : 0, 70464
Remote Config [baseline] (897.756 µs) : 0, 898
Remote Config [candidate] (929.0 µs) : 0, 929
Telemetry [baseline] (9.728 ms) : 0, 9728
Telemetry [candidate] (9.749 ms) : 0, 9749
section appsec
BytebuddyAgent [baseline] (1.004 s) : 0, 1004274
BytebuddyAgent [candidate] (1.007 s) : 0, 1006507
GlobalTracer [baseline] (444.952 ms) : 0, 444952
GlobalTracer [candidate] (445.727 ms) : 0, 445727
AppSec [baseline] (230.845 ms) : 0, 230845
AppSec [candidate] (231.189 ms) : 0, 231189
Remote Config [baseline] (775.907 µs) : 0, 776
Remote Config [candidate] (778.625 µs) : 0, 779
Telemetry [baseline] (11.566 ms) : 0, 11566
Telemetry [candidate] (10.477 ms) : 0, 10477
IAST [baseline] (24.716 ms) : 0, 24716
IAST [candidate] (25.674 ms) : 0, 25674
section iast
BytebuddyAgent [baseline] (1.149 s) : 0, 1149390
BytebuddyAgent [candidate] (1.15 s) : 0, 1149596
GlobalTracer [baseline] (433.175 ms) : 0, 433175
GlobalTracer [candidate] (433.374 ms) : 0, 433374
AppSec [baseline] (67.716 ms) : 0, 67716
AppSec [candidate] (69.937 ms) : 0, 69937
Remote Config [baseline] (725.309 µs) : 0, 725
Remote Config [candidate] (738.897 µs) : 0, 739
Telemetry [baseline] (9.962 ms) : 0, 9962
Telemetry [candidate] (10.097 ms) : 0, 10097
IAST [baseline] (31.786 ms) : 0, 31786
IAST [candidate] (29.258 ms) : 0, 29258
section profiling
BytebuddyAgent [baseline] (983.9 ms) : 0, 983900
BytebuddyAgent [candidate] (983.319 ms) : 0, 983319
GlobalTracer [baseline] (582.964 ms) : 0, 582964
GlobalTracer [candidate] (583.741 ms) : 0, 583741
AppSec [baseline] (72.141 ms) : 0, 72141
AppSec [candidate] (72.107 ms) : 0, 72107
Remote Config [baseline] (866.615 µs) : 0, 867
Remote Config [candidate] (858.844 µs) : 0, 859
Telemetry [baseline] (9.318 ms) : 0, 9318
Telemetry [candidate] (9.299 ms) : 0, 9299
ProfilingAgent [baseline] (146.071 ms) : 0, 146071
ProfilingAgent [candidate] (147.111 ms) : 0, 147111
Profiling [baseline] (146.141 ms) : 0, 146141
Profiling [candidate] (147.177 ms) : 0, 147177
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.38.0-SNAPSHOT~175ed5b9c0, baseline=1.38.0-SNAPSHOT~7028eafd9d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.54 s) : 0, 1540293
Total [baseline] (11.716 s) : 0, 11716347
Agent [candidate] (1.542 s) : 0, 1542013
Total [candidate] (11.766 s) : 0, 11766122
section iast
Agent [baseline] (1.73 s) : 0, 1730322
Total [baseline] (12.507 s) : 0, 12506577
Agent [candidate] (1.711 s) : 0, 1711181
Total [candidate] (12.445 s) : 0, 12444649
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.721 s) : 0, 1721242
Total [baseline] (12.512 s) : 0, 12512485
Agent [candidate] (1.727 s) : 0, 1727358
Total [candidate] (12.421 s) : 0, 12421407
section iast_TELEMETRY_OFF
Agent [baseline] (1.716 s) : 0, 1715659
Total [baseline] (12.507 s) : 0, 12506671
Agent [candidate] (1.714 s) : 0, 1713576
Total [candidate] (12.436 s) : 0, 12435949
gantt
title insecure-bank - break down per module: candidate=1.38.0-SNAPSHOT~175ed5b9c0, baseline=1.38.0-SNAPSHOT~7028eafd9d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (988.82 ms) : 0, 988820
BytebuddyAgent [candidate] (989.249 ms) : 0, 989249
GlobalTracer [baseline] (450.485 ms) : 0, 450485
GlobalTracer [candidate] (451.329 ms) : 0, 451329
AppSec [baseline] (70.428 ms) : 0, 70428
AppSec [candidate] (70.834 ms) : 0, 70834
Remote Config [baseline] (880.24 µs) : 0, 880
Remote Config [candidate] (906.083 µs) : 0, 906
Telemetry [baseline] (9.814 ms) : 0, 9814
Telemetry [candidate] (9.763 ms) : 0, 9763
section iast
BytebuddyAgent [baseline] (1.161 s) : 0, 1160593
BytebuddyAgent [candidate] (1.147 s) : 0, 1146917
GlobalTracer [baseline] (437.078 ms) : 0, 437078
GlobalTracer [candidate] (433.042 ms) : 0, 433042
AppSec [baseline] (74.086 ms) : 0, 74086
AppSec [candidate] (72.057 ms) : 0, 72057
Remote Config [baseline] (732.447 µs) : 0, 732
Remote Config [candidate] (796.719 µs) : 0, 797
Telemetry [baseline] (9.213 ms) : 0, 9213
Telemetry [candidate] (8.901 ms) : 0, 8901
IAST [baseline] (28.551 ms) : 0, 28551
IAST [candidate] (29.525 ms) : 0, 29525
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (1.154 s) : 0, 1154079
BytebuddyAgent [candidate] (1.158 s) : 0, 1158443
GlobalTracer [baseline] (435.079 ms) : 0, 435079
GlobalTracer [candidate] (436.595 ms) : 0, 436595
AppSec [baseline] (72.2 ms) : 0, 72200
AppSec [candidate] (73.461 ms) : 0, 73461
Remote Config [baseline] (746.16 µs) : 0, 746
Remote Config [candidate] (730.077 µs) : 0, 730
Telemetry [baseline] (9.268 ms) : 0, 9268
Telemetry [candidate] (9.229 ms) : 0, 9229
IAST [baseline] (29.798 ms) : 0, 29798
IAST [candidate] (28.621 ms) : 0, 28621
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (1.15 s) : 0, 1149527
BytebuddyAgent [candidate] (1.152 s) : 0, 1152095
GlobalTracer [baseline] (435.24 ms) : 0, 435240
GlobalTracer [candidate] (434.278 ms) : 0, 434278
AppSec [baseline] (67.04 ms) : 0, 67040
AppSec [candidate] (66.867 ms) : 0, 66867
Remote Config [baseline] (723.132 µs) : 0, 723
Remote Config [candidate] (738.923 µs) : 0, 739
Telemetry [baseline] (8.974 ms) : 0, 8974
Telemetry [candidate] (9.057 ms) : 0, 9057
IAST [baseline] (34.07 ms) : 0, 34070
IAST [candidate] (30.443 ms) : 0, 30443
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 6 metrics, 22 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~175ed5b9c0, baseline=1.38.0-SNAPSHOT~7028eafd9d
dateFormat X
axisFormat %s
section baseline
no_agent (447.38 µs) : 419, 476
. : milestone, 447,
iast (578.715 µs) : 547, 610
. : milestone, 579,
iast_FULL (682.098 µs) : 650, 715
. : milestone, 682,
iast_GLOBAL (613.541 µs) : 581, 646
. : milestone, 614,
iast_HARDCODED_SECRET_DISABLED (579.073 µs) : 547, 611
. : milestone, 579,
iast_INACTIVE (545.436 µs) : 514, 577
. : milestone, 545,
iast_TELEMETRY_OFF (567.239 µs) : 535, 599
. : milestone, 567,
tracing (537.287 µs) : 508, 567
. : milestone, 537,
section candidate
no_agent (446.501 µs) : 418, 475
. : milestone, 447,
iast (577.591 µs) : 546, 609
. : milestone, 578,
iast_FULL (684.749 µs) : 652, 717
. : milestone, 685,
iast_GLOBAL (613.342 µs) : 581, 646
. : milestone, 613,
iast_HARDCODED_SECRET_DISABLED (573.497 µs) : 542, 605
. : milestone, 573,
iast_INACTIVE (553.737 µs) : 521, 587
. : milestone, 554,
iast_TELEMETRY_OFF (571.72 µs) : 540, 604
. : milestone, 572,
tracing (533.044 µs) : 503, 563
. : milestone, 533,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~175ed5b9c0, baseline=1.38.0-SNAPSHOT~7028eafd9d
dateFormat X
axisFormat %s
section baseline
no_agent (1.711 ms) : 1687, 1736
. : milestone, 1711,
appsec (2.174 ms) : 2144, 2204
. : milestone, 2174,
appsec_no_iast (2.17 ms) : 2138, 2202
. : milestone, 2170,
iast (1.89 ms) : 1860, 1920
. : milestone, 1890,
profiling (1.825 ms) : 1793, 1857
. : milestone, 1825,
tracing (1.827 ms) : 1795, 1860
. : milestone, 1827,
section candidate
no_agent (1.703 ms) : 1678, 1729
. : milestone, 1703,
appsec (2.167 ms) : 2135, 2200
. : milestone, 2167,
appsec_no_iast (2.177 ms) : 2145, 2210
. : milestone, 2177,
iast (1.894 ms) : 1864, 1923
. : milestone, 1894,
profiling (1.864 ms) : 1832, 1896
. : milestone, 1864,
tracing (1.876 ms) : 1843, 1909
. : milestone, 1876,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~175ed5b9c0, baseline=1.38.0-SNAPSHOT~7028eafd9d
dateFormat X
axisFormat %s
section baseline
no_agent (1.459 ms) : 1448, 1471
. : milestone, 1459,
appsec (2.227 ms) : 2191, 2262
. : milestone, 2227,
iast (1.981 ms) : 1939, 2023
. : milestone, 1981,
iast_GLOBAL (2.013 ms) : 1970, 2057
. : milestone, 2013,
profiling (1.861 ms) : 1827, 1895
. : milestone, 1861,
tracing (1.832 ms) : 1800, 1865
. : milestone, 1832,
section candidate
no_agent (1.463 ms) : 1451, 1474
. : milestone, 1463,
appsec (2.225 ms) : 2189, 2260
. : milestone, 2225,
iast (1.977 ms) : 1935, 2020
. : milestone, 1977,
iast_GLOBAL (2.037 ms) : 1994, 2080
. : milestone, 2037,
profiling (1.861 ms) : 1825, 1896
. : milestone, 1861,
tracing (1.843 ms) : 1809, 1876
. : milestone, 1843,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~175ed5b9c0, baseline=1.38.0-SNAPSHOT~7028eafd9d
dateFormat X
axisFormat %s
section baseline
no_agent (15.034 s) : 15034000, 15034000
. : milestone, 15034000,
appsec (15.165 s) : 15165000, 15165000
. : milestone, 15165000,
iast (18.552 s) : 18552000, 18552000
. : milestone, 18552000,
iast_GLOBAL (18.0 s) : 18000000, 18000000
. : milestone, 18000000,
profiling (15.226 s) : 15226000, 15226000
. : milestone, 15226000,
tracing (14.746 s) : 14746000, 14746000
. : milestone, 14746000,
section candidate
no_agent (15.373 s) : 15373000, 15373000
. : milestone, 15373000,
appsec (15.175 s) : 15175000, 15175000
. : milestone, 15175000,
iast (18.877 s) : 18877000, 18877000
. : milestone, 18877000,
iast_GLOBAL (17.772 s) : 17772000, 17772000
. : milestone, 17772000,
profiling (15.23 s) : 15230000, 15230000
. : milestone, 15230000,
tracing (15.2 s) : 15200000, 15200000
. : milestone, 15200000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
What Does This Do
Fixes the links in the pull request template
Motivation
The relative links don't work in the pull request even though the work correctly when browsing to
.github/pull_request_template.md
. You can see them broken in the Contributor Checklist below. This PR uses the full URL to CONTRIBUTING.mdContributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issue