-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow subsampling the liveheap profiling data #7380
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~060e520733, baseline=1.38.0-SNAPSHOT~60ddc9e0d7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1045341
Total [baseline] (10.446 s) : 0, 10446058
Agent [candidate] (1.05 s) : 0, 1050342
Total [candidate] (10.33 s) : 0, 10329884
section appsec
Agent [baseline] (1.165 s) : 0, 1164843
Total [baseline] (10.491 s) : 0, 10491434
Agent [candidate] (1.178 s) : 0, 1178331
Total [candidate] (10.507 s) : 0, 10506812
section iast
Agent [baseline] (1.17 s) : 0, 1170219
Total [baseline] (10.828 s) : 0, 10827731
Agent [candidate] (1.172 s) : 0, 1172020
Total [candidate] (10.808 s) : 0, 10807986
section profiling
Agent [baseline] (1.243 s) : 0, 1243179
Total [baseline] (10.629 s) : 0, 10628567
Agent [candidate] (1.245 s) : 0, 1245256
Total [candidate] (10.6 s) : 0, 10600136
gantt
title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~060e520733, baseline=1.38.0-SNAPSHOT~60ddc9e0d7
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.294 ms) : 0, 668294
BytebuddyAgent [candidate] (671.144 ms) : 0, 671144
GlobalTracer [baseline] (305.242 ms) : 0, 305242
GlobalTracer [candidate] (307.138 ms) : 0, 307138
AppSec [baseline] (50.382 ms) : 0, 50382
AppSec [candidate] (50.528 ms) : 0, 50528
Remote Config [baseline] (685.108 µs) : 0, 685
Remote Config [candidate] (687.979 µs) : 0, 688
Telemetry [baseline] (7.319 ms) : 0, 7319
Telemetry [candidate] (7.344 ms) : 0, 7344
section appsec
BytebuddyAgent [baseline] (678.002 ms) : 0, 678002
BytebuddyAgent [candidate] (685.964 ms) : 0, 685964
GlobalTracer [baseline] (299.047 ms) : 0, 299047
GlobalTracer [candidate] (302.143 ms) : 0, 302143
AppSec [baseline] (154.784 ms) : 0, 154784
AppSec [candidate] (156.098 ms) : 0, 156098
IAST [baseline] (21.455 ms) : 0, 21455
IAST [candidate] (22.799 ms) : 0, 22799
Remote Config [baseline] (598.129 µs) : 0, 598
Remote Config [candidate] (599.246 µs) : 0, 599
Telemetry [baseline] (8.201 ms) : 0, 8201
Telemetry [candidate] (8.486 ms) : 0, 8486
section iast
BytebuddyAgent [baseline] (781.133 ms) : 0, 781133
BytebuddyAgent [candidate] (782.395 ms) : 0, 782395
GlobalTracer [baseline] (294.848 ms) : 0, 294848
GlobalTracer [candidate] (295.533 ms) : 0, 295533
AppSec [baseline] (50.515 ms) : 0, 50515
AppSec [candidate] (49.465 ms) : 0, 49465
IAST [baseline] (22.654 ms) : 0, 22654
IAST [candidate] (22.815 ms) : 0, 22815
Remote Config [baseline] (575.214 µs) : 0, 575
Remote Config [candidate] (573.748 µs) : 0, 574
Telemetry [baseline] (7.035 ms) : 0, 7035
Telemetry [candidate] (7.714 ms) : 0, 7714
section profiling
BytebuddyAgent [baseline] (663.697 ms) : 0, 663697
BytebuddyAgent [candidate] (663.643 ms) : 0, 663643
GlobalTracer [baseline] (388.964 ms) : 0, 388964
GlobalTracer [candidate] (389.472 ms) : 0, 389472
AppSec [baseline] (51.42 ms) : 0, 51420
AppSec [candidate] (51.472 ms) : 0, 51472
Remote Config [baseline] (701.848 µs) : 0, 702
Remote Config [candidate] (700.383 µs) : 0, 700
Telemetry [baseline] (7.247 ms) : 0, 7247
Telemetry [candidate] (7.268 ms) : 0, 7268
ProfilingAgent [baseline] (94.06 ms) : 0, 94060
ProfilingAgent [candidate] (95.579 ms) : 0, 95579
Profiling [baseline] (94.086 ms) : 0, 94086
Profiling [candidate] (95.604 ms) : 0, 95604
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~060e520733, baseline=1.38.0-SNAPSHOT~60ddc9e0d7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1046518
Total [baseline] (8.483 s) : 0, 8482652
Agent [candidate] (1.054 s) : 0, 1053819
Total [candidate] (8.521 s) : 0, 8521348
section iast
Agent [baseline] (1.175 s) : 0, 1174644
Total [baseline] (9.023 s) : 0, 9022995
Agent [candidate] (1.177 s) : 0, 1176588
Total [candidate] (8.992 s) : 0, 8991692
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.174 s) : 0, 1173818
Total [baseline] (8.96 s) : 0, 8959789
Agent [candidate] (1.185 s) : 0, 1184710
Total [candidate] (8.997 s) : 0, 8997101
section iast_TELEMETRY_OFF
Agent [baseline] (1.171 s) : 0, 1171062
Total [baseline] (8.964 s) : 0, 8964094
Agent [candidate] (1.186 s) : 0, 1185977
Total [candidate] (8.995 s) : 0, 8995312
gantt
title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~060e520733, baseline=1.38.0-SNAPSHOT~60ddc9e0d7
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.877 ms) : 0, 668877
BytebuddyAgent [candidate] (673.936 ms) : 0, 673936
GlobalTracer [baseline] (305.813 ms) : 0, 305813
GlobalTracer [candidate] (307.629 ms) : 0, 307629
AppSec [baseline] (50.38 ms) : 0, 50380
AppSec [candidate] (50.66 ms) : 0, 50660
Remote Config [baseline] (688.412 µs) : 0, 688
Remote Config [candidate] (689.558 µs) : 0, 690
Telemetry [baseline] (7.343 ms) : 0, 7343
Telemetry [candidate] (7.401 ms) : 0, 7401
section iast
BytebuddyAgent [baseline] (784.047 ms) : 0, 784047
BytebuddyAgent [candidate] (784.991 ms) : 0, 784991
GlobalTracer [baseline] (294.955 ms) : 0, 294955
GlobalTracer [candidate] (295.61 ms) : 0, 295610
AppSec [baseline] (50.254 ms) : 0, 50254
AppSec [candidate] (50.291 ms) : 0, 50291
IAST [baseline] (24.182 ms) : 0, 24182
IAST [candidate] (24.677 ms) : 0, 24677
Remote Config [baseline] (621.218 µs) : 0, 621
Remote Config [candidate] (565.475 µs) : 0, 565
Telemetry [baseline] (7.081 ms) : 0, 7081
Telemetry [candidate] (6.975 ms) : 0, 6975
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (781.752 ms) : 0, 781752
BytebuddyAgent [candidate] (790.187 ms) : 0, 790187
GlobalTracer [baseline] (295.72 ms) : 0, 295720
GlobalTracer [candidate] (298.129 ms) : 0, 298129
AppSec [baseline] (53.689 ms) : 0, 53689
AppSec [candidate] (53.384 ms) : 0, 53384
IAST [baseline] (21.606 ms) : 0, 21606
IAST [candidate] (21.008 ms) : 0, 21008
Remote Config [baseline] (558.809 µs) : 0, 559
Remote Config [candidate] (1.286 ms) : 0, 1286
Telemetry [baseline] (6.944 ms) : 0, 6944
Telemetry [candidate] (7.075 ms) : 0, 7075
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (781.206 ms) : 0, 781206
BytebuddyAgent [candidate] (790.975 ms) : 0, 790975
GlobalTracer [baseline] (296.023 ms) : 0, 296023
GlobalTracer [candidate] (299.147 ms) : 0, 299147
AppSec [baseline] (46.755 ms) : 0, 46755
AppSec [candidate] (47.919 ms) : 0, 47919
IAST [baseline] (26.036 ms) : 0, 26036
IAST [candidate] (26.584 ms) : 0, 26584
Remote Config [baseline] (608.33 µs) : 0, 608
Remote Config [candidate] (624.518 µs) : 0, 625
Telemetry [baseline] (6.905 ms) : 0, 6905
Telemetry [candidate] (7.038 ms) : 0, 7038
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~060e520733, baseline=1.38.0-SNAPSHOT~60ddc9e0d7
dateFormat X
axisFormat %s
section baseline
no_agent (1.339 ms) : 1320, 1358
. : milestone, 1339,
appsec (1.727 ms) : 1704, 1751
. : milestone, 1727,
appsec_no_iast (1.726 ms) : 1703, 1749
. : milestone, 1726,
iast (1.477 ms) : 1455, 1500
. : milestone, 1477,
profiling (1.469 ms) : 1444, 1493
. : milestone, 1469,
tracing (1.452 ms) : 1427, 1477
. : milestone, 1452,
section candidate
no_agent (1.349 ms) : 1330, 1368
. : milestone, 1349,
appsec (1.701 ms) : 1677, 1725
. : milestone, 1701,
appsec_no_iast (1.712 ms) : 1688, 1735
. : milestone, 1712,
iast (1.471 ms) : 1449, 1494
. : milestone, 1471,
profiling (1.541 ms) : 1515, 1566
. : milestone, 1541,
tracing (1.467 ms) : 1443, 1491
. : milestone, 1467,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~060e520733, baseline=1.38.0-SNAPSHOT~60ddc9e0d7
dateFormat X
axisFormat %s
section baseline
no_agent (367.765 µs) : 348, 388
. : milestone, 368,
iast (478.923 µs) : 458, 500
. : milestone, 479,
iast_FULL (547.14 µs) : 526, 568
. : milestone, 547,
iast_GLOBAL (508.166 µs) : 486, 530
. : milestone, 508,
iast_HARDCODED_SECRET_DISABLED (479.99 µs) : 459, 501
. : milestone, 480,
iast_INACTIVE (451.641 µs) : 430, 473
. : milestone, 452,
iast_TELEMETRY_OFF (472.373 µs) : 450, 494
. : milestone, 472,
tracing (439.39 µs) : 419, 460
. : milestone, 439,
section candidate
no_agent (371.19 µs) : 351, 391
. : milestone, 371,
iast (476.254 µs) : 455, 497
. : milestone, 476,
iast_FULL (541.657 µs) : 520, 563
. : milestone, 542,
iast_GLOBAL (501.413 µs) : 480, 523
. : milestone, 501,
iast_HARDCODED_SECRET_DISABLED (474.407 µs) : 454, 495
. : milestone, 474,
iast_INACTIVE (452.269 µs) : 430, 475
. : milestone, 452,
iast_TELEMETRY_OFF (464.028 µs) : 443, 485
. : milestone, 464,
tracing (446.624 µs) : 425, 468
. : milestone, 447,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~060e520733, baseline=1.38.0-SNAPSHOT~60ddc9e0d7
dateFormat X
axisFormat %s
section baseline
no_agent (15.439 s) : 15439000, 15439000
. : milestone, 15439000,
appsec (15.222 s) : 15222000, 15222000
. : milestone, 15222000,
iast (18.792 s) : 18792000, 18792000
. : milestone, 18792000,
iast_GLOBAL (17.781 s) : 17781000, 17781000
. : milestone, 17781000,
profiling (15.272 s) : 15272000, 15272000
. : milestone, 15272000,
tracing (15.126 s) : 15126000, 15126000
. : milestone, 15126000,
section candidate
no_agent (15.008 s) : 15008000, 15008000
. : milestone, 15008000,
appsec (15.15 s) : 15150000, 15150000
. : milestone, 15150000,
iast (18.884 s) : 18884000, 18884000
. : milestone, 18884000,
iast_GLOBAL (18.07 s) : 18070000, 18070000
. : milestone, 18070000,
profiling (15.271 s) : 15271000, 15271000
. : milestone, 15271000,
tracing (14.729 s) : 14729000, 14729000
. : milestone, 14729000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~060e520733, baseline=1.38.0-SNAPSHOT~60ddc9e0d7
dateFormat X
axisFormat %s
section baseline
no_agent (1.462 ms) : 1451, 1473
. : milestone, 1462,
appsec (2.238 ms) : 2203, 2274
. : milestone, 2238,
iast (1.995 ms) : 1953, 2038
. : milestone, 1995,
iast_GLOBAL (2.027 ms) : 1985, 2070
. : milestone, 2027,
profiling (1.872 ms) : 1838, 1907
. : milestone, 1872,
tracing (1.844 ms) : 1810, 1877
. : milestone, 1844,
section candidate
no_agent (1.466 ms) : 1455, 1478
. : milestone, 1466,
appsec (2.246 ms) : 2211, 2282
. : milestone, 2246,
iast (1.986 ms) : 1944, 2028
. : milestone, 1986,
iast_GLOBAL (2.026 ms) : 1983, 2069
. : milestone, 2026,
profiling (2.355 ms) : 2169, 2540
. : milestone, 2355,
tracing (1.84 ms) : 1808, 1873
. : milestone, 1840,
|
27953ec
to
8867b96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What Does This Do
Adds a new configuration option for the liveheap profile subsampling
Motivation
Expose the ddprof-java library configuration to the dd-trace-java users
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: PROF-10303