-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash-tracking uploader script overwrite warning #7386
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~e9003d8654, baseline=1.38.0-SNAPSHOT~60ddc9e0d7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.546 s) : 0, 1546041
Total [baseline] (11.84 s) : 0, 11840121
Agent [candidate] (1.551 s) : 0, 1550828
Total [candidate] (11.835 s) : 0, 11834538
section iast
Agent [baseline] (1.722 s) : 0, 1721696
Total [baseline] (12.539 s) : 0, 12538859
Agent [candidate] (1.725 s) : 0, 1725081
Total [candidate] (12.509 s) : 0, 12508946
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.72 s) : 0, 1720222
Total [baseline] (12.515 s) : 0, 12514937
Agent [candidate] (1.725 s) : 0, 1725360
Total [candidate] (12.438 s) : 0, 12437959
section iast_TELEMETRY_OFF
Agent [baseline] (1.715 s) : 0, 1714745
Total [baseline] (12.493 s) : 0, 12493239
Agent [candidate] (1.718 s) : 0, 1718473
Total [candidate] (12.483 s) : 0, 12482811
gantt
title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~e9003d8654, baseline=1.38.0-SNAPSHOT~60ddc9e0d7
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (990.712 ms) : 0, 990712
BytebuddyAgent [candidate] (995.012 ms) : 0, 995012
GlobalTracer [baseline] (454.028 ms) : 0, 454028
GlobalTracer [candidate] (454.587 ms) : 0, 454587
AppSec [baseline] (70.999 ms) : 0, 70999
AppSec [candidate] (70.767 ms) : 0, 70767
Remote Config [baseline] (840.569 µs) : 0, 841
Remote Config [candidate] (844.425 µs) : 0, 844
Telemetry [baseline] (9.528 ms) : 0, 9528
Telemetry [candidate] (9.531 ms) : 0, 9531
section iast
BytebuddyAgent [baseline] (1.157 s) : 0, 1157146
BytebuddyAgent [candidate] (1.159 s) : 0, 1158876
GlobalTracer [baseline] (434.948 ms) : 0, 434948
GlobalTracer [candidate] (435.738 ms) : 0, 435738
AppSec [baseline] (69.243 ms) : 0, 69243
AppSec [candidate] (70.895 ms) : 0, 70895
IAST [baseline] (30.076 ms) : 0, 30076
IAST [candidate] (29.286 ms) : 0, 29286
Remote Config [baseline] (978.701 µs) : 0, 979
Remote Config [candidate] (811.18 µs) : 0, 811
Telemetry [baseline] (9.215 ms) : 0, 9215
Telemetry [candidate] (9.242 ms) : 0, 9242
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (1.153 s) : 0, 1153006
BytebuddyAgent [candidate] (1.159 s) : 0, 1158658
GlobalTracer [baseline] (435.237 ms) : 0, 435237
GlobalTracer [candidate] (435.65 ms) : 0, 435650
AppSec [baseline] (71.171 ms) : 0, 71171
AppSec [candidate] (69.221 ms) : 0, 69221
IAST [baseline] (30.946 ms) : 0, 30946
IAST [candidate] (31.837 ms) : 0, 31837
Remote Config [baseline] (729.928 µs) : 0, 730
Remote Config [candidate] (731.155 µs) : 0, 731
Telemetry [baseline] (9.03 ms) : 0, 9030
Telemetry [candidate] (9.015 ms) : 0, 9015
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (1.148 s) : 0, 1148279
BytebuddyAgent [candidate] (1.154 s) : 0, 1153521
GlobalTracer [baseline] (434.562 ms) : 0, 434562
GlobalTracer [candidate] (434.283 ms) : 0, 434283
AppSec [baseline] (68.17 ms) : 0, 68170
AppSec [candidate] (66.123 ms) : 0, 66123
IAST [baseline] (33.926 ms) : 0, 33926
IAST [candidate] (34.678 ms) : 0, 34678
Remote Config [baseline] (777.094 µs) : 0, 777
Remote Config [candidate] (759.434 µs) : 0, 759
Telemetry [baseline] (8.933 ms) : 0, 8933
Telemetry [candidate] (8.837 ms) : 0, 8837
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~e9003d8654, baseline=1.38.0-SNAPSHOT~60ddc9e0d7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.552 s) : 0, 1552061
Total [baseline] (14.248 s) : 0, 14248318
Agent [candidate] (1.545 s) : 0, 1544802
Total [candidate] (14.22 s) : 0, 14219584
section appsec
Agent [baseline] (1.728 s) : 0, 1728106
Total [baseline] (14.441 s) : 0, 14440537
Agent [candidate] (1.728 s) : 0, 1728200
Total [candidate] (14.401 s) : 0, 14401267
section iast
Agent [baseline] (1.717 s) : 0, 1717499
Total [baseline] (14.87 s) : 0, 14869744
Agent [candidate] (1.715 s) : 0, 1714856
Total [candidate] (14.775 s) : 0, 14775403
section profiling
Agent [baseline] (1.856 s) : 0, 1855827
Total [baseline] (14.78 s) : 0, 14780023
Agent [candidate] (1.857 s) : 0, 1857205
Total [candidate] (14.678 s) : 0, 14678263
gantt
title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~e9003d8654, baseline=1.38.0-SNAPSHOT~60ddc9e0d7
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (995.171 ms) : 0, 995171
BytebuddyAgent [candidate] (991.199 ms) : 0, 991199
GlobalTracer [baseline] (454.86 ms) : 0, 454860
GlobalTracer [candidate] (452.58 ms) : 0, 452580
AppSec [baseline] (71.477 ms) : 0, 71477
AppSec [candidate] (70.653 ms) : 0, 70653
Remote Config [baseline] (858.477 µs) : 0, 858
Remote Config [candidate] (840.27 µs) : 0, 840
Telemetry [baseline] (9.658 ms) : 0, 9658
Telemetry [candidate] (9.522 ms) : 0, 9522
section appsec
BytebuddyAgent [baseline] (1.007 s) : 0, 1007411
BytebuddyAgent [candidate] (1.007 s) : 0, 1006843
GlobalTracer [baseline] (444.729 ms) : 0, 444729
GlobalTracer [candidate] (445.226 ms) : 0, 445226
AppSec [baseline] (232.687 ms) : 0, 232687
AppSec [candidate] (232.371 ms) : 0, 232371
IAST [baseline] (24.85 ms) : 0, 24850
IAST [candidate] (25.494 ms) : 0, 25494
Remote Config [baseline] (764.286 µs) : 0, 764
Remote Config [candidate] (761.31 µs) : 0, 761
Telemetry [baseline] (10.123 ms) : 0, 10123
Telemetry [candidate] (10.031 ms) : 0, 10031
section iast
BytebuddyAgent [baseline] (1.153 s) : 0, 1153029
BytebuddyAgent [candidate] (1.151 s) : 0, 1151161
GlobalTracer [baseline] (433.736 ms) : 0, 433736
GlobalTracer [candidate] (434.297 ms) : 0, 434297
AppSec [baseline] (72.407 ms) : 0, 72407
AppSec [candidate] (71.148 ms) : 0, 71148
IAST [baseline] (27.554 ms) : 0, 27554
IAST [candidate] (28.269 ms) : 0, 28269
Remote Config [baseline] (1.59 ms) : 0, 1590
Remote Config [candidate] (732.247 µs) : 0, 732
Telemetry [baseline] (9.179 ms) : 0, 9179
Telemetry [candidate] (9.176 ms) : 0, 9176
section profiling
BytebuddyAgent [baseline] (984.661 ms) : 0, 984661
BytebuddyAgent [candidate] (985.361 ms) : 0, 985361
GlobalTracer [baseline] (584.168 ms) : 0, 584168
GlobalTracer [candidate] (583.738 ms) : 0, 583738
AppSec [baseline] (72.171 ms) : 0, 72171
AppSec [candidate] (72.176 ms) : 0, 72176
Remote Config [baseline] (915.802 µs) : 0, 916
Remote Config [candidate] (910.622 µs) : 0, 911
Telemetry [baseline] (9.241 ms) : 0, 9241
Telemetry [candidate] (9.316 ms) : 0, 9316
ProfilingAgent [baseline] (148.89 ms) : 0, 148890
ProfilingAgent [candidate] (149.799 ms) : 0, 149799
Profiling [baseline] (148.962 ms) : 0, 148962
Profiling [candidate] (149.885 ms) : 0, 149885
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 6 metrics, 22 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~e9003d8654, baseline=1.38.0-SNAPSHOT~60ddc9e0d7
dateFormat X
axisFormat %s
section baseline
no_agent (446.958 µs) : 418, 476
. : milestone, 447,
iast (585.736 µs) : 554, 618
. : milestone, 586,
iast_FULL (680.687 µs) : 648, 713
. : milestone, 681,
iast_GLOBAL (618.704 µs) : 587, 651
. : milestone, 619,
iast_HARDCODED_SECRET_DISABLED (582.172 µs) : 550, 614
. : milestone, 582,
iast_INACTIVE (543.7 µs) : 511, 576
. : milestone, 544,
iast_TELEMETRY_OFF (571.823 µs) : 540, 604
. : milestone, 572,
tracing (532.731 µs) : 503, 563
. : milestone, 533,
section candidate
no_agent (452.735 µs) : 424, 481
. : milestone, 453,
iast (585.21 µs) : 553, 617
. : milestone, 585,
iast_FULL (684.297 µs) : 653, 716
. : milestone, 684,
iast_GLOBAL (615.69 µs) : 584, 647
. : milestone, 616,
iast_HARDCODED_SECRET_DISABLED (586.457 µs) : 555, 618
. : milestone, 586,
iast_INACTIVE (551.327 µs) : 519, 583
. : milestone, 551,
iast_TELEMETRY_OFF (573.98 µs) : 542, 606
. : milestone, 574,
tracing (529.538 µs) : 500, 559
. : milestone, 530,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~e9003d8654, baseline=1.38.0-SNAPSHOT~60ddc9e0d7
dateFormat X
axisFormat %s
section baseline
no_agent (1.705 ms) : 1680, 1730
. : milestone, 1705,
appsec (2.172 ms) : 2139, 2205
. : milestone, 2172,
appsec_no_iast (2.171 ms) : 2140, 2202
. : milestone, 2171,
iast (1.87 ms) : 1841, 1898
. : milestone, 1870,
profiling (1.896 ms) : 1863, 1930
. : milestone, 1896,
tracing (1.857 ms) : 1825, 1889
. : milestone, 1857,
section candidate
no_agent (1.707 ms) : 1682, 1732
. : milestone, 1707,
appsec (2.172 ms) : 2139, 2204
. : milestone, 2172,
appsec_no_iast (2.176 ms) : 2144, 2207
. : milestone, 2176,
iast (1.865 ms) : 1836, 1894
. : milestone, 1865,
profiling (1.962 ms) : 1926, 1999
. : milestone, 1962,
tracing (1.852 ms) : 1821, 1882
. : milestone, 1852,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~e9003d8654, baseline=1.38.0-SNAPSHOT~60ddc9e0d7
dateFormat X
axisFormat %s
section baseline
no_agent (1.541 ms) : 1528, 1553
. : milestone, 1541,
appsec (2.708 ms) : 2646, 2771
. : milestone, 2708,
iast (2.339 ms) : 2268, 2411
. : milestone, 2339,
iast_GLOBAL (2.421 ms) : 2347, 2496
. : milestone, 2421,
profiling (2.24 ms) : 2176, 2304
. : milestone, 2240,
tracing (2.199 ms) : 2139, 2259
. : milestone, 2199,
section candidate
no_agent (1.543 ms) : 1530, 1555
. : milestone, 1543,
appsec (2.706 ms) : 2643, 2768
. : milestone, 2706,
iast (2.363 ms) : 2291, 2435
. : milestone, 2363,
iast_GLOBAL (2.417 ms) : 2343, 2491
. : milestone, 2417,
profiling (2.24 ms) : 2176, 2304
. : milestone, 2240,
tracing (2.185 ms) : 2126, 2245
. : milestone, 2185,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~e9003d8654, baseline=1.38.0-SNAPSHOT~60ddc9e0d7
dateFormat X
axisFormat %s
section baseline
no_agent (20.961 s) : 20961000, 20961000
. : milestone, 20961000,
appsec (21.986 s) : 21986000, 21986000
. : milestone, 21986000,
iast (24.809 s) : 24809000, 24809000
. : milestone, 24809000,
iast_GLOBAL (25.087 s) : 25087000, 25087000
. : milestone, 25087000,
profiling (20.815 s) : 20815000, 20815000
. : milestone, 20815000,
tracing (20.688 s) : 20688000, 20688000
. : milestone, 20688000,
section candidate
no_agent (20.549 s) : 20549000, 20549000
. : milestone, 20549000,
appsec (21.788 s) : 21788000, 21788000
. : milestone, 21788000,
iast (24.65 s) : 24650000, 24650000
. : milestone, 24650000,
iast_GLOBAL (25.072 s) : 25072000, 25072000
. : milestone, 25072000,
profiling (20.867 s) : 20867000, 20867000
. : milestone, 20867000,
tracing (20.891 s) : 20891000, 20891000
. : milestone, 20891000,
|
MattAlp
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
It fixes a (embarrassing) bug in the crash uploader script initialization
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: PROF-10324