-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade builds to latest JDK versions #7390
Conversation
+1 once the CI issues have been resolved The CI errors look similar to those seen in the nightly CI builds (the ones with "Timeout has been exceeded") Solving these failures should therefore also fix those nightly runs. |
Thanks for having a look at it. I haven't paid attention yet. Isn't weird that upgrading JDKs lead to the same kind of than nightly? Upgrading JDK should not have an impact of which dependency version is used, right? 🤔 (if it's the root cause of the timeouts) |
Nightlies currently run with latest docker images. |
a103080
to
6417822
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~64178225f0, baseline=1.39.0-SNAPSHOT~2fa95bf182
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052070
Total [baseline] (10.317 s) : 0, 10316896
Agent [candidate] (1.053 s) : 0, 1053192
Total [candidate] (10.34 s) : 0, 10339963
section appsec
Agent [baseline] (1.17 s) : 0, 1169827
Total [baseline] (10.436 s) : 0, 10436079
Agent [candidate] (1.169 s) : 0, 1168934
Total [candidate] (10.472 s) : 0, 10472430
section iast
Agent [baseline] (1.186 s) : 0, 1185731
Total [baseline] (10.838 s) : 0, 10838456
Agent [candidate] (1.179 s) : 0, 1179069
Total [candidate] (10.804 s) : 0, 10803536
section profiling
Agent [baseline] (1.25 s) : 0, 1250444
Total [baseline] (10.561 s) : 0, 10561196
Agent [candidate] (1.26 s) : 0, 1259640
Total [candidate] (10.615 s) : 0, 10614638
gantt
title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~64178225f0, baseline=1.39.0-SNAPSHOT~2fa95bf182
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (672.706 ms) : 0, 672706
BytebuddyAgent [candidate] (672.068 ms) : 0, 672068
GlobalTracer [baseline] (306.484 ms) : 0, 306484
GlobalTracer [candidate] (308.168 ms) : 0, 308168
AppSec [baseline] (51.175 ms) : 0, 51175
AppSec [candidate] (51.27 ms) : 0, 51270
Remote Config [baseline] (683.665 µs) : 0, 684
Remote Config [candidate] (684.474 µs) : 0, 684
Telemetry [baseline] (7.504 ms) : 0, 7504
Telemetry [candidate] (7.464 ms) : 0, 7464
section appsec
BytebuddyAgent [baseline] (678.791 ms) : 0, 678791
BytebuddyAgent [candidate] (678.162 ms) : 0, 678162
GlobalTracer [baseline] (300.147 ms) : 0, 300147
GlobalTracer [candidate] (299.578 ms) : 0, 299578
AppSec [baseline] (157.227 ms) : 0, 157227
AppSec [candidate] (157.361 ms) : 0, 157361
Remote Config [baseline] (603.556 µs) : 0, 604
Remote Config [candidate] (600.444 µs) : 0, 600
Telemetry [baseline] (9.463 ms) : 0, 9463
Telemetry [candidate] (8.679 ms) : 0, 8679
IAST [baseline] (20.255 ms) : 0, 20255
IAST [candidate] (22.111 ms) : 0, 22111
section iast
BytebuddyAgent [baseline] (788.938 ms) : 0, 788938
BytebuddyAgent [candidate] (783.905 ms) : 0, 783905
GlobalTracer [baseline] (298.133 ms) : 0, 298133
GlobalTracer [candidate] (297.393 ms) : 0, 297393
AppSec [baseline] (52.169 ms) : 0, 52169
AppSec [candidate] (52.53 ms) : 0, 52530
Remote Config [baseline] (612.055 µs) : 0, 612
Remote Config [candidate] (579.03 µs) : 0, 579
Telemetry [baseline] (9.603 ms) : 0, 9603
Telemetry [candidate] (8.607 ms) : 0, 8607
IAST [baseline] (22.712 ms) : 0, 22712
IAST [candidate] (22.53 ms) : 0, 22530
section profiling
ProfilingAgent [baseline] (95.221 ms) : 0, 95221
ProfilingAgent [candidate] (95.523 ms) : 0, 95523
BytebuddyAgent [baseline] (664.207 ms) : 0, 664207
BytebuddyAgent [candidate] (671.032 ms) : 0, 671032
GlobalTracer [baseline] (393.219 ms) : 0, 393219
GlobalTracer [candidate] (394.305 ms) : 0, 394305
AppSec [baseline] (52.497 ms) : 0, 52497
AppSec [candidate] (52.962 ms) : 0, 52962
Remote Config [baseline] (686.503 µs) : 0, 687
Remote Config [candidate] (686.321 µs) : 0, 686
Telemetry [baseline] (7.471 ms) : 0, 7471
Telemetry [candidate] (7.546 ms) : 0, 7546
Profiling [baseline] (95.246 ms) : 0, 95246
Profiling [candidate] (95.549 ms) : 0, 95549
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~64178225f0, baseline=1.39.0-SNAPSHOT~2fa95bf182
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1043808
Total [baseline] (8.539 s) : 0, 8538680
Agent [candidate] (1.047 s) : 0, 1046548
Total [candidate] (8.501 s) : 0, 8500574
section iast
Agent [baseline] (1.175 s) : 0, 1175411
Total [baseline] (8.991 s) : 0, 8991138
Agent [candidate] (1.173 s) : 0, 1173113
Total [candidate] (8.971 s) : 0, 8971320
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.173 s) : 0, 1173423
Total [baseline] (9.007 s) : 0, 9006803
Agent [candidate] (1.173 s) : 0, 1173349
Total [candidate] (9.014 s) : 0, 9014145
section iast_TELEMETRY_OFF
Agent [baseline] (1.178 s) : 0, 1177958
Total [baseline] (8.984 s) : 0, 8984177
Agent [candidate] (1.181 s) : 0, 1180811
Total [candidate] (8.987 s) : 0, 8986581
gantt
title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~64178225f0, baseline=1.39.0-SNAPSHOT~2fa95bf182
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (665.571 ms) : 0, 665571
BytebuddyAgent [candidate] (667.558 ms) : 0, 667558
GlobalTracer [baseline] (305.682 ms) : 0, 305682
GlobalTracer [candidate] (306.105 ms) : 0, 306105
AppSec [baseline] (51.051 ms) : 0, 51051
AppSec [candidate] (51.315 ms) : 0, 51315
Remote Config [baseline] (678.01 µs) : 0, 678
Remote Config [candidate] (685.876 µs) : 0, 686
Telemetry [baseline] (7.432 ms) : 0, 7432
Telemetry [candidate] (7.494 ms) : 0, 7494
section iast
BytebuddyAgent [baseline] (782.486 ms) : 0, 782486
BytebuddyAgent [candidate] (780.75 ms) : 0, 780750
GlobalTracer [baseline] (295.814 ms) : 0, 295814
GlobalTracer [candidate] (295.574 ms) : 0, 295574
AppSec [baseline] (51.903 ms) : 0, 51903
AppSec [candidate] (53.562 ms) : 0, 53562
Remote Config [baseline] (583.292 µs) : 0, 583
Remote Config [candidate] (568.344 µs) : 0, 568
Telemetry [baseline] (7.83 ms) : 0, 7830
Telemetry [candidate] (7.81 ms) : 0, 7810
IAST [baseline] (23.299 ms) : 0, 23299
IAST [candidate] (21.414 ms) : 0, 21414
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (780.987 ms) : 0, 780987
BytebuddyAgent [candidate] (781.357 ms) : 0, 781357
GlobalTracer [baseline] (296.227 ms) : 0, 296227
GlobalTracer [candidate] (296.479 ms) : 0, 296479
AppSec [baseline] (50.064 ms) : 0, 50064
AppSec [candidate] (49.964 ms) : 0, 49964
Remote Config [baseline] (576.396 µs) : 0, 576
Remote Config [candidate] (572.337 µs) : 0, 572
Telemetry [baseline] (8.757 ms) : 0, 8757
Telemetry [candidate] (7.991 ms) : 0, 7991
IAST [baseline] (23.294 ms) : 0, 23294
IAST [candidate] (23.45 ms) : 0, 23450
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (784.214 ms) : 0, 784214
BytebuddyAgent [candidate] (785.244 ms) : 0, 785244
GlobalTracer [baseline] (298.363 ms) : 0, 298363
GlobalTracer [candidate] (298.688 ms) : 0, 298688
AppSec [baseline] (51.396 ms) : 0, 51396
AppSec [candidate] (53.215 ms) : 0, 53215
Remote Config [baseline] (603.665 µs) : 0, 604
Remote Config [candidate] (625.854 µs) : 0, 626
Telemetry [baseline] (6.984 ms) : 0, 6984
Telemetry [candidate] (7.122 ms) : 0, 7122
IAST [baseline] (22.816 ms) : 0, 22816
IAST [candidate] (22.312 ms) : 0, 22312
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~64178225f0, baseline=1.39.0-SNAPSHOT~2fa95bf182
dateFormat X
axisFormat %s
section baseline
no_agent (1.344 ms) : 1324, 1364
. : milestone, 1344,
appsec (1.715 ms) : 1692, 1738
. : milestone, 1715,
appsec_no_iast (1.699 ms) : 1675, 1723
. : milestone, 1699,
iast (1.467 ms) : 1444, 1490
. : milestone, 1467,
profiling (1.537 ms) : 1504, 1571
. : milestone, 1537,
tracing (1.46 ms) : 1436, 1484
. : milestone, 1460,
section candidate
no_agent (1.342 ms) : 1323, 1361
. : milestone, 1342,
appsec (1.714 ms) : 1690, 1738
. : milestone, 1714,
appsec_no_iast (1.723 ms) : 1698, 1747
. : milestone, 1723,
iast (1.463 ms) : 1441, 1486
. : milestone, 1463,
profiling (1.474 ms) : 1449, 1498
. : milestone, 1474,
tracing (1.462 ms) : 1436, 1488
. : milestone, 1462,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~64178225f0, baseline=1.39.0-SNAPSHOT~2fa95bf182
dateFormat X
axisFormat %s
section baseline
no_agent (360.201 µs) : 340, 381
. : milestone, 360,
iast (471.86 µs) : 451, 493
. : milestone, 472,
iast_FULL (538.541 µs) : 516, 561
. : milestone, 539,
iast_GLOBAL (507.0 µs) : 484, 530
. : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (482.126 µs) : 460, 504
. : milestone, 482,
iast_INACTIVE (444.329 µs) : 422, 466
. : milestone, 444,
iast_TELEMETRY_OFF (467.939 µs) : 446, 490
. : milestone, 468,
tracing (434.06 µs) : 414, 454
. : milestone, 434,
section candidate
no_agent (357.232 µs) : 338, 377
. : milestone, 357,
iast (472.577 µs) : 451, 494
. : milestone, 473,
iast_FULL (540.618 µs) : 518, 563
. : milestone, 541,
iast_GLOBAL (506.113 µs) : 483, 529
. : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (482.197 µs) : 461, 503
. : milestone, 482,
iast_INACTIVE (450.815 µs) : 429, 473
. : milestone, 451,
iast_TELEMETRY_OFF (464.278 µs) : 443, 485
. : milestone, 464,
tracing (435.354 µs) : 415, 456
. : milestone, 435,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~64178225f0, baseline=1.39.0-SNAPSHOT~2fa95bf182
dateFormat X
axisFormat %s
section baseline
no_agent (15.017 s) : 15017000, 15017000
. : milestone, 15017000,
appsec (14.96 s) : 14960000, 14960000
. : milestone, 14960000,
iast (18.826 s) : 18826000, 18826000
. : milestone, 18826000,
iast_GLOBAL (18.019 s) : 18019000, 18019000
. : milestone, 18019000,
profiling (15.778 s) : 15778000, 15778000
. : milestone, 15778000,
tracing (15.103 s) : 15103000, 15103000
. : milestone, 15103000,
section candidate
no_agent (15.176 s) : 15176000, 15176000
. : milestone, 15176000,
appsec (15.206 s) : 15206000, 15206000
. : milestone, 15206000,
iast (18.981 s) : 18981000, 18981000
. : milestone, 18981000,
iast_GLOBAL (18.07 s) : 18070000, 18070000
. : milestone, 18070000,
profiling (15.122 s) : 15122000, 15122000
. : milestone, 15122000,
tracing (15.019 s) : 15019000, 15019000
. : milestone, 15019000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~64178225f0, baseline=1.39.0-SNAPSHOT~2fa95bf182
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1481
. : milestone, 1469,
appsec (2.242 ms) : 2207, 2278
. : milestone, 2242,
iast (1.976 ms) : 1934, 2018
. : milestone, 1976,
iast_GLOBAL (2.026 ms) : 1983, 2069
. : milestone, 2026,
profiling (1.869 ms) : 1834, 1903
. : milestone, 1869,
tracing (1.851 ms) : 1818, 1885
. : milestone, 1851,
section candidate
no_agent (1.463 ms) : 1452, 1475
. : milestone, 1463,
appsec (2.245 ms) : 2209, 2280
. : milestone, 2245,
iast (1.985 ms) : 1942, 2028
. : milestone, 1985,
iast_GLOBAL (2.025 ms) : 1982, 2069
. : milestone, 2025,
profiling (1.865 ms) : 1831, 1899
. : milestone, 1865,
tracing (1.845 ms) : 1812, 1878
. : milestone, 1845,
|
6417822
to
9b077f4
Compare
What Does This Do
This PR upgrades to docker build image to https://github.com/DataDog/dd-trace-java-docker-build/actions/runs/10056908860
Motivation
Use update versions to build
dd-trace-java
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]