-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ClassNotFoundException: net.jpountz.lz4.LZ4JavaSafeCompressor when instrumenting Kafka 3.7 with Quarkus native #7404
Conversation
…ath when using GraalVM native-images
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 18 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~de920b4469, baseline=1.39.0-SNAPSHOT~bec85d9b82
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1046461
Total [baseline] (10.313 s) : 0, 10312857
Agent [candidate] (1.055 s) : 0, 1054648
Total [candidate] (10.298 s) : 0, 10298482
section appsec
Agent [baseline] (1.169 s) : 0, 1168934
Total [baseline] (10.514 s) : 0, 10514394
Agent [candidate] (1.172 s) : 0, 1171770
Total [candidate] (10.463 s) : 0, 10462674
section iast
Agent [baseline] (1.182 s) : 0, 1181921
Total [baseline] (10.74 s) : 0, 10740122
Agent [candidate] (1.185 s) : 0, 1185226
Total [candidate] (10.827 s) : 0, 10827000
section profiling
Agent [baseline] (1.246 s) : 0, 1245733
Total [baseline] (10.562 s) : 0, 10562178
Agent [candidate] (1.255 s) : 0, 1254661
Total [candidate] (10.639 s) : 0, 10639268
gantt
title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~de920b4469, baseline=1.39.0-SNAPSHOT~bec85d9b82
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.058 ms) : 0, 668058
BytebuddyAgent [candidate] (673.569 ms) : 0, 673569
GlobalTracer [baseline] (306.646 ms) : 0, 306646
GlobalTracer [candidate] (308.946 ms) : 0, 308946
AppSec [baseline] (50.343 ms) : 0, 50343
AppSec [candidate] (50.526 ms) : 0, 50526
Remote Config [baseline] (693.048 µs) : 0, 693
Remote Config [candidate] (696.597 µs) : 0, 697
Telemetry [baseline] (7.295 ms) : 0, 7295
Telemetry [candidate] (7.366 ms) : 0, 7366
section appsec
BytebuddyAgent [baseline] (679.52 ms) : 0, 679520
BytebuddyAgent [candidate] (681.384 ms) : 0, 681384
GlobalTracer [baseline] (300.254 ms) : 0, 300254
GlobalTracer [candidate] (301.464 ms) : 0, 301464
AppSec [baseline] (155.491 ms) : 0, 155491
AppSec [candidate] (155.45 ms) : 0, 155450
Remote Config [baseline] (599.755 µs) : 0, 600
Remote Config [candidate] (606.57 µs) : 0, 607
Telemetry [baseline] (7.871 ms) : 0, 7871
Telemetry [candidate] (8.574 ms) : 0, 8574
IAST [baseline] (23.398 ms) : 0, 23398
IAST [candidate] (21.462 ms) : 0, 21462
section iast
BytebuddyAgent [baseline] (787.237 ms) : 0, 787237
BytebuddyAgent [candidate] (789.973 ms) : 0, 789973
GlobalTracer [baseline] (297.75 ms) : 0, 297750
GlobalTracer [candidate] (298.562 ms) : 0, 298562
AppSec [baseline] (51.718 ms) : 0, 51718
AppSec [candidate] (51.964 ms) : 0, 51964
Remote Config [baseline] (579.426 µs) : 0, 579
Remote Config [candidate] (580.14 µs) : 0, 580
Telemetry [baseline] (7.711 ms) : 0, 7711
Telemetry [candidate] (6.987 ms) : 0, 6987
IAST [baseline] (23.375 ms) : 0, 23375
IAST [candidate] (23.521 ms) : 0, 23521
section profiling
BytebuddyAgent [baseline] (664.254 ms) : 0, 664254
BytebuddyAgent [candidate] (668.801 ms) : 0, 668801
GlobalTracer [baseline] (390.842 ms) : 0, 390842
GlobalTracer [candidate] (393.755 ms) : 0, 393755
AppSec [baseline] (51.262 ms) : 0, 51262
AppSec [candidate] (52.007 ms) : 0, 52007
Remote Config [baseline] (696.453 µs) : 0, 696
Remote Config [candidate] (707.607 µs) : 0, 708
Telemetry [baseline] (7.164 ms) : 0, 7164
Telemetry [candidate] (7.257 ms) : 0, 7257
ProfilingAgent [baseline] (94.365 ms) : 0, 94365
ProfilingAgent [candidate] (94.689 ms) : 0, 94689
Profiling [baseline] (94.39 ms) : 0, 94390
Profiling [candidate] (94.714 ms) : 0, 94714
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~de920b4469, baseline=1.39.0-SNAPSHOT~bec85d9b82
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1049623
Total [baseline] (8.509 s) : 0, 8509077
Agent [candidate] (1.046 s) : 0, 1045501
Total [candidate] (8.478 s) : 0, 8477979
section iast
Agent [baseline] (1.183 s) : 0, 1183283
Total [baseline] (8.991 s) : 0, 8990502
Agent [candidate] (1.185 s) : 0, 1185157
Total [candidate] (9.005 s) : 0, 9005344
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.194 s) : 0, 1193968
Total [baseline] (9.076 s) : 0, 9076199
Agent [candidate] (1.175 s) : 0, 1174592
Total [candidate] (8.959 s) : 0, 8958676
section iast_TELEMETRY_OFF
Agent [baseline] (1.173 s) : 0, 1172715
Total [baseline] (8.975 s) : 0, 8975281
Agent [candidate] (1.173 s) : 0, 1172768
Total [candidate] (8.988 s) : 0, 8988396
gantt
title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~de920b4469, baseline=1.39.0-SNAPSHOT~bec85d9b82
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.793 ms) : 0, 669793
BytebuddyAgent [candidate] (667.278 ms) : 0, 667278
GlobalTracer [baseline] (307.792 ms) : 0, 307792
GlobalTracer [candidate] (306.723 ms) : 0, 306723
AppSec [baseline] (50.511 ms) : 0, 50511
AppSec [candidate] (50.126 ms) : 0, 50126
Remote Config [baseline] (699.001 µs) : 0, 699
Remote Config [candidate] (680.039 µs) : 0, 680
Telemetry [baseline] (7.384 ms) : 0, 7384
Telemetry [candidate] (7.28 ms) : 0, 7280
section iast
BytebuddyAgent [baseline] (788.019 ms) : 0, 788019
BytebuddyAgent [candidate] (789.891 ms) : 0, 789891
GlobalTracer [baseline] (298.115 ms) : 0, 298115
GlobalTracer [candidate] (298.954 ms) : 0, 298954
AppSec [baseline] (51.639 ms) : 0, 51639
AppSec [candidate] (52.614 ms) : 0, 52614
IAST [baseline] (23.61 ms) : 0, 23610
IAST [candidate] (21.69 ms) : 0, 21690
Remote Config [baseline] (580.274 µs) : 0, 580
Remote Config [candidate] (597.281 µs) : 0, 597
Telemetry [baseline] (7.772 ms) : 0, 7772
Telemetry [candidate] (7.805 ms) : 0, 7805
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (795.764 ms) : 0, 795764
BytebuddyAgent [candidate] (781.345 ms) : 0, 781345
GlobalTracer [baseline] (300.693 ms) : 0, 300693
GlobalTracer [candidate] (297.184 ms) : 0, 297184
AppSec [baseline] (50.843 ms) : 0, 50843
AppSec [candidate] (50.933 ms) : 0, 50933
IAST [baseline] (23.613 ms) : 0, 23613
IAST [candidate] (23.992 ms) : 0, 23992
Remote Config [baseline] (596.457 µs) : 0, 596
Remote Config [candidate] (597.342 µs) : 0, 597
Telemetry [baseline] (8.753 ms) : 0, 8753
Telemetry [candidate] (6.987 ms) : 0, 6987
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (780.088 ms) : 0, 780088
BytebuddyAgent [candidate] (779.96 ms) : 0, 779960
GlobalTracer [baseline] (296.694 ms) : 0, 296694
GlobalTracer [candidate] (297.311 ms) : 0, 297311
AppSec [baseline] (49.529 ms) : 0, 49529
AppSec [candidate] (46.751 ms) : 0, 46751
IAST [baseline] (24.567 ms) : 0, 24567
IAST [candidate] (27.74 ms) : 0, 27740
Remote Config [baseline] (616.349 µs) : 0, 616
Remote Config [candidate] (599.006 µs) : 0, 599
Telemetry [baseline] (7.731 ms) : 0, 7731
Telemetry [candidate] (6.901 ms) : 0, 6901
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~de920b4469, baseline=1.39.0-SNAPSHOT~bec85d9b82
dateFormat X
axisFormat %s
section baseline
no_agent (1.326 ms) : 1307, 1345
. : milestone, 1326,
appsec (1.72 ms) : 1697, 1744
. : milestone, 1720,
appsec_no_iast (1.695 ms) : 1670, 1720
. : milestone, 1695,
iast (1.474 ms) : 1452, 1497
. : milestone, 1474,
profiling (1.548 ms) : 1522, 1574
. : milestone, 1548,
tracing (1.457 ms) : 1433, 1481
. : milestone, 1457,
section candidate
no_agent (1.346 ms) : 1326, 1366
. : milestone, 1346,
appsec (1.692 ms) : 1668, 1717
. : milestone, 1692,
appsec_no_iast (1.704 ms) : 1679, 1729
. : milestone, 1704,
iast (1.464 ms) : 1442, 1487
. : milestone, 1464,
profiling (1.516 ms) : 1490, 1543
. : milestone, 1516,
tracing (1.424 ms) : 1400, 1449
. : milestone, 1424,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~de920b4469, baseline=1.39.0-SNAPSHOT~bec85d9b82
dateFormat X
axisFormat %s
section baseline
no_agent (367.507 µs) : 345, 390
. : milestone, 368,
iast (473.788 µs) : 452, 495
. : milestone, 474,
iast_FULL (544.53 µs) : 523, 566
. : milestone, 545,
iast_GLOBAL (499.505 µs) : 478, 521
. : milestone, 500,
iast_HARDCODED_SECRET_DISABLED (482.438 µs) : 461, 504
. : milestone, 482,
iast_INACTIVE (444.977 µs) : 424, 466
. : milestone, 445,
iast_TELEMETRY_OFF (473.007 µs) : 452, 494
. : milestone, 473,
tracing (433.238 µs) : 412, 454
. : milestone, 433,
section candidate
no_agent (362.447 µs) : 343, 382
. : milestone, 362,
iast (482.69 µs) : 461, 505
. : milestone, 483,
iast_FULL (550.798 µs) : 530, 572
. : milestone, 551,
iast_GLOBAL (509.194 µs) : 486, 533
. : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (470.53 µs) : 450, 491
. : milestone, 471,
iast_INACTIVE (441.909 µs) : 420, 463
. : milestone, 442,
iast_TELEMETRY_OFF (468.793 µs) : 448, 490
. : milestone, 469,
tracing (444.431 µs) : 423, 466
. : milestone, 444,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~de920b4469, baseline=1.39.0-SNAPSHOT~bec85d9b82
dateFormat X
axisFormat %s
section baseline
no_agent (15.019 s) : 15019000, 15019000
. : milestone, 15019000,
appsec (15.167 s) : 15167000, 15167000
. : milestone, 15167000,
iast (18.828 s) : 18828000, 18828000
. : milestone, 18828000,
iast_GLOBAL (17.834 s) : 17834000, 17834000
. : milestone, 17834000,
profiling (15.717 s) : 15717000, 15717000
. : milestone, 15717000,
tracing (14.99 s) : 14990000, 14990000
. : milestone, 14990000,
section candidate
no_agent (15.043 s) : 15043000, 15043000
. : milestone, 15043000,
appsec (15.069 s) : 15069000, 15069000
. : milestone, 15069000,
iast (18.744 s) : 18744000, 18744000
. : milestone, 18744000,
iast_GLOBAL (17.728 s) : 17728000, 17728000
. : milestone, 17728000,
profiling (15.291 s) : 15291000, 15291000
. : milestone, 15291000,
tracing (15.057 s) : 15057000, 15057000
. : milestone, 15057000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~de920b4469, baseline=1.39.0-SNAPSHOT~bec85d9b82
dateFormat X
axisFormat %s
section baseline
no_agent (1.46 ms) : 1449, 1471
. : milestone, 1460,
appsec (2.226 ms) : 2191, 2262
. : milestone, 2226,
iast (1.979 ms) : 1937, 2021
. : milestone, 1979,
iast_GLOBAL (2.018 ms) : 1975, 2061
. : milestone, 2018,
profiling (1.857 ms) : 1823, 1891
. : milestone, 1857,
tracing (1.828 ms) : 1796, 1860
. : milestone, 1828,
section candidate
no_agent (1.464 ms) : 1452, 1475
. : milestone, 1464,
appsec (2.215 ms) : 2180, 2250
. : milestone, 2215,
iast (1.963 ms) : 1921, 2005
. : milestone, 1963,
iast_GLOBAL (2.018 ms) : 1975, 2062
. : milestone, 2018,
profiling (1.849 ms) : 1814, 1884
. : milestone, 1849,
tracing (1.839 ms) : 1806, 1871
. : milestone, 1839,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
What Does This Do
Relocate embedded
jpountz
classes to avoid conflict with flat class-path when using GraalVM native-images.In this case both the Java tracer and Kafka 3.7 contained
net.jpountz
LZ4 classes at slightly different versions.Jira ticket: APMS-12871