-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw exception when using repo index to resolve source path for classes with identical names #7805
Merged
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/backport-pr-7793
Oct 18, 2024
Merged
Throw exception when using repo index to resolve source path for classes with identical names #7805
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/backport-pr-7793
Oct 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ses with identical names
nikita-tkachenko-datadog
added
type: bug
comp: ci visibility
Continuous Integration Visibility
labels
Oct 18, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 52 metrics, 9 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.42.0-SNAPSHOT~e5f5e07d41, baseline=1.42.0-SNAPSHOT~52cdab0c9c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1076210
Total [baseline] (8.521 s) : 0, 8521220
Agent [candidate] (1.071 s) : 0, 1070900
Total [candidate] (8.564 s) : 0, 8564323
section iast
Agent [baseline] (1.201 s) : 0, 1200670
Total [baseline] (9.086 s) : 0, 9085606
Agent [candidate] (1.199 s) : 0, 1198924
Total [candidate] (9.087 s) : 0, 9087123
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.196 s) : 0, 1196214
Total [baseline] (9.072 s) : 0, 9072033
Agent [candidate] (1.197 s) : 0, 1197104
Total [candidate] (9.068 s) : 0, 9067559
section iast_TELEMETRY_OFF
Agent [baseline] (1.196 s) : 0, 1195726
Total [baseline] (9.083 s) : 0, 9083275
Agent [candidate] (1.194 s) : 0, 1193842
Total [candidate] (9.063 s) : 0, 9063492
gantt
title insecure-bank - break down per module: candidate=1.42.0-SNAPSHOT~e5f5e07d41, baseline=1.42.0-SNAPSHOT~52cdab0c9c
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.543 ms) : 0, 685543
BytebuddyAgent [candidate] (683.221 ms) : 0, 683221
GlobalTracer [baseline] (312.071 ms) : 0, 312071
GlobalTracer [candidate] (312.146 ms) : 0, 312146
AppSec [baseline] (53.945 ms) : 0, 53945
AppSec [candidate] (53.83 ms) : 0, 53830
Remote Config [baseline] (661.229 µs) : 0, 661
Remote Config [candidate] (660.095 µs) : 0, 660
Telemetry [baseline] (10.412 ms) : 0, 10412
Telemetry [candidate] (7.434 ms) : 0, 7434
section iast
BytebuddyAgent [baseline] (800.211 ms) : 0, 800211
BytebuddyAgent [candidate] (798.295 ms) : 0, 798295
GlobalTracer [baseline] (300.814 ms) : 0, 300814
GlobalTracer [candidate] (301.289 ms) : 0, 301289
AppSec [baseline] (56.395 ms) : 0, 56395
AppSec [candidate] (56.894 ms) : 0, 56894
IAST [baseline] (21.925 ms) : 0, 21925
IAST [candidate] (21.11 ms) : 0, 21110
Remote Config [baseline] (613.485 µs) : 0, 613
Remote Config [candidate] (592.78 µs) : 0, 593
Telemetry [baseline] (7.091 ms) : 0, 7091
Telemetry [candidate] (7.064 ms) : 0, 7064
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (797.221 ms) : 0, 797221
BytebuddyAgent [candidate] (797.087 ms) : 0, 797087
GlobalTracer [baseline] (300.154 ms) : 0, 300154
GlobalTracer [candidate] (300.762 ms) : 0, 300762
AppSec [baseline] (57.655 ms) : 0, 57655
AppSec [candidate] (56.024 ms) : 0, 56024
IAST [baseline] (20.036 ms) : 0, 20036
IAST [candidate] (22.0 ms) : 0, 22000
Remote Config [baseline] (593.451 µs) : 0, 593
Remote Config [candidate] (602.167 µs) : 0, 602
Telemetry [baseline] (7.006 ms) : 0, 7006
Telemetry [candidate] (7.011 ms) : 0, 7011
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (796.087 ms) : 0, 796087
BytebuddyAgent [candidate] (793.943 ms) : 0, 793943
GlobalTracer [baseline] (301.182 ms) : 0, 301182
GlobalTracer [candidate] (300.968 ms) : 0, 300968
AppSec [baseline] (57.578 ms) : 0, 57578
AppSec [candidate] (56.162 ms) : 0, 56162
IAST [baseline] (19.767 ms) : 0, 19767
IAST [candidate] (21.576 ms) : 0, 21576
Remote Config [baseline] (591.649 µs) : 0, 592
Remote Config [candidate] (595.606 µs) : 0, 596
Telemetry [baseline] (6.902 ms) : 0, 6902
Telemetry [candidate] (6.933 ms) : 0, 6933
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.42.0-SNAPSHOT~e5f5e07d41, baseline=1.42.0-SNAPSHOT~52cdab0c9c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1074728
Total [baseline] (10.337 s) : 0, 10337471
Agent [candidate] (1.07 s) : 0, 1070131
Total [candidate] (10.397 s) : 0, 10396744
section appsec
Agent [baseline] (1.217 s) : 0, 1216566
Total [baseline] (10.58 s) : 0, 10579629
Agent [candidate] (1.207 s) : 0, 1207135
Total [candidate] (10.573 s) : 0, 10572687
section iast
Agent [baseline] (1.197 s) : 0, 1197456
Total [baseline] (10.799 s) : 0, 10798988
Agent [candidate] (1.2 s) : 0, 1199672
Total [candidate] (10.916 s) : 0, 10915835
section profiling
Agent [baseline] (1.271 s) : 0, 1271486
Total [baseline] (10.687 s) : 0, 10687286
Agent [candidate] (1.271 s) : 0, 1270694
Total [candidate] (10.657 s) : 0, 10656995
gantt
title petclinic - break down per module: candidate=1.42.0-SNAPSHOT~e5f5e07d41, baseline=1.42.0-SNAPSHOT~52cdab0c9c
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.293 ms) : 0, 684293
BytebuddyAgent [candidate] (682.604 ms) : 0, 682604
GlobalTracer [baseline] (311.98 ms) : 0, 311980
GlobalTracer [candidate] (311.887 ms) : 0, 311887
AppSec [baseline] (53.831 ms) : 0, 53831
AppSec [candidate] (53.946 ms) : 0, 53946
Remote Config [baseline] (671.123 µs) : 0, 671
Remote Config [candidate] (653.293 µs) : 0, 653
Telemetry [baseline] (10.359 ms) : 0, 10359
Telemetry [candidate] (7.427 ms) : 0, 7427
section appsec
BytebuddyAgent [baseline] (706.74 ms) : 0, 706740
BytebuddyAgent [candidate] (701.447 ms) : 0, 701447
GlobalTracer [baseline] (311.462 ms) : 0, 311462
GlobalTracer [candidate] (309.55 ms) : 0, 309550
AppSec [baseline] (167.806 ms) : 0, 167806
AppSec [candidate] (163.675 ms) : 0, 163675
Remote Config [baseline] (637.953 µs) : 0, 638
Remote Config [candidate] (630.274 µs) : 0, 630
Telemetry [baseline] (7.029 ms) : 0, 7029
Telemetry [candidate] (8.512 ms) : 0, 8512
IAST [baseline] (18.451 ms) : 0, 18451
IAST [candidate] (19.355 ms) : 0, 19355
section iast
BytebuddyAgent [baseline] (798.325 ms) : 0, 798325
BytebuddyAgent [candidate] (799.01 ms) : 0, 799010
GlobalTracer [baseline] (300.369 ms) : 0, 300369
GlobalTracer [candidate] (301.015 ms) : 0, 301015
AppSec [baseline] (57.087 ms) : 0, 57087
AppSec [candidate] (56.284 ms) : 0, 56284
Remote Config [baseline] (600.327 µs) : 0, 600
Remote Config [candidate] (603.06 µs) : 0, 603
Telemetry [baseline] (6.986 ms) : 0, 6986
Telemetry [candidate] (7.076 ms) : 0, 7076
IAST [baseline] (20.517 ms) : 0, 20517
IAST [candidate] (22.01 ms) : 0, 22010
section profiling
BytebuddyAgent [baseline] (679.163 ms) : 0, 679163
BytebuddyAgent [candidate] (677.302 ms) : 0, 677302
GlobalTracer [baseline] (395.493 ms) : 0, 395493
GlobalTracer [candidate] (395.573 ms) : 0, 395573
AppSec [baseline] (54.485 ms) : 0, 54485
AppSec [candidate] (54.52 ms) : 0, 54520
Remote Config [baseline] (646.943 µs) : 0, 647
Remote Config [candidate] (647.805 µs) : 0, 648
Telemetry [baseline] (12.961 ms) : 0, 12961
Telemetry [candidate] (7.487 ms) : 0, 7487
ProfilingAgent [baseline] (90.167 ms) : 0, 90167
ProfilingAgent [candidate] (96.61 ms) : 0, 96610
Profiling [baseline] (90.191 ms) : 0, 90191
Profiling [candidate] (96.636 ms) : 0, 96636
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~e5f5e07d41, baseline=1.42.0-SNAPSHOT~52cdab0c9c
dateFormat X
axisFormat %s
section baseline
no_agent (372.762 µs) : 353, 392
. : milestone, 373,
iast (492.979 µs) : 471, 514
. : milestone, 493,
iast_FULL (553.304 µs) : 532, 574
. : milestone, 553,
iast_GLOBAL (514.407 µs) : 493, 536
. : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (491.03 µs) : 470, 512
. : milestone, 491,
iast_INACTIVE (455.739 µs) : 435, 477
. : milestone, 456,
iast_TELEMETRY_OFF (480.915 µs) : 460, 502
. : milestone, 481,
tracing (450.25 µs) : 430, 470
. : milestone, 450,
section candidate
no_agent (376.029 µs) : 356, 396
. : milestone, 376,
iast (492.1 µs) : 471, 513
. : milestone, 492,
iast_FULL (566.564 µs) : 545, 588
. : milestone, 567,
iast_GLOBAL (506.859 µs) : 486, 528
. : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (496.966 µs) : 475, 519
. : milestone, 497,
iast_INACTIVE (452.517 µs) : 432, 473
. : milestone, 453,
iast_TELEMETRY_OFF (488.454 µs) : 466, 511
. : milestone, 488,
tracing (451.238 µs) : 431, 472
. : milestone, 451,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~e5f5e07d41, baseline=1.42.0-SNAPSHOT~52cdab0c9c
dateFormat X
axisFormat %s
section baseline
no_agent (1.347 ms) : 1328, 1366
. : milestone, 1347,
appsec (1.728 ms) : 1705, 1751
. : milestone, 1728,
appsec_no_iast (1.724 ms) : 1700, 1747
. : milestone, 1724,
iast (1.494 ms) : 1472, 1516
. : milestone, 1494,
profiling (1.489 ms) : 1465, 1513
. : milestone, 1489,
tracing (1.467 ms) : 1442, 1491
. : milestone, 1467,
section candidate
no_agent (1.323 ms) : 1304, 1342
. : milestone, 1323,
appsec (1.721 ms) : 1697, 1746
. : milestone, 1721,
appsec_no_iast (1.74 ms) : 1717, 1764
. : milestone, 1740,
iast (1.499 ms) : 1476, 1522
. : milestone, 1499,
profiling (1.523 ms) : 1500, 1547
. : milestone, 1523,
tracing (1.452 ms) : 1428, 1476
. : milestone, 1452,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~e5f5e07d41, baseline=1.42.0-SNAPSHOT~52cdab0c9c
dateFormat X
axisFormat %s
section baseline
no_agent (15.778 s) : 15778000, 15778000
. : milestone, 15778000,
appsec (15.481 s) : 15481000, 15481000
. : milestone, 15481000,
iast (18.782 s) : 18782000, 18782000
. : milestone, 18782000,
iast_GLOBAL (17.873 s) : 17873000, 17873000
. : milestone, 17873000,
profiling (15.13 s) : 15130000, 15130000
. : milestone, 15130000,
tracing (15.209 s) : 15209000, 15209000
. : milestone, 15209000,
section candidate
no_agent (15.039 s) : 15039000, 15039000
. : milestone, 15039000,
appsec (15.264 s) : 15264000, 15264000
. : milestone, 15264000,
iast (18.889 s) : 18889000, 18889000
. : milestone, 18889000,
iast_GLOBAL (17.912 s) : 17912000, 17912000
. : milestone, 17912000,
profiling (15.275 s) : 15275000, 15275000
. : milestone, 15275000,
tracing (14.949 s) : 14949000, 14949000
. : milestone, 14949000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~e5f5e07d41, baseline=1.42.0-SNAPSHOT~52cdab0c9c
dateFormat X
axisFormat %s
section baseline
no_agent (1.468 ms) : 1456, 1480
. : milestone, 1468,
appsec (2.323 ms) : 2282, 2364
. : milestone, 2323,
iast (2.084 ms) : 2032, 2136
. : milestone, 2084,
iast_GLOBAL (2.115 ms) : 2063, 2167
. : milestone, 2115,
profiling (1.947 ms) : 1905, 1990
. : milestone, 1947,
tracing (1.916 ms) : 1876, 1956
. : milestone, 1916,
section candidate
no_agent (1.463 ms) : 1452, 1474
. : milestone, 1463,
appsec (2.319 ms) : 2278, 2359
. : milestone, 2319,
iast (2.074 ms) : 2022, 2125
. : milestone, 2074,
iast_GLOBAL (2.117 ms) : 2064, 2169
. : milestone, 2117,
profiling (1.942 ms) : 1900, 1984
. : milestone, 1942,
tracing (1.91 ms) : 1871, 1949
. : milestone, 1910,
|
juan-fernandez
approved these changes
Oct 18, 2024
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/backport-pr-7793
branch
October 18, 2024 13:13
nikita-tkachenko-datadog
restored the
nikita-tkachenko/backport-pr-7793
branch
October 18, 2024 13:17
nikita-tkachenko-datadog
added
the
tag: no release notes
Changes to exclude from release notes
label
Oct 18, 2024
nikita-tkachenko-datadog
changed the title
[🍒 7793] Throw exception when using repo index to resolve source path for classes with identical names
Throw exception when using repo index to resolve source path for classes with identical names
Oct 18, 2024
nikita-tkachenko-datadog
added
type: duplicate
and removed
type: bug
comp: ci visibility
Continuous Integration Visibility
labels
Oct 18, 2024
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/backport-pr-7793
branch
October 18, 2024 14:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicates #7793, merged by mistake