Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🍒 #7885] Fix memory leak in Exception Replay #7888

Closed
wants to merge 1 commit into from
Closed

[🍒 #7885] Fix memory leak in Exception Replay #7888

wants to merge 1 commit into from

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Nov 5, 2024

Backport #7885 to v1.42.1

What Does This Do

The weak map stateByThrowable keep the throwable as the key but this exception is also strong referenced by snapshots stored inside the ThrowableState in CapturedThrowable and in locals and extensions for @exception.
Fixing by storing weak reference inside the CapturedThrowable and clearing the other ref for @exception at commit time

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@jpbempel
Fix memory leak in Exception Replay (#7885)
ba91d0b 
The weak map stateByThrowable keep the throwable as the key but this
exception is also strong referenced by snapshots stored inside the
ThrowableState in CapturedThrowable and in locals and extensions for
@exception.
Fixing by storing weak reference inside the CapturedThrowable and
clearing the other ref for @exception at commit time
@jpbempel jpbempel requested a review from a team as a code owner November 5, 2024 17:48
@jpbempel jpbempel requested review from shatzi and removed request for a team November 5, 2024 17:48
@jpbempel jpbempel added comp: debugger Dynamic Instrumentation type: bug labels Nov 5, 2024
@ygree ygree added this to the 1.42.1 milestone Nov 5, 2024
@ygree ygree changed the base branch from release/v1.42.1 to release/v1.42.x November 5, 2024 17:55
@pr-commenter
Copy link

pr-commenter bot commented Nov 5, 2024

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1730829412 1730829800
end_time 2024-11-05T17:58:07 2024-11-05T18:04:36
git_branch master jean-philippe.bempel/backport-pr-7885
git_commit_sha 21c0b2d ba91d0b
start_time 2024-11-05T17:56:53 2024-11-05T18:03:21
See matching parameters
Baseline Candidate
ci_job_id 696179028 696179028
ci_pipeline_id 48282817 48282817
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1730828765 1730828765

Summary

Found 5 performance improvements and 0 performance regressions! Performance is the same for 4 metrics, 6 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:loop better
[-635.813µs; -624.760µs] or [-5.898%; -5.795%]		 better
[-663.877µs; -594.541µs] or [-6.062%; -5.429%]		 better
[-666.304µs; -561.603µs] or [-6.045%; -5.095%]		 better
[-943.504µs; -402.671µs] or [-8.207%; -3.503%]		 better
[+4.438op/s; +5.954op/s] or [+4.904%; +6.579%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-16.295µs; +20.546µs] or [-6.260%; +7.893%]		 unstable
[-22.872µs; +36.208µs] or [-7.688%; +12.171%]		 unstable
[-32.204µs; +49.515µs] or [-10.371%; +15.946%]		 unstable
[-104.476µs; +85.512µs] or [-16.725%; +13.690%]		 same
scenario:basic same same same unstable
[-57.689µs; +31.881µs] or [-10.475%; +5.789%]		 unstable
[-142.905op/s; +142.905op/s] or [-5.573%; +5.573%]
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (297.496 µs) : 273, 322
.   : milestone, 297,
basic (304.691 µs) : 296, 314
.   : milestone, 305,
loop (10.951 ms) : 10925, 10977
.   : milestone, 10951,
section candidate
noprobe (304.164 µs) : 272, 336
.   : milestone, 304,
basic (302.117 µs) : 294, 310
.   : milestone, 302,
loop (10.322 ms) : 10284, 10359
.   : milestone, 10322,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 297.496 µs [273.454 µs, 321.538 µs]
basic 304.691 µs [295.865 µs, 313.517 µs]
loop 10.951 ms [10.925 ms, 10.977 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 304.164 µs [272.397 µs, 335.931 µs]
basic 302.117 µs [294.028 µs, 310.206 µs]
loop 10.322 ms [10.284 ms, 10.359 ms]

@pr-commenter
Copy link

pr-commenter bot commented Nov 5, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jean-philippe.bempel/backport-pr-7885
git_commit_date 1730827777 1730828765
git_commit_sha 21c0b2d ba91d0b
release_version 1.43.0-SNAPSHOT~21c0b2df63 1.43.0-SNAPSHOT~ba91d0b1cf
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1730831124 1730831124
ci_job_id 696179022 696179022
ci_pipeline_id 48282817 48282817
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~ba91d0b1cf, baseline=1.43.0-SNAPSHOT~21c0b2df63

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.093 s) : 0, 1093115
Total [baseline] (8.596 s) : 0, 8595984
Agent [candidate] (1.087 s) : 0, 1086634
Total [candidate] (8.59 s) : 0, 8590256
section iast
Agent [baseline] (1.209 s) : 0, 1209219
Total [baseline] (9.121 s) : 0, 9120762
Agent [candidate] (1.209 s) : 0, 1209454
Total [candidate] (9.135 s) : 0, 9135350
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.209 s) : 0, 1209209
Total [baseline] (9.089 s) : 0, 9089440
Agent [candidate] (1.209 s) : 0, 1208955
Total [candidate] (9.165 s) : 0, 9164716
section iast_TELEMETRY_OFF
Agent [baseline] (1.213 s) : 0, 1212701
Total [baseline] (9.112 s) : 0, 9111649
Agent [candidate] (1.205 s) : 0, 1204574
Total [candidate] (9.156 s) : 0, 9156290
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.093 s -
Agent iast 1.209 s 116.104 ms (10.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.209 s 116.094 ms (10.6%)
Agent iast_TELEMETRY_OFF 1.213 s 119.586 ms (10.9%)
Total tracing 8.596 s -
Total iast 9.121 s 524.778 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.089 s 493.456 ms (5.7%)
Total iast_TELEMETRY_OFF 9.112 s 515.665 ms (6.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.087 s -
Agent iast 1.209 s 122.82 ms (11.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.209 s 122.321 ms (11.3%)
Agent iast_TELEMETRY_OFF 1.205 s 117.939 ms (10.9%)
Total tracing 8.59 s -
Total iast 9.135 s 545.095 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.165 s 574.46 ms (6.7%)
Total iast_TELEMETRY_OFF 9.156 s 566.034 ms (6.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~ba91d0b1cf, baseline=1.43.0-SNAPSHOT~21c0b2df63

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.589 ms) : 0, 693589
BytebuddyAgent [candidate] (690.15 ms) : 0, 690150
GlobalTracer [baseline] (317.97 ms) : 0, 317970
GlobalTracer [candidate] (317.547 ms) : 0, 317547
AppSec [baseline] (54.521 ms) : 0, 54521
AppSec [candidate] (54.524 ms) : 0, 54524
Remote Config [baseline] (667.57 µs) : 0, 668
Remote Config [candidate] (663.313 µs) : 0, 663
Telemetry [baseline] (12.558 ms) : 0, 12558
Telemetry [candidate] (10.012 ms) : 0, 10012
section iast
BytebuddyAgent [baseline] (805.003 ms) : 0, 805003
BytebuddyAgent [candidate] (804.075 ms) : 0, 804075
GlobalTracer [baseline] (304.914 ms) : 0, 304914
GlobalTracer [candidate] (304.989 ms) : 0, 304989
AppSec [baseline] (56.988 ms) : 0, 56988
AppSec [candidate] (55.572 ms) : 0, 55572
IAST [baseline] (20.517 ms) : 0, 20517
IAST [candidate] (22.946 ms) : 0, 22946
Remote Config [baseline] (599.35 µs) : 0, 599
Remote Config [candidate] (619.07 µs) : 0, 619
Telemetry [baseline] (7.422 ms) : 0, 7422
Telemetry [candidate] (7.461 ms) : 0, 7461
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (804.35 ms) : 0, 804350
BytebuddyAgent [candidate] (803.533 ms) : 0, 803533
GlobalTracer [baseline] (305.173 ms) : 0, 305173
GlobalTracer [candidate] (304.859 ms) : 0, 304859
AppSec [baseline] (57.452 ms) : 0, 57452
AppSec [candidate] (57.183 ms) : 0, 57183
IAST [baseline] (20.447 ms) : 0, 20447
IAST [candidate] (21.44 ms) : 0, 21440
Remote Config [baseline] (598.478 µs) : 0, 598
Remote Config [candidate] (616.383 µs) : 0, 616
Telemetry [baseline] (7.423 ms) : 0, 7423
Telemetry [candidate] (7.542 ms) : 0, 7542
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (806.861 ms) : 0, 806861
BytebuddyAgent [candidate] (800.429 ms) : 0, 800429
GlobalTracer [baseline] (306.355 ms) : 0, 306355
GlobalTracer [candidate] (304.56 ms) : 0, 304560
AppSec [baseline] (57.714 ms) : 0, 57714
AppSec [candidate] (56.989 ms) : 0, 56989
IAST [baseline] (19.974 ms) : 0, 19974
IAST [candidate] (20.92 ms) : 0, 20920
Remote Config [baseline] (584.128 µs) : 0, 584
Remote Config [candidate] (599.576 µs) : 0, 600
Telemetry [baseline] (7.41 ms) : 0, 7410
Telemetry [candidate] (7.365 ms) : 0, 7365
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~ba91d0b1cf, baseline=1.43.0-SNAPSHOT~21c0b2df63

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.082 s) : 0, 1081849
Total [baseline] (10.39 s) : 0, 10390499
Agent [candidate] (1.085 s) : 0, 1085257
Total [candidate] (10.434 s) : 0, 10433858
section appsec
Agent [baseline] (1.222 s) : 0, 1221606
Total [baseline] (10.654 s) : 0, 10654414
Agent [candidate] (1.218 s) : 0, 1218224
Total [candidate] (10.654 s) : 0, 10653788
section iast
Agent [baseline] (1.21 s) : 0, 1210014
Total [baseline] (10.899 s) : 0, 10898858
Agent [candidate] (1.209 s) : 0, 1208756
Total [candidate] (10.933 s) : 0, 10933308
section profiling
Agent [baseline] (1.283 s) : 0, 1283003
Total [baseline] (10.826 s) : 0, 10825920
Agent [candidate] (1.283 s) : 0, 1282692
Total [candidate] (10.787 s) : 0, 10787141
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.082 s -
Agent appsec 1.222 s 139.757 ms (12.9%)
Agent iast 1.21 s 128.165 ms (11.8%)
Agent profiling 1.283 s 201.154 ms (18.6%)
Total tracing 10.39 s -
Total appsec 10.654 s 263.915 ms (2.5%)
Total iast 10.899 s 508.359 ms (4.9%)
Total profiling 10.826 s 435.421 ms (4.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.085 s -
Agent appsec 1.218 s 132.967 ms (12.3%)
Agent iast 1.209 s 123.499 ms (11.4%)
Agent profiling 1.283 s 197.435 ms (18.2%)
Total tracing 10.434 s -
Total appsec 10.654 s 219.931 ms (2.1%)
Total iast 10.933 s 499.45 ms (4.8%)
Total profiling 10.787 s 353.283 ms (3.4%) 
gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~ba91d0b1cf, baseline=1.43.0-SNAPSHOT~21c0b2df63

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.691 ms) : 0, 687691
BytebuddyAgent [candidate] (689.303 ms) : 0, 689303
GlobalTracer [baseline] (316.298 ms) : 0, 316298
GlobalTracer [candidate] (316.608 ms) : 0, 316608
AppSec [baseline] (54.326 ms) : 0, 54326
AppSec [candidate] (54.358 ms) : 0, 54358
Remote Config [baseline] (661.592 µs) : 0, 662
Remote Config [candidate] (662.278 µs) : 0, 662
Telemetry [baseline] (9.15 ms) : 0, 9150
Telemetry [candidate] (10.56 ms) : 0, 10560
section appsec
BytebuddyAgent [baseline] (708.862 ms) : 0, 708862
BytebuddyAgent [candidate] (706.167 ms) : 0, 706167
GlobalTracer [baseline] (314.512 ms) : 0, 314512
GlobalTracer [candidate] (313.487 ms) : 0, 313487
AppSec [baseline] (165.62 ms) : 0, 165620
AppSec [candidate] (166.776 ms) : 0, 166776
IAST [baseline] (20.07 ms) : 0, 20070
IAST [candidate] (18.633 ms) : 0, 18633
Remote Config [baseline] (640.453 µs) : 0, 640
Remote Config [candidate] (633.865 µs) : 0, 634
Telemetry [baseline] (8.175 ms) : 0, 8175
Telemetry [candidate] (8.108 ms) : 0, 8108
section iast
BytebuddyAgent [baseline] (804.742 ms) : 0, 804742
BytebuddyAgent [candidate] (803.826 ms) : 0, 803826
GlobalTracer [baseline] (305.112 ms) : 0, 305112
GlobalTracer [candidate] (304.612 ms) : 0, 304612
AppSec [baseline] (57.527 ms) : 0, 57527
AppSec [candidate] (56.199 ms) : 0, 56199
IAST [baseline] (20.776 ms) : 0, 20776
IAST [candidate] (22.264 ms) : 0, 22264
Remote Config [baseline] (611.409 µs) : 0, 611
Remote Config [candidate] (611.541 µs) : 0, 612
Telemetry [baseline] (7.487 ms) : 0, 7487
Telemetry [candidate] (7.494 ms) : 0, 7494
section profiling
BytebuddyAgent [baseline] (682.979 ms) : 0, 682979
BytebuddyAgent [candidate] (682.281 ms) : 0, 682281
GlobalTracer [baseline] (399.915 ms) : 0, 399915
GlobalTracer [candidate] (400.91 ms) : 0, 400910
AppSec [baseline] (54.869 ms) : 0, 54869
AppSec [candidate] (54.627 ms) : 0, 54627
Remote Config [baseline] (692.38 µs) : 0, 692
Remote Config [candidate] (678.002 µs) : 0, 678
Telemetry [baseline] (12.903 ms) : 0, 12903
Telemetry [candidate] (13.522 ms) : 0, 13522
ProfilingAgent [baseline] (92.542 ms) : 0, 92542
ProfilingAgent [candidate] (91.601 ms) : 0, 91601
Profiling [baseline] (92.565 ms) : 0, 92565
Profiling [candidate] (91.624 ms) : 0, 91624
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-05T17:56:08 2024-11-05T18:05:17
git_branch master jean-philippe.bempel/backport-pr-7885
git_commit_date 1730827777 1730828765
git_commit_sha 21c0b2d ba91d0b
release_version 1.43.0-SNAPSHOT~21c0b2df63 1.43.0-SNAPSHOT~ba91d0b1cf
start_time 2024-11-05T17:55:52 2024-11-05T18:05:00
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1730830382 1730830382
ci_job_id 696179023 696179023
ci_pipeline_id 48282817 48282817
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 7 metrics, 21 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~ba91d0b1cf, baseline=1.43.0-SNAPSHOT~21c0b2df63
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.689 ms) : 1663, 1715
.   : milestone, 1689,
appsec (2.173 ms) : 2142, 2205
.   : milestone, 2173,
appsec_no_iast (2.172 ms) : 2141, 2204
.   : milestone, 2172,
iast (1.851 ms) : 1822, 1881
.   : milestone, 1851,
profiling (1.953 ms) : 1919, 1988
.   : milestone, 1953,
tracing (1.883 ms) : 1850, 1915
.   : milestone, 1883,
section candidate
no_agent (1.728 ms) : 1702, 1753
.   : milestone, 1728,
appsec (2.209 ms) : 2179, 2239
.   : milestone, 2209,
appsec_no_iast (2.22 ms) : 2187, 2253
.   : milestone, 2220,
iast (1.885 ms) : 1854, 1915
.   : milestone, 1885,
profiling (1.937 ms) : 1903, 1970
.   : milestone, 1937,
tracing (1.887 ms) : 1856, 1919
.   : milestone, 1887,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.689 ms [1.663 ms, 1.715 ms] -
appsec 2.173 ms [2.142 ms, 2.205 ms] 484.048 µs (28.7%)
appsec_no_iast 2.172 ms [2.141 ms, 2.204 ms] 483.077 µs (28.6%)
iast 1.851 ms [1.822 ms, 1.881 ms] 162.081 µs (9.6%)
profiling 1.953 ms [1.919 ms, 1.988 ms] 264.091 µs (15.6%)
tracing 1.883 ms [1.85 ms, 1.915 ms] 193.319 µs (11.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.728 ms [1.702 ms, 1.753 ms] -
appsec 2.209 ms [2.179 ms, 2.239 ms] 481.606 µs (27.9%)
appsec_no_iast 2.22 ms [2.187 ms, 2.253 ms] 492.235 µs (28.5%)
iast 1.885 ms [1.854 ms, 1.915 ms] 156.924 µs (9.1%)
profiling 1.937 ms [1.903 ms, 1.97 ms] 209.096 µs (12.1%)
tracing 1.887 ms [1.856 ms, 1.919 ms] 159.639 µs (9.2%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~ba91d0b1cf, baseline=1.43.0-SNAPSHOT~21c0b2df63
    dateFormat X
    axisFormat %s
section baseline
no_agent (452.936 µs) : 424, 482
.   : milestone, 453,
iast (586.655 µs) : 555, 619
.   : milestone, 587,
iast_FULL (835.129 µs) : 802, 868
.   : milestone, 835,
iast_GLOBAL (620.685 µs) : 588, 653
.   : milestone, 621,
iast_HARDCODED_SECRET_DISABLED (589.725 µs) : 557, 622
.   : milestone, 590,
iast_INACTIVE (541.342 µs) : 511, 572
.   : milestone, 541,
iast_TELEMETRY_OFF (573.801 µs) : 542, 606
.   : milestone, 574,
tracing (533.85 µs) : 504, 564
.   : milestone, 534,
section candidate
no_agent (455.799 µs) : 426, 485
.   : milestone, 456,
iast (600.882 µs) : 568, 634
.   : milestone, 601,
iast_FULL (836.208 µs) : 803, 869
.   : milestone, 836,
iast_GLOBAL (624.102 µs) : 591, 657
.   : milestone, 624,
iast_HARDCODED_SECRET_DISABLED (592.251 µs) : 560, 625
.   : milestone, 592,
iast_INACTIVE (546.046 µs) : 515, 577
.   : milestone, 546,
iast_TELEMETRY_OFF (576.453 µs) : 544, 609
.   : milestone, 576,
tracing (532.393 µs) : 502, 562
.   : milestone, 532,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 452.936 µs [423.834 µs, 482.039 µs] -
iast 586.655 µs [554.81 µs, 618.501 µs] 133.719 µs (29.5%)
iast_FULL 835.129 µs [802.067 µs, 868.192 µs] 382.193 µs (84.4%)
iast_GLOBAL 620.685 µs [588.478 µs, 652.892 µs] 167.749 µs (37.0%)
iast_HARDCODED_SECRET_DISABLED 589.725 µs [557.266 µs, 622.184 µs] 136.789 µs (30.2%)
iast_INACTIVE 541.342 µs [510.916 µs, 571.769 µs] 88.406 µs (19.5%)
iast_TELEMETRY_OFF 573.801 µs [541.527 µs, 606.076 µs] 120.865 µs (26.7%)
tracing 533.85 µs [503.809 µs, 563.892 µs] 80.914 µs (17.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 455.799 µs [426.414 µs, 485.183 µs] -
iast 600.882 µs [568.231 µs, 633.533 µs] 145.083 µs (31.8%)
iast_FULL 836.208 µs [803.31 µs, 869.106 µs] 380.409 µs (83.5%)
iast_GLOBAL 624.102 µs [591.184 µs, 657.021 µs] 168.304 µs (36.9%)
iast_HARDCODED_SECRET_DISABLED 592.251 µs [559.544 µs, 624.959 µs] 136.453 µs (29.9%)
iast_INACTIVE 546.046 µs [515.43 µs, 576.662 µs] 90.247 µs (19.8%)
iast_TELEMETRY_OFF 576.453 µs [544.094 µs, 608.811 µs] 120.654 µs (26.5%)
tracing 532.393 µs [502.478 µs, 562.308 µs] 76.595 µs (16.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jean-philippe.bempel/backport-pr-7885
git_commit_date 1730827777 1730828765
git_commit_sha 21c0b2d ba91d0b
release_version 1.43.0-SNAPSHOT~21c0b2df63 1.43.0-SNAPSHOT~ba91d0b1cf
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1730831272 1730831272
ci_job_id 696179024 696179024
ci_pipeline_id 48282817 48282817
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~ba91d0b1cf, baseline=1.43.0-SNAPSHOT~21c0b2df63
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.542 ms) : 1529, 1555
.   : milestone, 1542,
appsec (2.871 ms) : 2799, 2944
.   : milestone, 2871,
iast (2.516 ms) : 2426, 2606
.   : milestone, 2516,
iast_GLOBAL (2.579 ms) : 2488, 2669
.   : milestone, 2579,
profiling (2.344 ms) : 2268, 2421
.   : milestone, 2344,
tracing (2.297 ms) : 2226, 2368
.   : milestone, 2297,
section candidate
no_agent (1.55 ms) : 1537, 1562
.   : milestone, 1550,
appsec (2.902 ms) : 2830, 2974
.   : milestone, 2902,
iast (2.502 ms) : 2414, 2590
.   : milestone, 2502,
iast_GLOBAL (2.592 ms) : 2502, 2683
.   : milestone, 2592,
profiling (3.024 ms) : 2755, 3293
.   : milestone, 3024,
tracing (2.309 ms) : 2238, 2380
.   : milestone, 2309,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.542 ms [1.529 ms, 1.555 ms] -
appsec 2.871 ms [2.799 ms, 2.944 ms] 1.329 ms (86.2%)
iast 2.516 ms [2.426 ms, 2.606 ms] 974.063 µs (63.2%)
iast_GLOBAL 2.579 ms [2.488 ms, 2.669 ms] 1.037 ms (67.2%)
profiling 2.344 ms [2.268 ms, 2.421 ms] 802.528 µs (52.0%)
tracing 2.297 ms [2.226 ms, 2.368 ms] 754.862 µs (49.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.55 ms [1.537 ms, 1.562 ms] -
appsec 2.902 ms [2.83 ms, 2.974 ms] 1.353 ms (87.3%)
iast 2.502 ms [2.414 ms, 2.59 ms] 952.32 µs (61.5%)
iast_GLOBAL 2.592 ms [2.502 ms, 2.683 ms] 1.043 ms (67.3%)
profiling 3.024 ms [2.755 ms, 3.293 ms] 1.474 ms (95.1%)
tracing 2.309 ms [2.238 ms, 2.38 ms] 758.997 µs (49.0%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~ba91d0b1cf, baseline=1.43.0-SNAPSHOT~21c0b2df63
    dateFormat X
    axisFormat %s
section baseline
no_agent (20.485 s) : 20485000, 20485000
.   : milestone, 20485000,
appsec (21.052 s) : 21052000, 21052000
.   : milestone, 21052000,
iast (24.807 s) : 24807000, 24807000
.   : milestone, 24807000,
iast_GLOBAL (25.109 s) : 25109000, 25109000
.   : milestone, 25109000,
profiling (20.923 s) : 20923000, 20923000
.   : milestone, 20923000,
tracing (21.378 s) : 21378000, 21378000
.   : milestone, 21378000,
section candidate
no_agent (20.677 s) : 20677000, 20677000
.   : milestone, 20677000,
appsec (21.424 s) : 21424000, 21424000
.   : milestone, 21424000,
iast (24.657 s) : 24657000, 24657000
.   : milestone, 24657000,
iast_GLOBAL (24.984 s) : 24984000, 24984000
.   : milestone, 24984000,
profiling (21.206 s) : 21206000, 21206000
.   : milestone, 21206000,
tracing (21.133 s) : 21133000, 21133000
.   : milestone, 21133000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 20.485 s [20.485 s, 20.485 s] -
appsec 21.052 s [21.052 s, 21.052 s] 567.0 ms (2.8%)
iast 24.807 s [24.807 s, 24.807 s] 4.322 s (21.1%)
iast_GLOBAL 25.109 s [25.109 s, 25.109 s] 4.624 s (22.6%)
profiling 20.923 s [20.923 s, 20.923 s] 438.0 ms (2.1%)
tracing 21.378 s [21.378 s, 21.378 s] 893.0 ms (4.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 20.677 s [20.677 s, 20.677 s] -
appsec 21.424 s [21.424 s, 21.424 s] 747.0 ms (3.6%)
iast 24.657 s [24.657 s, 24.657 s] 3.98 s (19.2%)
iast_GLOBAL 24.984 s [24.984 s, 24.984 s] 4.307 s (20.8%)
profiling 21.206 s [21.206 s, 21.206 s] 529.0 ms (2.6%)
tracing 21.133 s [21.133 s, 21.133 s] 456.0 ms (2.2%)

@ygree ygree changed the base branch from release/v1.42.x to release/v1.42.1.DO_NOT_USE November 5, 2024 19:09
@ygree ygree changed the base branch from release/v1.42.1.DO_NOT_USE to release/v1.42.x November 5, 2024 19:10
@jpbempel jpbempel closed this Nov 5, 2024
@jpbempel jpbempel reopened this Nov 5, 2024
@jpbempel jpbempel closed this Nov 5, 2024
@PerfectSlayer PerfectSlayer removed this from the 1.42.1 milestone Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shatzi shatzi Awaiting requested review from shatzi shatzi is a code owner automatically assigned from DataDog/debugger-java

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpbempel @PerfectSlayer @ygree