Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing test for JarReader with trailing separator #7929

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Add missing test for JarReader with trailing separator #7929

merged 1 commit into from
Nov 11, 2024

Conversation

smola
Copy link
Member

@smola smola commented Nov 11, 2024 •
edited by jira bot
Loading

What Does This Do

Add missing test case for JarReader for nested jar path with trailing !/.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: APPSEC-55773 (related)

@smola smola added tag: no release notes Changes to exclude from release notes comp: telemetry Telemetry labels Nov 11, 2024
@smola smola requested a review from a team as a code owner November 11, 2024 13:37
@pr-commenter
Copy link

pr-commenter bot commented Nov 11, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/telemetry-jarreader-nested-ending-sep
git_commit_date 1731085528 1731332200
git_commit_sha 9e8d0dc 0179ac5
release_version 1.43.0-SNAPSHOT~9e8d0dcb45 1.43.0-SNAPSHOT~0179ac5d07
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1731334585 1731334585
ci_job_id 702145399 702145399
ci_pipeline_id 48693863 48693863
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~0179ac5d07, baseline=1.43.0-SNAPSHOT~9e8d0dcb45

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1080193
Total [baseline] (10.334 s) : 0, 10333773
Agent [candidate] (1.083 s) : 0, 1083139
Total [candidate] (10.395 s) : 0, 10394588
section appsec
Agent [baseline] (1.216 s) : 0, 1216431
Total [baseline] (10.629 s) : 0, 10629031
Agent [candidate] (1.213 s) : 0, 1213082
Total [candidate] (10.626 s) : 0, 10626165
section iast
Agent [baseline] (1.204 s) : 0, 1204014
Total [baseline] (10.903 s) : 0, 10902516
Agent [candidate] (1.204 s) : 0, 1203848
Total [candidate] (10.882 s) : 0, 10882328
section profiling
Agent [baseline] (1.284 s) : 0, 1284457
Total [baseline] (10.737 s) : 0, 10736683
Agent [candidate] (1.277 s) : 0, 1276814
Total [candidate] (10.662 s) : 0, 10661590
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent appsec 1.216 s 136.239 ms (12.6%)
Agent iast 1.204 s 123.821 ms (11.5%)
Agent profiling 1.284 s 204.265 ms (18.9%)
Total tracing 10.334 s -
Total appsec 10.629 s 295.258 ms (2.9%)
Total iast 10.903 s 568.743 ms (5.5%)
Total profiling 10.737 s 402.91 ms (3.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.083 s -
Agent appsec 1.213 s 129.943 ms (12.0%)
Agent iast 1.204 s 120.709 ms (11.1%)
Agent profiling 1.277 s 193.675 ms (17.9%)
Total tracing 10.395 s -
Total appsec 10.626 s 231.577 ms (2.2%)
Total iast 10.882 s 487.74 ms (4.7%)
Total profiling 10.662 s 267.001 ms (2.6%) 
gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~0179ac5d07, baseline=1.43.0-SNAPSHOT~9e8d0dcb45

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.319 ms) : 0, 686319
BytebuddyAgent [candidate] (687.087 ms) : 0, 687087
GlobalTracer [baseline] (314.808 ms) : 0, 314808
GlobalTracer [candidate] (315.548 ms) : 0, 315548
AppSec [baseline] (54.176 ms) : 0, 54176
AppSec [candidate] (54.173 ms) : 0, 54173
Remote Config [baseline] (684.685 µs) : 0, 685
Remote Config [candidate] (672.684 µs) : 0, 673
Telemetry [baseline] (10.562 ms) : 0, 10562
Telemetry [candidate] (11.99 ms) : 0, 11990
section appsec
BytebuddyAgent [baseline] (705.043 ms) : 0, 705043
BytebuddyAgent [candidate] (702.603 ms) : 0, 702603
GlobalTracer [baseline] (313.582 ms) : 0, 313582
GlobalTracer [candidate] (312.526 ms) : 0, 312526
AppSec [baseline] (166.445 ms) : 0, 166445
AppSec [candidate] (165.451 ms) : 0, 165451
Remote Config [baseline] (631.71 µs) : 0, 632
Remote Config [candidate] (633.168 µs) : 0, 633
Telemetry [baseline] (7.382 ms) : 0, 7382
Telemetry [candidate] (7.749 ms) : 0, 7749
IAST [baseline] (19.352 ms) : 0, 19352
IAST [candidate] (20.965 ms) : 0, 20965
section iast
BytebuddyAgent [baseline] (800.128 ms) : 0, 800128
BytebuddyAgent [candidate] (800.647 ms) : 0, 800647
GlobalTracer [baseline] (303.893 ms) : 0, 303893
GlobalTracer [candidate] (304.388 ms) : 0, 304388
AppSec [baseline] (56.764 ms) : 0, 56764
AppSec [candidate] (56.775 ms) : 0, 56775
Remote Config [baseline] (611.879 µs) : 0, 612
Remote Config [candidate] (623.027 µs) : 0, 623
Telemetry [baseline] (7.488 ms) : 0, 7488
Telemetry [candidate] (7.349 ms) : 0, 7349
IAST [baseline] (21.474 ms) : 0, 21474
IAST [candidate] (20.397 ms) : 0, 20397
section profiling
BytebuddyAgent [baseline] (684.453 ms) : 0, 684453
BytebuddyAgent [candidate] (680.208 ms) : 0, 680208
GlobalTracer [baseline] (400.904 ms) : 0, 400904
GlobalTracer [candidate] (398.823 ms) : 0, 398823
AppSec [baseline] (54.878 ms) : 0, 54878
AppSec [candidate] (54.434 ms) : 0, 54434
Remote Config [baseline] (670.666 µs) : 0, 671
Remote Config [candidate] (669.123 µs) : 0, 669
Telemetry [baseline] (13.968 ms) : 0, 13968
Telemetry [candidate] (12.738 ms) : 0, 12738
ProfilingAgent [baseline] (90.485 ms) : 0, 90485
ProfilingAgent [candidate] (91.08 ms) : 0, 91080
Profiling [baseline] (90.509 ms) : 0, 90509
Profiling [candidate] (91.104 ms) : 0, 91104
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~0179ac5d07, baseline=1.43.0-SNAPSHOT~9e8d0dcb45

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1084035
Total [baseline] (8.63 s) : 0, 8629535
Agent [candidate] (1.08 s) : 0, 1080157
Total [candidate] (8.592 s) : 0, 8591673
section iast
Agent [baseline] (1.205 s) : 0, 1204718
Total [baseline] (9.154 s) : 0, 9154231
Agent [candidate] (1.204 s) : 0, 1204293
Total [candidate] (9.126 s) : 0, 9126181
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.205 s) : 0, 1205400
Total [baseline] (9.067 s) : 0, 9066644
Agent [candidate] (1.205 s) : 0, 1205161
Total [candidate] (9.12 s) : 0, 9120482
section iast_TELEMETRY_OFF
Agent [baseline] (1.2 s) : 0, 1199845
Total [baseline] (9.077 s) : 0, 9076959
Agent [candidate] (1.211 s) : 0, 1211164
Total [candidate] (9.109 s) : 0, 9108599
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.084 s -
Agent iast 1.205 s 120.683 ms (11.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.205 s 121.364 ms (11.2%)
Agent iast_TELEMETRY_OFF 1.2 s 115.81 ms (10.7%)
Total tracing 8.63 s -
Total iast 9.154 s 524.696 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.067 s 437.109 ms (5.1%)
Total iast_TELEMETRY_OFF 9.077 s 447.424 ms (5.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent iast 1.204 s 124.136 ms (11.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.205 s 125.004 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.211 s 131.007 ms (12.1%)
Total tracing 8.592 s -
Total iast 9.126 s 534.508 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.12 s 528.81 ms (6.2%)
Total iast_TELEMETRY_OFF 9.109 s 516.926 ms (6.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~0179ac5d07, baseline=1.43.0-SNAPSHOT~9e8d0dcb45

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.292 ms) : 0, 687292
BytebuddyAgent [candidate] (686.437 ms) : 0, 686437
GlobalTracer [baseline] (317.035 ms) : 0, 317035
GlobalTracer [candidate] (315.342 ms) : 0, 315342
AppSec [baseline] (54.056 ms) : 0, 54056
AppSec [candidate] (54.084 ms) : 0, 54084
Remote Config [baseline] (668.414 µs) : 0, 668
Remote Config [candidate] (671.348 µs) : 0, 671
Telemetry [baseline] (11.325 ms) : 0, 11325
Telemetry [candidate] (9.925 ms) : 0, 9925
section iast
BytebuddyAgent [baseline] (801.496 ms) : 0, 801496
BytebuddyAgent [candidate] (801.002 ms) : 0, 801002
GlobalTracer [baseline] (304.187 ms) : 0, 304187
GlobalTracer [candidate] (303.677 ms) : 0, 303677
AppSec [baseline] (57.194 ms) : 0, 57194
AppSec [candidate] (56.498 ms) : 0, 56498
IAST [baseline] (20.269 ms) : 0, 20269
IAST [candidate] (21.355 ms) : 0, 21355
Remote Config [baseline] (608.154 µs) : 0, 608
Remote Config [candidate] (619.447 µs) : 0, 619
Telemetry [baseline] (7.305 ms) : 0, 7305
Telemetry [candidate] (7.469 ms) : 0, 7469
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (801.328 ms) : 0, 801328
BytebuddyAgent [candidate] (801.326 ms) : 0, 801326
GlobalTracer [baseline] (304.608 ms) : 0, 304608
GlobalTracer [candidate] (304.453 ms) : 0, 304453
AppSec [baseline] (56.548 ms) : 0, 56548
AppSec [candidate] (57.023 ms) : 0, 57023
IAST [baseline] (21.207 ms) : 0, 21207
IAST [candidate] (20.608 ms) : 0, 20608
Remote Config [baseline] (586.594 µs) : 0, 587
Remote Config [candidate] (600.706 µs) : 0, 601
Telemetry [baseline] (7.451 ms) : 0, 7451
Telemetry [candidate] (7.468 ms) : 0, 7468
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (797.338 ms) : 0, 797338
BytebuddyAgent [candidate] (805.277 ms) : 0, 805277
GlobalTracer [baseline] (303.177 ms) : 0, 303177
GlobalTracer [candidate] (306.449 ms) : 0, 306449
AppSec [baseline] (56.604 ms) : 0, 56604
AppSec [candidate] (56.911 ms) : 0, 56911
IAST [baseline] (21.126 ms) : 0, 21126
IAST [candidate] (20.799 ms) : 0, 20799
Remote Config [baseline] (614.319 µs) : 0, 614
Remote Config [candidate] (595.152 µs) : 0, 595
Telemetry [baseline] (7.368 ms) : 0, 7368
Telemetry [candidate] (7.344 ms) : 0, 7344
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-11T13:46:59 2024-11-11T13:53:54
git_branch master smola/telemetry-jarreader-nested-ending-sep
git_commit_date 1731085528 1731332200
git_commit_sha 9e8d0dc 0179ac5
release_version 1.43.0-SNAPSHOT~9e8d0dcb45 1.43.0-SNAPSHOT~0179ac5d07
start_time 2024-11-11T13:46:46 2024-11-11T13:53:41
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1731333584 1731333584
ci_job_id 702145400 702145400
ci_pipeline_id 48693863 48693863
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~0179ac5d07, baseline=1.43.0-SNAPSHOT~9e8d0dcb45
    dateFormat X
    axisFormat %s
section baseline
no_agent (366.788 µs) : 347, 386
.   : milestone, 367,
iast (488.908 µs) : 468, 510
.   : milestone, 489,
iast_FULL (644.264 µs) : 623, 666
.   : milestone, 644,
iast_GLOBAL (513.987 µs) : 493, 535
.   : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (495.599 µs) : 474, 517
.   : milestone, 496,
iast_INACTIVE (451.55 µs) : 430, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (472.058 µs) : 451, 493
.   : milestone, 472,
tracing (443.842 µs) : 423, 464
.   : milestone, 444,
section candidate
no_agent (374.605 µs) : 355, 394
.   : milestone, 375,
iast (486.843 µs) : 465, 508
.   : milestone, 487,
iast_FULL (646.75 µs) : 625, 668
.   : milestone, 647,
iast_GLOBAL (509.772 µs) : 489, 531
.   : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (485.588 µs) : 464, 507
.   : milestone, 486,
iast_INACTIVE (446.458 µs) : 426, 467
.   : milestone, 446,
iast_TELEMETRY_OFF (477.854 µs) : 456, 499
.   : milestone, 478,
tracing (451.674 µs) : 430, 473
.   : milestone, 452,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.788 µs [347.11 µs, 386.465 µs] -
iast 488.908 µs [467.557 µs, 510.259 µs] 122.12 µs (33.3%)
iast_FULL 644.264 µs [622.979 µs, 665.548 µs] 277.476 µs (75.7%)
iast_GLOBAL 513.987 µs [492.906 µs, 535.067 µs] 147.199 µs (40.1%)
iast_HARDCODED_SECRET_DISABLED 495.599 µs [474.391 µs, 516.808 µs] 128.812 µs (35.1%)
iast_INACTIVE 451.55 µs [430.002 µs, 473.098 µs] 84.763 µs (23.1%)
iast_TELEMETRY_OFF 472.058 µs [451.236 µs, 492.88 µs] 105.27 µs (28.7%)
tracing 443.842 µs [423.311 µs, 464.373 µs] 77.054 µs (21.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.605 µs [355.114 µs, 394.096 µs] -
iast 486.843 µs [465.376 µs, 508.309 µs] 112.238 µs (30.0%)
iast_FULL 646.75 µs [625.229 µs, 668.27 µs] 272.145 µs (72.6%)
iast_GLOBAL 509.772 µs [488.558 µs, 530.986 µs] 135.167 µs (36.1%)
iast_HARDCODED_SECRET_DISABLED 485.588 µs [464.088 µs, 507.088 µs] 110.983 µs (29.6%)
iast_INACTIVE 446.458 µs [426.087 µs, 466.828 µs] 71.853 µs (19.2%)
iast_TELEMETRY_OFF 477.854 µs [456.427 µs, 499.28 µs] 103.249 µs (27.6%)
tracing 451.674 µs [430.447 µs, 472.902 µs] 77.069 µs (20.6%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~0179ac5d07, baseline=1.43.0-SNAPSHOT~9e8d0dcb45
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.334 ms) : 1315, 1352
.   : milestone, 1334,
appsec (1.725 ms) : 1701, 1749
.   : milestone, 1725,
appsec_no_iast (1.729 ms) : 1704, 1753
.   : milestone, 1729,
iast (1.483 ms) : 1461, 1506
.   : milestone, 1483,
profiling (1.491 ms) : 1468, 1514
.   : milestone, 1491,
tracing (1.494 ms) : 1469, 1520
.   : milestone, 1494,
section candidate
no_agent (1.351 ms) : 1332, 1370
.   : milestone, 1351,
appsec (1.734 ms) : 1710, 1759
.   : milestone, 1734,
appsec_no_iast (1.723 ms) : 1699, 1747
.   : milestone, 1723,
iast (1.489 ms) : 1466, 1512
.   : milestone, 1489,
profiling (1.504 ms) : 1480, 1529
.   : milestone, 1504,
tracing (1.466 ms) : 1442, 1490
.   : milestone, 1466,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.334 ms [1.315 ms, 1.352 ms] -
appsec 1.725 ms [1.701 ms, 1.749 ms] 391.541 µs (29.4%)
appsec_no_iast 1.729 ms [1.704 ms, 1.753 ms] 394.855 µs (29.6%)
iast 1.483 ms [1.461 ms, 1.506 ms] 149.587 µs (11.2%)
profiling 1.491 ms [1.468 ms, 1.514 ms] 157.205 µs (11.8%)
tracing 1.494 ms [1.469 ms, 1.52 ms] 160.649 µs (12.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.351 ms [1.332 ms, 1.37 ms] -
appsec 1.734 ms [1.71 ms, 1.759 ms] 383.355 µs (28.4%)
appsec_no_iast 1.723 ms [1.699 ms, 1.747 ms] 371.763 µs (27.5%)
iast 1.489 ms [1.466 ms, 1.512 ms] 137.711 µs (10.2%)
profiling 1.504 ms [1.48 ms, 1.529 ms] 153.096 µs (11.3%)
tracing 1.466 ms [1.442 ms, 1.49 ms] 114.625 µs (8.5%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/telemetry-jarreader-nested-ending-sep
git_commit_date 1731085528 1731332200
git_commit_sha 9e8d0dc 0179ac5
release_version 1.43.0-SNAPSHOT~9e8d0dcb45 1.43.0-SNAPSHOT~0179ac5d07
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1731334126 1731334126
ci_job_id 702145401 702145401
ci_pipeline_id 48693863 48693863
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~0179ac5d07, baseline=1.43.0-SNAPSHOT~9e8d0dcb45
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
.   : milestone, 1469,
appsec (2.341 ms) : 2300, 2382
.   : milestone, 2341,
iast (2.078 ms) : 2026, 2131
.   : milestone, 2078,
iast_GLOBAL (2.123 ms) : 2070, 2175
.   : milestone, 2123,
profiling (1.939 ms) : 1896, 1981
.   : milestone, 1939,
tracing (1.918 ms) : 1878, 1958
.   : milestone, 1918,
section candidate
no_agent (1.475 ms) : 1463, 1486
.   : milestone, 1475,
appsec (2.349 ms) : 2308, 2391
.   : milestone, 2349,
iast (2.084 ms) : 2032, 2136
.   : milestone, 2084,
iast_GLOBAL (2.123 ms) : 2070, 2175
.   : milestone, 2123,
profiling (1.949 ms) : 1907, 1991
.   : milestone, 1949,
tracing (1.929 ms) : 1889, 1969
.   : milestone, 1929,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.458 ms, 1.481 ms] -
appsec 2.341 ms [2.3 ms, 2.382 ms] 871.605 µs (59.3%)
iast 2.078 ms [2.026 ms, 2.131 ms] 608.713 µs (41.4%)
iast_GLOBAL 2.123 ms [2.07 ms, 2.175 ms] 653.427 µs (44.5%)
profiling 1.939 ms [1.896 ms, 1.981 ms] 469.118 µs (31.9%)
tracing 1.918 ms [1.878 ms, 1.958 ms] 448.366 µs (30.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.475 ms [1.463 ms, 1.486 ms] -
appsec 2.349 ms [2.308 ms, 2.391 ms] 874.842 µs (59.3%)
iast 2.084 ms [2.032 ms, 2.136 ms] 609.2 µs (41.3%)
iast_GLOBAL 2.123 ms [2.07 ms, 2.175 ms] 648.218 µs (44.0%)
profiling 1.949 ms [1.907 ms, 1.991 ms] 474.735 µs (32.2%)
tracing 1.929 ms [1.889 ms, 1.969 ms] 454.661 µs (30.8%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~0179ac5d07, baseline=1.43.0-SNAPSHOT~9e8d0dcb45
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.094 s) : 15094000, 15094000
.   : milestone, 15094000,
appsec (15.363 s) : 15363000, 15363000
.   : milestone, 15363000,
iast (18.253 s) : 18253000, 18253000
.   : milestone, 18253000,
iast_GLOBAL (18.013 s) : 18013000, 18013000
.   : milestone, 18013000,
profiling (15.569 s) : 15569000, 15569000
.   : milestone, 15569000,
tracing (15.35 s) : 15350000, 15350000
.   : milestone, 15350000,
section candidate
no_agent (15.256 s) : 15256000, 15256000
.   : milestone, 15256000,
appsec (15.331 s) : 15331000, 15331000
.   : milestone, 15331000,
iast (18.398 s) : 18398000, 18398000
.   : milestone, 18398000,
iast_GLOBAL (17.973 s) : 17973000, 17973000
.   : milestone, 17973000,
profiling (14.849 s) : 14849000, 14849000
.   : milestone, 14849000,
tracing (14.917 s) : 14917000, 14917000
.   : milestone, 14917000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.094 s [15.094 s, 15.094 s] -
appsec 15.363 s [15.363 s, 15.363 s] 269.0 ms (1.8%)
iast 18.253 s [18.253 s, 18.253 s] 3.159 s (20.9%)
iast_GLOBAL 18.013 s [18.013 s, 18.013 s] 2.919 s (19.3%)
profiling 15.569 s [15.569 s, 15.569 s] 475.0 ms (3.1%)
tracing 15.35 s [15.35 s, 15.35 s] 256.0 ms (1.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.256 s [15.256 s, 15.256 s] -
appsec 15.331 s [15.331 s, 15.331 s] 75.0 ms (0.5%)
iast 18.398 s [18.398 s, 18.398 s] 3.142 s (20.6%)
iast_GLOBAL 17.973 s [17.973 s, 17.973 s] 2.717 s (17.8%)
profiling 14.849 s [14.849 s, 14.849 s] -407.0 ms (-2.7%)
tracing 14.917 s [14.917 s, 14.917 s] -339.0 ms (-2.2%)

@smola smola merged commit 31bfaf7 into master Nov 11, 2024
108 checks passed
@smola smola deleted the smola/telemetry-jarreader-nested-ending-sep branch November 11, 2024 15:52
@github-actions github-actions bot added this to the 1.43.0 milestone Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariovido Mariovido Mariovido approved these changes

@manuel-alvarez-alvarez manuel-alvarez-alvarez Awaiting requested review from manuel-alvarez-alvarez manuel-alvarez-alvarez is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: telemetry Telemetry tag: no release notes Changes to exclude from release notes
Projects
None yet
Milestone
1.43.0
Development

Successfully merging this pull request may close these issues.
2 participants
@smola @Mariovido