Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude dev.failsafe from IAST instrumentation #7938

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Exclude dev.failsafe from IAST instrumentation #7938

merged 1 commit into from
Nov 13, 2024

Conversation

smola
Copy link
Member

@smola smola commented Nov 12, 2024 •
edited by jira bot
Loading

What Does This Do

Exclude IAST instrumentation from dev.failsafe.*.

Motivation

Avoids weak randomness false positive. Instrumentation fully exclude since there's little value in running for this library (retry operations).

Additional Notes

Contributor Checklist

Jira ticket: APPSEC-55801

@smola smola added the comp: asm iast Application Security Management (IAST) label Nov 12, 2024
@smola smola requested a review from a team as a code owner November 12, 2024 16:34
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited
Loading

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@pr-commenter
Copy link

pr-commenter bot commented Nov 12, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/exclude-dev-failsafe
git_commit_date 1731426404 1731429109
git_commit_sha cb6a6fc c7ded8b
release_version 1.43.0-SNAPSHOT~cb6a6fcd72 1.43.0-SNAPSHOT~c7ded8b5a1
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1731431411 1731431411
ci_job_id 704019896 704019896
ci_pipeline_id 48817313 48817313
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~c7ded8b5a1, baseline=1.43.0-SNAPSHOT~cb6a6fcd72

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.092 s) : 0, 1091676
Total [baseline] (8.608 s) : 0, 8607823
Agent [candidate] (1.082 s) : 0, 1081548
Total [candidate] (8.566 s) : 0, 8565844
section iast
Agent [baseline] (1.219 s) : 0, 1219164
Total [baseline] (9.15 s) : 0, 9150476
Agent [candidate] (1.213 s) : 0, 1212975
Total [candidate] (9.112 s) : 0, 9112053
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.204 s) : 0, 1204257
Total [baseline] (9.061 s) : 0, 9061345
Agent [candidate] (1.214 s) : 0, 1214183
Total [candidate] (9.096 s) : 0, 9096141
section iast_TELEMETRY_OFF
Agent [baseline] (1.204 s) : 0, 1204089
Total [baseline] (9.116 s) : 0, 9116225
Agent [candidate] (1.203 s) : 0, 1203060
Total [candidate] (9.109 s) : 0, 9108747
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.092 s -
Agent iast 1.219 s 127.488 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.204 s 112.581 ms (10.3%)
Agent iast_TELEMETRY_OFF 1.204 s 112.413 ms (10.3%)
Total tracing 8.608 s -
Total iast 9.15 s 542.653 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.061 s 453.522 ms (5.3%)
Total iast_TELEMETRY_OFF 9.116 s 508.402 ms (5.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.082 s -
Agent iast 1.213 s 131.426 ms (12.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.214 s 132.635 ms (12.3%)
Agent iast_TELEMETRY_OFF 1.203 s 121.512 ms (11.2%)
Total tracing 8.566 s -
Total iast 9.112 s 546.209 ms (6.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.096 s 530.297 ms (6.2%)
Total iast_TELEMETRY_OFF 9.109 s 542.902 ms (6.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~c7ded8b5a1, baseline=1.43.0-SNAPSHOT~cb6a6fcd72

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (694.46 ms) : 0, 694460
BytebuddyAgent [candidate] (686.847 ms) : 0, 686847
GlobalTracer [baseline] (316.895 ms) : 0, 316895
GlobalTracer [candidate] (315.725 ms) : 0, 315725
AppSec [baseline] (54.319 ms) : 0, 54319
AppSec [candidate] (53.949 ms) : 0, 53949
Remote Config [baseline] (686.248 µs) : 0, 686
Remote Config [candidate] (681.121 µs) : 0, 681
Telemetry [baseline] (11.459 ms) : 0, 11459
Telemetry [candidate] (10.651 ms) : 0, 10651
section iast
BytebuddyAgent [baseline] (813.088 ms) : 0, 813088
BytebuddyAgent [candidate] (806.907 ms) : 0, 806907
GlobalTracer [baseline] (306.608 ms) : 0, 306608
GlobalTracer [candidate] (305.996 ms) : 0, 305996
AppSec [baseline] (57.191 ms) : 0, 57191
AppSec [candidate] (57.602 ms) : 0, 57602
IAST [baseline] (20.429 ms) : 0, 20429
IAST [candidate] (20.616 ms) : 0, 20616
Remote Config [baseline] (612.271 µs) : 0, 612
Remote Config [candidate] (614.744 µs) : 0, 615
Telemetry [baseline] (7.38 ms) : 0, 7380
Telemetry [candidate] (7.483 ms) : 0, 7483
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (800.413 ms) : 0, 800413
BytebuddyAgent [candidate] (807.285 ms) : 0, 807285
GlobalTracer [baseline] (303.955 ms) : 0, 303955
GlobalTracer [candidate] (306.425 ms) : 0, 306425
AppSec [baseline] (55.191 ms) : 0, 55191
AppSec [candidate] (56.164 ms) : 0, 56164
IAST [baseline] (23.01 ms) : 0, 23010
IAST [candidate] (22.422 ms) : 0, 22422
Remote Config [baseline] (597.938 µs) : 0, 598
Remote Config [candidate] (613.138 µs) : 0, 613
Telemetry [baseline] (7.429 ms) : 0, 7429
Telemetry [candidate] (7.511 ms) : 0, 7511
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (800.109 ms) : 0, 800109
BytebuddyAgent [candidate] (799.177 ms) : 0, 799177
GlobalTracer [baseline] (304.168 ms) : 0, 304168
GlobalTracer [candidate] (304.456 ms) : 0, 304456
AppSec [baseline] (56.216 ms) : 0, 56216
AppSec [candidate] (57.512 ms) : 0, 57512
IAST [baseline] (21.899 ms) : 0, 21899
IAST [candidate] (20.239 ms) : 0, 20239
Remote Config [baseline] (605.487 µs) : 0, 605
Remote Config [candidate] (601.709 µs) : 0, 602
Telemetry [baseline] (7.432 ms) : 0, 7432
Telemetry [candidate] (7.388 ms) : 0, 7388
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~c7ded8b5a1, baseline=1.43.0-SNAPSHOT~cb6a6fcd72

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.103 s) : 0, 1102785
Total [baseline] (10.438 s) : 0, 10437767
Agent [candidate] (1.092 s) : 0, 1092096
Total [candidate] (10.41 s) : 0, 10410261
section appsec
Agent [baseline] (1.216 s) : 0, 1216093
Total [baseline] (10.68 s) : 0, 10680372
Agent [candidate] (1.215 s) : 0, 1214708
Total [candidate] (10.685 s) : 0, 10684681
section iast
Agent [baseline] (1.208 s) : 0, 1207654
Total [baseline] (10.941 s) : 0, 10941435
Agent [candidate] (1.217 s) : 0, 1217078
Total [candidate] (10.967 s) : 0, 10966725
section profiling
Agent [baseline] (1.275 s) : 0, 1275204
Total [baseline] (10.685 s) : 0, 10684558
Agent [candidate] (1.285 s) : 0, 1284546
Total [candidate] (10.739 s) : 0, 10739235
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.103 s -
Agent appsec 1.216 s 113.308 ms (10.3%)
Agent iast 1.208 s 104.869 ms (9.5%)
Agent profiling 1.275 s 172.419 ms (15.6%)
Total tracing 10.438 s -
Total appsec 10.68 s 242.604 ms (2.3%)
Total iast 10.941 s 503.668 ms (4.8%)
Total profiling 10.685 s 246.791 ms (2.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.092 s -
Agent appsec 1.215 s 122.611 ms (11.2%)
Agent iast 1.217 s 124.982 ms (11.4%)
Agent profiling 1.285 s 192.45 ms (17.6%)
Total tracing 10.41 s -
Total appsec 10.685 s 274.421 ms (2.6%)
Total iast 10.967 s 556.465 ms (5.3%)
Total profiling 10.739 s 328.974 ms (3.2%) 
gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~c7ded8b5a1, baseline=1.43.0-SNAPSHOT~cb6a6fcd72

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (701.206 ms) : 0, 701206
BytebuddyAgent [candidate] (693.138 ms) : 0, 693138
GlobalTracer [baseline] (322.24 ms) : 0, 322240
GlobalTracer [candidate] (320.551 ms) : 0, 320551
AppSec [baseline] (54.75 ms) : 0, 54750
AppSec [candidate] (54.69 ms) : 0, 54690
Remote Config [baseline] (676.931 µs) : 0, 677
Remote Config [candidate] (683.795 µs) : 0, 684
Telemetry [baseline] (9.946 ms) : 0, 9946
Telemetry [candidate] (9.236 ms) : 0, 9236
section appsec
BytebuddyAgent [baseline] (704.935 ms) : 0, 704935
BytebuddyAgent [candidate] (703.551 ms) : 0, 703551
GlobalTracer [baseline] (313.837 ms) : 0, 313837
GlobalTracer [candidate] (312.77 ms) : 0, 312770
AppSec [baseline] (164.778 ms) : 0, 164778
AppSec [candidate] (165.922 ms) : 0, 165922
IAST [baseline] (20.187 ms) : 0, 20187
IAST [candidate] (20.069 ms) : 0, 20069
Remote Config [baseline] (634.492 µs) : 0, 634
Remote Config [candidate] (641.004 µs) : 0, 641
Telemetry [baseline] (8.165 ms) : 0, 8165
Telemetry [candidate] (8.156 ms) : 0, 8156
section iast
BytebuddyAgent [baseline] (803.021 ms) : 0, 803021
BytebuddyAgent [candidate] (809.835 ms) : 0, 809835
GlobalTracer [baseline] (304.954 ms) : 0, 304954
GlobalTracer [candidate] (306.784 ms) : 0, 306784
AppSec [baseline] (57.363 ms) : 0, 57363
AppSec [candidate] (56.878 ms) : 0, 56878
IAST [baseline] (20.539 ms) : 0, 20539
IAST [candidate] (21.699 ms) : 0, 21699
Remote Config [baseline] (605.233 µs) : 0, 605
Remote Config [candidate] (621.564 µs) : 0, 622
Telemetry [baseline] (7.495 ms) : 0, 7495
Telemetry [candidate] (7.484 ms) : 0, 7484
section profiling
BytebuddyAgent [baseline] (678.743 ms) : 0, 678743
BytebuddyAgent [candidate] (684.472 ms) : 0, 684472
GlobalTracer [baseline] (398.553 ms) : 0, 398553
GlobalTracer [candidate] (401.446 ms) : 0, 401446
AppSec [baseline] (54.54 ms) : 0, 54540
AppSec [candidate] (54.624 ms) : 0, 54624
Remote Config [baseline] (654.114 µs) : 0, 654
Remote Config [candidate] (668.361 µs) : 0, 668
Telemetry [baseline] (11.919 ms) : 0, 11919
Telemetry [candidate] (11.884 ms) : 0, 11884
ProfilingAgent [baseline] (92.012 ms) : 0, 92012
ProfilingAgent [candidate] (92.396 ms) : 0, 92396
Profiling [baseline] (92.035 ms) : 0, 92035
Profiling [candidate] (92.419 ms) : 0, 92419
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-12T16:40:46 2024-11-12T16:47:43
git_branch master smola/exclude-dev-failsafe
git_commit_date 1731426404 1731429109
git_commit_sha cb6a6fc c7ded8b
release_version 1.43.0-SNAPSHOT~cb6a6fcd72 1.43.0-SNAPSHOT~c7ded8b5a1
start_time 2024-11-12T16:40:32 2024-11-12T16:47:29
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1731430415 1731430415
ci_job_id 704019898 704019898
ci_pipeline_id 48817313 48817313
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~c7ded8b5a1, baseline=1.43.0-SNAPSHOT~cb6a6fcd72
    dateFormat X
    axisFormat %s
section baseline
no_agent (374.75 µs) : 354, 396
.   : milestone, 375,
iast (492.664 µs) : 472, 513
.   : milestone, 493,
iast_FULL (656.278 µs) : 635, 678
.   : milestone, 656,
iast_GLOBAL (521.659 µs) : 500, 543
.   : milestone, 522,
iast_HARDCODED_SECRET_DISABLED (492.816 µs) : 471, 514
.   : milestone, 493,
iast_INACTIVE (448.47 µs) : 428, 469
.   : milestone, 448,
iast_TELEMETRY_OFF (479.439 µs) : 458, 500
.   : milestone, 479,
tracing (447.186 µs) : 427, 468
.   : milestone, 447,
section candidate
no_agent (376.03 µs) : 356, 397
.   : milestone, 376,
iast (495.633 µs) : 474, 517
.   : milestone, 496,
iast_FULL (646.599 µs) : 625, 668
.   : milestone, 647,
iast_GLOBAL (527.097 µs) : 505, 549
.   : milestone, 527,
iast_HARDCODED_SECRET_DISABLED (491.475 µs) : 470, 513
.   : milestone, 491,
iast_INACTIVE (449.11 µs) : 428, 470
.   : milestone, 449,
iast_TELEMETRY_OFF (474.735 µs) : 453, 496
.   : milestone, 475,
tracing (445.975 µs) : 425, 466
.   : milestone, 446,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.75 µs [353.999 µs, 395.5 µs] -
iast 492.664 µs [471.876 µs, 513.452 µs] 117.914 µs (31.5%)
iast_FULL 656.278 µs [634.736 µs, 677.82 µs] 281.528 µs (75.1%)
iast_GLOBAL 521.659 µs [500.102 µs, 543.216 µs] 146.909 µs (39.2%)
iast_HARDCODED_SECRET_DISABLED 492.816 µs [471.493 µs, 514.14 µs] 118.067 µs (31.5%)
iast_INACTIVE 448.47 µs [427.619 µs, 469.321 µs] 73.72 µs (19.7%)
iast_TELEMETRY_OFF 479.439 µs [458.428 µs, 500.45 µs] 104.69 µs (27.9%)
tracing 447.186 µs [426.671 µs, 467.7 µs] 72.436 µs (19.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.03 µs [355.514 µs, 396.547 µs] -
iast 495.633 µs [474.379 µs, 516.886 µs] 119.602 µs (31.8%)
iast_FULL 646.599 µs [625.13 µs, 668.069 µs] 270.569 µs (72.0%)
iast_GLOBAL 527.097 µs [504.915 µs, 549.28 µs] 151.067 µs (40.2%)
iast_HARDCODED_SECRET_DISABLED 491.475 µs [470.154 µs, 512.796 µs] 115.444 µs (30.7%)
iast_INACTIVE 449.11 µs [428.439 µs, 469.782 µs] 73.08 µs (19.4%)
iast_TELEMETRY_OFF 474.735 µs [453.486 µs, 495.984 µs] 98.705 µs (26.2%)
tracing 445.975 µs [425.464 µs, 466.486 µs] 69.945 µs (18.6%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~c7ded8b5a1, baseline=1.43.0-SNAPSHOT~cb6a6fcd72
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.36 ms) : 1340, 1379
.   : milestone, 1360,
appsec (1.734 ms) : 1709, 1759
.   : milestone, 1734,
appsec_no_iast (1.709 ms) : 1683, 1734
.   : milestone, 1709,
iast (1.5 ms) : 1477, 1522
.   : milestone, 1500,
profiling (1.532 ms) : 1508, 1556
.   : milestone, 1532,
tracing (1.468 ms) : 1443, 1492
.   : milestone, 1468,
section candidate
no_agent (1.337 ms) : 1317, 1357
.   : milestone, 1337,
appsec (1.709 ms) : 1685, 1732
.   : milestone, 1709,
appsec_no_iast (1.764 ms) : 1740, 1788
.   : milestone, 1764,
iast (1.492 ms) : 1469, 1515
.   : milestone, 1492,
profiling (1.552 ms) : 1528, 1575
.   : milestone, 1552,
tracing (1.493 ms) : 1469, 1518
.   : milestone, 1493,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.36 ms [1.34 ms, 1.379 ms] -
appsec 1.734 ms [1.709 ms, 1.759 ms] 374.386 µs (27.5%)
appsec_no_iast 1.709 ms [1.683 ms, 1.734 ms] 349.015 µs (25.7%)
iast 1.5 ms [1.477 ms, 1.522 ms] 139.994 µs (10.3%)
profiling 1.532 ms [1.508 ms, 1.556 ms] 172.651 µs (12.7%)
tracing 1.468 ms [1.443 ms, 1.492 ms] 107.893 µs (7.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.337 ms [1.317 ms, 1.357 ms] -
appsec 1.709 ms [1.685 ms, 1.732 ms] 371.819 µs (27.8%)
appsec_no_iast 1.764 ms [1.74 ms, 1.788 ms] 426.672 µs (31.9%)
iast 1.492 ms [1.469 ms, 1.515 ms] 155.306 µs (11.6%)
profiling 1.552 ms [1.528 ms, 1.575 ms] 214.755 µs (16.1%)
tracing 1.493 ms [1.469 ms, 1.518 ms] 156.438 µs (11.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/exclude-dev-failsafe
git_commit_date 1731426404 1731429109
git_commit_sha cb6a6fc c7ded8b
release_version 1.43.0-SNAPSHOT~cb6a6fcd72 1.43.0-SNAPSHOT~c7ded8b5a1
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1731430832 1731430832
ci_job_id 704019900 704019900
ci_pipeline_id 48817313 48817313
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~c7ded8b5a1, baseline=1.43.0-SNAPSHOT~cb6a6fcd72
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.075 s) : 15075000, 15075000
.   : milestone, 15075000,
appsec (14.947 s) : 14947000, 14947000
.   : milestone, 14947000,
iast (18.93 s) : 18930000, 18930000
.   : milestone, 18930000,
iast_GLOBAL (18.556 s) : 18556000, 18556000
.   : milestone, 18556000,
profiling (15.049 s) : 15049000, 15049000
.   : milestone, 15049000,
tracing (14.766 s) : 14766000, 14766000
.   : milestone, 14766000,
section candidate
no_agent (15.028 s) : 15028000, 15028000
.   : milestone, 15028000,
appsec (15.081 s) : 15081000, 15081000
.   : milestone, 15081000,
iast (19.085 s) : 19085000, 19085000
.   : milestone, 19085000,
iast_GLOBAL (18.506 s) : 18506000, 18506000
.   : milestone, 18506000,
profiling (15.563 s) : 15563000, 15563000
.   : milestone, 15563000,
tracing (15.144 s) : 15144000, 15144000
.   : milestone, 15144000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.075 s [15.075 s, 15.075 s] -
appsec 14.947 s [14.947 s, 14.947 s] -128.0 ms (-0.8%)
iast 18.93 s [18.93 s, 18.93 s] 3.855 s (25.6%)
iast_GLOBAL 18.556 s [18.556 s, 18.556 s] 3.481 s (23.1%)
profiling 15.049 s [15.049 s, 15.049 s] -26.0 ms (-0.2%)
tracing 14.766 s [14.766 s, 14.766 s] -309.0 ms (-2.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.028 s [15.028 s, 15.028 s] -
appsec 15.081 s [15.081 s, 15.081 s] 53.0 ms (0.4%)
iast 19.085 s [19.085 s, 19.085 s] 4.057 s (27.0%)
iast_GLOBAL 18.506 s [18.506 s, 18.506 s] 3.478 s (23.1%)
profiling 15.563 s [15.563 s, 15.563 s] 535.0 ms (3.6%)
tracing 15.144 s [15.144 s, 15.144 s] 116.0 ms (0.8%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~c7ded8b5a1, baseline=1.43.0-SNAPSHOT~cb6a6fcd72
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1455, 1478
.   : milestone, 1467,
appsec (2.317 ms) : 2276, 2358
.   : milestone, 2317,
iast (2.077 ms) : 2026, 2129
.   : milestone, 2077,
iast_GLOBAL (2.126 ms) : 2073, 2178
.   : milestone, 2126,
profiling (1.943 ms) : 1902, 1985
.   : milestone, 1943,
tracing (1.909 ms) : 1870, 1948
.   : milestone, 1909,
section candidate
no_agent (1.47 ms) : 1458, 1481
.   : milestone, 1470,
appsec (2.329 ms) : 2288, 2370
.   : milestone, 2329,
iast (2.072 ms) : 2020, 2124
.   : milestone, 2072,
iast_GLOBAL (2.126 ms) : 2074, 2179
.   : milestone, 2126,
profiling (2.388 ms) : 2211, 2565
.   : milestone, 2388,
tracing (1.928 ms) : 1888, 1968
.   : milestone, 1928,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.455 ms, 1.478 ms] -
appsec 2.317 ms [2.276 ms, 2.358 ms] 850.625 µs (58.0%)
iast 2.077 ms [2.026 ms, 2.129 ms] 610.591 µs (41.6%)
iast_GLOBAL 2.126 ms [2.073 ms, 2.178 ms] 658.766 µs (44.9%)
profiling 1.943 ms [1.902 ms, 1.985 ms] 476.62 µs (32.5%)
tracing 1.909 ms [1.87 ms, 1.948 ms] 441.876 µs (30.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.47 ms [1.458 ms, 1.481 ms] -
appsec 2.329 ms [2.288 ms, 2.37 ms] 859.08 µs (58.4%)
iast 2.072 ms [2.02 ms, 2.124 ms] 602.27 µs (41.0%)
iast_GLOBAL 2.126 ms [2.074 ms, 2.179 ms] 656.444 µs (44.7%)
profiling 2.388 ms [2.211 ms, 2.565 ms] 918.298 µs (62.5%)
tracing 1.928 ms [1.888 ms, 1.968 ms] 458.185 µs (31.2%)

@smola smola merged commit 82196d0 into master Nov 13, 2024
104 of 107 checks passed
@smola smola deleted the smola/exclude-dev-failsafe branch November 13, 2024 09:13
@github-actions github-actions bot added this to the 1.43.0 milestone Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariovido Mariovido Mariovido approved these changes

@jandro996 jandro996 jandro996 approved these changes

@manuel-alvarez-alvarez manuel-alvarez-alvarez Awaiting requested review from manuel-alvarez-alvarez manuel-alvarez-alvarez is a code owner automatically assigned from DataDog/asm-java

Assignees
No one assigned
Labels
comp: asm iast Application Security Management (IAST) type: bug
Projects
None yet
Milestone
1.43.0
Development

Successfully merging this pull request may close these issues.
3 participants
@smola @jandro996 @Mariovido