-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add trace injection for prepared statements in Postgres #7940
Draft
nenadnoveljic
wants to merge
1
commit into
master
Choose a base branch
from
nenadnoveljic/pg-prepared
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~d3151b63d2, baseline=1.43.0-SNAPSHOT~0ab886489d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1081147
Total [baseline] (8.564 s) : 0, 8563647
Agent [candidate] (1.078 s) : 0, 1077787
Total [candidate] (8.565 s) : 0, 8564958
section iast
Agent [baseline] (1.204 s) : 0, 1204306
Total [baseline] (9.113 s) : 0, 9112886
Agent [candidate] (1.223 s) : 0, 1223335
Total [candidate] (9.201 s) : 0, 9201145
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.207 s) : 0, 1207098
Total [baseline] (9.087 s) : 0, 9086760
Agent [candidate] (1.206 s) : 0, 1205779
Total [candidate] (9.084 s) : 0, 9084399
section iast_TELEMETRY_OFF
Agent [baseline] (1.202 s) : 0, 1202125
Total [baseline] (9.096 s) : 0, 9096261
Agent [candidate] (1.212 s) : 0, 1211699
Total [candidate] (9.181 s) : 0, 9180843
gantt
title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~d3151b63d2, baseline=1.43.0-SNAPSHOT~0ab886489d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.409 ms) : 0, 687409
BytebuddyAgent [candidate] (686.395 ms) : 0, 686395
GlobalTracer [baseline] (314.545 ms) : 0, 314545
GlobalTracer [candidate] (314.55 ms) : 0, 314550
AppSec [baseline] (54.285 ms) : 0, 54285
AppSec [candidate] (54.067 ms) : 0, 54067
Remote Config [baseline] (680.645 µs) : 0, 681
Remote Config [candidate] (682.822 µs) : 0, 683
Telemetry [baseline] (10.564 ms) : 0, 10564
Telemetry [candidate] (8.44 ms) : 0, 8440
section iast
BytebuddyAgent [baseline] (800.922 ms) : 0, 800922
BytebuddyAgent [candidate] (814.944 ms) : 0, 814944
GlobalTracer [baseline] (303.858 ms) : 0, 303858
GlobalTracer [candidate] (308.045 ms) : 0, 308045
AppSec [baseline] (57.42 ms) : 0, 57420
AppSec [candidate] (57.509 ms) : 0, 57509
Remote Config [baseline] (618.847 µs) : 0, 619
Remote Config [candidate] (622.727 µs) : 0, 623
Telemetry [baseline] (7.445 ms) : 0, 7445
Telemetry [candidate] (7.535 ms) : 0, 7535
IAST [baseline] (20.412 ms) : 0, 20412
IAST [candidate] (20.831 ms) : 0, 20831
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (803.017 ms) : 0, 803017
BytebuddyAgent [candidate] (801.652 ms) : 0, 801652
GlobalTracer [baseline] (304.401 ms) : 0, 304401
GlobalTracer [candidate] (304.098 ms) : 0, 304098
AppSec [baseline] (57.476 ms) : 0, 57476
AppSec [candidate] (56.747 ms) : 0, 56747
Remote Config [baseline] (594.662 µs) : 0, 595
Remote Config [candidate] (616.585 µs) : 0, 617
Telemetry [baseline] (7.414 ms) : 0, 7414
Telemetry [candidate] (7.463 ms) : 0, 7463
IAST [baseline] (20.556 ms) : 0, 20556
IAST [candidate] (21.547 ms) : 0, 21547
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (799.222 ms) : 0, 799222
BytebuddyAgent [candidate] (805.538 ms) : 0, 805538
GlobalTracer [baseline] (303.45 ms) : 0, 303450
GlobalTracer [candidate] (306.054 ms) : 0, 306054
AppSec [baseline] (56.9 ms) : 0, 56900
AppSec [candidate] (57.109 ms) : 0, 57109
Remote Config [baseline] (609.995 µs) : 0, 610
Remote Config [candidate] (613.797 µs) : 0, 614
Telemetry [baseline] (7.302 ms) : 0, 7302
Telemetry [candidate] (7.423 ms) : 0, 7423
IAST [baseline] (21.025 ms) : 0, 21025
IAST [candidate] (21.242 ms) : 0, 21242
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~d3151b63d2, baseline=1.43.0-SNAPSHOT~0ab886489d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1085720
Total [baseline] (10.443 s) : 0, 10443180
Agent [candidate] (1.088 s) : 0, 1087579
Total [candidate] (10.492 s) : 0, 10491706
section appsec
Agent [baseline] (1.22 s) : 0, 1220350
Total [baseline] (10.664 s) : 0, 10663519
Agent [candidate] (1.216 s) : 0, 1215787
Total [candidate] (10.645 s) : 0, 10645177
section iast
Agent [baseline] (1.205 s) : 0, 1205238
Total [baseline] (10.949 s) : 0, 10948527
Agent [candidate] (1.214 s) : 0, 1213769
Total [candidate] (10.985 s) : 0, 10985233
section profiling
Agent [baseline] (1.286 s) : 0, 1286046
Total [baseline] (10.84 s) : 0, 10839634
Agent [candidate] (1.294 s) : 0, 1294093
Total [candidate] (10.745 s) : 0, 10744526
gantt
title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~d3151b63d2, baseline=1.43.0-SNAPSHOT~0ab886489d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.959 ms) : 0, 689959
BytebuddyAgent [candidate] (691.55 ms) : 0, 691550
GlobalTracer [baseline] (316.23 ms) : 0, 316230
GlobalTracer [candidate] (316.675 ms) : 0, 316675
AppSec [baseline] (54.549 ms) : 0, 54549
AppSec [candidate] (54.338 ms) : 0, 54338
Remote Config [baseline] (684.252 µs) : 0, 684
Remote Config [candidate] (675.148 µs) : 0, 675
Telemetry [baseline] (10.597 ms) : 0, 10597
Telemetry [candidate] (10.658 ms) : 0, 10658
section appsec
BytebuddyAgent [baseline] (708.888 ms) : 0, 708888
BytebuddyAgent [candidate] (704.271 ms) : 0, 704271
GlobalTracer [baseline] (313.726 ms) : 0, 313726
GlobalTracer [candidate] (312.76 ms) : 0, 312760
AppSec [baseline] (165.075 ms) : 0, 165075
AppSec [candidate] (167.037 ms) : 0, 167037
Remote Config [baseline] (639.834 µs) : 0, 640
Remote Config [candidate] (634.216 µs) : 0, 634
Telemetry [baseline] (8.553 ms) : 0, 8553
Telemetry [candidate] (7.756 ms) : 0, 7756
IAST [baseline] (19.533 ms) : 0, 19533
IAST [candidate] (19.423 ms) : 0, 19423
section iast
BytebuddyAgent [baseline] (802.331 ms) : 0, 802331
BytebuddyAgent [candidate] (807.107 ms) : 0, 807107
GlobalTracer [baseline] (303.925 ms) : 0, 303925
GlobalTracer [candidate] (306.325 ms) : 0, 306325
AppSec [baseline] (57.05 ms) : 0, 57050
AppSec [candidate] (56.929 ms) : 0, 56929
Remote Config [baseline] (621.495 µs) : 0, 621
Remote Config [candidate] (634.892 µs) : 0, 635
Telemetry [baseline] (7.416 ms) : 0, 7416
Telemetry [candidate] (7.464 ms) : 0, 7464
IAST [baseline] (20.293 ms) : 0, 20293
IAST [candidate] (21.689 ms) : 0, 21689
section profiling
BytebuddyAgent [baseline] (685.419 ms) : 0, 685419
BytebuddyAgent [candidate] (689.408 ms) : 0, 689408
GlobalTracer [baseline] (401.051 ms) : 0, 401051
GlobalTracer [candidate] (402.942 ms) : 0, 402942
AppSec [baseline] (54.895 ms) : 0, 54895
AppSec [candidate] (55.249 ms) : 0, 55249
Remote Config [baseline] (667.87 µs) : 0, 668
Remote Config [candidate] (672.661 µs) : 0, 673
Telemetry [baseline] (11.184 ms) : 0, 11184
Telemetry [candidate] (10.686 ms) : 0, 10686
ProfilingAgent [baseline] (93.789 ms) : 0, 93789
ProfilingAgent [candidate] (95.752 ms) : 0, 95752
Profiling [baseline] (93.813 ms) : 0, 93813
Profiling [candidate] (95.776 ms) : 0, 95776
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~d3151b63d2, baseline=1.43.0-SNAPSHOT~0ab886489d
dateFormat X
axisFormat %s
section baseline
no_agent (1.341 ms) : 1322, 1361
. : milestone, 1341,
appsec (1.732 ms) : 1707, 1757
. : milestone, 1732,
appsec_no_iast (1.723 ms) : 1699, 1747
. : milestone, 1723,
iast (1.464 ms) : 1441, 1488
. : milestone, 1464,
profiling (1.497 ms) : 1474, 1520
. : milestone, 1497,
tracing (1.483 ms) : 1459, 1507
. : milestone, 1483,
section candidate
no_agent (1.339 ms) : 1319, 1358
. : milestone, 1339,
appsec (1.734 ms) : 1710, 1759
. : milestone, 1734,
appsec_no_iast (1.714 ms) : 1690, 1739
. : milestone, 1714,
iast (1.476 ms) : 1453, 1499
. : milestone, 1476,
profiling (1.504 ms) : 1479, 1528
. : milestone, 1504,
tracing (1.473 ms) : 1449, 1497
. : milestone, 1473,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~d3151b63d2, baseline=1.43.0-SNAPSHOT~0ab886489d
dateFormat X
axisFormat %s
section baseline
no_agent (370.397 µs) : 349, 392
. : milestone, 370,
iast (486.059 µs) : 465, 507
. : milestone, 486,
iast_FULL (641.625 µs) : 620, 663
. : milestone, 642,
iast_GLOBAL (512.963 µs) : 491, 535
. : milestone, 513,
iast_HARDCODED_SECRET_DISABLED (488.356 µs) : 467, 510
. : milestone, 488,
iast_INACTIVE (449.812 µs) : 429, 471
. : milestone, 450,
iast_TELEMETRY_OFF (472.264 µs) : 451, 493
. : milestone, 472,
tracing (442.854 µs) : 422, 464
. : milestone, 443,
section candidate
no_agent (370.13 µs) : 351, 390
. : milestone, 370,
iast (487.278 µs) : 466, 509
. : milestone, 487,
iast_FULL (649.574 µs) : 628, 671
. : milestone, 650,
iast_GLOBAL (512.07 µs) : 491, 534
. : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (486.6 µs) : 465, 508
. : milestone, 487,
iast_INACTIVE (447.77 µs) : 427, 469
. : milestone, 448,
iast_TELEMETRY_OFF (479.316 µs) : 458, 501
. : milestone, 479,
tracing (442.715 µs) : 422, 463
. : milestone, 443,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~d3151b63d2, baseline=1.43.0-SNAPSHOT~0ab886489d
dateFormat X
axisFormat %s
section baseline
no_agent (15.068 s) : 15068000, 15068000
. : milestone, 15068000,
appsec (15.34 s) : 15340000, 15340000
. : milestone, 15340000,
iast (18.642 s) : 18642000, 18642000
. : milestone, 18642000,
iast_GLOBAL (18.188 s) : 18188000, 18188000
. : milestone, 18188000,
profiling (14.965 s) : 14965000, 14965000
. : milestone, 14965000,
tracing (14.932 s) : 14932000, 14932000
. : milestone, 14932000,
section candidate
no_agent (15.17 s) : 15170000, 15170000
. : milestone, 15170000,
appsec (15.094 s) : 15094000, 15094000
. : milestone, 15094000,
iast (18.976 s) : 18976000, 18976000
. : milestone, 18976000,
iast_GLOBAL (18.197 s) : 18197000, 18197000
. : milestone, 18197000,
profiling (14.954 s) : 14954000, 14954000
. : milestone, 14954000,
tracing (15.169 s) : 15169000, 15169000
. : milestone, 15169000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~d3151b63d2, baseline=1.43.0-SNAPSHOT~0ab886489d
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.359 ms) : 2318, 2401
. : milestone, 2359,
iast (2.084 ms) : 2032, 2136
. : milestone, 2084,
iast_GLOBAL (2.124 ms) : 2072, 2176
. : milestone, 2124,
profiling (1.947 ms) : 1906, 1989
. : milestone, 1947,
tracing (1.938 ms) : 1898, 1978
. : milestone, 1938,
section candidate
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (2.352 ms) : 2310, 2393
. : milestone, 2352,
iast (2.08 ms) : 2028, 2131
. : milestone, 2080,
iast_GLOBAL (2.13 ms) : 2077, 2183
. : milestone, 2130,
profiling (1.942 ms) : 1901, 1983
. : milestone, 1942,
tracing (1.923 ms) : 1884, 1963
. : milestone, 1923,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]