-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement code origin support for grpc server entry spans #7942
base: master
Are you sure you want to change the base?
Conversation
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 5 performance regressions! Performance is the same for 2 metrics, 8 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (314.495 µs) : 251, 378
. : milestone, 314,
basic (295.696 µs) : 280, 312
. : milestone, 296,
loop (10.397 ms) : 10361, 10433
. : milestone, 10397,
section candidate
noprobe (308.802 µs) : 264, 354
. : milestone, 309,
basic (305.183 µs) : 295, 316
. : milestone, 305,
loop (10.978 ms) : 10945, 11012
. : milestone, 10978,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 50 metrics, 10 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~8cd1292cbf, baseline=1.43.0-SNAPSHOT~0ab886489d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1081064
Total [baseline] (8.577 s) : 0, 8576872
Agent [candidate] (1.112 s) : 0, 1112246
Total [candidate] (8.602 s) : 0, 8602063
section iast
Agent [baseline] (1.204 s) : 0, 1203694
Total [baseline] (9.118 s) : 0, 9118090
Agent [candidate] (1.242 s) : 0, 1242432
Total [candidate] (9.138 s) : 0, 9137709
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.208 s) : 0, 1207879
Total [baseline] (9.086 s) : 0, 9085762
Agent [candidate] (1.236 s) : 0, 1236294
Total [candidate] (9.156 s) : 0, 9156180
section iast_TELEMETRY_OFF
Agent [baseline] (1.216 s) : 0, 1216405
Total [baseline] (9.157 s) : 0, 9157061
Agent [candidate] (1.231 s) : 0, 1231362
Total [candidate] (9.151 s) : 0, 9150859
gantt
title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~8cd1292cbf, baseline=1.43.0-SNAPSHOT~0ab886489d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.694 ms) : 0, 687694
BytebuddyAgent [candidate] (691.319 ms) : 0, 691319
GlobalTracer [baseline] (315.002 ms) : 0, 315002
GlobalTracer [candidate] (319.543 ms) : 0, 319543
AppSec [baseline] (54.062 ms) : 0, 54062
AppSec [candidate] (55.092 ms) : 0, 55092
Remote Config [baseline] (677.925 µs) : 0, 678
Remote Config [candidate] (672.24 µs) : 0, 672
Telemetry [baseline] (9.963 ms) : 0, 9963
Telemetry [candidate] (8.487 ms) : 0, 8487
section iast
BytebuddyAgent [baseline] (800.881 ms) : 0, 800881
BytebuddyAgent [candidate] (808.435 ms) : 0, 808435
GlobalTracer [baseline] (303.62 ms) : 0, 303620
GlobalTracer [candidate] (309.736 ms) : 0, 309736
AppSec [baseline] (57.085 ms) : 0, 57085
AppSec [candidate] (58.143 ms) : 0, 58143
Remote Config [baseline] (609.404 µs) : 0, 609
Remote Config [candidate] (614.518 µs) : 0, 615
Telemetry [baseline] (7.405 ms) : 0, 7405
Telemetry [candidate] (7.455 ms) : 0, 7455
IAST [baseline] (20.446 ms) : 0, 20446
IAST [candidate] (20.849 ms) : 0, 20849
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (804.568 ms) : 0, 804568
BytebuddyAgent [candidate] (802.257 ms) : 0, 802257
GlobalTracer [baseline] (303.287 ms) : 0, 303287
GlobalTracer [candidate] (309.988 ms) : 0, 309988
AppSec [baseline] (55.254 ms) : 0, 55254
AppSec [candidate] (57.638 ms) : 0, 57638
Remote Config [baseline] (603.344 µs) : 0, 603
Remote Config [candidate] (604.762 µs) : 0, 605
Telemetry [baseline] (7.459 ms) : 0, 7459
Telemetry [candidate] (7.407 ms) : 0, 7407
IAST [baseline] (23.005 ms) : 0, 23005
IAST [candidate] (21.568 ms) : 0, 21568
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (809.269 ms) : 0, 809269
BytebuddyAgent [candidate] (800.12 ms) : 0, 800120
GlobalTracer [baseline] (306.209 ms) : 0, 306209
GlobalTracer [candidate] (309.161 ms) : 0, 309161
AppSec [baseline] (57.788 ms) : 0, 57788
AppSec [candidate] (56.37 ms) : 0, 56370
Remote Config [baseline] (604.294 µs) : 0, 604
Remote Config [candidate] (598.927 µs) : 0, 599
Telemetry [baseline] (7.464 ms) : 0, 7464
Telemetry [candidate] (7.244 ms) : 0, 7244
IAST [baseline] (21.267 ms) : 0, 21267
IAST [candidate] (20.894 ms) : 0, 20894
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~8cd1292cbf, baseline=1.43.0-SNAPSHOT~0ab886489d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.077 s) : 0, 1076770
Total [baseline] (10.368 s) : 0, 10368004
Agent [candidate] (1.104 s) : 0, 1104090
Total [candidate] (10.45 s) : 0, 10449826
section appsec
Agent [baseline] (1.221 s) : 0, 1220982
Total [baseline] (10.656 s) : 0, 10655828
Agent [candidate] (1.247 s) : 0, 1246755
Total [candidate] (10.675 s) : 0, 10675206
section iast
Agent [baseline] (1.213 s) : 0, 1212532
Total [baseline] (10.9 s) : 0, 10899850
Agent [candidate] (1.236 s) : 0, 1236101
Total [candidate] (10.951 s) : 0, 10951390
section profiling
Agent [baseline] (1.276 s) : 0, 1276102
Total [baseline] (10.718 s) : 0, 10717993
Agent [candidate] (1.303 s) : 0, 1303128
Total [candidate] (10.666 s) : 0, 10666077
gantt
title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~8cd1292cbf, baseline=1.43.0-SNAPSHOT~0ab886489d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.945 ms) : 0, 683945
BytebuddyAgent [candidate] (686.287 ms) : 0, 686287
GlobalTracer [baseline] (313.369 ms) : 0, 313369
GlobalTracer [candidate] (317.337 ms) : 0, 317337
AppSec [baseline] (54.012 ms) : 0, 54012
AppSec [candidate] (55.178 ms) : 0, 55178
Remote Config [baseline] (672.432 µs) : 0, 672
Remote Config [candidate] (681.918 µs) : 0, 682
Telemetry [baseline] (11.18 ms) : 0, 11180
Telemetry [candidate] (7.744 ms) : 0, 7744
section appsec
BytebuddyAgent [baseline] (708.03 ms) : 0, 708030
BytebuddyAgent [candidate] (711.149 ms) : 0, 711149
GlobalTracer [baseline] (313.933 ms) : 0, 313933
GlobalTracer [candidate] (318.594 ms) : 0, 318594
AppSec [baseline] (165.271 ms) : 0, 165271
AppSec [candidate] (159.862 ms) : 0, 159862
Remote Config [baseline] (639.248 µs) : 0, 639
Remote Config [candidate] (642.445 µs) : 0, 642
Telemetry [baseline] (9.191 ms) : 0, 9191
Telemetry [candidate] (8.62 ms) : 0, 8620
IAST [baseline] (20.473 ms) : 0, 20473
IAST [candidate] (21.356 ms) : 0, 21356
section iast
BytebuddyAgent [baseline] (807.089 ms) : 0, 807089
BytebuddyAgent [candidate] (803.899 ms) : 0, 803899
GlobalTracer [baseline] (305.424 ms) : 0, 305424
GlobalTracer [candidate] (308.62 ms) : 0, 308620
AppSec [baseline] (57.656 ms) : 0, 57656
AppSec [candidate] (57.301 ms) : 0, 57301
Remote Config [baseline] (611.654 µs) : 0, 612
Remote Config [candidate] (612.822 µs) : 0, 613
Telemetry [baseline] (7.497 ms) : 0, 7497
Telemetry [candidate] (7.335 ms) : 0, 7335
IAST [baseline] (20.55 ms) : 0, 20550
IAST [candidate] (21.421 ms) : 0, 21421
section profiling
BytebuddyAgent [baseline] (679.585 ms) : 0, 679585
BytebuddyAgent [candidate] (681.77 ms) : 0, 681770
GlobalTracer [baseline] (398.6 ms) : 0, 398600
GlobalTracer [candidate] (401.469 ms) : 0, 401469
AppSec [baseline] (54.453 ms) : 0, 54453
AppSec [candidate] (58.184 ms) : 0, 58184
Remote Config [baseline] (659.483 µs) : 0, 659
Remote Config [candidate] (702.853 µs) : 0, 703
Telemetry [baseline] (11.183 ms) : 0, 11183
Telemetry [candidate] (10.195 ms) : 0, 10195
ProfilingAgent [baseline] (92.828 ms) : 0, 92828
ProfilingAgent [candidate] (88.709 ms) : 0, 88709
Profiling [baseline] (92.852 ms) : 0, 92852
Profiling [candidate] (88.734 ms) : 0, 88734
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~8cd1292cbf, baseline=1.43.0-SNAPSHOT~0ab886489d
dateFormat X
axisFormat %s
section baseline
no_agent (1.337 ms) : 1317, 1357
. : milestone, 1337,
appsec (1.728 ms) : 1704, 1753
. : milestone, 1728,
appsec_no_iast (1.727 ms) : 1703, 1750
. : milestone, 1727,
iast (1.476 ms) : 1452, 1499
. : milestone, 1476,
profiling (1.529 ms) : 1505, 1553
. : milestone, 1529,
tracing (1.465 ms) : 1439, 1490
. : milestone, 1465,
section candidate
no_agent (1.344 ms) : 1324, 1363
. : milestone, 1344,
appsec (1.736 ms) : 1713, 1759
. : milestone, 1736,
appsec_no_iast (1.726 ms) : 1701, 1751
. : milestone, 1726,
iast (1.475 ms) : 1452, 1497
. : milestone, 1475,
profiling (1.554 ms) : 1530, 1579
. : milestone, 1554,
tracing (1.479 ms) : 1454, 1504
. : milestone, 1479,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~8cd1292cbf, baseline=1.43.0-SNAPSHOT~0ab886489d
dateFormat X
axisFormat %s
section baseline
no_agent (371.014 µs) : 352, 390
. : milestone, 371,
iast (478.876 µs) : 458, 500
. : milestone, 479,
iast_FULL (640.739 µs) : 619, 662
. : milestone, 641,
iast_GLOBAL (508.412 µs) : 487, 530
. : milestone, 508,
iast_HARDCODED_SECRET_DISABLED (479.736 µs) : 458, 502
. : milestone, 480,
iast_INACTIVE (444.219 µs) : 423, 465
. : milestone, 444,
iast_TELEMETRY_OFF (479.747 µs) : 458, 502
. : milestone, 480,
tracing (444.69 µs) : 424, 466
. : milestone, 445,
section candidate
no_agent (367.754 µs) : 349, 387
. : milestone, 368,
iast (487.822 µs) : 466, 510
. : milestone, 488,
iast_FULL (639.223 µs) : 618, 661
. : milestone, 639,
iast_GLOBAL (511.507 µs) : 490, 533
. : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (487.538 µs) : 466, 509
. : milestone, 488,
iast_INACTIVE (441.493 µs) : 421, 462
. : milestone, 441,
iast_TELEMETRY_OFF (481.394 µs) : 460, 503
. : milestone, 481,
tracing (438.686 µs) : 418, 459
. : milestone, 439,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~8cd1292cbf, baseline=1.43.0-SNAPSHOT~0ab886489d
dateFormat X
axisFormat %s
section baseline
no_agent (15.54 s) : 15540000, 15540000
. : milestone, 15540000,
appsec (15.136 s) : 15136000, 15136000
. : milestone, 15136000,
iast (19.092 s) : 19092000, 19092000
. : milestone, 19092000,
iast_GLOBAL (18.215 s) : 18215000, 18215000
. : milestone, 18215000,
profiling (15.761 s) : 15761000, 15761000
. : milestone, 15761000,
tracing (15.115 s) : 15115000, 15115000
. : milestone, 15115000,
section candidate
no_agent (15.423 s) : 15423000, 15423000
. : milestone, 15423000,
appsec (15.376 s) : 15376000, 15376000
. : milestone, 15376000,
iast (19.562 s) : 19562000, 19562000
. : milestone, 19562000,
iast_GLOBAL (18.62 s) : 18620000, 18620000
. : milestone, 18620000,
profiling (15.842 s) : 15842000, 15842000
. : milestone, 15842000,
tracing (15.42 s) : 15420000, 15420000
. : milestone, 15420000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~8cd1292cbf, baseline=1.43.0-SNAPSHOT~0ab886489d
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1480
. : milestone, 1469,
appsec (2.368 ms) : 2327, 2410
. : milestone, 2368,
iast (2.075 ms) : 2024, 2127
. : milestone, 2075,
iast_GLOBAL (2.127 ms) : 2075, 2180
. : milestone, 2127,
profiling (1.931 ms) : 1891, 1972
. : milestone, 1931,
tracing (1.926 ms) : 1887, 1966
. : milestone, 1926,
section candidate
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (2.355 ms) : 2313, 2397
. : milestone, 2355,
iast (2.084 ms) : 2032, 2137
. : milestone, 2084,
iast_GLOBAL (2.127 ms) : 2075, 2180
. : milestone, 2127,
profiling (1.95 ms) : 1908, 1992
. : milestone, 1950,
tracing (1.92 ms) : 1880, 1959
. : milestone, 1920,
|
What Does This Do
This updates the grpc integration to enable code origin support for grpc servers.
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: DEBUG-3109