Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up DSM pathway binary encoding #8137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clean up DSM pathway binary encoding #8137

wants to merge 1 commit into from

Conversation

PerfectSlayer
Copy link
Contributor

@PerfectSlayer PerfectSlayer commented Dec 31, 2024 •
edited by jira bot
Loading

What Does This Do

This PR cleans up the BinarySetter API used to inject binary data during context propagation.

Motivation

This API was only used by DSM for Pathway context injection and is no more used.
Currently, only the dd-pathway-ctx-base64 key is injected / extracted and is a base64 string.
The legacy dd-pathway-ctx was already no more used.

Additional Notes

This is preliminary refactoring work for the new context propagation API.

Contributor Checklist

Jira ticket: LANGPLAT-38

@PerfectSlayer PerfectSlayer added comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring comp: data streams Data Streams Monitoring labels Dec 31, 2024
@pr-commenter
Copy link

pr-commenter bot commented Dec 31, 2024 •
edited
Loading

Kafka / producer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/context-propagation-cleanup
git_commit_date 1735568221 1735649019
git_commit_sha 0dc9c08 0ec88c5
See matching parameters
Baseline Candidate
ci_job_date 1735650142 1735650142
ci_job_id 751503773 751503773
ci_pipeline_id 51940780 51940780
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.25 11.0.25
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.25+9-post-Ubuntu-1ubuntu122.04 11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce same

@pr-commenter
Copy link

pr-commenter bot commented Dec 31, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/context-propagation-cleanup
git_commit_date 1735646307 1735649019
git_commit_sha da26e28 0ec88c5
release_version 1.45.0-SNAPSHOT~da26e28ed5 1.45.0-SNAPSHOT~0ec88c5512
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1735651529 1735651529
ci_job_id 751503769 751503769
ci_pipeline_id 51940780 51940780
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~0ec88c5512, baseline=1.45.0-SNAPSHOT~da26e28ed5

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1062224
Total [baseline] (8.618 s) : 0, 8617636
Agent [candidate] (1.049 s) : 0, 1048703
Total [candidate] (8.582 s) : 0, 8582095
section iast
Agent [baseline] (1.188 s) : 0, 1188391
Total [baseline] (9.184 s) : 0, 9183781
Agent [candidate] (1.178 s) : 0, 1177734
Total [candidate] (9.234 s) : 0, 9234382
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.186 s) : 0, 1185696
Total [baseline] (9.19 s) : 0, 9190053
Agent [candidate] (1.183 s) : 0, 1182681
Total [candidate] (9.211 s) : 0, 9210646
section iast_TELEMETRY_OFF
Agent [baseline] (1.18 s) : 0, 1180245
Total [baseline] (9.23 s) : 0, 9229644
Agent [candidate] (1.184 s) : 0, 1183759
Total [candidate] (9.212 s) : 0, 9212200
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent iast 1.188 s 126.168 ms (11.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.186 s 123.472 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.18 s 118.021 ms (11.1%)
Total tracing 8.618 s -
Total iast 9.184 s 566.145 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.19 s 572.417 ms (6.6%)
Total iast_TELEMETRY_OFF 9.23 s 612.008 ms (7.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent iast 1.178 s 129.031 ms (12.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.183 s 133.978 ms (12.8%)
Agent iast_TELEMETRY_OFF 1.184 s 135.056 ms (12.9%)
Total tracing 8.582 s -
Total iast 9.234 s 652.287 ms (7.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.211 s 628.55 ms (7.3%)
Total iast_TELEMETRY_OFF 9.212 s 630.105 ms (7.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~0ec88c5512, baseline=1.45.0-SNAPSHOT~da26e28ed5

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (720.65 ms) : 0, 720650
BytebuddyAgent [candidate] (710.286 ms) : 0, 710286
GlobalTracer [baseline] (258.114 ms) : 0, 258114
GlobalTracer [candidate] (255.992 ms) : 0, 255992
AppSec [baseline] (55.391 ms) : 0, 55391
AppSec [candidate] (54.767 ms) : 0, 54767
Remote Config [baseline] (725.915 µs) : 0, 726
Remote Config [candidate] (716.559 µs) : 0, 717
Telemetry [baseline] (12.126 ms) : 0, 12126
Telemetry [candidate] (11.934 ms) : 0, 11934
section iast
BytebuddyAgent [baseline] (837.575 ms) : 0, 837575
BytebuddyAgent [candidate] (827.85 ms) : 0, 827850
GlobalTracer [baseline] (247.532 ms) : 0, 247532
GlobalTracer [candidate] (246.071 ms) : 0, 246071
AppSec [baseline] (57.766 ms) : 0, 57766
AppSec [candidate] (57.951 ms) : 0, 57951
Remote Config [baseline] (640.565 µs) : 0, 641
Remote Config [candidate] (660.74 µs) : 0, 661
Telemetry [baseline] (8.55 ms) : 0, 8550
Telemetry [candidate] (8.601 ms) : 0, 8601
IAST [baseline] (21.232 ms) : 0, 21232
IAST [candidate] (21.604 ms) : 0, 21604
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (833.565 ms) : 0, 833565
BytebuddyAgent [candidate] (830.165 ms) : 0, 830165
GlobalTracer [baseline] (247.653 ms) : 0, 247653
GlobalTracer [candidate] (248.097 ms) : 0, 248097
AppSec [baseline] (58.329 ms) : 0, 58329
AppSec [candidate] (58.348 ms) : 0, 58348
Remote Config [baseline] (654.86 µs) : 0, 655
Remote Config [candidate] (663.38 µs) : 0, 663
Telemetry [baseline] (8.66 ms) : 0, 8660
Telemetry [candidate] (8.644 ms) : 0, 8644
IAST [baseline] (21.697 ms) : 0, 21697
IAST [candidate] (21.717 ms) : 0, 21717
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (829.658 ms) : 0, 829658
BytebuddyAgent [candidate] (831.715 ms) : 0, 831715
GlobalTracer [baseline] (247.245 ms) : 0, 247245
GlobalTracer [candidate] (247.946 ms) : 0, 247946
AppSec [baseline] (58.054 ms) : 0, 58054
AppSec [candidate] (58.268 ms) : 0, 58268
Remote Config [baseline] (666.119 µs) : 0, 666
Remote Config [candidate] (686.776 µs) : 0, 687
Telemetry [baseline] (8.487 ms) : 0, 8487
Telemetry [candidate] (8.579 ms) : 0, 8579
IAST [baseline] (21.105 ms) : 0, 21105
IAST [candidate] (21.437 ms) : 0, 21437
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~0ec88c5512, baseline=1.45.0-SNAPSHOT~da26e28ed5

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1049976
Total [baseline] (10.418 s) : 0, 10418177
Agent [candidate] (1.049 s) : 0, 1049276
Total [candidate] (10.396 s) : 0, 10396308
section appsec
Agent [baseline] (1.187 s) : 0, 1186973
Total [baseline] (10.688 s) : 0, 10687608
Agent [candidate] (1.184 s) : 0, 1184203
Total [candidate] (10.716 s) : 0, 10716469
section iast
Agent [baseline] (1.176 s) : 0, 1175634
Total [baseline] (11.005 s) : 0, 11004670
Agent [candidate] (1.173 s) : 0, 1173496
Total [candidate] (10.934 s) : 0, 10934372
section profiling
Agent [baseline] (1.267 s) : 0, 1267406
Total [baseline] (10.786 s) : 0, 10786178
Agent [candidate] (1.271 s) : 0, 1270598
Total [candidate] (10.785 s) : 0, 10784543
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.05 s -
Agent appsec 1.187 s 136.998 ms (13.0%)
Agent iast 1.176 s 125.658 ms (12.0%)
Agent profiling 1.267 s 217.43 ms (20.7%)
Total tracing 10.418 s -
Total appsec 10.688 s 269.432 ms (2.6%)
Total iast 11.005 s 586.493 ms (5.6%)
Total profiling 10.786 s 368.001 ms (3.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent appsec 1.184 s 134.927 ms (12.9%)
Agent iast 1.173 s 124.22 ms (11.8%)
Agent profiling 1.271 s 221.322 ms (21.1%)
Total tracing 10.396 s -
Total appsec 10.716 s 320.161 ms (3.1%)
Total iast 10.934 s 538.064 ms (5.2%)
Total profiling 10.785 s 388.235 ms (3.7%) 
gantt
    title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~0ec88c5512, baseline=1.45.0-SNAPSHOT~da26e28ed5

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (710.969 ms) : 0, 710969
BytebuddyAgent [candidate] (710.292 ms) : 0, 710292
GlobalTracer [baseline] (256.089 ms) : 0, 256089
GlobalTracer [candidate] (256.176 ms) : 0, 256176
AppSec [baseline] (55.059 ms) : 0, 55059
AppSec [candidate] (55.039 ms) : 0, 55039
Remote Config [baseline] (723.423 µs) : 0, 723
Remote Config [candidate] (710.404 µs) : 0, 710
Telemetry [baseline] (12.13 ms) : 0, 12130
Telemetry [candidate] (12.058 ms) : 0, 12058
section appsec
BytebuddyAgent [baseline] (729.225 ms) : 0, 729225
BytebuddyAgent [candidate] (727.292 ms) : 0, 727292
GlobalTracer [baseline] (253.237 ms) : 0, 253237
GlobalTracer [candidate] (252.639 ms) : 0, 252639
AppSec [baseline] (171.143 ms) : 0, 171143
AppSec [candidate] (170.14 ms) : 0, 170140
Remote Config [baseline] (680.861 µs) : 0, 681
Remote Config [candidate] (671.595 µs) : 0, 672
Telemetry [baseline] (8.019 ms) : 0, 8019
Telemetry [candidate] (8.378 ms) : 0, 8378
IAST [baseline] (19.39 ms) : 0, 19390
IAST [candidate] (20.164 ms) : 0, 20164
section iast
BytebuddyAgent [baseline] (825.932 ms) : 0, 825932
BytebuddyAgent [candidate] (824.621 ms) : 0, 824621
GlobalTracer [baseline] (246.204 ms) : 0, 246204
GlobalTracer [candidate] (245.334 ms) : 0, 245334
AppSec [baseline] (58.086 ms) : 0, 58086
AppSec [candidate] (57.954 ms) : 0, 57954
Remote Config [baseline] (654.707 µs) : 0, 655
Remote Config [candidate] (672.55 µs) : 0, 673
Telemetry [baseline] (8.612 ms) : 0, 8612
Telemetry [candidate] (8.564 ms) : 0, 8564
IAST [baseline] (21.239 ms) : 0, 21239
IAST [candidate] (21.429 ms) : 0, 21429
section profiling
ProfilingAgent [baseline] (95.105 ms) : 0, 95105
ProfilingAgent [candidate] (95.241 ms) : 0, 95241
BytebuddyAgent [baseline] (698.128 ms) : 0, 698128
BytebuddyAgent [candidate] (699.83 ms) : 0, 699830
GlobalTracer [baseline] (370.427 ms) : 0, 370427
GlobalTracer [candidate] (371.913 ms) : 0, 371913
AppSec [baseline] (53.862 ms) : 0, 53862
AppSec [candidate] (53.508 ms) : 0, 53508
Remote Config [baseline] (675.475 µs) : 0, 675
Remote Config [candidate] (681.185 µs) : 0, 681
Telemetry [baseline] (7.769 ms) : 0, 7769
Telemetry [candidate] (7.709 ms) : 0, 7709
Profiling [baseline] (95.129 ms) : 0, 95129
Profiling [candidate] (95.265 ms) : 0, 95265
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-12-31T12:55:45 2024-12-31T13:02:42
git_branch master bbujon/context-propagation-cleanup
git_commit_date 1735646307 1735649019
git_commit_sha da26e28 0ec88c5
release_version 1.45.0-SNAPSHOT~da26e28ed5 1.45.0-SNAPSHOT~0ec88c5512
start_time 2024-12-31T12:55:31 2024-12-31T13:02:28
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1735650515 1735650515
ci_job_id 751503770 751503770
ci_pipeline_id 51940780 51940780
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 11 metrics, 16 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling worse
[+32.532µs; +84.423µs] or [+2.171%; +5.633%]		 unstable
[-711.465op/s; +483.545op/s] or [-23.123%; +15.715%]		 1.557ms 2962.963op/s 1.499ms 3076.923op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~0ec88c5512, baseline=1.45.0-SNAPSHOT~da26e28ed5
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.358 ms) : 1338, 1378
.   : milestone, 1358,
appsec (1.743 ms) : 1720, 1767
.   : milestone, 1743,
appsec_no_iast (1.751 ms) : 1725, 1776
.   : milestone, 1751,
iast (1.498 ms) : 1474, 1521
.   : milestone, 1498,
profiling (1.499 ms) : 1475, 1522
.   : milestone, 1499,
tracing (1.474 ms) : 1449, 1498
.   : milestone, 1474,
section candidate
no_agent (1.35 ms) : 1331, 1369
.   : milestone, 1350,
appsec (1.742 ms) : 1718, 1766
.   : milestone, 1742,
appsec_no_iast (1.763 ms) : 1739, 1787
.   : milestone, 1763,
iast (1.487 ms) : 1464, 1510
.   : milestone, 1487,
profiling (1.557 ms) : 1533, 1582
.   : milestone, 1557,
tracing (1.488 ms) : 1463, 1512
.   : milestone, 1488,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.358 ms [1.338 ms, 1.378 ms] -
appsec 1.743 ms [1.72 ms, 1.767 ms] 385.661 µs (28.4%)
appsec_no_iast 1.751 ms [1.725 ms, 1.776 ms] 392.739 µs (28.9%)
iast 1.498 ms [1.474 ms, 1.521 ms] 140.161 µs (10.3%)
profiling 1.499 ms [1.475 ms, 1.522 ms] 140.891 µs (10.4%)
tracing 1.474 ms [1.449 ms, 1.498 ms] 115.908 µs (8.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.35 ms [1.331 ms, 1.369 ms] -
appsec 1.742 ms [1.718 ms, 1.766 ms] 391.835 µs (29.0%)
appsec_no_iast 1.763 ms [1.739 ms, 1.787 ms] 413.348 µs (30.6%)
iast 1.487 ms [1.464 ms, 1.51 ms] 137.003 µs (10.1%)
profiling 1.557 ms [1.533 ms, 1.582 ms] 207.29 µs (15.4%)
tracing 1.488 ms [1.463 ms, 1.512 ms] 137.759 µs (10.2%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~0ec88c5512, baseline=1.45.0-SNAPSHOT~da26e28ed5
    dateFormat X
    axisFormat %s
section baseline
no_agent (374.966 µs) : 355, 395
.   : milestone, 375,
iast (487.764 µs) : 466, 509
.   : milestone, 488,
iast_FULL (653.246 µs) : 632, 675
.   : milestone, 653,
iast_GLOBAL (519.371 µs) : 498, 541
.   : milestone, 519,
iast_HARDCODED_SECRET_DISABLED (497.406 µs) : 476, 519
.   : milestone, 497,
iast_INACTIVE (452.217 µs) : 431, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (483.942 µs) : 462, 506
.   : milestone, 484,
tracing (450.103 µs) : 429, 471
.   : milestone, 450,
section candidate
no_agent (374.016 µs) : 354, 394
.   : milestone, 374,
iast (489.947 µs) : 469, 511
.   : milestone, 490,
iast_FULL (657.295 µs) : 635, 679
.   : milestone, 657,
iast_GLOBAL (525.68 µs) : 503, 548
.   : milestone, 526,
iast_HARDCODED_SECRET_DISABLED (493.01 µs) : 471, 515
.   : milestone, 493,
iast_INACTIVE (451.814 µs) : 430, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (480.038 µs) : 458, 502
.   : milestone, 480,
tracing (446.408 µs) : 426, 467
.   : milestone, 446,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.966 µs [355.027 µs, 394.905 µs] -
iast 487.764 µs [466.197 µs, 509.332 µs] 112.799 µs (30.1%)
iast_FULL 653.246 µs [631.555 µs, 674.937 µs] 278.28 µs (74.2%)
iast_GLOBAL 519.371 µs [497.849 µs, 540.893 µs] 144.405 µs (38.5%)
iast_HARDCODED_SECRET_DISABLED 497.406 µs [475.584 µs, 519.229 µs] 122.44 µs (32.7%)
iast_INACTIVE 452.217 µs [431.272 µs, 473.161 µs] 77.251 µs (20.6%)
iast_TELEMETRY_OFF 483.942 µs [461.958 µs, 505.927 µs] 108.977 µs (29.1%)
tracing 450.103 µs [429.242 µs, 470.964 µs] 75.137 µs (20.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.016 µs [353.815 µs, 394.217 µs] -
iast 489.947 µs [468.529 µs, 511.366 µs] 115.931 µs (31.0%)
iast_FULL 657.295 µs [635.49 µs, 679.1 µs] 283.279 µs (75.7%)
iast_GLOBAL 525.68 µs [503.34 µs, 548.019 µs] 151.664 µs (40.6%)
iast_HARDCODED_SECRET_DISABLED 493.01 µs [471.356 µs, 514.665 µs] 118.994 µs (31.8%)
iast_INACTIVE 451.814 µs [430.318 µs, 473.31 µs] 77.798 µs (20.8%)
iast_TELEMETRY_OFF 480.038 µs [458.455 µs, 501.621 µs] 106.022 µs (28.3%)
tracing 446.408 µs [425.755 µs, 467.06 µs] 72.392 µs (19.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/context-propagation-cleanup
git_commit_date 1735646307 1735649019
git_commit_sha da26e28 0ec88c5
release_version 1.45.0-SNAPSHOT~da26e28ed5 1.45.0-SNAPSHOT~0ec88c5512
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1735651074 1735651074
ci_job_id 751503771 751503771
ci_pipeline_id 51940780 51940780
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~0ec88c5512, baseline=1.45.0-SNAPSHOT~da26e28ed5
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
.   : milestone, 1469,
appsec (2.339 ms) : 2298, 2381
.   : milestone, 2339,
iast (2.085 ms) : 2032, 2138
.   : milestone, 2085,
iast_GLOBAL (2.126 ms) : 2073, 2179
.   : milestone, 2126,
profiling (1.949 ms) : 1907, 1991
.   : milestone, 1949,
tracing (1.928 ms) : 1887, 1968
.   : milestone, 1928,
section candidate
no_agent (1.47 ms) : 1459, 1482
.   : milestone, 1470,
appsec (2.331 ms) : 2289, 2373
.   : milestone, 2331,
iast (2.085 ms) : 2032, 2138
.   : milestone, 2085,
iast_GLOBAL (2.127 ms) : 2074, 2180
.   : milestone, 2127,
profiling (1.961 ms) : 1918, 2004
.   : milestone, 1961,
tracing (1.941 ms) : 1900, 1981
.   : milestone, 1941,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.458 ms, 1.481 ms] -
appsec 2.339 ms [2.298 ms, 2.381 ms] 869.674 µs (59.2%)
iast 2.085 ms [2.032 ms, 2.138 ms] 615.247 µs (41.9%)
iast_GLOBAL 2.126 ms [2.073 ms, 2.179 ms] 656.442 µs (44.7%)
profiling 1.949 ms [1.907 ms, 1.991 ms] 479.746 µs (32.6%)
tracing 1.928 ms [1.887 ms, 1.968 ms] 458.175 µs (31.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.47 ms [1.459 ms, 1.482 ms] -
appsec 2.331 ms [2.289 ms, 2.373 ms] 860.328 µs (58.5%)
iast 2.085 ms [2.032 ms, 2.138 ms] 614.91 µs (41.8%)
iast_GLOBAL 2.127 ms [2.074 ms, 2.18 ms] 656.739 µs (44.7%)
profiling 1.961 ms [1.918 ms, 2.004 ms] 490.795 µs (33.4%)
tracing 1.941 ms [1.9 ms, 1.981 ms] 470.074 µs (32.0%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~0ec88c5512, baseline=1.45.0-SNAPSHOT~da26e28ed5
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.28 s) : 15280000, 15280000
.   : milestone, 15280000,
appsec (15.116 s) : 15116000, 15116000
.   : milestone, 15116000,
iast (19.097 s) : 19097000, 19097000
.   : milestone, 19097000,
iast_GLOBAL (17.814 s) : 17814000, 17814000
.   : milestone, 17814000,
profiling (15.153 s) : 15153000, 15153000
.   : milestone, 15153000,
tracing (15.04 s) : 15040000, 15040000
.   : milestone, 15040000,
section candidate
no_agent (15.26 s) : 15260000, 15260000
.   : milestone, 15260000,
appsec (15.161 s) : 15161000, 15161000
.   : milestone, 15161000,
iast (18.969 s) : 18969000, 18969000
.   : milestone, 18969000,
iast_GLOBAL (17.941 s) : 17941000, 17941000
.   : milestone, 17941000,
profiling (14.986 s) : 14986000, 14986000
.   : milestone, 14986000,
tracing (14.91 s) : 14910000, 14910000
.   : milestone, 14910000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.28 s [15.28 s, 15.28 s] -
appsec 15.116 s [15.116 s, 15.116 s] -164.0 ms (-1.1%)
iast 19.097 s [19.097 s, 19.097 s] 3.817 s (25.0%)
iast_GLOBAL 17.814 s [17.814 s, 17.814 s] 2.534 s (16.6%)
profiling 15.153 s [15.153 s, 15.153 s] -127.0 ms (-0.8%)
tracing 15.04 s [15.04 s, 15.04 s] -240.0 ms (-1.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.26 s [15.26 s, 15.26 s] -
appsec 15.161 s [15.161 s, 15.161 s] -99.0 ms (-0.6%)
iast 18.969 s [18.969 s, 18.969 s] 3.709 s (24.3%)
iast_GLOBAL 17.941 s [17.941 s, 17.941 s] 2.681 s (17.6%)
profiling 14.986 s [14.986 s, 14.986 s] -274.0 ms (-1.8%)
tracing 14.91 s [14.91 s, 14.91 s] -350.0 ms (-2.3%)

@pr-commenter
Copy link

pr-commenter bot commented Dec 31, 2024 •
edited
Loading

Kafka / consumer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/context-propagation-cleanup
git_commit_date 1735568221 1735649019
git_commit_sha 0dc9c08 0ec88c5
See matching parameters
Baseline Candidate
ci_job_date 1735650178 1735650178
ci_job_id 751503774 751503774
ci_pipeline_id 51940780 51940780
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.25 11.0.25
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.25+9-post-Ubuntu-1ubuntu122.04 11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume unsure
[+1430.848op/s; +21186.685op/s] or [+0.474%; +7.013%]
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume same

@PerfectSlayer PerfectSlayer force-pushed the bbujon/context-propagation-cleanup branch from 09e4067 to 256f2bb Compare December 31, 2024 12:15
@PerfectSlayer PerfectSlayer changed the title Clean up pathway binary encoding Clean up DSM pathway binary encoding Dec 31, 2024
@PerfectSlayer PerfectSlayer force-pushed the bbujon/context-propagation-cleanup branch from 256f2bb to 0ec88c5 Compare December 31, 2024 12:44
@PerfectSlayer PerfectSlayer marked this pull request as ready for review December 31, 2024 13:52
@PerfectSlayer PerfectSlayer requested review from a team as code owners December 31, 2024 13:52
@PerfectSlayer PerfectSlayer requested a review from ygree December 31, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
comp: core Tracer core comp: data streams Data Streams Monitoring tag: no release notes Changes to exclude from release notes type: refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PerfectSlayer