PoC of bursty profiles #8149
Draft
PoC of bursty profiles #8149
+132
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| }); | ||
|
|
||
| private class ScheduledTask implements Runnable { | ||
| private final Random rnd = new Random(UUID.randomUUID().getLeastSignificantBits()); |
There was a problem hiding this comment.
⚪ Code Vulnerability
Use of insecure random values (...read more)
Functions as Math.random() and objects like java.util.Random() do not provide strong enough randomness. Consider using java.security.SecureRandom() instead.
jbachorik
force-pushed
the
jb/burst_tracing
branch
from
7e7ba79 to
4b98b6b
Compare
(Similar to Go execution tracing approach)
jbachorik
force-pushed
the
jb/burst_tracing
branch
from
4b98b6b to
d2f96e9
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 57 metrics, 3 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~d2f96e9b60, baseline=1.45.0-SNAPSHOT~a8b33d5c49
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1051956
Total [baseline] (10.454 s) : 0, 10454263
Agent [candidate] (1.054 s) : 0, 1053862
Total [candidate] (10.438 s) : 0, 10437970
section appsec
Agent [baseline] (1.188 s) : 0, 1188413
Total [baseline] (10.738 s) : 0, 10737727
Agent [candidate] (1.187 s) : 0, 1186545
Total [candidate] (10.756 s) : 0, 10755548
section iast
Agent [baseline] (1.187 s) : 0, 1186712
Total [baseline] (11.013 s) : 0, 11012890
Agent [candidate] (1.178 s) : 0, 1178004
Total [candidate] (10.981 s) : 0, 10980721
section profiling
Agent [baseline] (1.275 s) : 0, 1274643
Total [baseline] (10.828 s) : 0, 10827864
Agent [candidate] (1.329 s) : 0, 1329005
Total [candidate] (10.845 s) : 0, 10844753
gantt
title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~d2f96e9b60, baseline=1.45.0-SNAPSHOT~a8b33d5c49
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (712.039 ms) : 0, 712039
BytebuddyAgent [candidate] (712.532 ms) : 0, 712532
GlobalTracer [baseline] (255.983 ms) : 0, 255983
GlobalTracer [candidate] (256.685 ms) : 0, 256685
AppSec [baseline] (55.391 ms) : 0, 55391
AppSec [candidate] (55.298 ms) : 0, 55298
Remote Config [baseline] (720.097 µs) : 0, 720
Remote Config [candidate] (715.238 µs) : 0, 715
Telemetry [baseline] (12.745 ms) : 0, 12745
Telemetry [candidate] (13.487 ms) : 0, 13487
section appsec
BytebuddyAgent [baseline] (730.765 ms) : 0, 730765
BytebuddyAgent [candidate] (729.124 ms) : 0, 729124
GlobalTracer [baseline] (253.329 ms) : 0, 253329
GlobalTracer [candidate] (253.309 ms) : 0, 253309
AppSec [baseline] (171.04 ms) : 0, 171040
AppSec [candidate] (170.58 ms) : 0, 170580
IAST [baseline] (19.227 ms) : 0, 19227
IAST [candidate] (19.511 ms) : 0, 19511
Remote Config [baseline] (658.368 µs) : 0, 658
Remote Config [candidate] (666.042 µs) : 0, 666
Telemetry [baseline] (8.034 ms) : 0, 8034
Telemetry [candidate] (8.091 ms) : 0, 8091
section iast
BytebuddyAgent [baseline] (835.063 ms) : 0, 835063
BytebuddyAgent [candidate] (827.915 ms) : 0, 827915
GlobalTracer [baseline] (247.673 ms) : 0, 247673
GlobalTracer [candidate] (246.248 ms) : 0, 246248
AppSec [baseline] (58.176 ms) : 0, 58176
AppSec [candidate] (57.91 ms) : 0, 57910
IAST [baseline] (21.485 ms) : 0, 21485
IAST [candidate] (21.646 ms) : 0, 21646
Remote Config [baseline] (662.449 µs) : 0, 662
Remote Config [candidate] (658.542 µs) : 0, 659
Telemetry [baseline] (8.575 ms) : 0, 8575
Telemetry [candidate] (8.615 ms) : 0, 8615
section profiling
BytebuddyAgent [baseline] (701.956 ms) : 0, 701956
BytebuddyAgent [candidate] (706.855 ms) : 0, 706855
GlobalTracer [baseline] (372.836 ms) : 0, 372836
GlobalTracer [candidate] (374.995 ms) : 0, 374995
AppSec [baseline] (53.67 ms) : 0, 53670
AppSec [candidate] (54.277 ms) : 0, 54277
Remote Config [baseline] (656.825 µs) : 0, 657
Remote Config [candidate] (669.469 µs) : 0, 669
Telemetry [baseline] (7.863 ms) : 0, 7863
Telemetry [candidate] (7.937 ms) : 0, 7937
ProfilingAgent [baseline] (95.896 ms) : 0, 95896
ProfilingAgent [candidate] (142.228 ms) : 0, 142228
Profiling [baseline] (95.92 ms) : 0, 95920
Profiling [candidate] (142.254 ms) : 0, 142254
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~d2f96e9b60, baseline=1.45.0-SNAPSHOT~a8b33d5c49
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1057291
Total [baseline] (8.681 s) : 0, 8681208
Agent [candidate] (1.05 s) : 0, 1050133
Total [candidate] (8.642 s) : 0, 8642042
section iast
Agent [baseline] (1.18 s) : 0, 1180477
Total [baseline] (9.219 s) : 0, 9219322
Agent [candidate] (1.18 s) : 0, 1180305
Total [candidate] (9.194 s) : 0, 9194396
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.18 s) : 0, 1180363
Total [baseline] (9.199 s) : 0, 9198582
Agent [candidate] (1.18 s) : 0, 1180004
Total [candidate] (9.196 s) : 0, 9196120
section iast_TELEMETRY_OFF
Agent [baseline] (1.182 s) : 0, 1181970
Total [baseline] (9.19 s) : 0, 9189656
Agent [candidate] (1.178 s) : 0, 1178159
Total [candidate] (9.169 s) : 0, 9169261
gantt
title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~d2f96e9b60, baseline=1.45.0-SNAPSHOT~a8b33d5c49
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.79 ms) : 0, 717790
BytebuddyAgent [candidate] (711.698 ms) : 0, 711698
GlobalTracer [baseline] (257.033 ms) : 0, 257033
GlobalTracer [candidate] (256.285 ms) : 0, 256285
AppSec [baseline] (55.289 ms) : 0, 55289
AppSec [candidate] (55.097 ms) : 0, 55097
Remote Config [baseline] (716.836 µs) : 0, 717
Remote Config [candidate] (724.205 µs) : 0, 724
Telemetry [baseline] (11.313 ms) : 0, 11313
Telemetry [candidate] (11.299 ms) : 0, 11299
section iast
BytebuddyAgent [baseline] (829.89 ms) : 0, 829890
BytebuddyAgent [candidate] (829.673 ms) : 0, 829673
GlobalTracer [baseline] (246.68 ms) : 0, 246680
GlobalTracer [candidate] (246.812 ms) : 0, 246812
AppSec [baseline] (58.05 ms) : 0, 58050
AppSec [candidate] (58.154 ms) : 0, 58154
IAST [baseline] (21.622 ms) : 0, 21622
IAST [candidate] (21.475 ms) : 0, 21475
Remote Config [baseline] (659.979 µs) : 0, 660
Remote Config [candidate] (652.268 µs) : 0, 652
Telemetry [baseline] (8.563 ms) : 0, 8563
Telemetry [candidate] (8.524 ms) : 0, 8524
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (829.427 ms) : 0, 829427
BytebuddyAgent [candidate] (829.425 ms) : 0, 829425
GlobalTracer [baseline] (246.789 ms) : 0, 246789
GlobalTracer [candidate] (247.265 ms) : 0, 247265
AppSec [baseline] (58.361 ms) : 0, 58361
AppSec [candidate] (57.898 ms) : 0, 57898
IAST [baseline] (21.541 ms) : 0, 21541
IAST [candidate] (21.243 ms) : 0, 21243
Remote Config [baseline] (670.004 µs) : 0, 670
Remote Config [candidate] (645.286 µs) : 0, 645
Telemetry [baseline] (8.58 ms) : 0, 8580
Telemetry [candidate] (8.429 ms) : 0, 8429
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (831.286 ms) : 0, 831286
BytebuddyAgent [candidate] (827.85 ms) : 0, 827850
GlobalTracer [baseline] (247.557 ms) : 0, 247557
GlobalTracer [candidate] (246.951 ms) : 0, 246951
AppSec [baseline] (57.884 ms) : 0, 57884
AppSec [candidate] (58.061 ms) : 0, 58061
IAST [baseline] (21.08 ms) : 0, 21080
IAST [candidate] (20.998 ms) : 0, 20998
Remote Config [baseline] (658.527 µs) : 0, 659
Remote Config [candidate] (658.339 µs) : 0, 658
Telemetry [baseline] (8.442 ms) : 0, 8442
Telemetry [candidate] (8.551 ms) : 0, 8551
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~d2f96e9b60, baseline=1.45.0-SNAPSHOT~a8b33d5c49
dateFormat X
axisFormat %s
section baseline
no_agent (378.086 µs) : 356, 400
. : milestone, 378,
iast (487.944 µs) : 467, 509
. : milestone, 488,
iast_FULL (655.445 µs) : 634, 677
. : milestone, 655,
iast_GLOBAL (520.7 µs) : 498, 543
. : milestone, 521,
iast_HARDCODED_SECRET_DISABLED (487.327 µs) : 466, 509
. : milestone, 487,
iast_INACTIVE (451.952 µs) : 431, 473
. : milestone, 452,
iast_TELEMETRY_OFF (475.959 µs) : 454, 498
. : milestone, 476,
tracing (443.415 µs) : 423, 464
. : milestone, 443,
section candidate
no_agent (372.703 µs) : 352, 393
. : milestone, 373,
iast (484.939 µs) : 463, 506
. : milestone, 485,
iast_FULL (650.812 µs) : 629, 672
. : milestone, 651,
iast_GLOBAL (513.893 µs) : 492, 535
. : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (491.492 µs) : 470, 513
. : milestone, 491,
iast_INACTIVE (449.795 µs) : 429, 471
. : milestone, 450,
iast_TELEMETRY_OFF (478.162 µs) : 457, 500
. : milestone, 478,
tracing (442.545 µs) : 422, 463
. : milestone, 443,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~d2f96e9b60, baseline=1.45.0-SNAPSHOT~a8b33d5c49
dateFormat X
axisFormat %s
section baseline
no_agent (1.349 ms) : 1329, 1368
. : milestone, 1349,
appsec (1.741 ms) : 1717, 1765
. : milestone, 1741,
appsec_no_iast (1.733 ms) : 1709, 1758
. : milestone, 1733,
iast (1.486 ms) : 1463, 1510
. : milestone, 1486,
profiling (1.522 ms) : 1498, 1547
. : milestone, 1522,
tracing (1.503 ms) : 1478, 1528
. : milestone, 1503,
section candidate
no_agent (1.361 ms) : 1342, 1381
. : milestone, 1361,
appsec (1.752 ms) : 1728, 1776
. : milestone, 1752,
appsec_no_iast (1.74 ms) : 1717, 1763
. : milestone, 1740,
iast (1.481 ms) : 1458, 1504
. : milestone, 1481,
profiling (1.495 ms) : 1471, 1519
. : milestone, 1495,
tracing (1.476 ms) : 1451, 1501
. : milestone, 1476,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~d2f96e9b60, baseline=1.45.0-SNAPSHOT~a8b33d5c49
dateFormat X
axisFormat %s
section baseline
no_agent (14.67 s) : 14670000, 14670000
. : milestone, 14670000,
appsec (15.103 s) : 15103000, 15103000
. : milestone, 15103000,
iast (18.478 s) : 18478000, 18478000
. : milestone, 18478000,
iast_GLOBAL (18.019 s) : 18019000, 18019000
. : milestone, 18019000,
profiling (15.088 s) : 15088000, 15088000
. : milestone, 15088000,
tracing (15.021 s) : 15021000, 15021000
. : milestone, 15021000,
section candidate
no_agent (15.409 s) : 15409000, 15409000
. : milestone, 15409000,
appsec (15.143 s) : 15143000, 15143000
. : milestone, 15143000,
iast (18.541 s) : 18541000, 18541000
. : milestone, 18541000,
iast_GLOBAL (17.643 s) : 17643000, 17643000
. : milestone, 17643000,
profiling (15.529 s) : 15529000, 15529000
. : milestone, 15529000,
tracing (15.183 s) : 15183000, 15183000
. : milestone, 15183000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~d2f96e9b60, baseline=1.45.0-SNAPSHOT~a8b33d5c49
dateFormat X
axisFormat %s
section baseline
no_agent (1.466 ms) : 1454, 1477
. : milestone, 1466,
appsec (2.339 ms) : 2297, 2381
. : milestone, 2339,
iast (2.09 ms) : 2037, 2143
. : milestone, 2090,
iast_GLOBAL (2.127 ms) : 2074, 2181
. : milestone, 2127,
profiling (2.437 ms) : 2193, 2682
. : milestone, 2437,
tracing (1.922 ms) : 1881, 1962
. : milestone, 1922,
section candidate
no_agent (1.464 ms) : 1453, 1476
. : milestone, 1464,
appsec (2.34 ms) : 2298, 2382
. : milestone, 2340,
iast (2.08 ms) : 2028, 2133
. : milestone, 2080,
iast_GLOBAL (2.127 ms) : 2074, 2181
. : milestone, 2127,
profiling (2.442 ms) : 2253, 2631
. : milestone, 2442,
tracing (1.925 ms) : 1884, 1966
. : milestone, 1925,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This is a PoC of bursty profiling that would temporarily lower thresholds for latency events for a short time.
Motivation
Mostly validation of the concept - improving the level of details for the latency profiles by having short bursts of high precision data with much longer intervals of data of coarser granularity (but at much lower cost).
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]