-
Notifications
You must be signed in to change notification settings - Fork 312
Refactor JUnit4 @Rule
to JUnit5 @TempDir
.
#9524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AlexeyKuznetsov-DD
merged 1 commit into
master
from
alexeyk/refactor-junit4-temporary-folder-rule
Sep 12, 2025
Merged
Refactor JUnit4 @Rule
to JUnit5 @TempDir
.
#9524
AlexeyKuznetsov-DD
merged 1 commit into
master
from
alexeyk/refactor-junit4-temporary-folder-rule
Sep 12, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-tkachenko-datadog
approved these changes
Sep 12, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~d4cabd4a56, baseline=1.54.0-SNAPSHOT~3b4a22b8c3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.068 s) : 0, 1067715
Total [baseline] (8.65 s) : 0, 8649973
Agent [candidate] (1.064 s) : 0, 1064025
Total [candidate] (8.636 s) : 0, 8636325
section iast
Agent [baseline] (1.19 s) : 0, 1190415
Total [baseline] (9.297 s) : 0, 9297104
Agent [candidate] (1.189 s) : 0, 1189244
Total [candidate] (9.355 s) : 0, 9354890
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~d4cabd4a56, baseline=1.54.0-SNAPSHOT~3b4a22b8c3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (737.17 ms) : 0, 737170
BytebuddyAgent [candidate] (735.153 ms) : 0, 735153
GlobalTracer [baseline] (253.38 ms) : 0, 253380
GlobalTracer [candidate] (252.554 ms) : 0, 252554
AppSec [baseline] (30.992 ms) : 0, 30992
AppSec [candidate] (30.597 ms) : 0, 30597
Debugger [baseline] (6.493 ms) : 0, 6493
Debugger [candidate] (6.395 ms) : 0, 6395
Remote Config [baseline] (693.183 µs) : 0, 693
Remote Config [candidate] (681.999 µs) : 0, 682
Telemetry [baseline] (16.421 ms) : 0, 16421
Telemetry [candidate] (16.128 ms) : 0, 16128
section iast
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (852.585 ms) : 0, 852585
BytebuddyAgent [candidate] (851.433 ms) : 0, 851433
GlobalTracer [baseline] (244.417 ms) : 0, 244417
GlobalTracer [candidate] (245.832 ms) : 0, 245832
IAST [baseline] (29.728 ms) : 0, 29728
IAST [candidate] (29.078 ms) : 0, 29078
AppSec [baseline] (26.384 ms) : 0, 26384
AppSec [candidate] (25.561 ms) : 0, 25561
Debugger [baseline] (6.065 ms) : 0, 6065
Debugger [candidate] (6.101 ms) : 0, 6101
Remote Config [baseline] (596.981 µs) : 0, 597
Remote Config [candidate] (596.193 µs) : 0, 596
Telemetry [baseline] (8.238 ms) : 0, 8238
Telemetry [candidate] (8.241 ms) : 0, 8241
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~d4cabd4a56, baseline=1.54.0-SNAPSHOT~3b4a22b8c3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062843
Total [baseline] (10.667 s) : 0, 10666540
Agent [candidate] (1.064 s) : 0, 1064326
Total [candidate] (10.8 s) : 0, 10800332
section appsec
Agent [baseline] (1.235 s) : 0, 1235380
Total [baseline] (10.949 s) : 0, 10949020
Agent [candidate] (1.238 s) : 0, 1238016
Total [candidate] (11.148 s) : 0, 11148481
section iast
Agent [baseline] (1.192 s) : 0, 1191659
Total [baseline] (11.021 s) : 0, 11021099
Agent [candidate] (1.191 s) : 0, 1190947
Total [candidate] (11.063 s) : 0, 11062872
section profiling
Agent [baseline] (1.21 s) : 0, 1209755
Total [baseline] (10.924 s) : 0, 10924493
Agent [candidate] (1.218 s) : 0, 1217917
Total [candidate] (11.071 s) : 0, 11070904
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~d4cabd4a56, baseline=1.54.0-SNAPSHOT~3b4a22b8c3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.443 ms) : 0, 1443
BytebuddyAgent [baseline] (733.596 ms) : 0, 733596
BytebuddyAgent [candidate] (734.788 ms) : 0, 734788
GlobalTracer [baseline] (252.641 ms) : 0, 252641
GlobalTracer [candidate] (252.886 ms) : 0, 252886
AppSec [baseline] (30.628 ms) : 0, 30628
AppSec [candidate] (30.645 ms) : 0, 30645
Debugger [baseline] (6.366 ms) : 0, 6366
Debugger [candidate] (6.396 ms) : 0, 6396
Remote Config [baseline] (697.959 µs) : 0, 698
Remote Config [candidate] (681.012 µs) : 0, 681
Telemetry [baseline] (16.347 ms) : 0, 16347
Telemetry [candidate] (16.344 ms) : 0, 16344
section appsec
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (755.59 ms) : 0, 755590
BytebuddyAgent [candidate] (757.719 ms) : 0, 757719
GlobalTracer [baseline] (246.54 ms) : 0, 246540
GlobalTracer [candidate] (246.109 ms) : 0, 246109
AppSec [baseline] (171.499 ms) : 0, 171499
AppSec [candidate] (172.398 ms) : 0, 172398
Debugger [baseline] (6.033 ms) : 0, 6033
Debugger [candidate] (6.115 ms) : 0, 6115
Remote Config [baseline] (615.623 µs) : 0, 616
Remote Config [candidate] (642.121 µs) : 0, 642
Telemetry [baseline] (8.39 ms) : 0, 8390
Telemetry [candidate] (8.599 ms) : 0, 8599
IAST [baseline] (24.012 ms) : 0, 24012
IAST [candidate] (23.754 ms) : 0, 23754
section iast
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (852.932 ms) : 0, 852932
BytebuddyAgent [candidate] (852.69 ms) : 0, 852690
GlobalTracer [baseline] (249.083 ms) : 0, 249083
GlobalTracer [candidate] (245.991 ms) : 0, 245991
AppSec [baseline] (24.865 ms) : 0, 24865
AppSec [candidate] (24.562 ms) : 0, 24562
Debugger [baseline] (6.088 ms) : 0, 6088
Debugger [candidate] (6.073 ms) : 0, 6073
Remote Config [baseline] (614.798 µs) : 0, 615
Remote Config [candidate] (591.164 µs) : 0, 591
Telemetry [baseline] (8.242 ms) : 0, 8242
Telemetry [candidate] (8.112 ms) : 0, 8112
IAST [baseline] (27.325 ms) : 0, 27325
IAST [candidate] (30.426 ms) : 0, 30426
section profiling
ProfilingAgent [baseline] (108.692 ms) : 0, 108692
ProfilingAgent [candidate] (108.141 ms) : 0, 108141
crashtracking [baseline] (1.436 ms) : 0, 1436
crashtracking [candidate] (1.441 ms) : 0, 1441
BytebuddyAgent [baseline] (761.262 ms) : 0, 761262
BytebuddyAgent [candidate] (767.656 ms) : 0, 767656
GlobalTracer [baseline] (232.702 ms) : 0, 232702
GlobalTracer [candidate] (234.764 ms) : 0, 234764
AppSec [baseline] (30.286 ms) : 0, 30286
AppSec [candidate] (31.474 ms) : 0, 31474
Debugger [baseline] (8.299 ms) : 0, 8299
Debugger [candidate] (8.2 ms) : 0, 8200
Remote Config [baseline] (713.323 µs) : 0, 713
Remote Config [candidate] (731.125 µs) : 0, 731
Telemetry [baseline] (15.435 ms) : 0, 15435
Telemetry [candidate] (14.164 ms) : 0, 14164
Profiling [baseline] (109.355 ms) : 0, 109355
Profiling [candidate] (108.789 ms) : 0, 108789
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~d4cabd4a56, baseline=1.54.0-SNAPSHOT~3b4a22b8c3
dateFormat X
axisFormat %s
section baseline
no_agent (37.552 ms) : 37246, 37857
. : milestone, 37552,
appsec (48.417 ms) : 47982, 48852
. : milestone, 48417,
code_origins (45.298 ms) : 44906, 45690
. : milestone, 45298,
iast (44.646 ms) : 44268, 45025
. : milestone, 44646,
profiling (48.788 ms) : 48332, 49243
. : milestone, 48788,
tracing (45.048 ms) : 44666, 45429
. : milestone, 45048,
section candidate
no_agent (36.746 ms) : 36451, 37041
. : milestone, 36746,
appsec (50.25 ms) : 49787, 50714
. : milestone, 50250,
code_origins (44.114 ms) : 43724, 44503
. : milestone, 44114,
iast (45.924 ms) : 45514, 46334
. : milestone, 45924,
profiling (49.68 ms) : 49227, 50132
. : milestone, 49680,
tracing (43.033 ms) : 42675, 43391
. : milestone, 43033,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~d4cabd4a56, baseline=1.54.0-SNAPSHOT~3b4a22b8c3
dateFormat X
axisFormat %s
section baseline
no_agent (4.148 ms) : 4102, 4194
. : milestone, 4148,
iast (9.709 ms) : 9547, 9870
. : milestone, 9709,
iast_FULL (14.329 ms) : 14044, 14615
. : milestone, 14329,
iast_GLOBAL (10.055 ms) : 9875, 10235
. : milestone, 10055,
profiling (8.963 ms) : 8819, 9107
. : milestone, 8963,
tracing (7.849 ms) : 7737, 7961
. : milestone, 7849,
section candidate
no_agent (4.38 ms) : 4330, 4429
. : milestone, 4380,
iast (9.533 ms) : 9377, 9689
. : milestone, 9533,
iast_FULL (14.298 ms) : 14013, 14583
. : milestone, 14298,
iast_GLOBAL (10.6 ms) : 10413, 10787
. : milestone, 10600,
profiling (8.956 ms) : 8804, 9108
. : milestone, 8956,
tracing (7.842 ms) : 7722, 7963
. : milestone, 7842,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~d4cabd4a56, baseline=1.54.0-SNAPSHOT~3b4a22b8c3
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.729 ms) : 3512, 3945
. : milestone, 3729,
iast (2.213 ms) : 2150, 2276
. : milestone, 2213,
iast_GLOBAL (2.249 ms) : 2186, 2312
. : milestone, 2249,
profiling (2.069 ms) : 2017, 2122
. : milestone, 2069,
tracing (2.039 ms) : 1990, 2089
. : milestone, 2039,
section candidate
no_agent (1.484 ms) : 1472, 1495
. : milestone, 1484,
appsec (3.755 ms) : 3531, 3979
. : milestone, 3755,
iast (2.211 ms) : 2148, 2273
. : milestone, 2211,
iast_GLOBAL (2.248 ms) : 2185, 2311
. : milestone, 2248,
profiling (2.074 ms) : 2022, 2126
. : milestone, 2074,
tracing (2.026 ms) : 1977, 2075
. : milestone, 2026,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~d4cabd4a56, baseline=1.54.0-SNAPSHOT~3b4a22b8c3
dateFormat X
axisFormat %s
section baseline
no_agent (15.363 s) : 15363000, 15363000
. : milestone, 15363000,
appsec (14.878 s) : 14878000, 14878000
. : milestone, 14878000,
iast (18.38 s) : 18380000, 18380000
. : milestone, 18380000,
iast_GLOBAL (18.1 s) : 18100000, 18100000
. : milestone, 18100000,
profiling (15.761 s) : 15761000, 15761000
. : milestone, 15761000,
tracing (14.77 s) : 14770000, 14770000
. : milestone, 14770000,
section candidate
no_agent (15.02 s) : 15020000, 15020000
. : milestone, 15020000,
appsec (15.08 s) : 15080000, 15080000
. : milestone, 15080000,
iast (18.445 s) : 18445000, 18445000
. : milestone, 18445000,
iast_GLOBAL (18.108 s) : 18108000, 18108000
. : milestone, 18108000,
profiling (15.47 s) : 15470000, 15470000
. : milestone, 15470000,
tracing (15.093 s) : 15093000, 15093000
. : milestone, 15093000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Refactors tests to replace JUnit4
@Rule
usage with JUnit5’s@TempDir
.Motivation
Improves code clarity and consistency by aligning with JUnit5 APIs. This removes legacy JUnit4 dependencies and moves the test suite fully onto JUnit5.
Additional Notes
This PR is a follow-up for #9445.