-
Notifications
You must be signed in to change notification settings - Fork 312
Add downstream HTTP request/response analysis for OkHttp2 client #9572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 46 metrics, 10 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~4ce366c83a, baseline=1.54.0-SNAPSHOT~fc0582d498
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.028 s) : 0, 1028308
Total [baseline] (8.729 s) : 0, 8729008
Agent [candidate] (1.024 s) : 0, 1024180
Total [candidate] (8.711 s) : 0, 8710723
section iast
Agent [baseline] (1.155 s) : 0, 1154892
Total [baseline] (9.392 s) : 0, 9391669
Agent [candidate] (1.156 s) : 0, 1155520
Total [candidate] (9.346 s) : 0, 9345853
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~4ce366c83a, baseline=1.54.0-SNAPSHOT~fc0582d498
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (693.011 ms) : 0, 693011
BytebuddyAgent [candidate] (688.746 ms) : 0, 688746
GlobalTracer [baseline] (259.995 ms) : 0, 259995
GlobalTracer [candidate] (259.366 ms) : 0, 259366
AppSec [baseline] (31.959 ms) : 0, 31959
AppSec [candidate] (33.209 ms) : 0, 33209
Debugger [baseline] (6.39 ms) : 0, 6390
Debugger [candidate] (6.307 ms) : 0, 6307
Remote Config [baseline] (685.563 µs) : 0, 686
Remote Config [candidate] (716.903 µs) : 0, 717
Telemetry [baseline] (13.669 ms) : 0, 13669
Telemetry [candidate] (13.358 ms) : 0, 13358
section iast
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.475 ms) : 0, 1475
BytebuddyAgent [baseline] (809.081 ms) : 0, 809081
BytebuddyAgent [candidate] (808.089 ms) : 0, 808089
GlobalTracer [baseline] (249.163 ms) : 0, 249163
GlobalTracer [candidate] (249.707 ms) : 0, 249707
AppSec [baseline] (27.245 ms) : 0, 27245
AppSec [candidate] (28.743 ms) : 0, 28743
Debugger [baseline] (6.109 ms) : 0, 6109
Debugger [candidate] (7.008 ms) : 0, 7008
Remote Config [baseline] (610.075 µs) : 0, 610
Remote Config [candidate] (600.26 µs) : 0, 600
Telemetry [baseline] (8.148 ms) : 0, 8148
Telemetry [candidate] (8.162 ms) : 0, 8162
IAST [baseline] (32.096 ms) : 0, 32096
IAST [candidate] (30.77 ms) : 0, 30770
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~4ce366c83a, baseline=1.54.0-SNAPSHOT~fc0582d498
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1018890
Total [baseline] (10.716 s) : 0, 10716395
Agent [candidate] (1.02 s) : 0, 1019834
Total [candidate] (10.728 s) : 0, 10728446
section appsec
Agent [baseline] (1.198 s) : 0, 1198290
Total [baseline] (11.074 s) : 0, 11074462
Agent [candidate] (1.198 s) : 0, 1198325
Total [candidate] (10.968 s) : 0, 10967596
section iast
Agent [baseline] (1.154 s) : 0, 1153734
Total [baseline] (11.052 s) : 0, 11052118
Agent [candidate] (1.157 s) : 0, 1157460
Total [candidate] (11.148 s) : 0, 11147567
section profiling
Agent [baseline] (1.164 s) : 0, 1164075
Total [baseline] (11.082 s) : 0, 11082157
Agent [candidate] (1.172 s) : 0, 1172483
Total [candidate] (11.1 s) : 0, 11099995
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~4ce366c83a, baseline=1.54.0-SNAPSHOT~fc0582d498
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.443 ms) : 0, 1443
BytebuddyAgent [baseline] (686.983 ms) : 0, 686983
BytebuddyAgent [candidate] (685.921 ms) : 0, 685921
GlobalTracer [baseline] (258.786 ms) : 0, 258786
GlobalTracer [candidate] (258.576 ms) : 0, 258576
AppSec [baseline] (31.771 ms) : 0, 31771
AppSec [candidate] (33.351 ms) : 0, 33351
Debugger [baseline] (6.346 ms) : 0, 6346
Debugger [candidate] (6.371 ms) : 0, 6371
Remote Config [baseline] (692.135 µs) : 0, 692
Remote Config [candidate] (718.027 µs) : 0, 718
Telemetry [baseline] (11.8 ms) : 0, 11800
Telemetry [candidate] (12.386 ms) : 0, 12386
section appsec
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (711.786 ms) : 0, 711786
BytebuddyAgent [candidate] (710.526 ms) : 0, 710526
GlobalTracer [baseline] (251.4 ms) : 0, 251400
GlobalTracer [candidate] (251.058 ms) : 0, 251058
IAST [baseline] (25.042 ms) : 0, 25042
IAST [candidate] (24.972 ms) : 0, 24972
AppSec [baseline] (170.823 ms) : 0, 170823
AppSec [candidate] (171.683 ms) : 0, 171683
Debugger [baseline] (6.082 ms) : 0, 6082
Debugger [candidate] (6.052 ms) : 0, 6052
Remote Config [baseline] (615.858 µs) : 0, 616
Remote Config [candidate] (648.708 µs) : 0, 649
Telemetry [baseline] (9.863 ms) : 0, 9863
Telemetry [candidate] (10.785 ms) : 0, 10785
section iast
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (807.85 ms) : 0, 807850
BytebuddyAgent [candidate] (809.458 ms) : 0, 809458
GlobalTracer [baseline] (249.609 ms) : 0, 249609
GlobalTracer [candidate] (249.626 ms) : 0, 249626
IAST [baseline] (30.678 ms) : 0, 30678
IAST [candidate] (31.2 ms) : 0, 31200
AppSec [baseline] (28.133 ms) : 0, 28133
AppSec [candidate] (29.711 ms) : 0, 29711
Debugger [baseline] (6.109 ms) : 0, 6109
Debugger [candidate] (6.138 ms) : 0, 6138
Remote Config [baseline] (613.28 µs) : 0, 613
Remote Config [candidate] (617.508 µs) : 0, 618
Telemetry [baseline] (8.146 ms) : 0, 8146
Telemetry [candidate] (8.249 ms) : 0, 8249
section profiling
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.447 ms) : 0, 1447
BytebuddyAgent [baseline] (718.161 ms) : 0, 718161
BytebuddyAgent [candidate] (723.138 ms) : 0, 723138
GlobalTracer [baseline] (236.474 ms) : 0, 236474
GlobalTracer [candidate] (237.54 ms) : 0, 237540
AppSec [baseline] (31.229 ms) : 0, 31229
AppSec [candidate] (33.024 ms) : 0, 33024
Debugger [baseline] (6.498 ms) : 0, 6498
Debugger [candidate] (6.547 ms) : 0, 6547
Remote Config [baseline] (706.088 µs) : 0, 706
Remote Config [candidate] (812.606 µs) : 0, 813
Telemetry [baseline] (16.697 ms) : 0, 16697
Telemetry [candidate] (16.564 ms) : 0, 16564
ProfilingAgent [baseline] (101.829 ms) : 0, 101829
ProfilingAgent [candidate] (101.912 ms) : 0, 101912
Profiling [baseline] (102.422 ms) : 0, 102422
Profiling [candidate] (102.506 ms) : 0, 102506
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 11 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~4ce366c83a, baseline=1.54.0-SNAPSHOT~fc0582d498
dateFormat X
axisFormat %s
section baseline
no_agent (36.672 ms) : 36387, 36957
. : milestone, 36672,
appsec (50.194 ms) : 49737, 50652
. : milestone, 50194,
code_origins (45.111 ms) : 44722, 45500
. : milestone, 45111,
iast (45.942 ms) : 45539, 46345
. : milestone, 45942,
profiling (48.568 ms) : 48113, 49023
. : milestone, 48568,
tracing (44.65 ms) : 44279, 45021
. : milestone, 44650,
section candidate
no_agent (36.893 ms) : 36604, 37182
. : milestone, 36893,
appsec (50.819 ms) : 50389, 51248
. : milestone, 50819,
code_origins (46.579 ms) : 46170, 46987
. : milestone, 46579,
iast (44.758 ms) : 44371, 45145
. : milestone, 44758,
profiling (48.971 ms) : 48544, 49398
. : milestone, 48971,
tracing (44.924 ms) : 44528, 45319
. : milestone, 44924,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~4ce366c83a, baseline=1.54.0-SNAPSHOT~fc0582d498
dateFormat X
axisFormat %s
section baseline
no_agent (4.445 ms) : 4396, 4495
. : milestone, 4445,
iast (9.638 ms) : 9475, 9802
. : milestone, 9638,
iast_FULL (14.499 ms) : 14214, 14784
. : milestone, 14499,
iast_GLOBAL (10.525 ms) : 10340, 10710
. : milestone, 10525,
profiling (8.918 ms) : 8780, 9056
. : milestone, 8918,
tracing (7.948 ms) : 7827, 8070
. : milestone, 7948,
section candidate
no_agent (4.506 ms) : 4456, 4555
. : milestone, 4506,
iast (9.931 ms) : 9762, 10100
. : milestone, 9931,
iast_FULL (14.228 ms) : 13944, 14511
. : milestone, 14228,
iast_GLOBAL (10.763 ms) : 10573, 10953
. : milestone, 10763,
profiling (9.111 ms) : 8967, 9254
. : milestone, 9111,
tracing (7.761 ms) : 7648, 7874
. : milestone, 7761,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~4ce366c83a, baseline=1.54.0-SNAPSHOT~fc0582d498
dateFormat X
axisFormat %s
section baseline
no_agent (15.546 s) : 15546000, 15546000
. : milestone, 15546000,
appsec (15.095 s) : 15095000, 15095000
. : milestone, 15095000,
iast (18.812 s) : 18812000, 18812000
. : milestone, 18812000,
iast_GLOBAL (18.209 s) : 18209000, 18209000
. : milestone, 18209000,
profiling (15.059 s) : 15059000, 15059000
. : milestone, 15059000,
tracing (15.005 s) : 15005000, 15005000
. : milestone, 15005000,
section candidate
no_agent (15.384 s) : 15384000, 15384000
. : milestone, 15384000,
appsec (15.151 s) : 15151000, 15151000
. : milestone, 15151000,
iast (18.337 s) : 18337000, 18337000
. : milestone, 18337000,
iast_GLOBAL (18.123 s) : 18123000, 18123000
. : milestone, 18123000,
profiling (15.294 s) : 15294000, 15294000
. : milestone, 15294000,
tracing (14.961 s) : 14961000, 14961000
. : milestone, 14961000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~4ce366c83a, baseline=1.54.0-SNAPSHOT~fc0582d498
dateFormat X
axisFormat %s
section baseline
no_agent (1.483 ms) : 1472, 1495
. : milestone, 1483,
appsec (2.454 ms) : 2404, 2505
. : milestone, 2454,
iast (2.205 ms) : 2141, 2269
. : milestone, 2205,
iast_GLOBAL (2.253 ms) : 2189, 2316
. : milestone, 2253,
profiling (2.056 ms) : 2005, 2107
. : milestone, 2056,
tracing (2.033 ms) : 1983, 2082
. : milestone, 2033,
section candidate
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (3.716 ms) : 3498, 3935
. : milestone, 3716,
iast (2.201 ms) : 2138, 2264
. : milestone, 2201,
iast_GLOBAL (2.249 ms) : 2186, 2313
. : milestone, 2249,
profiling (2.075 ms) : 2022, 2128
. : milestone, 2075,
tracing (2.027 ms) : 1978, 2076
. : milestone, 2027,
|
e10c32e
to
094375b
Compare
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
fe39167
to
1dae6dc
Compare
1dae6dc
to
86ba6d2
Compare
86ba6d2
to
4ce366c
Compare
🎯 Code Coverage 🔗 Commit SHA: 4ce366c | Docs | Was this helpful? Give us feedback! |
What Does This Do
Adds support for downstream HTTP request and response analysis in the OkHttp2 client instrumentation.
Motivation
Enable AppSec to analyze outbound requests made through OkHttp2. This expands coverage for API security and SSRF protections, while supporting downstream traffic inspection with configurable sampling.
Additional Notes
RFC
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APPSEC-58613