-
Couldn't load subscription status.
- Fork 315
Bump spotbugs gradle plugin to 6.4.4 #9748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…internal-api Also this forces JDK 11 to be the minimum.
# Conflicts: # communication/src/main/java/datadog/communication/ddagent/SharedCommunicationObjects.java # utils/test-utils/src/main/groovy/datadog/trace/test/util/DDSpecification.groovy
Debugger benchmarksParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 6 metrics, 6 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (322.865 µs) : 284, 362
. : milestone, 323,
basic (292.34 µs) : 286, 299
. : milestone, 292,
loop (8.956 ms) : 8953, 8959
. : milestone, 8956,
section candidate
noprobe (331.706 µs) : 280, 383
. : milestone, 332,
basic (279.828 µs) : 273, 286
. : milestone, 280,
loop (8.956 ms) : 8950, 8962
. : milestone, 8956,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~b4b8e6468d, baseline=1.55.0-SNAPSHOT~b733cdaf4e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1042013
Total [baseline] (10.834 s) : 0, 10833701
Agent [candidate] (1.038 s) : 0, 1038449
Total [candidate] (10.855 s) : 0, 10855411
section appsec
Agent [baseline] (1.201 s) : 0, 1200710
Total [baseline] (10.987 s) : 0, 10987428
Agent [candidate] (1.2 s) : 0, 1199687
Total [candidate] (10.886 s) : 0, 10886290
section iast
Agent [baseline] (1.167 s) : 0, 1166531
Total [baseline] (11.127 s) : 0, 11127075
Agent [candidate] (1.169 s) : 0, 1168671
Total [candidate] (11.157 s) : 0, 11157430
section profiling
Agent [baseline] (1.175 s) : 0, 1174667
Total [baseline] (10.889 s) : 0, 10888627
Agent [candidate] (1.176 s) : 0, 1175528
Total [candidate] (10.871 s) : 0, 10870687
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~b4b8e6468d, baseline=1.55.0-SNAPSHOT~b733cdaf4e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.478 ms) : 0, 1478
BytebuddyAgent [baseline] (710.576 ms) : 0, 710576
BytebuddyAgent [candidate] (708.32 ms) : 0, 708320
GlobalTracer [baseline] (247.577 ms) : 0, 247577
GlobalTracer [candidate] (246.552 ms) : 0, 246552
AppSec [baseline] (32.74 ms) : 0, 32740
AppSec [candidate] (32.68 ms) : 0, 32680
Debugger [baseline] (6.498 ms) : 0, 6498
Debugger [candidate] (6.456 ms) : 0, 6456
Remote Config [baseline] (686.047 µs) : 0, 686
Remote Config [candidate] (677.865 µs) : 0, 678
Telemetry [baseline] (13.905 ms) : 0, 13905
Telemetry [candidate] (15.179 ms) : 0, 15179
Flare Poller [baseline] (7.222 ms) : 0, 7222
Flare Poller [candidate] (5.82 ms) : 0, 5820
section appsec
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (723.992 ms) : 0, 723992
BytebuddyAgent [candidate] (725.011 ms) : 0, 725011
GlobalTracer [baseline] (236.508 ms) : 0, 236508
GlobalTracer [candidate] (234.798 ms) : 0, 234798
IAST [baseline] (24.918 ms) : 0, 24918
IAST [candidate] (24.839 ms) : 0, 24839
AppSec [baseline] (173.764 ms) : 0, 173764
AppSec [candidate] (173.903 ms) : 0, 173903
Debugger [baseline] (5.918 ms) : 0, 5918
Debugger [candidate] (5.898 ms) : 0, 5898
Remote Config [baseline] (621.486 µs) : 0, 621
Remote Config [candidate] (625.348 µs) : 0, 625
Telemetry [baseline] (8.439 ms) : 0, 8439
Telemetry [candidate] (8.336 ms) : 0, 8336
Flare Poller [baseline] (3.856 ms) : 0, 3856
Flare Poller [candidate] (3.826 ms) : 0, 3826
section iast
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (827.53 ms) : 0, 827530
BytebuddyAgent [candidate] (830.697 ms) : 0, 830697
GlobalTracer [baseline] (234.489 ms) : 0, 234489
GlobalTracer [candidate] (234.54 ms) : 0, 234540
IAST [baseline] (32.968 ms) : 0, 32968
IAST [candidate] (33.422 ms) : 0, 33422
AppSec [baseline] (29.014 ms) : 0, 29014
AppSec [candidate] (27.982 ms) : 0, 27982
Debugger [baseline] (6.283 ms) : 0, 6283
Debugger [candidate] (6.167 ms) : 0, 6167
Remote Config [baseline] (608.777 µs) : 0, 609
Remote Config [candidate] (593.22 µs) : 0, 593
Telemetry [baseline] (8.626 ms) : 0, 8626
Telemetry [candidate] (8.331 ms) : 0, 8331
Flare Poller [baseline] (4.132 ms) : 0, 4132
Flare Poller [candidate] (4.131 ms) : 0, 4131
section profiling
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.434 ms) : 0, 1434
BytebuddyAgent [baseline] (729.005 ms) : 0, 729005
BytebuddyAgent [candidate] (729.855 ms) : 0, 729855
GlobalTracer [baseline] (219.598 ms) : 0, 219598
GlobalTracer [candidate] (220.373 ms) : 0, 220373
AppSec [baseline] (32.345 ms) : 0, 32345
AppSec [candidate] (32.989 ms) : 0, 32989
Debugger [baseline] (12.881 ms) : 0, 12881
Debugger [candidate] (11.336 ms) : 0, 11336
Remote Config [baseline] (724.798 µs) : 0, 725
Remote Config [candidate] (692.049 µs) : 0, 692
Telemetry [baseline] (9.901 ms) : 0, 9901
Telemetry [candidate] (10.516 ms) : 0, 10516
Flare Poller [baseline] (4.057 ms) : 0, 4057
Flare Poller [candidate] (4.094 ms) : 0, 4094
ProfilingAgent [baseline] (109.106 ms) : 0, 109106
ProfilingAgent [candidate] (108.639 ms) : 0, 108639
Profiling [baseline] (109.762 ms) : 0, 109762
Profiling [candidate] (109.295 ms) : 0, 109295
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~b4b8e6468d, baseline=1.55.0-SNAPSHOT~b733cdaf4e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.029 s) : 0, 1028565
Total [baseline] (8.693 s) : 0, 8693152
Agent [candidate] (1.031 s) : 0, 1030686
Total [candidate] (8.671 s) : 0, 8671129
section iast
Agent [baseline] (1.176 s) : 0, 1176245
Total [baseline] (9.36 s) : 0, 9360208
Agent [candidate] (1.159 s) : 0, 1158725
Total [candidate] (9.331 s) : 0, 9330611
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~b4b8e6468d, baseline=1.55.0-SNAPSHOT~b733cdaf4e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (701.217 ms) : 0, 701217
BytebuddyAgent [candidate] (702.616 ms) : 0, 702616
GlobalTracer [baseline] (244.57 ms) : 0, 244570
GlobalTracer [candidate] (244.948 ms) : 0, 244948
AppSec [baseline] (32.244 ms) : 0, 32244
AppSec [candidate] (32.414 ms) : 0, 32414
Debugger [baseline] (6.376 ms) : 0, 6376
Debugger [candidate] (6.367 ms) : 0, 6367
Remote Config [baseline] (672.187 µs) : 0, 672
Remote Config [candidate] (672.261 µs) : 0, 672
Telemetry [baseline] (13.696 ms) : 0, 13696
Telemetry [candidate] (14.48 ms) : 0, 14480
Flare Poller [baseline] (7.231 ms) : 0, 7231
Flare Poller [candidate] (6.638 ms) : 0, 6638
section iast
crashtracking [baseline] (1.505 ms) : 0, 1505
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (835.869 ms) : 0, 835869
BytebuddyAgent [candidate] (822.861 ms) : 0, 822861
GlobalTracer [baseline] (235.887 ms) : 0, 235887
GlobalTracer [candidate] (233.035 ms) : 0, 233035
IAST [baseline] (31.813 ms) : 0, 31813
IAST [candidate] (32.364 ms) : 0, 32364
AppSec [baseline] (30.001 ms) : 0, 30001
AppSec [candidate] (28.515 ms) : 0, 28515
Debugger [baseline] (6.147 ms) : 0, 6147
Debugger [candidate] (6.148 ms) : 0, 6148
Remote Config [baseline] (604.308 µs) : 0, 604
Remote Config [candidate] (604.944 µs) : 0, 605
Telemetry [baseline] (8.593 ms) : 0, 8593
Telemetry [candidate] (8.444 ms) : 0, 8444
Flare Poller [baseline] (4.185 ms) : 0, 4185
Flare Poller [candidate] (4.083 ms) : 0, 4083
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~b4b8e6468d, baseline=1.55.0-SNAPSHOT~b733cdaf4e
dateFormat X
axisFormat %s
section baseline
no_agent (36.604 ms) : 36311, 36897
. : milestone, 36604,
appsec (48.186 ms) : 47766, 48606
. : milestone, 48186,
code_origins (43.106 ms) : 42741, 43471
. : milestone, 43106,
iast (45.106 ms) : 44714, 45497
. : milestone, 45106,
profiling (49.733 ms) : 49280, 50186
. : milestone, 49733,
tracing (44.378 ms) : 43991, 44765
. : milestone, 44378,
section candidate
no_agent (36.489 ms) : 36193, 36786
. : milestone, 36489,
appsec (48.852 ms) : 48429, 49274
. : milestone, 48852,
code_origins (43.17 ms) : 42812, 43527
. : milestone, 43170,
iast (46.056 ms) : 45649, 46462
. : milestone, 46056,
profiling (47.783 ms) : 47321, 48244
. : milestone, 47783,
tracing (43.351 ms) : 42975, 43728
. : milestone, 43351,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~b4b8e6468d, baseline=1.55.0-SNAPSHOT~b733cdaf4e
dateFormat X
axisFormat %s
section baseline
no_agent (4.498 ms) : 4448, 4549
. : milestone, 4498,
iast (9.764 ms) : 9600, 9928
. : milestone, 9764,
iast_FULL (13.797 ms) : 13524, 14070
. : milestone, 13797,
iast_GLOBAL (11.161 ms) : 10959, 11362
. : milestone, 11161,
profiling (9.225 ms) : 9077, 9373
. : milestone, 9225,
tracing (8.074 ms) : 7955, 8194
. : milestone, 8074,
section candidate
no_agent (4.479 ms) : 4427, 4530
. : milestone, 4479,
iast (9.377 ms) : 9221, 9533
. : milestone, 9377,
iast_FULL (14.964 ms) : 14667, 15262
. : milestone, 14964,
iast_GLOBAL (11.387 ms) : 11181, 11594
. : milestone, 11387,
profiling (8.772 ms) : 8621, 8922
. : milestone, 8772,
tracing (7.854 ms) : 7738, 7971
. : milestone, 7854,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~b4b8e6468d, baseline=1.55.0-SNAPSHOT~b733cdaf4e
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (3.698 ms) : 3481, 3916
. : milestone, 3698,
iast (2.203 ms) : 2140, 2267
. : milestone, 2203,
iast_GLOBAL (2.258 ms) : 2194, 2323
. : milestone, 2258,
profiling (2.047 ms) : 1996, 2098
. : milestone, 2047,
tracing (2.015 ms) : 1965, 2065
. : milestone, 2015,
section candidate
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (3.621 ms) : 3408, 3834
. : milestone, 3621,
iast (2.216 ms) : 2152, 2281
. : milestone, 2216,
iast_GLOBAL (2.252 ms) : 2188, 2316
. : milestone, 2252,
profiling (2.056 ms) : 2004, 2108
. : milestone, 2056,
tracing (2.019 ms) : 1969, 2069
. : milestone, 2019,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~b4b8e6468d, baseline=1.55.0-SNAPSHOT~b733cdaf4e
dateFormat X
axisFormat %s
section baseline
no_agent (15.399 s) : 15399000, 15399000
. : milestone, 15399000,
appsec (14.648 s) : 14648000, 14648000
. : milestone, 14648000,
iast (18.486 s) : 18486000, 18486000
. : milestone, 18486000,
iast_GLOBAL (17.991 s) : 17991000, 17991000
. : milestone, 17991000,
profiling (15.132 s) : 15132000, 15132000
. : milestone, 15132000,
tracing (15.238 s) : 15238000, 15238000
. : milestone, 15238000,
section candidate
no_agent (14.903 s) : 14903000, 14903000
. : milestone, 14903000,
appsec (15.053 s) : 15053000, 15053000
. : milestone, 15053000,
iast (18.527 s) : 18527000, 18527000
. : milestone, 18527000,
iast_GLOBAL (17.879 s) : 17879000, 17879000
. : milestone, 17879000,
profiling (15.249 s) : 15249000, 15249000
. : milestone, 15249000,
tracing (14.814 s) : 14814000, 14814000
. : milestone, 14814000,
|
|
🎯 Code Coverage 🔗 Commit SHA: b4b8e64 | Docs | Was this helpful? Give us feedback! |
What Does This Do
This PR bumps spotbugs gradle plugin to the most recent version 6.4.4 to this day (from 5.0.14).
And require a JDK 11 minimum to run.
Important
This version of spotbugs has new rules, better detection engine that requires to change so of the warnings ignores, or fix some code.
Motivation
Latest tools provide more value.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]