Crashtracking: send ping message #9804
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarziali
added
type: enhancement
jbachorik
reviewed
Oct 20, 2025
Comment on lines
140
to
141
| // if we send more than 1 file via the CLI, let's make sure we have unique uuid (will be | ||
| // generated if null) |
There was a problem hiding this comment.
This will mean that only the first file will have UUID matching with the ping, right?
Is this expected/acceptable?
There was a problem hiding this comment.
we only send 1 file when the crash report are sent by the agent. The other mode is when the CLI is used (i.e. manual?). So I think yes. Perhaps we should not send the ping when multiple files are sent, wdyt?
There was a problem hiding this comment.
as discussed let's remove the possibility of uploading multiple files: f3e0d49
|
🎯 Code Coverage 🔗 Commit SHA: d6567d8 | Docs | Was this helpful? Give us feedback! |
jbachorik
reviewed
Oct 20, 2025
| log.error("Failed to upload crash file: {}", file, e); | ||
| CrashLog crashLog = CrashLogParser.fromHotspotCrashLog(uuid, content); | ||
| if (crashLog == null) { | ||
| log.error("Failed to parse crash log"); |
There was a problem hiding this comment.
I wonder, can we send this error message also to instrumentation telemetry, such that eg. our support engineers could easily check if there are any issues with parsing the crash logs at a customer?
There was a problem hiding this comment.
I initially misread the suggestion. Yes indeed. I added in 5d2a8ea a telemetry send marker and the info about the uuid so we can relate.
jbachorik
reviewed
Oct 20, 2025
| if (storedConfig == null) { | ||
| log.error("Unable to parse config file {}", configFile); | ||
| System.exit(1); | ||
| error += "Unable to parse config file"; |
There was a problem hiding this comment.
Perhaps, inserting a new line to make the error more readable?
The current code will just append to the previous error message.
There was a problem hiding this comment.
Yes it was not intended to concatenate the + is a typo (but yes ideally at this point we can have both failures so I'll insert a newline)
amarziali
force-pushed
the
andrea.marziali/crashtracker-ping
branch
from
62e2d16 to
5d2a8ea
Compare
jbachorik
approved these changes
Oct 20, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 13 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~d6567d8b9e, baseline=1.55.0-SNAPSHOT~c5537512d2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.032 s) : 0, 1031614
Total [baseline] (8.652 s) : 0, 8651671
Agent [candidate] (1.029 s) : 0, 1028873
Total [candidate] (8.641 s) : 0, 8640988
section iast
Agent [baseline] (1.185 s) : 0, 1184562
Total [baseline] (9.426 s) : 0, 9426334
Agent [candidate] (1.172 s) : 0, 1172304
Total [candidate] (9.377 s) : 0, 9376608
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~d6567d8b9e, baseline=1.55.0-SNAPSHOT~c5537512d2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (703.68 ms) : 0, 703680
BytebuddyAgent [candidate] (701.508 ms) : 0, 701508
GlobalTracer [baseline] (244.987 ms) : 0, 244987
GlobalTracer [candidate] (244.828 ms) : 0, 244828
AppSec [baseline] (32.361 ms) : 0, 32361
AppSec [candidate] (32.168 ms) : 0, 32168
Debugger [baseline] (6.413 ms) : 0, 6413
Debugger [candidate] (6.352 ms) : 0, 6352
Remote Config [baseline] (684.599 µs) : 0, 685
Remote Config [candidate] (676.977 µs) : 0, 677
Telemetry [baseline] (15.934 ms) : 0, 15934
Telemetry [candidate] (14.917 ms) : 0, 14917
Flare Poller [baseline] (4.944 ms) : 0, 4944
Flare Poller [candidate] (5.785 ms) : 0, 5785
section iast
crashtracking [baseline] (1.489 ms) : 0, 1489
crashtracking [candidate] (1.509 ms) : 0, 1509
BytebuddyAgent [baseline] (842.298 ms) : 0, 842298
BytebuddyAgent [candidate] (832.508 ms) : 0, 832508
GlobalTracer [baseline] (237.066 ms) : 0, 237066
GlobalTracer [candidate] (235.435 ms) : 0, 235435
AppSec [baseline] (29.283 ms) : 0, 29283
AppSec [candidate] (28.017 ms) : 0, 28017
Debugger [baseline] (6.237 ms) : 0, 6237
Debugger [candidate] (6.222 ms) : 0, 6222
Remote Config [baseline] (604.247 µs) : 0, 604
Remote Config [candidate] (607.259 µs) : 0, 607
Telemetry [baseline] (8.568 ms) : 0, 8568
Telemetry [candidate] (8.497 ms) : 0, 8497
Flare Poller [baseline] (4.128 ms) : 0, 4128
Flare Poller [candidate] (4.141 ms) : 0, 4141
IAST [baseline] (33.194 ms) : 0, 33194
IAST [candidate] (33.803 ms) : 0, 33803
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~d6567d8b9e, baseline=1.55.0-SNAPSHOT~c5537512d2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.029 s) : 0, 1028843
Total [baseline] (10.845 s) : 0, 10844849
Agent [candidate] (1.033 s) : 0, 1032828
Total [candidate] (10.873 s) : 0, 10872799
section appsec
Agent [baseline] (1.199 s) : 0, 1198858
Total [baseline] (10.962 s) : 0, 10962373
Agent [candidate] (1.207 s) : 0, 1207085
Total [candidate] (10.885 s) : 0, 10885166
section iast
Agent [baseline] (1.16 s) : 0, 1159697
Total [baseline] (11.063 s) : 0, 11063451
Agent [candidate] (1.164 s) : 0, 1163709
Total [candidate] (11.101 s) : 0, 11101367
section profiling
Agent [baseline] (1.17 s) : 0, 1170354
Total [baseline] (10.83 s) : 0, 10830254
Agent [candidate] (1.183 s) : 0, 1182855
Total [candidate] (10.962 s) : 0, 10962318
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~d6567d8b9e, baseline=1.55.0-SNAPSHOT~c5537512d2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.451 ms) : 0, 1451
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (701.389 ms) : 0, 701389
BytebuddyAgent [candidate] (704.232 ms) : 0, 704232
GlobalTracer [baseline] (244.721 ms) : 0, 244721
GlobalTracer [candidate] (245.58 ms) : 0, 245580
AppSec [baseline] (32.27 ms) : 0, 32270
AppSec [candidate] (32.416 ms) : 0, 32416
Debugger [baseline] (6.371 ms) : 0, 6371
Debugger [candidate] (6.437 ms) : 0, 6437
Remote Config [baseline] (680.574 µs) : 0, 681
Remote Config [candidate] (673.017 µs) : 0, 673
Telemetry [baseline] (14.336 ms) : 0, 14336
Telemetry [candidate] (15.129 ms) : 0, 15129
Flare Poller [baseline] (6.49 ms) : 0, 6490
Flare Poller [candidate] (5.79 ms) : 0, 5790
section appsec
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (723.685 ms) : 0, 723685
BytebuddyAgent [candidate] (728.363 ms) : 0, 728363
GlobalTracer [baseline] (235.004 ms) : 0, 235004
GlobalTracer [candidate] (237.377 ms) : 0, 237377
AppSec [baseline] (173.734 ms) : 0, 173734
AppSec [candidate] (174.665 ms) : 0, 174665
Debugger [baseline] (5.92 ms) : 0, 5920
Debugger [candidate] (5.972 ms) : 0, 5972
Remote Config [baseline] (625.262 µs) : 0, 625
Remote Config [candidate] (623.517 µs) : 0, 624
Telemetry [baseline] (8.49 ms) : 0, 8490
Telemetry [candidate] (8.416 ms) : 0, 8416
Flare Poller [baseline] (3.921 ms) : 0, 3921
Flare Poller [candidate] (3.914 ms) : 0, 3914
IAST [baseline] (24.93 ms) : 0, 24930
IAST [candidate] (25.144 ms) : 0, 25144
section iast
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (822.632 ms) : 0, 822632
BytebuddyAgent [candidate] (826.289 ms) : 0, 826289
GlobalTracer [baseline] (233.519 ms) : 0, 233519
GlobalTracer [candidate] (234.226 ms) : 0, 234226
AppSec [baseline] (30.592 ms) : 0, 30592
AppSec [candidate] (27.052 ms) : 0, 27052
Debugger [baseline] (6.092 ms) : 0, 6092
Debugger [candidate] (6.148 ms) : 0, 6148
Remote Config [baseline] (598.362 µs) : 0, 598
Remote Config [candidate] (589.665 µs) : 0, 590
Telemetry [baseline] (8.397 ms) : 0, 8397
Telemetry [candidate] (8.398 ms) : 0, 8398
Flare Poller [baseline] (4.191 ms) : 0, 4191
Flare Poller [candidate] (4.081 ms) : 0, 4081
IAST [baseline] (30.929 ms) : 0, 30929
IAST [candidate] (34.22 ms) : 0, 34220
section profiling
crashtracking [baseline] (1.445 ms) : 0, 1445
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (724.2 ms) : 0, 724200
BytebuddyAgent [candidate] (732.54 ms) : 0, 732540
GlobalTracer [baseline] (219.749 ms) : 0, 219749
GlobalTracer [candidate] (222.238 ms) : 0, 222238
AppSec [baseline] (32.279 ms) : 0, 32279
AppSec [candidate] (33.533 ms) : 0, 33533
Debugger [baseline] (12.961 ms) : 0, 12961
Debugger [candidate] (12.145 ms) : 0, 12145
Remote Config [baseline] (1.485 ms) : 0, 1485
Remote Config [candidate] (710.585 µs) : 0, 711
Telemetry [baseline] (9.084 ms) : 0, 9084
Telemetry [candidate] (9.934 ms) : 0, 9934
Flare Poller [baseline] (4.088 ms) : 0, 4088
Flare Poller [candidate] (4.167 ms) : 0, 4167
ProfilingAgent [baseline] (109.747 ms) : 0, 109747
ProfilingAgent [candidate] (110.354 ms) : 0, 110354
Profiling [baseline] (110.385 ms) : 0, 110385
Profiling [candidate] (110.996 ms) : 0, 110996
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~d6567d8b9e, baseline=1.55.0-SNAPSHOT~c5537512d2
dateFormat X
axisFormat %s
section baseline
no_agent (36.81 ms) : 36517, 37104
. : milestone, 36810,
appsec (48.655 ms) : 48239, 49071
. : milestone, 48655,
code_origins (44.889 ms) : 44518, 45260
. : milestone, 44889,
iast (44.99 ms) : 44603, 45378
. : milestone, 44990,
profiling (49.003 ms) : 48549, 49457
. : milestone, 49003,
tracing (43.26 ms) : 42904, 43616
. : milestone, 43260,
section candidate
no_agent (37.146 ms) : 36841, 37451
. : milestone, 37146,
appsec (46.875 ms) : 46450, 47300
. : milestone, 46875,
code_origins (44.342 ms) : 43967, 44718
. : milestone, 44342,
iast (44.594 ms) : 44194, 44993
. : milestone, 44594,
profiling (50.572 ms) : 50092, 51053
. : milestone, 50572,
tracing (46.527 ms) : 46120, 46933
. : milestone, 46527,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~d6567d8b9e, baseline=1.55.0-SNAPSHOT~c5537512d2
dateFormat X
axisFormat %s
section baseline
no_agent (4.412 ms) : 4361, 4463
. : milestone, 4412,
iast (9.966 ms) : 9798, 10134
. : milestone, 9966,
iast_FULL (14.083 ms) : 13803, 14363
. : milestone, 14083,
iast_GLOBAL (10.923 ms) : 10727, 11119
. : milestone, 10923,
profiling (8.828 ms) : 8684, 8973
. : milestone, 8828,
tracing (8.086 ms) : 7968, 8203
. : milestone, 8086,
section candidate
no_agent (4.361 ms) : 4308, 4414
. : milestone, 4361,
iast (10.142 ms) : 9967, 10316
. : milestone, 10142,
iast_FULL (14.524 ms) : 14230, 14817
. : milestone, 14524,
iast_GLOBAL (10.933 ms) : 10733, 11133
. : milestone, 10933,
profiling (9.757 ms) : 9598, 9916
. : milestone, 9757,
tracing (7.966 ms) : 7843, 8089
. : milestone, 7966,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~d6567d8b9e, baseline=1.55.0-SNAPSHOT~c5537512d2
dateFormat X
axisFormat %s
section baseline
no_agent (1.487 ms) : 1475, 1499
. : milestone, 1487,
appsec (3.681 ms) : 3464, 3897
. : milestone, 3681,
iast (2.216 ms) : 2152, 2279
. : milestone, 2216,
iast_GLOBAL (2.267 ms) : 2203, 2332
. : milestone, 2267,
profiling (2.069 ms) : 2017, 2122
. : milestone, 2069,
tracing (2.027 ms) : 1978, 2077
. : milestone, 2027,
section candidate
no_agent (1.478 ms) : 1466, 1490
. : milestone, 1478,
appsec (3.646 ms) : 3434, 3859
. : milestone, 3646,
iast (2.222 ms) : 2158, 2285
. : milestone, 2222,
iast_GLOBAL (2.269 ms) : 2205, 2334
. : milestone, 2269,
profiling (2.065 ms) : 2013, 2116
. : milestone, 2065,
tracing (2.035 ms) : 1986, 2085
. : milestone, 2035,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~d6567d8b9e, baseline=1.55.0-SNAPSHOT~c5537512d2
dateFormat X
axisFormat %s
section baseline
no_agent (15.005 s) : 15005000, 15005000
. : milestone, 15005000,
appsec (14.995 s) : 14995000, 14995000
. : milestone, 14995000,
iast (18.688 s) : 18688000, 18688000
. : milestone, 18688000,
iast_GLOBAL (18.231 s) : 18231000, 18231000
. : milestone, 18231000,
profiling (15.129 s) : 15129000, 15129000
. : milestone, 15129000,
tracing (15.059 s) : 15059000, 15059000
. : milestone, 15059000,
section candidate
no_agent (15.313 s) : 15313000, 15313000
. : milestone, 15313000,
appsec (14.902 s) : 14902000, 14902000
. : milestone, 14902000,
iast (18.336 s) : 18336000, 18336000
. : milestone, 18336000,
iast_GLOBAL (18.068 s) : 18068000, 18068000
. : milestone, 18068000,
profiling (15.285 s) : 15285000, 15285000
. : milestone, 15285000,
tracing (15.262 s) : 15262000, 15262000
. : milestone, 15262000,
|
amarziali
force-pushed
the
andrea.marziali/crashtracker-ping
branch
from
6797413 to
d5e4dcd
Compare
amarziali
force-pushed
the
andrea.marziali/crashtracker-ping
branch
from
3bda3f0 to
ecada21
Compare
gleocadie
approved these changes
Oct 21, 2025
amarziali
force-pushed
the
andrea.marziali/crashtracker-ping
branch
from
1f4e825 to
0b0de74
Compare
amarziali
requested review from
AlexeyKuznetsov-DD and
erikayasuda
and removed request for
a team
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (325.642 µs) : 291, 360
. : milestone, 326,
basic (295.087 µs) : 288, 302
. : milestone, 295,
loop (8.959 ms) : 8954, 8964
. : milestone, 8959,
section candidate
noprobe (331.591 µs) : 288, 375
. : milestone, 332,
basic (297.753 µs) : 290, 306
. : milestone, 298,
loop (8.958 ms) : 8954, 8961
. : milestone, 8958,
|
amarziali
force-pushed
the
andrea.marziali/crashtracker-ping
branch
from
6f723f2 to
45baaf8
Compare
amarziali
removed request for
a team,
AlexeyKuznetsov-DD,
erikayasuda,
evanchooly,
nikita-tkachenko-datadog,
robertpi and
sezen-datadog
amarziali
force-pushed
the
andrea.marziali/crashtracker-ping
branch
from
45baaf8 to
d6567d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Send a ping message to notify the telemetry that the crash tracking process is initiated.
The ping message will use the same UUID (stored under
crash_uuid) than the crash report. This will allow to know which report have a ping but don't have a linked report.Other than this, we also send a ping if we cannot parse the config file or the report, specifying it in the ping message.
Few improvements have also been done on the testing in order to refactor common assert and deterministic UUID usage
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]