-
Notifications
You must be signed in to change notification settings - Fork 315
Fixed thread local cleanup detected by IDEA. #9856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: 4e03d23 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~4e03d23c61, baseline=1.55.0-SNAPSHOT~5370add8f6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.035 s) : 0, 1034716
Total [baseline] (10.798 s) : 0, 10797516
Agent [candidate] (1.028 s) : 0, 1028458
Total [candidate] (10.728 s) : 0, 10728146
section appsec
Agent [baseline] (1.203 s) : 0, 1202889
Total [baseline] (10.972 s) : 0, 10972476
Agent [candidate] (1.211 s) : 0, 1211011
Total [candidate] (10.942 s) : 0, 10942162
section iast
Agent [baseline] (1.167 s) : 0, 1167017
Total [baseline] (11.009 s) : 0, 11008537
Agent [candidate] (1.169 s) : 0, 1169323
Total [candidate] (11.127 s) : 0, 11126944
section profiling
Agent [baseline] (1.172 s) : 0, 1172082
Total [baseline] (10.893 s) : 0, 10892762
Agent [candidate] (1.179 s) : 0, 1178916
Total [candidate] (10.887 s) : 0, 10886995
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~4e03d23c61, baseline=1.55.0-SNAPSHOT~5370add8f6
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (705.464 ms) : 0, 705464
BytebuddyAgent [candidate] (700.941 ms) : 0, 700941
GlobalTracer [baseline] (245.858 ms) : 0, 245858
GlobalTracer [candidate] (244.409 ms) : 0, 244409
AppSec [baseline] (32.516 ms) : 0, 32516
AppSec [candidate] (32.259 ms) : 0, 32259
Debugger [baseline] (6.467 ms) : 0, 6467
Debugger [candidate] (6.418 ms) : 0, 6418
Remote Config [baseline] (680.507 µs) : 0, 681
Remote Config [candidate] (673.815 µs) : 0, 674
Telemetry [baseline] (15.244 ms) : 0, 15244
Telemetry [candidate] (14.552 ms) : 0, 14552
Flare Poller [baseline] (5.709 ms) : 0, 5709
Flare Poller [candidate] (6.631 ms) : 0, 6631
section appsec
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (726.12 ms) : 0, 726120
BytebuddyAgent [candidate] (731.359 ms) : 0, 731359
GlobalTracer [baseline] (235.66 ms) : 0, 235660
GlobalTracer [candidate] (237.541 ms) : 0, 237541
IAST [baseline] (24.989 ms) : 0, 24989
IAST [candidate] (25.175 ms) : 0, 25175
AppSec [baseline] (174.599 ms) : 0, 174599
AppSec [candidate] (175.157 ms) : 0, 175157
Debugger [baseline] (5.935 ms) : 0, 5935
Debugger [candidate] (5.98 ms) : 0, 5980
Remote Config [baseline] (628.102 µs) : 0, 628
Remote Config [candidate] (647.251 µs) : 0, 647
Telemetry [baseline] (8.476 ms) : 0, 8476
Telemetry [candidate] (8.522 ms) : 0, 8522
Flare Poller [baseline] (3.896 ms) : 0, 3896
Flare Poller [candidate] (3.904 ms) : 0, 3904
section iast
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.473 ms) : 0, 1473
BytebuddyAgent [baseline] (828.856 ms) : 0, 828856
BytebuddyAgent [candidate] (830.968 ms) : 0, 830968
GlobalTracer [baseline] (234.656 ms) : 0, 234656
GlobalTracer [candidate] (235.005 ms) : 0, 235005
IAST [baseline] (35.399 ms) : 0, 35399
IAST [candidate] (31.712 ms) : 0, 31712
AppSec [baseline] (26.204 ms) : 0, 26204
AppSec [candidate] (29.558 ms) : 0, 29558
Debugger [baseline] (6.071 ms) : 0, 6071
Debugger [candidate] (6.122 ms) : 0, 6122
Remote Config [baseline] (584.008 µs) : 0, 584
Remote Config [candidate] (605.707 µs) : 0, 606
Telemetry [baseline] (8.283 ms) : 0, 8283
Telemetry [candidate] (8.348 ms) : 0, 8348
Flare Poller [baseline] (4.066 ms) : 0, 4066
Flare Poller [candidate] (4.097 ms) : 0, 4097
section profiling
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (726.526 ms) : 0, 726526
BytebuddyAgent [candidate] (729.347 ms) : 0, 729347
GlobalTracer [baseline] (220.403 ms) : 0, 220403
GlobalTracer [candidate] (221.996 ms) : 0, 221996
AppSec [baseline] (32.187 ms) : 0, 32187
AppSec [candidate] (32.591 ms) : 0, 32591
Debugger [baseline] (12.98 ms) : 0, 12980
Debugger [candidate] (12.295 ms) : 0, 12295
Remote Config [baseline] (1.489 ms) : 0, 1489
Remote Config [candidate] (699.64 µs) : 0, 700
Telemetry [baseline] (8.901 ms) : 0, 8901
Telemetry [candidate] (10.66 ms) : 0, 10660
Flare Poller [baseline] (4.206 ms) : 0, 4206
Flare Poller [candidate] (4.181 ms) : 0, 4181
ProfilingAgent [baseline] (108.557 ms) : 0, 108557
ProfilingAgent [candidate] (110.276 ms) : 0, 110276
Profiling [baseline] (109.187 ms) : 0, 109187
Profiling [candidate] (110.955 ms) : 0, 110955
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~4e03d23c61, baseline=1.55.0-SNAPSHOT~5370add8f6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.033 s) : 0, 1033284
Total [baseline] (8.649 s) : 0, 8649232
Agent [candidate] (1.037 s) : 0, 1036697
Total [candidate] (8.647 s) : 0, 8647479
section iast
Agent [baseline] (1.158 s) : 0, 1158214
Total [baseline] (9.352 s) : 0, 9352037
Agent [candidate] (1.161 s) : 0, 1160528
Total [candidate] (9.361 s) : 0, 9360573
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~4e03d23c61, baseline=1.55.0-SNAPSHOT~5370add8f6
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (704.837 ms) : 0, 704837
BytebuddyAgent [candidate] (706.969 ms) : 0, 706969
GlobalTracer [baseline] (245.052 ms) : 0, 245052
GlobalTracer [candidate] (246.09 ms) : 0, 246090
AppSec [baseline] (32.454 ms) : 0, 32454
AppSec [candidate] (32.635 ms) : 0, 32635
Debugger [baseline] (6.467 ms) : 0, 6467
Debugger [candidate] (6.461 ms) : 0, 6461
Remote Config [baseline] (677.852 µs) : 0, 678
Remote Config [candidate] (681.402 µs) : 0, 681
Telemetry [baseline] (13.104 ms) : 0, 13104
Telemetry [candidate] (13.134 ms) : 0, 13134
Flare Poller [baseline] (8.05 ms) : 0, 8050
Flare Poller [candidate] (7.993 ms) : 0, 7993
section iast
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (821.641 ms) : 0, 821641
BytebuddyAgent [candidate] (823.14 ms) : 0, 823140
GlobalTracer [baseline] (233.113 ms) : 0, 233113
GlobalTracer [candidate] (234.03 ms) : 0, 234030
IAST [baseline] (32.423 ms) : 0, 32423
IAST [candidate] (33.503 ms) : 0, 33503
AppSec [baseline] (28.957 ms) : 0, 28957
AppSec [candidate] (27.967 ms) : 0, 27967
Debugger [baseline] (6.156 ms) : 0, 6156
Debugger [candidate] (6.14 ms) : 0, 6140
Remote Config [baseline] (601.773 µs) : 0, 602
Remote Config [candidate] (601.252 µs) : 0, 601
Telemetry [baseline] (8.514 ms) : 0, 8514
Telemetry [candidate] (8.43 ms) : 0, 8430
Flare Poller [baseline] (4.12 ms) : 0, 4120
Flare Poller [candidate] (4.07 ms) : 0, 4070
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 4 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~4e03d23c61, baseline=1.55.0-SNAPSHOT~5370add8f6
dateFormat X
axisFormat %s
section baseline
no_agent (4.284 ms) : 4235, 4333
. : milestone, 4284,
iast (10.292 ms) : 10116, 10467
. : milestone, 10292,
iast_FULL (14.288 ms) : 14008, 14568
. : milestone, 14288,
iast_GLOBAL (10.818 ms) : 10620, 11016
. : milestone, 10818,
profiling (8.956 ms) : 8806, 9105
. : milestone, 8956,
tracing (7.81 ms) : 7692, 7927
. : milestone, 7810,
section candidate
no_agent (4.306 ms) : 4257, 4355
. : milestone, 4306,
iast (9.88 ms) : 9712, 10048
. : milestone, 9880,
iast_FULL (13.73 ms) : 13458, 14003
. : milestone, 13730,
iast_GLOBAL (11.528 ms) : 11322, 11733
. : milestone, 11528,
profiling (8.984 ms) : 8828, 9140
. : milestone, 8984,
tracing (8.022 ms) : 7903, 8141
. : milestone, 8022,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~4e03d23c61, baseline=1.55.0-SNAPSHOT~5370add8f6
dateFormat X
axisFormat %s
section baseline
no_agent (35.562 ms) : 35284, 35841
. : milestone, 35562,
appsec (47.612 ms) : 47199, 48026
. : milestone, 47612,
code_origins (43.123 ms) : 42756, 43489
. : milestone, 43123,
iast (43.548 ms) : 43168, 43928
. : milestone, 43548,
profiling (48.54 ms) : 48064, 49016
. : milestone, 48540,
tracing (42.758 ms) : 42414, 43101
. : milestone, 42758,
section candidate
no_agent (37.313 ms) : 37014, 37611
. : milestone, 37313,
appsec (50.458 ms) : 50011, 50905
. : milestone, 50458,
code_origins (44.084 ms) : 43699, 44469
. : milestone, 44084,
iast (44.071 ms) : 43699, 44442
. : milestone, 44071,
profiling (49.344 ms) : 48880, 49808
. : milestone, 49344,
tracing (44.867 ms) : 44474, 45261
. : milestone, 44867,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~4e03d23c61, baseline=1.55.0-SNAPSHOT~5370add8f6
dateFormat X
axisFormat %s
section baseline
no_agent (14.847 s) : 14847000, 14847000
. : milestone, 14847000,
appsec (14.759 s) : 14759000, 14759000
. : milestone, 14759000,
iast (18.276 s) : 18276000, 18276000
. : milestone, 18276000,
iast_GLOBAL (18.387 s) : 18387000, 18387000
. : milestone, 18387000,
profiling (15.205 s) : 15205000, 15205000
. : milestone, 15205000,
tracing (15.13 s) : 15130000, 15130000
. : milestone, 15130000,
section candidate
no_agent (14.95 s) : 14950000, 14950000
. : milestone, 14950000,
appsec (14.722 s) : 14722000, 14722000
. : milestone, 14722000,
iast (18.197 s) : 18197000, 18197000
. : milestone, 18197000,
iast_GLOBAL (17.886 s) : 17886000, 17886000
. : milestone, 17886000,
profiling (15.86 s) : 15860000, 15860000
. : milestone, 15860000,
tracing (15.261 s) : 15261000, 15261000
. : milestone, 15261000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~4e03d23c61, baseline=1.55.0-SNAPSHOT~5370add8f6
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (3.683 ms) : 3465, 3900
. : milestone, 3683,
iast (2.196 ms) : 2133, 2259
. : milestone, 2196,
iast_GLOBAL (2.241 ms) : 2178, 2305
. : milestone, 2241,
profiling (2.049 ms) : 1998, 2100
. : milestone, 2049,
tracing (2.025 ms) : 1975, 2074
. : milestone, 2025,
section candidate
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (2.452 ms) : 2401, 2503
. : milestone, 2452,
iast (2.207 ms) : 2144, 2270
. : milestone, 2207,
iast_GLOBAL (2.239 ms) : 2176, 2303
. : milestone, 2239,
profiling (2.066 ms) : 2013, 2118
. : milestone, 2066,
tracing (2.018 ms) : 1969, 2067
. : milestone, 2018,
|
What Does This Do
Quick fix proposed by IntelliJ IDEA Qodana.
Motivation
Correct code.
Additional Notes
Description from IDEA: