Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic userID tracking and blocking + automatic session tracking #4670

Draft
wants to merge 100 commits into
base: master
Choose a base branch
from

Conversation

simon-id
Copy link
Member

@simon-id simon-id commented Sep 11, 2024

TODO:

  • check if there is any unexpected behavior when using passport-jwt

What does this PR do?

Motivation

Plugin Checklist

Additional Notes

@simon-id simon-id self-assigned this Sep 11, 2024
@simon-id simon-id changed the title instrument passport Automatic userID blocking Sep 11, 2024
Copy link

github-actions bot commented Sep 11, 2024

Overall package size

Self size: 8.42 MB
Deduped: 94.88 MB
No deduping: 95.4 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.3.0 | 29.43 MB | 29.43 MB | | @datadog/native-appsec | 8.3.0 | 19.37 MB | 19.38 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Sep 11, 2024

Benchmarks

Benchmark execution time: 2024-12-27 14:37:28

Comparing candidate commit 775bf9a in PR branch automatic_userid_blocking with baseline commit a17c93f in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 774 metrics, 24 unstable metrics.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 20.16807% with 95 lines in your changes missing coverage. Please review.

Project coverage is 61.16%. Comparing base (70a2c22) to head (79a7ff5).
Report is 74 commits behind head on master.

Files with missing lines Patch % Lines
packages/dd-trace/src/appsec/user_tracking.js 19.71% 57 Missing ⚠️
packages/dd-trace/src/appsec/sdk/track_event.js 7.69% 12 Missing ⚠️
packages/dd-trace/src/appsec/sdk/set_user.js 9.09% 10 Missing ⚠️
...ackages/dd-trace/src/appsec/remote_config/index.js 25.00% 9 Missing ⚠️
packages/dd-trace/src/appsec/index.js 44.44% 5 Missing ⚠️
packages/dd-trace/src/appsec/telemetry.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4670      +/-   ##
==========================================
- Coverage   66.25%   61.16%   -5.09%     
==========================================
  Files         112      144      +32     
  Lines        3734     5166    +1432     
==========================================
+ Hits         2474     3160     +686     
- Misses       1260     2006     +746     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


const strategy = this._strategy(name)

strategy._verify
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

options.session can be used to know if it's login or session or not ?

Base automatically changed from new_user_collection to master December 16, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant