Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Sirun benchmark SPLITS from 3 to 4 #5094

Closed
wants to merge 7 commits into from

Conversation

watson
Copy link
Collaborator

@watson watson commented Jan 13, 2025

What does this PR do?

Increase the SPLITS variable used for running Sirun benchmarks from 3 to 4 to ensure there's room to run all out benchmarks.

Motivation

After merging #5004 that adds one more benchmark, it was discovered that one of the other benchmarks stopped running. Hopefully this fixes it.

Plugin Checklist

Additional Notes

@watson watson requested a review from a team as a code owner January 13, 2025 09:45
@watson watson self-assigned this Jan 13, 2025
Copy link
Collaborator Author

watson commented Jan 13, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Jan 13, 2025

Overall package size

Self size: 8.39 MB
Deduped: 94.74 MB
No deduping: 95.25 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.3.0 | 29.43 MB | 29.43 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@watson watson force-pushed the watson/DEBUG-2740/fix branch from 9c66ede to 46b2c38 Compare January 13, 2025 09:50
@watson watson marked this pull request as draft January 13, 2025 10:48
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.23%. Comparing base (4886c38) to head (0137576).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5094      +/-   ##
==========================================
+ Coverage   79.95%   88.23%   +8.27%     
==========================================
  Files         291      133     -158     
  Lines       13631     4734    -8897     
==========================================
- Hits        10899     4177    -6722     
+ Misses       2732      557    -2175     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@watson watson force-pushed the watson/DEBUG-2740/fix branch 2 times, most recently from 7b35f25 to d9b09d0 Compare January 13, 2025 12:38
@watson watson force-pushed the watson/DEBUG-2740/fix branch from d9b09d0 to 8db0b74 Compare January 13, 2025 12:56
@pr-commenter
Copy link

pr-commenter bot commented Jan 13, 2025

Benchmarks

Benchmark execution time: 2025-01-13 13:10:31

Comparing candidate commit cba073d in PR branch watson/DEBUG-2740/fix with baseline commit 587957e in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 858 metrics, 14 unstable metrics.

scenario:plugin-graphql-with-async-hooks-22

  • 🟥 max_rss_usage [+103.412MB; +118.576MB] or [+19.132%; +21.937%]

@watson watson force-pushed the watson/DEBUG-2740/fix branch from 8e1a27f to 0137576 Compare January 13, 2025 13:20
@watson watson closed this Jan 14, 2025
@watson watson deleted the watson/DEBUG-2740/fix branch January 14, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant