Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve benchmarks runner to abort if not enough CPU cores #5095

Closed
wants to merge 1 commit into from
+6 −0
Closed

Improve benchmarks runner to abort if not enough CPU cores #5095

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions benchmark/sirun/runall.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,12 @@ done
BENCH_COUNT=$(($BENCH_COUNT+$BENCH_COUNT%$SPLITS))
GROUP_SIZE=$(($BENCH_COUNT/$SPLITS))

if [ ${GROUP_SIZE} -gt ${CPU_AFFINITY} ]; then
echo "Not enough CPU cores available to run benchmarks, aborting..."
echo "Consider increasing the number of groups/splits or decreasing the number of benchmarks."
exit 1
fi

run_all_variants () {
local variants="$(node ../get-variants.js)"

Expand Down
Loading