Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix control case for the profiler benchmark #5108

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

szegedi
Copy link
Contributor

@szegedi szegedi commented Jan 14, 2025

What does this PR do?

Fixes the sirun profiler benchmark's control case.

Motivation

It was pointed out it doesn't work.

Additional Notes

JIRA: PROF-11118

Copy link

github-actions bot commented Jan 14, 2025

Overall package size

Self size: 8.39 MB
Deduped: 94.74 MB
No deduping: 95.25 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.3.0 | 29.43 MB | 29.43 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.73%. Comparing base (4886c38) to head (5363ee6).
Report is 9 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5108       +/-   ##
===========================================
- Coverage   79.95%   57.73%   -22.23%     
===========================================
  Files         291      289        -2     
  Lines       13631    13561       -70     
===========================================
- Hits        10899     7829     -3070     
- Misses       2732     5732     +3000     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szegedi szegedi force-pushed the szegedi/fix-profiling-benchmark branch from 5363ee6 to d103790 Compare January 14, 2025 14:26
@pr-commenter
Copy link

pr-commenter bot commented Jan 14, 2025

Benchmarks

Benchmark execution time: 2025-01-14 14:51:31

Comparing candidate commit ac85ce4 in PR branch szegedi/fix-profiling-benchmark with baseline commit 708b627 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 876 metrics, 27 unstable metrics.

@szegedi szegedi force-pushed the szegedi/fix-profiling-benchmark branch from d103790 to ac85ce4 Compare January 14, 2025 14:40
@szegedi szegedi merged commit 9e36df0 into master Jan 14, 2025
329 checks passed
@szegedi szegedi deleted the szegedi/fix-profiling-benchmark branch January 14, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants