Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.33.0 proposal #5160

Merged
merged 11 commits into from
Jan 29, 2025
Prev Previous commit
Next Next commit
remove http.route from inferred proxy spans (#5132)
remove inferred http route
zarirhamza authored and szegedi committed Jan 28, 2025
commit db8be83bb44062a5048246a6ac64e7bd4af831fd
2 changes: 0 additions & 2 deletions packages/dd-trace/src/plugins/util/inferred_proxy.js
Original file line number Diff line number Diff line change
@@ -2,7 +2,6 @@ const log = require('../../log')
const tags = require('../../../../../ext/tags')

const RESOURCE_NAME = tags.RESOURCE_NAME
const HTTP_ROUTE = tags.HTTP_ROUTE
const SPAN_KIND = tags.SPAN_KIND
const SPAN_TYPE = tags.SPAN_TYPE
const HTTP_URL = tags.HTTP_URL
@@ -54,7 +53,6 @@ function createInferredProxySpan (headers, childOf, tracer, context) {
[SPAN_TYPE]: 'web',
[HTTP_METHOD]: proxyContext.method,
[HTTP_URL]: proxyContext.domainName + proxyContext.path,
[HTTP_ROUTE]: proxyContext.path,
stage: proxyContext.stage
}
}
2 changes: 0 additions & 2 deletions packages/dd-trace/test/plugins/util/inferred_proxy.spec.js
Original file line number Diff line number Diff line change
@@ -81,7 +81,6 @@ describe('Inferred Proxy Spans', function () {
expect(spans[0].meta).to.have.property('http.url', 'example.com/test')
expect(spans[0].meta).to.have.property('http.method', 'GET')
expect(spans[0].meta).to.have.property('http.status_code', '200')
expect(spans[0].meta).to.have.property('http.route', '/test')
expect(spans[0].meta).to.have.property('span.kind', 'internal')
expect(spans[0].meta).to.have.property('component', 'aws-apigateway')
expect(spans[0].meta).to.have.property('_dd.inferred_span', '1')
@@ -130,7 +129,6 @@ describe('Inferred Proxy Spans', function () {
expect(spans[0].meta).to.have.property('http.url', 'example.com/test')
expect(spans[0].meta).to.have.property('http.method', 'GET')
expect(spans[0].meta).to.have.property('http.status_code', '500')
expect(spans[0].meta).to.have.property('http.route', '/test')
expect(spans[0].meta).to.have.property('span.kind', 'internal')
expect(spans[0].meta).to.have.property('component', 'aws-apigateway')
expect(spans[0].error).to.be.equal(1)