Skip to content

Conversation

juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented Oct 7, 2025

What does this PR do?

Change channel and variable names to files rather than tests, when applicable.

Motivation

What we're actually grabbing are modified files, not tests. Calling it tests makes it confusing.

Plugin Checklist

Just check the current tests are passing.

Copy link

github-actions bot commented Oct 7, 2025

Overall package size

Self size: 12.64 MB
Deduped: 112.86 MB
No deduping: 113.26 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.2.1 | 20.64 MB | 20.65 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.10.0 | 9.91 MB | 10.3 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.73 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.14.4 | 123.18 kB | 851.76 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.80%. Comparing base (ab33cb0) to head (f477bbe).
⚠️ Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
packages/dd-trace/src/plugins/ci_plugin.js 0.00% 5 Missing ⚠️
packages/datadog-plugin-mocha/src/index.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6614   +/-   ##
=======================================
  Coverage   83.80%   83.80%           
=======================================
  Files         490      490           
  Lines       20653    20653           
=======================================
  Hits        17308    17308           
  Misses       3345     3345           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This comment has been minimized.

@pr-commenter
Copy link

pr-commenter bot commented Oct 7, 2025

Benchmarks

Benchmark execution time: 2025-10-14 13:56:05

Comparing candidate commit f477bbe in PR branch juan-fernandez/modify-nomenclature-modified-tests with baseline commit ab33cb0 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1604 metrics, 66 unstable metrics.

@juan-fernandez juan-fernandez force-pushed the juan-fernandez/modify-nomenclature-modified-tests branch from 8e7a36b to 66b00b6 Compare October 10, 2025 10:15
@juan-fernandez juan-fernandez changed the title [test optimization] Better names for modified tests [test optimization] Better nomenclature usage in impacted tests logic Oct 10, 2025
@juan-fernandez juan-fernandez marked this pull request as ready for review October 10, 2025 10:48
@juan-fernandez juan-fernandez requested review from a team as code owners October 10, 2025 10:48
calvinbayer
calvinbayer previously approved these changes Oct 13, 2025
? this.getModifiedTestForThisSuite(modifiedTests)
: this.getModifiedTestForThisSuite(this.testEnvironmentOptions._ddModifiedTests)
const hasImpactedTests = Object.keys(modifiedFiles).length > 0
// TODO: check if `this.testEnvironmentOptions._ddModifiedFiles` is serialized to JSON
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this TODO supposed to be merged?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. I don't think so, no

@juan-fernandez juan-fernandez merged commit 6de63eb into master Oct 15, 2025
1006 of 1008 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/modify-nomenclature-modified-tests branch October 15, 2025 10:00
@dd-octo-sts dd-octo-sts bot mentioned this pull request Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants