Skip to content

Conversation

uurien
Copy link
Collaborator

@uurien uurien commented Oct 9, 2025

What does this PR do?

Support extended data collection of the request body in Fastify and Nextjs

Motivation

Improve support

Additional Notes

System tests
APPSEC-58759

Copy link

github-actions bot commented Oct 9, 2025

Overall package size

Self size: 12.72 MB
Deduped: 115.33 MB
No deduping: 117.54 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.2.1 | 20.64 MB | 20.65 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.11.1 | 9.96 MB | 10.34 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.73 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @opentelemetry/resources | 1.9.1 | 306.54 kB | 1.74 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api-logs | 0.205.0 | 201.51 kB | 1.42 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | @datadog/openfeature-node-server | 0.1.0-preview.10 | 95.11 kB | 401.46 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.03%. Comparing base (7f63420) to head (99dc978).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6631      +/-   ##
==========================================
- Coverage   84.11%   84.03%   -0.09%     
==========================================
  Files         503      499       -4     
  Lines       21006    20877     -129     
==========================================
- Hits        17670    17544     -126     
+ Misses       3336     3333       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Oct 9, 2025

Benchmarks

Benchmark execution time: 2025-10-16 15:40:08

Comparing candidate commit 99dc978 in PR branch ugaitz/extended-data-collection-fastify with baseline commit 7f63420 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1605 metrics, 65 unstable metrics.

@uurien uurien force-pushed the ugaitz/extended-data-collection-fastify branch 2 times, most recently from 46eb7b1 to 3a27bd2 Compare October 10, 2025 13:20
@datadog-datadog-prod-us1

This comment has been minimized.

@uurien uurien force-pushed the ugaitz/extended-data-collection-fastify branch from 3a27bd2 to 42bd4e7 Compare October 10, 2025 13:34
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole file is a copy of initApp and startServer methods from index.next.plugin.spec.js to reuse it in the new test file.

They have few differences:

  • methods now have some extra parameters, because the version and realVersion where variables out o the methods.
  • A line copying rules file wasn't necessary, I have removed it.

@uurien uurien marked this pull request as ready for review October 17, 2025 03:25
@uurien uurien requested a review from a team as a code owner October 17, 2025 03:25
Copy link
Contributor

@IlyasShabi IlyasShabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uurien uurien merged commit 2056fe7 into master Oct 17, 2025
747 of 753 checks passed
@uurien uurien deleted the ugaitz/extended-data-collection-fastify branch October 17, 2025 09:56
@dd-octo-sts dd-octo-sts bot mentioned this pull request Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants