test: rewrite assertion to use Node.js assert

[BridgeAR]

Please check the individual commis for details.

The first two are a script that is mostly auto generated to transform the assertions.

The third commit is the rewrite with that script.
The fourth commit is the auto fixes by eslint.
The fifth commit includes all manual changes on top. I had quite a few of these, since the script used a few rewrites in ways that were not correct.

I suggest to take a glimpse at the script, than to have a glimpse at the auto changed things individually per commit and to have a closer look at all manual changes. Yes, they are way more than I wanted, while we still have more assertions to change and more chai assertions are added as long as we do not change these entries soon.

[pr-commenter]

Benchmarks

Benchmark execution time: 2025-12-11 10:32:06

Comparing candidate commit e96695b in PR branch BridgeAR/2025-11-24-more-chai-to-assert with baseline commit 460bf14 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 289 metrics, 31 unstable metrics.

[github-actions]

Overall package size

Self size: 13.73 MB
Deduped: 113.93 MB
No deduping: 128.94 MB

Dependency sizes

| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.3.0 | 20.73 MB | 20.74 MB | | @datadog/pprof | 5.12.0 | 11.19 MB | 11.57 MB | | @datadog/native-iast-taint-tracking | 4.1.0 | 9.01 MB | 9.02 MB | | @opentelemetry/resources | 1.30.1 | 557.67 kB | 7.71 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.83 MB | | @datadog/wasm-js-rewriter | 5.0.1 | 2.82 MB | 3.53 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api-logs | 0.208.0 | 199.48 kB | 1.42 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | @datadog/openfeature-node-server | 0.2.0 | 118.51 kB | 437.19 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | @isaacs/ttlcache | 2.1.3 | 90.79 kB | 90.79 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB | | escape-string-regexp | 5.0.0 | 3.66 kB | 3.66 kB |

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.82%. Comparing base (460bf14) to head (e96695b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6999      +/-   ##
==========================================
- Coverage   84.83%   84.82%   -0.01%     
==========================================
  Files         515      515              
  Lines       22015    22015              
==========================================
- Hits        18676    18674       -2     
- Misses       3339     3341       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[simon-id]

is this generate with a script like last PR ?

[watson]

@simon-id yes, but with manual fixes along the way. See commits
@BridgeAR you should add PR description

[BridgeAR]

@watson I just added the PR description and updated the code.

@simon-id as @watson outlined, it is mostly auto generated, while this contains quite a lot of manual changes as well.
I added suggestions how to review this best in the PR description.

[pabloerhard]

Is there an equivalent of includeMembers which does not involve having to use deepStrictEqual (saw in some place that asserObjectContains is used)? Just curious what would happen if a bigger array needed to be asserted.

[BridgeAR]

assertObjectContains() stands for assert.partialDeepStrictEqual() and is the equivalent, while it is a tad stricter (the order matters and duplicates are not ignored).

So if you want to match a subset, that is perfect.

[pabloerhard]

Went quickly over the script and looked into all the manual changes (along some of the full files), LGTM.