-
Notifications
You must be signed in to change notification settings - Fork 360
chore(datastreams): separate DSM specific test behavior and add to CODEOWNERS #7076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore(datastreams): separate DSM specific test behavior and add to CODEOWNERS #7076
Conversation
Overall package sizeSelf size: 3.58 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7076 +/- ##
=======================================
Coverage 84.82% 84.82%
=======================================
Files 515 515
Lines 22022 22022
=======================================
Hits 18681 18681
Misses 3341 3341 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2025-12-12 15:12:09 Comparing candidate commit 3253660 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 288 metrics, 32 unstable metrics. |
This comment has been minimized.
This comment has been minimized.
| "test:openfeature": "mocha -r \"packages/dd-trace/test/setup/mocha.js\" \"packages/dd-trace/test/openfeature/*.spec.js\"", | ||
| "test:openfeature:ci": "nyc --no-clean --include \"packages/dd-trace/src/openfeature/**/*.js\" -- npm run test:openfeature", | ||
| "test:plugins": "mocha -r \"packages/dd-trace/test/setup/mocha.js\" \"packages/datadog-plugin-@($(echo $PLUGINS))/test/**/@($(echo ${SPEC:-'*'})).spec.js\"", | ||
| "test:plugins": "mocha -r \"packages/dd-trace/test/setup/mocha.js\" \"packages/datadog-plugin-@($(echo $PLUGINS))/test/**/@($(echo ${SPEC:-'*'}))*.spec.js\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so i.e. SPEC=sqs will still test sqs.dsm.spec.js, which is consistent with how this would work if SPEC wasn't set.
What does this PR do?
Splits DSM specific tests into their own test files, and updates CODEOWNERS so that the DSM team owns these tests.
Tests still run e.g.:
amqplib: https://github.com/DataDog/dd-trace-js/actions/runs/20139301302/job/57801733910?pr=7076#step:4:492
confluentinc-kafka-javascript: https://github.com/DataDog/dd-trace-js/actions/runs/20139301302/job/57801734114?pr=7076#step:7:410
kafkajs: https://github.com/DataDog/dd-trace-js/actions/runs/20139301302/job/57801734472?pr=7076#step:7:49
Motivation
Plugin Checklist
Additional Notes