Skip to content

Conversation

@robcarlan-datadog
Copy link

@robcarlan-datadog robcarlan-datadog commented Dec 10, 2025

What does this PR do?

Splits DSM specific tests into their own test files, and updates CODEOWNERS so that the DSM team owns these tests.

Tests still run e.g.:
amqplib: https://github.com/DataDog/dd-trace-js/actions/runs/20139301302/job/57801733910?pr=7076#step:4:492
confluentinc-kafka-javascript: https://github.com/DataDog/dd-trace-js/actions/runs/20139301302/job/57801734114?pr=7076#step:7:410
kafkajs: https://github.com/DataDog/dd-trace-js/actions/runs/20139301302/job/57801734472?pr=7076#step:7:49

Motivation

Plugin Checklist

Additional Notes

@github-actions
Copy link

github-actions bot commented Dec 10, 2025

Overall package size

Self size: 3.58 MB
Deduped: 4.46 MB
No deduping: 4.46 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.82%. Comparing base (acc6bef) to head (3253660).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7076   +/-   ##
=======================================
  Coverage   84.82%   84.82%           
=======================================
  Files         515      515           
  Lines       22022    22022           
=======================================
  Hits        18681    18681           
  Misses       3341     3341           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Dec 10, 2025

Benchmarks

Benchmark execution time: 2025-12-12 15:12:09

Comparing candidate commit 3253660 in PR branch rob.carlan/DSMON-1162-dsm-test-ownership with baseline commit acc6bef in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 288 metrics, 32 unstable metrics.

@datadog-datadog-prod-us1

This comment has been minimized.

"test:openfeature": "mocha -r \"packages/dd-trace/test/setup/mocha.js\" \"packages/dd-trace/test/openfeature/*.spec.js\"",
"test:openfeature:ci": "nyc --no-clean --include \"packages/dd-trace/src/openfeature/**/*.js\" -- npm run test:openfeature",
"test:plugins": "mocha -r \"packages/dd-trace/test/setup/mocha.js\" \"packages/datadog-plugin-@($(echo $PLUGINS))/test/**/@($(echo ${SPEC:-'*'})).spec.js\"",
"test:plugins": "mocha -r \"packages/dd-trace/test/setup/mocha.js\" \"packages/datadog-plugin-@($(echo $PLUGINS))/test/**/@($(echo ${SPEC:-'*'}))*.spec.js\"",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so i.e. SPEC=sqs will still test sqs.dsm.spec.js, which is consistent with how this would work if SPEC wasn't set.

@robcarlan-datadog robcarlan-datadog marked this pull request as ready for review December 12, 2025 17:52
@robcarlan-datadog robcarlan-datadog requested review from a team as code owners December 12, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants