feat(prof): add 'tracing' features #3094
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3094 +/- ##
=========================================
Coverage 74.74% 74.74%
Complexity 2791 2791
=========================================
Files 112 112
Lines 11044 11044
=========================================
Hits 8255 8255
Misses 2789 2789
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
This adds tracing features to the profiler. These are not meant to be enabled for customer builds at this time. The goal is to use this data to enable benchmarking and other useful tools during development. Currently it's turned on by the RUST_LOG env var. We may want to move some of our logging of the PHP lifecycle to use this in the future.
morrisonlevi
force-pushed
the
levi/tracing-subscriber
branch
from
6412563 to
3c7d8c7
Compare
Benchmarks [ profiler ]Benchmark execution time: 2025-02-19 20:30:38 Comparing candidate commit 8c510e2 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 27 metrics, 7 unstable metrics. scenario:walk_stack/50
scenario:walk_stack/99
|
morrisonlevi
force-pushed
the
levi/tracing-subscriber
branch
from
e147475 to
8c510e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the
tracingandtracing-subscriberfeatures to the profiler. Enablingtracing-subscriberrequirestracing. These are not meant to be enabled for customer builds at this time. The goal is to use this data to enable benchmarking and other useful tools during development. Currently it's configured by theRUST_LOGenv var (when built with the feature, of course).We may want to move some of our logging of the PHP lifecycle to use this in the future.
Reviewer checklist