-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more logging around stack generation #3096
base: master
Are you sure you want to change the base?
Add more logging around stack generation #3096
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3096 +/- ##
=============================================
- Coverage 74.86% 51.96% -22.91%
Complexity 2792 2792
=============================================
Files 112 112
Lines 11046 11046
=============================================
- Hits 8270 5740 -2530
- Misses 2776 5306 +2530
Flags with carried forward coverage won't be shown. Click here to find out more. see 21 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Benchmarks [ appsec ]Benchmark execution time: 2025-02-20 17:29:50 Comparing candidate commit 1bf12b2 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. |
6895f6a
to
702bec6
Compare
702bec6
to
f5b4a78
Compare
f5b4a78
to
1bf12b2
Compare
return false; | ||
} | ||
|
||
mlog(dd_log_trace, "Stacktrace generated"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In terms of nomenclature you have backtrace
, stacktrace
and backtrace stack
, maybe use one term only?
Description
Reviewer checklist