Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more logging around stack generation #3096

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

estringana
Copy link
Contributor

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.96%. Comparing base (4da93b3) to head (6683b32).
Report is 5 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (4da93b3) and HEAD (6683b32). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (4da93b3) HEAD (6683b32)
tracer-php 11 10
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #3096       +/-   ##
=============================================
- Coverage     74.86%   51.96%   -22.91%     
  Complexity     2792     2792               
=============================================
  Files           112      112               
  Lines         11046    11046               
=============================================
- Hits           8270     5740     -2530     
- Misses         2776     5306     +2530     
Flag Coverage Δ
tracer-php 51.96% <ø> (-22.91%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 21 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4da93b3...6683b32. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Feb 19, 2025

Benchmarks [ appsec ]

Benchmark execution time: 2025-02-20 17:29:50

Comparing candidate commit 1bf12b2 in PR branch estringana/add-more-loggin-around-stacktrace-generation with baseline commit 4da93b3 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

@estringana estringana marked this pull request as ready for review February 20, 2025 15:56
@estringana estringana requested a review from a team as a code owner February 20, 2025 15:56
@estringana estringana force-pushed the estringana/add-more-loggin-around-stacktrace-generation branch from 6895f6a to 702bec6 Compare February 20, 2025 16:12
@estringana estringana force-pushed the estringana/add-more-loggin-around-stacktrace-generation branch from 702bec6 to f5b4a78 Compare February 20, 2025 16:12
@estringana estringana force-pushed the estringana/add-more-loggin-around-stacktrace-generation branch from f5b4a78 to 1bf12b2 Compare February 20, 2025 16:14
return false;
}

mlog(dd_log_trace, "Stacktrace generated");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of nomenclature you have backtrace, stacktrace and backtrace stack, maybe use one term only?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants