Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error parsing response cookies in FastAPI and awsgi #11829

Merged
merged 5 commits into from
Dec 26, 2024
Merged

fix: error parsing response cookies in FastAPI and awsgi #11829

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2d0f307
fix: cookies
avara1986 Dec 23, 2024
08ef3ea
fix: cookies
avara1986 Dec 23, 2024
059d6b2
Merge branch 'main' into avara1986/fix_fastapi_cookies_parse
avara1986 Dec 23, 2024
3ccd8eb
fix: cookies
avara1986 Dec 24, 2024
7bef2fe
fix: cookies
avara1986 Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ddtrace/contrib/internal/asgi/middleware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,10 @@ async def wrapped_send(message):
if span and message.get("type") == "http.response.start" and "status" in message:
cookies = {}
try:
cookie_key, cookie_value = response_headers.get("set-cookie", "").split("=", maxsplit=1)
cookies[cookie_key] = cookie_value
result = response_headers.get("set-cookie", "").split("=", maxsplit=1)
avara1986 marked this conversation as resolved.
Show resolved Hide resolved
if len(result) == 2:
cookie_key, cookie_value = result
cookies[cookie_key] = cookie_value
except Exception:
log.debug("failed to extract response cookies", exc_info=True)

Expand Down
4 changes: 4 additions & 0 deletions releasenotes/notes/iast-fix-awsgi-368c173e1f012400.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
fixes:
- |
ASGI: This fix resolves an issue parsing response cookies in FastAPI and awsgi
Loading