Skip to content

ci(benchmarks): add additional core api variants#17962

Open
brettlangdon wants to merge 3 commits into
mainfrom
brettlangdon/core.api.benchmarks
Open

ci(benchmarks): add additional core api variants#17962
brettlangdon wants to merge 3 commits into
mainfrom
brettlangdon/core.api.benchmarks

Conversation

@brettlangdon
Copy link
Copy Markdown
Member

Description

Expands the core_api benchmark suite with finer-grained variants — listener count sweeps (0/1/10/50), empty-args dispatch, exception path, and has_listeners — so we can detect regressions across a wider range of usage patterns.

Testing

Risks

Additional Notes

@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label May 7, 2026
@datadog-prod-us1-6
Copy link
Copy Markdown

datadog-prod-us1-6 Bot commented May 7, 2026

Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 2 Tests failed

BotocoreTest::test_aws_payload_tagging_kinesis[py3.11] from test.py   View in Datadog   (Fix with Cursor)
At request <Request GET /test/session/snapshot >:
   At snapshot (token='tests.contrib.botocore.test.BotocoreTest.test_aws_payload_tagging_kinesis'):
    - Directory: /go/src/github.com/DataDog/apm-reliability/dd-trace-py/tests/snapshots
    - CI mode: 1
    - Trace File: /go/src/github.com/DataDog/apm-reliability/dd-trace-py/tests/snapshots/tests.contrib.botocore.test.BotocoreTest.test_aws_payload_tagging_kinesis.json
    - Stats File: /go/src/github.com/DataDog/apm-reliability/dd-trace-py/tests/snapshots/tests.contrib.botocore.test.BotocoreTest.test_aws_payload_tagging_kinesis_tracestats.json
    At compare of 3 expected trace(s) to 3 received trace(s):
     At trace 'kinesis.manual_span' (3 spans):
      At snapshot compare of span 'kinesis.manual_span' at position 1 in trace:
       - Expected span:
...
BotocoreTest::test_aws_payload_tagging_kinesis[py3.14] from test.py   View in Datadog   (Fix with Cursor)
At request <Request GET /test/session/snapshot >:
   At snapshot (token='tests.contrib.botocore.test.BotocoreTest.test_aws_payload_tagging_kinesis'):
    - Directory: /go/src/github.com/DataDog/apm-reliability/dd-trace-py/tests/snapshots
    - CI mode: 1
    - Trace File: /go/src/github.com/DataDog/apm-reliability/dd-trace-py/tests/snapshots/tests.contrib.botocore.test.BotocoreTest.test_aws_payload_tagging_kinesis.json
    - Stats File: /go/src/github.com/DataDog/apm-reliability/dd-trace-py/tests/snapshots/tests.contrib.botocore.test.BotocoreTest.test_aws_payload_tagging_kinesis_tracestats.json
    At compare of 3 expected trace(s) to 1 received trace(s):
Did not receive expected traces: 'sqs.command','sqs.command'

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 16b0a20 | Docs | Datadog PR Page | Give us feedback!

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

Codeowners resolved as

.gitlab/benchmarks/bp-runner.microbenchmarks.fail-on-breach.template.yml  @DataDog/python-guild @DataDog/apm-core-python

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 7, 2026

Benchmarks

Benchmark execution time: 2026-05-11 13:23:12

Comparing candidate commit 16b0a20 in PR branch brettlangdon/core.api.benchmarks with baseline commit a3ecbc8 in branch main.

Found 0 performance improvements and 5 performance regressions! Performance is the same for 603 metrics, 9 unstable metrics.

scenario:iastaspects-lstrip_aspect

  • 🟥 execution_time [+64.592µs; +77.151µs] or [+23.519%; +28.092%]

scenario:iastaspects-translate_aspect

  • 🟥 execution_time [+65.064µs; +69.740µs] or [+12.854%; +13.778%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+87.746µs; +93.947µs] or [+20.873%; +22.348%]

scenario:span-start

  • 🟥 execution_time [+1.302ms; +1.457ms] or [+8.361%; +9.352%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+175.709ns; +209.791ns] or [+8.397%; +10.025%]

@brettlangdon brettlangdon marked this pull request as ready for review May 7, 2026 19:28
@brettlangdon brettlangdon requested review from a team as code owners May 7, 2026 19:28
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 58c561f694

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread benchmarks/core_api/config.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants