Skip to content

chore(build): fix all mypy errors in setup.py #17963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vlad-scherbich wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −12
Open

chore(build): fix all mypy errors in setup.py #17963

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e05f73
chore(build): fix all mypy errors in setup.py
vlad-scherbich May 7, 2026
e6b1683
Merge branch 'main' into vlad/fix-setup-py-mypy-errors
vlad-scherbich May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions setup.py
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@KowalskiThomas KowalskiThomas May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're fixing those errors, you might want to check the others as well

Image Image Image

Also I have mypy telling me some of those comments aren't used?

Image

Original file line number Diff line number Diff line change
Expand Up @@ -466,13 +466,13 @@ class LibraryDownload:
CACHE_DIR = Path(os.getenv("DD_SETUP_CACHE_DIR", HERE / ".download_cache"))
USE_CACHE = os.getenv("DD_SETUP_CACHE_DOWNLOADS", "1").lower() in ("1", "yes", "on", "true")

name = None
download_dir = Path.cwd()
version = None
url_root = None
available_releases = {}
expected_checksums = None
translate_suffix = {}
name: t.Optional[str] = None
download_dir: Path = Path.cwd()
version: t.Optional[str] = None
url_root: t.Optional[str] = None
available_releases: dict[str, list[str]] = {}
expected_checksums: t.Optional[dict[str, str]] = None
translate_suffix: dict[str, tuple[str, ...]] = {}

@classmethod
def download_artifacts(cls):
Expand Down Expand Up @@ -1038,7 +1038,7 @@ def _build_shared_dep(self, dep: SharedDep) -> None:
cmake_build_dir = Path(self.build_lib.replace("lib.", "cmake."), f"{dep.name}_build").resolve()
cmake_build_dir.mkdir(parents=True, exist_ok=True)

cmake_command = (Path(cmake.CMAKE_BIN_DIR) / "cmake").resolve()
cmake_command = (Path(cmake.CMAKE_BIN_DIR) / "cmake").resolve() # type: ignore[attr-defined]

cmake_args = self._base_cmake_args() + [
f"-S{dep.cmake_dir}",
Expand Down Expand Up @@ -1334,7 +1334,7 @@ def build_extension_cmake(self, ext: "CMakeExtension") -> None:
"-DCMAKE_CXX_FLAGS_%s=-O0" % ext.build_type.upper(),
]
cmake_command = (
Path(cmake.CMAKE_BIN_DIR) / "cmake"
Path(cmake.CMAKE_BIN_DIR) / "cmake" # type: ignore[attr-defined]
).resolve() # explicitly use the cmake provided by the cmake package
subprocess.run([cmake_command, *cmake_args], cwd=cmake_build_dir, check=True)
subprocess.run([cmake_command, "--build", ".", *build_args], cwd=cmake_build_dir, check=True)
Expand Down Expand Up @@ -1447,8 +1447,12 @@ def _time_phase(name: str):

if DebugMetadata.enabled:
DebugMetadata.start_ns = time.time_ns()
CustomBuildExt.build_extension = debug_build_extension(CustomBuildExt.build_extension)
CustomBuildExt._build_shared_dep = debug_build_shared_dep(CustomBuildExt._build_shared_dep)
CustomBuildExt.build_extension = ( # type: ignore[method-assign]
debug_build_extension(CustomBuildExt.build_extension)
)
CustomBuildExt._build_shared_dep = ( # type: ignore[method-assign]
debug_build_shared_dep(CustomBuildExt._build_shared_dep)
)
build_rust.build_extension = debug_build_extension(CustomBuildRust.build_extension)
atexit.register(DebugMetadata.dump_metadata)

Expand Down Expand Up @@ -1488,7 +1492,7 @@ def get_sources(self) -> list[Path]:
def is_valid_source(src: Path) -> bool:
return (
src.is_file()
and src.suffix
and bool(src.suffix)
# Exclude compiled/generated artifacts that are not real sources:
# .so/.dylib/.dll/.pyd — compiled native extensions (from co-located Cython exts)
# .c — Cython-generated C files (present in shared source directories)
Expand Down
Loading